github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[search] Make ISearchOptions compatible with DataViewLazy (#183939)

Browse source 
## Summary

Simply changing the type on `ISearchOptions` to work with DataViewLazy.
Nothing that uses `ISearchOption` uses the field list so these are type
only changes

Part of https://github.com/elastic/kibana/pull/183694
This commit is contained in:
Matthew Kime 2024-05-23 13:14:36 -05:00 • committed by GitHub
parent b1916090d0
commit 692b228517
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/kbn-search-errors/src/create_es_error.ts
View file

@ -9,7 +9,7 @@
import { estypes } from '@elastic/elasticsearch';
import { i18n } from '@kbn/i18n';
import type { ApplicationStart, CoreStart } from '@kbn/core/public';
import type { DataView } from '@kbn/data-views-plugin/common';
import type { AbstractDataView } from '@kbn/data-views-plugin/common';
import { IEsError } from './types';
import { EsError } from './es_error';
import { PainlessError } from './painless_error';
@ -34,7 +34,7 @@ export function createEsError(
err: IEsError,
openInInspector: () => void,
services: Services,
dataView?: DataView
dataView?: AbstractDataView
) {
const rootCauses = err.attributes?.error ? getNestedCauses(err.attributes?.error) : [];

6
packages/kbn-search-errors/src/painless_error.tsx
View file

@ -11,21 +11,21 @@ import { estypes } from '@elastic/elasticsearch';
import type { ApplicationStart } from '@kbn/core/public';
import { i18n } from '@kbn/i18n';
import { EuiButtonEmpty, EuiSpacer, EuiText, EuiCodeBlock } from '@elastic/eui';
import type { DataView } from '@kbn/data-views-plugin/common';
import type { AbstractDataView } from '@kbn/data-views-plugin/common';
import type { IEsError } from './types';
import { EsError } from './es_error';
export class PainlessError extends EsError {
private readonly applicationStart: ApplicationStart;
private readonly painlessCause: estypes.ErrorCause;
private readonly dataView?: DataView;
private readonly dataView?: AbstractDataView;
constructor(
err: IEsError,
openInInspector: () => void,
painlessCause: estypes.ErrorCause,
applicationStart: ApplicationStart,
dataView?: DataView
dataView?: AbstractDataView
) {
super(
err,