[FTR] Refactor test/common/services/* -> packages/kbn-ftr-common-functional-[ui-]services/* (#191805)

## Summary

Moving common services to respective new homes.

This PR is revived from a previously
[merged](09a365850e)
and [reverted PR](https://github.com/elastic/kibana/pull/191765) as
[detailed
here](https://github.com/elastic/kibana/pull/189051#issuecomment-2318999361).
- This was due to "extra" tests being applied to
https://github.com/elastic/kibana/pull/191708
- These "extra" tests were applied as
https://github.com/elastic/kibana/pull/191708 changes files within
`x-pack/plugins/observability_solution/` as configured
[here](https://github.com/elastic/kibana/blob/main/.buildkite/scripts/pipelines/pull_request/pipeline.ts#L129)

### Why these failures were not caught in the original
[PR](https://github.com/elastic/kibana/pull/189051)
The pipeline is generated at runtime, and the original
[PR](https://github.com/elastic/kibana/pull/189051) had zero changes
under `x-pack/plugins/observability_solution/`
 
 ## Changes on top of original PR
 - Add `ci:all-cypress-suites` label to run extra tests
- Add `services` stanza to which contains the missing references by
spreading the services from `@kbn/ftr-common-functional-services` &&
`@kbn/ftr-common-functional-ui-services` into the stanza, for the
following:
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/apm/ftr_e2e/ftr_config.ts` 
-
`x-pack/plugins/observability_solution/observability_onboarding/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/profiling/e2e/ftr_config.ts`
   - `x-pack/plugins/observability_solution/synthetics/e2e/config.ts`
   - `x-pack/plugins/observability_solution/uptime/e2e/config.ts`
 

 
 
Blocked by: https://github.com/elastic/kibana/issues/191961
Resolves: https://github.com/elastic/kibana/issues/188541

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Tre 2024-09-05 10:00:55 +01:00 committed by GitHub
parent 5b4f4afb44
commit 69665cecd0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
81 changed files with 264 additions and 190 deletions

View file

@ -203,7 +203,7 @@ Tests should run at the positive security boundary condition, meaning that they
The functional UI tests now default to logging in with a user named `test_user` and the roles of this user can be changed dynamically without logging in and out.
In order to achieve this a new service was introduced called `createTestUserService` (see `test/common/services/security/test_user.ts`). The purpose of this test user service is to create roles defined in the test config files and setRoles() or restoreDefaults().
In order to achieve this a new service was introduced called `createTestUserService` (see `packages/kbn-ftr-common-functional-ui-services/services/security/test_user.ts`). The purpose of this test user service is to create roles defined in the test config files and setRoles() or restoreDefaults().
An example of how to set the role like how its defined below:
@ -366,14 +366,14 @@ await testSubjects.click(containerButton);
** `find.allByCssSelector()`
**retry:**:::
// * Source: {kibana-blob}test/common/services/retry/retry.ts[test/common/services/retry/retry.ts]
// * Source: {kibana-blob}packages/kbn-ftr-common-functional-services/services/retry/retry.ts[packages/kbn-ftr-common-functional-services/services/retry/retry.ts]
* Helpers for retrying operations
* Popular methods:
** `retry.try(fn, onFailureBlock)` - Execute `fn` in a loop until it succeeds or the default timeout elapses. The optional `onFailureBlock` is executed before each retry attempt.
** `retry.tryForTime(ms, fn, onFailureBlock)` - Execute `fn` in a loop until it succeeds or `ms` milliseconds elapses. The optional `onFailureBlock` is executed before each retry attempt.
**kibanaServer:**:::
// * Source: {kibana-blob}test/common/services/kibana_server/kibana_server.js[test/common/services/kibana_server/kibana_server.js]
// * Source: {kibana-blob}packages/kbn-ftr-common-functional-services/services/kibana_server/kibana_server.ts[packages/kbn-ftr-common-functional-services/services/kibana_server/kibana_server.ts]
* Helpers for interacting with {kib}'s server
* Commonly used methods:
** `kibanaServer.uiSettings.update()`
@ -381,7 +381,7 @@ await testSubjects.click(containerButton);
** `kibanaServer.status.getOverallState()`
**esArchiver:**:::
// * Source: {kibana-blob}test/common/services/es_archiver.ts[test/common/services/es_archiver.ts]
// * Source: {kibana-blob}packages/kbn-ftr-common-functional-services/services/es_archiver.ts[packages/kbn-ftr-common-functional-services/services/es_archiver.ts]
* Load/unload archives created with the `esArchiver`
* Popular methods:
** `esArchiver.load(path)`
@ -393,7 +393,7 @@ Full list of services that are used in functional tests can be found here: {kiba
**Low-level utilities:**:::
* es
// ** Source: {kibana-blob}test/common/services/es.ts[test/common/services/es.ts]
// ** Source: {kibana-blob}packages/kbn-ftr-common-functional-services/services/es.ts[packages/kbn-ftr-common-functional-services/services/es.ts]
** {es} client
** Higher level options: `kibanaServer.uiSettings` or `esArchiver`
* remote

View file

@ -10,6 +10,7 @@ import { ProvidedType } from '@kbn/test';
export { services as commonFunctionalServices } from './services/all';
import { KibanaServerProvider } from './services/kibana_server';
export { KibanaServerProvider } from './services/kibana_server';
export type KibanaServer = ProvidedType<typeof KibanaServerProvider>;
export { RetryService } from './services/retry';
@ -18,6 +19,7 @@ import { EsArchiverProvider } from './services/es_archiver';
export type EsArchiver = ProvidedType<typeof EsArchiverProvider>;
import { EsProvider } from './services/es';
export { EsProvider } from './services/es';
export type Es = ProvidedType<typeof EsProvider>;
import { SupertestWithoutAuthProvider } from './services/supertest_without_auth';
@ -29,3 +31,10 @@ import { SamlAuthProvider } from './services/saml_auth/saml_auth_provider';
export type SamlAuthProviderType = ProvidedType<typeof SamlAuthProvider>;
export type { FtrProviderContext } from './services/ftr_provider_context';
export { runSavedObjInfoSvc } from './services/saved_object_info';
export type { BsearchService, SendOptions } from './services/bsearch';
export { SavedObjectInfoService } from './services/saved_object_info';
export { DeploymentService } from './services/deployment';
export { IndexPatternsService } from './services/index_patterns';
export { RandomnessService } from './services/randomness';

View file

@ -10,6 +10,13 @@ import { EsArchiverProvider } from './es_archiver';
import { EsProvider } from './es';
import { KibanaServerProvider } from './kibana_server';
import { RetryService } from './retry';
import { BsearchService } from './bsearch';
import { ConsoleProvider } from './console';
import { DeploymentService } from './deployment';
import { EsDeleteAllIndicesProvider } from './es_delete_all_indices';
import { IndexPatternsService } from './index_patterns';
import { SavedObjectInfoService } from './saved_object_info';
import { RandomnessService } from './randomness';
import { SupertestWithoutAuthProvider } from './supertest_without_auth';
import { SamlAuthProvider } from './saml_auth';
@ -18,6 +25,13 @@ export const services = {
kibanaServer: KibanaServerProvider,
esArchiver: EsArchiverProvider,
retry: RetryService,
bsearch: BsearchService,
console: ConsoleProvider,
deployment: DeploymentService,
esDeleteAllIndices: EsDeleteAllIndicesProvider,
indexPatterns: IndexPatternsService,
savedObjectInfo: SavedObjectInfoService,
randomness: RandomnessService,
supertestWithoutAuth: SupertestWithoutAuthProvider,
samlAuth: SamlAuthProvider,
};

View file

@ -12,7 +12,7 @@ import type SuperTest from 'supertest';
import type { IEsSearchResponse } from '@kbn/search-types';
import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common';
import { BFETCH_ROUTE_VERSION_LATEST } from '@kbn/bfetch-plugin/common';
import { FtrService } from '../ftr_provider_context';
import { FtrService } from './ftr_provider_context';
/**
* Function copied from here:
@ -62,6 +62,7 @@ export interface SendOptions {
* });
* expect(response).eql({ ... your value ... });
*/
export class BsearchService extends FtrService {
private readonly retry = this.ctx.getService('retry');

View file

@ -6,9 +6,9 @@
* Side Public License, v 1.
*/
import type { FtrProviderContext } from '../../ftr_provider_context';
import type { FtrProviderContext } from './ftr_provider_context';
export function helpers(getService: FtrProviderContext['getService']) {
export function ConsoleProvider({ getService }: FtrProviderContext) {
const client = getService('es');
const createIndex = async (indexName: string) => {

View file

@ -11,7 +11,7 @@ import { Agent } from 'https';
import fetch from 'node-fetch';
import { getUrl } from '@kbn/test';
import { FtrService } from '../ftr_provider_context';
import { FtrService } from './ftr_provider_context';
export class DeploymentService extends FtrService {
private readonly config = this.ctx.getService('config');

View file

@ -6,7 +6,7 @@
* Side Public License, v 1.
*/
import { FtrProviderContext } from '../ftr_provider_context';
import { FtrProviderContext } from './ftr_provider_context';
export function EsDeleteAllIndicesProvider({ getService }: FtrProviderContext) {
const log = getService('log');

View file

@ -6,10 +6,11 @@
* Side Public License, v 1.
*/
import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common';
import type { DataViewSpec } from '@kbn/data-plugin/common';
import { INITIAL_REST_VERSION } from '@kbn/data-views-plugin/server/constants';
import { DataViewSpec } from '@kbn/data-plugin/common';
import { FtrService } from '../ftr_provider_context';
import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common';
import { FtrService } from './ftr_provider_context';
export class IndexPatternsService extends FtrService {
private readonly kibanaServer = this.ctx.getService('kibanaServer');

View file

@ -9,7 +9,7 @@
import Chance from 'chance';
import { ToolingLog } from '@kbn/tooling-log';
import { FtrService } from '../ftr_provider_context';
import { FtrService } from './ftr_provider_context';
let __CACHED_SEED__: number | undefined;
function getSeed(log: ToolingLog) {

View file

@ -13,7 +13,7 @@ import { flow, pipe } from 'fp-ts/function';
import * as TE from 'fp-ts/lib/TaskEither';
import * as T from 'fp-ts/lib/Task';
import { ToolingLog } from '@kbn/tooling-log';
import { FtrService } from '../../ftr_provider_context';
import { FtrService } from '../ftr_provider_context';
import { print } from './utils';
const pluck =

View file

@ -16,8 +16,15 @@
"@kbn/es-archiver",
"@kbn/test",
"@kbn/expect",
"@kbn/search-types",
"@kbn/core-http-common",
"@kbn/bfetch-plugin",
"@kbn/data-plugin",
"@kbn/dev-cli-runner",
"@kbn/dev-cli-errors",
"@kbn/repo-info",
"@kbn/es",
"@kbn/data-views-plugin"
],
"exclude": [
"target/**/*",

View file

@ -22,3 +22,4 @@ export {
} from './services/remote/network_profiles';
export type { TimeoutOpt } from './types';
export { TestSubjects } from './services/test_subjects';
export { SecurityService } from './services/security';

View file

@ -12,6 +12,7 @@ import { FindProvider } from './find';
import { TestSubjects } from './test_subjects';
import { BrowserProvider } from './browser';
import { ToastsService } from './toasts';
import { SecurityServiceProvider } from './security';
export const services = {
retryOnStale: RetryOnStaleProvider,
@ -20,4 +21,5 @@ export const services = {
testSubjects: TestSubjects,
browser: BrowserProvider,
toasts: ToastsService,
security: SecurityServiceProvider,
};

View file

@ -7,12 +7,18 @@
*/
import { GenericFtrProviderContext, GenericFtrService } from '@kbn/test';
import { RetryService } from '@kbn/ftr-common-functional-services';
import {
RetryService,
EsProvider,
KibanaServerProvider,
} from '@kbn/ftr-common-functional-services';
import { services as commonFunctionalUiServices } from './all';
const services = {
...commonFunctionalUiServices,
retry: RetryService,
es: EsProvider,
kibanaServer: KibanaServerProvider,
};
export type FtrProviderContext = GenericFtrProviderContext<typeof services, {}>;

View file

@ -6,4 +6,4 @@
* Side Public License, v 1.
*/
export { SecurityServiceProvider } from './security';
export { SecurityService, SecurityServiceProvider } from './security';

View file

@ -9,7 +9,7 @@
import { Role } from './role';
import { User } from './user';
import { RoleMappings } from './role_mappings';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../ftr_provider_context';
import { createTestUserService, TestUserSupertestProvider, TestUser } from './test_user';
import { createSystemIndicesUser } from './system_indices_user';

View file

@ -13,7 +13,7 @@ import {
createEsClientForFtrConfig,
createRemoteEsClientForFtrConfig,
} from '@kbn/test';
import { FtrProviderContext } from '../../ftr_provider_context';
import { FtrProviderContext } from '../ftr_provider_context';
const SYSTEM_INDICES_SUPERUSER_ROLE = 'system_indices_superuser';

View file

@ -9,10 +9,11 @@
import { format as formatUrl } from 'url';
import supertest from 'supertest';
import { type Browser, TestSubjects } from '@kbn/ftr-common-functional-ui-services';
import type { Browser } from '../browser';
import type { TestSubjects } from '../test_subjects';
import { Role } from './role';
import { User } from './user';
import { FtrService, FtrProviderContext } from '../../ftr_provider_context';
import { FtrService, FtrProviderContext } from '../ftr_provider_context';
const TEST_USER_NAME = 'test_user';
const TEST_USER_PASSWORD = 'changeme';

View file

@ -7,4 +7,4 @@
*/
require('../src/setup_node_env');
require('@kbn/test-suites-src/common/services/saved_object_info').runSavedObjInfoSvc();
require('@kbn/ftr-common-functional-services').runSavedObjInfoSvc();

View file

@ -7,14 +7,17 @@
*/
import { GenericFtrProviderContext } from '@kbn/test';
import { services as commonServices } from '../../common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { services as functionalServices } from '../../functional/services';
import { pageObjects } from '../../functional/page_objects';
import { KibanaEBTServerProvider, KibanaEBTUIProvider } from './kibana_ebt';
export const services = {
...commonServices,
...commonFunctionalServices,
...commonFunctionalUIServices,
...functionalServices,
kibana_ebt_server: KibanaEBTServerProvider,
kibana_ebt_ui: KibanaEBTUIProvider,

View file

@ -8,25 +8,11 @@
import expect from '@kbn/expect';
import type { FtrProviderContext } from '../../ftr_provider_context';
import { helpers } from './helpers';
export default ({ getService }: FtrProviderContext) => {
const {
createIndex,
createAlias,
createLegacyTemplate,
createIndexTemplate,
createComponentTemplate,
createDataStream,
deleteIndex,
deleteAlias,
deleteLegacyTemplate,
deleteIndexTemplate,
deleteComponentTemplate,
deleteDataStream,
} = helpers(getService);
const console = getService('console');
const supertest = getService('supertest');
const sendRequest = (query: object) =>
supertest.get('/api/console/autocomplete_entities').query(query);
@ -40,22 +26,26 @@ export default ({ getService }: FtrProviderContext) => {
before(async () => {
// Setup indices, aliases, templates, and data streams
await createIndex(indexName);
await createAlias(indexName, aliasName);
await createComponentTemplate(componentTemplateName);
await createIndexTemplate(indexTemplateName, [dataStreamName], [componentTemplateName]);
await createDataStream(dataStreamName);
await createLegacyTemplate(legacyTemplateName);
await console.createIndex(indexName);
await console.createAlias(indexName, aliasName);
await console.createComponentTemplate(componentTemplateName);
await console.createIndexTemplate(
indexTemplateName,
[dataStreamName],
[componentTemplateName]
);
await console.createDataStream(dataStreamName);
await console.createLegacyTemplate(legacyTemplateName);
});
after(async () => {
// Cleanup indices, aliases, templates, and data streams
await deleteAlias(indexName, aliasName);
await deleteIndex(indexName);
await deleteDataStream(dataStreamName);
await deleteIndexTemplate(indexTemplateName);
await deleteComponentTemplate(componentTemplateName);
await deleteLegacyTemplate(legacyTemplateName);
await console.deleteAlias(indexName, aliasName);
await console.deleteIndex(indexName);
await console.deleteDataStream(dataStreamName);
await console.deleteIndexTemplate(indexTemplateName);
await console.deleteComponentTemplate(componentTemplateName);
await console.deleteLegacyTemplate(legacyTemplateName);
});
it('should not succeed if no settings are provided in query params', async () => {

View file

@ -6,12 +6,13 @@
* Side Public License, v 1.
*/
import { services as commonServices } from '../../common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { KibanaSupertestProvider, ElasticsearchSupertestProvider } from './supertest';
export const services = {
...commonServices,
...commonFunctionalServices,
...commonFunctionalUIServices,
supertest: KibanaSupertestProvider,
esSupertest: ElasticsearchSupertestProvider,
};

View file

@ -9,7 +9,6 @@
import path from 'path';
import { format as formatUrl } from 'url';
import { esTestConfig, kbnTestConfig, kibanaServerTestUser } from '@kbn/test';
import { services } from './services';
export default function () {
const servers = {
@ -85,6 +84,5 @@ export default function () {
})}`,
],
},
services,
};
}

View file

@ -1,14 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/
import { GenericFtrProviderContext, GenericFtrService } from '@kbn/test';
import { services } from './services';
export type FtrProviderContext = GenericFtrProviderContext<typeof services, {}>;
export class FtrService extends GenericFtrService<FtrProviderContext> {}

View file

@ -1,15 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0 and the Server Side Public License, v 1; you may not use this file except
* in compliance with, at your election, the Elastic License 2.0 or the Server
* Side Public License, v 1.
*/
import type { FtrProviderContext } from '../ftr_provider_context';
import { helpers } from '../../api_integration/apis/console/helpers';
export function ConsoleProvider({ getService }: FtrProviderContext) {
return {
helpers: helpers(getService),
};
}

View file

@ -7,17 +7,26 @@
*/
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { DeploymentService } from './deployment';
import { RandomnessService } from './randomness';
import { SecurityServiceProvider } from './security';
import { EsDeleteAllIndicesProvider } from './es_delete_all_indices';
import { SavedObjectInfoService } from './saved_object_info';
import { IndexPatternsService } from './index_patterns';
import { BsearchService } from './bsearch';
import { ConsoleProvider } from './console';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
// pick only services that work for any FTR config, e.g. 'samlAuth' requires SAML setup in config file
const { es, esArchiver, kibanaServer, retry, supertestWithoutAuth } = commonFunctionalServices;
const {
es,
esArchiver,
kibanaServer,
retry,
supertestWithoutAuth,
deployment,
randomness,
esDeleteAllIndices,
savedObjectInfo,
indexPatterns,
bsearch,
console,
} = commonFunctionalServices;
// pick what was there previously
const { security } = commonFunctionalUIServices;
export const services = {
es,
@ -25,12 +34,12 @@ export const services = {
kibanaServer,
retry,
supertestWithoutAuth,
deployment: DeploymentService,
randomness: RandomnessService,
security: SecurityServiceProvider,
esDeleteAllIndices: EsDeleteAllIndicesProvider,
savedObjectInfo: SavedObjectInfoService,
indexPatterns: IndexPatternsService,
bsearch: BsearchService,
console: ConsoleProvider,
deployment,
randomness,
security,
esDeleteAllIndices,
savedObjectInfo,
indexPatterns,
bsearch,
console,
};

View file

@ -7,7 +7,13 @@
*/
import { GenericFtrProviderContext } from '@kbn/test';
import { services } from '../../services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { services as functionalServces } from '../../services';
import { pageObjects } from '../../page_objects';
const services = {
...functionalServces,
...commonFunctionalServices,
};
export type FtrProviderContext = GenericFtrProviderContext<typeof services, typeof pageObjects>;

View file

@ -7,7 +7,7 @@
*/
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { services as commonServiceProviders } from '../../common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { AppsMenuService } from './apps_menu';
import {
@ -57,7 +57,7 @@ import { ESQLService } from './esql';
import { DataViewsService } from './data_views';
export const services = {
...commonServiceProviders,
...commonFunctionalServices,
...commonFunctionalUIServices,
filterBar: FilterBarService,
queryBar: QueryBarService,

View file

@ -6,11 +6,13 @@
* Side Public License, v 1.
*/
import { services as commonServices } from '../../common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { HealthGatewayService } from './health_gateway';
export const services = {
...commonServices,
...commonFunctionalServices,
...commonFunctionalUIServices,
healthGateway: HealthGatewayService,
};

View file

@ -12,13 +12,15 @@ import {
ElasticsearchSupertestProvider,
} from './services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
export default async function ({ readConfigFile }) {
const commonConfig = await readConfigFile(require.resolve('../common/config'));
const functionalConfig = await readConfigFile(require.resolve('../functional/config.base.js'));
return {
services: {
...commonConfig.get('services'),
...commonFunctionalServices,
supertest: createKibanaSupertestProvider(),
supertestWithoutAuth: KibanaSupertestWithoutAuthProvider,
esSupertest: ElasticsearchSupertestProvider,

View file

@ -7,7 +7,14 @@
*/
import { GenericFtrProviderContext } from '@kbn/test';
import { services as kibanaCommonServices } from '../../common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
export const kibanaCommonServices = {
...commonFunctionalServices,
...commonFunctionalUIServices,
} as const;
import { services as kibanaApiIntegrationServices } from '../../api_integration/services';
export type FtrProviderContext = GenericFtrProviderContext<

View file

@ -47,8 +47,6 @@
"@kbn/controls-plugin",
"@kbn/field-formats-plugin",
"@kbn/axe-config",
"@kbn/dev-cli-runner",
"@kbn/dev-cli-errors",
"@kbn/data-view-field-editor-plugin",
"@kbn/data-views-plugin",
"@kbn/guided-onboarding-plugin",
@ -71,7 +69,6 @@
"@kbn/links-plugin",
"@kbn/ftr-common-functional-ui-services",
"@kbn/monaco",
"@kbn/search-types",
"@kbn/console-plugin",
"@kbn/core-chrome-browser",
"@kbn/default-nav-ml",

View file

@ -7,6 +7,8 @@
import { FtrConfigProviderContext } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { cypressTestRunner } from './cypress_test_runner';
import { FtrProviderContext } from './ftr_provider_context';
@ -21,6 +23,11 @@ async function ftrConfig({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
...commonFunctionalUIServices,
},
esTestCluster: {
...xpackFunctionalTestsConfig.get('esTestCluster'),
serverArgs: [

View file

@ -14,6 +14,8 @@
"@kbn/dev-utils",
"@kbn/axe-config",
"@kbn/cypress-config",
"@kbn/apm-plugin"
"@kbn/apm-plugin",
"@kbn/ftr-common-functional-services",
"@kbn/ftr-common-functional-ui-services"
]
}

View file

@ -7,6 +7,8 @@
import { FtrConfigProviderContext } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import path from 'path';
const kibanaYamlFilePath = path.join(__dirname, './ftr_kibana.yml');
@ -22,6 +24,11 @@ async function ftrConfig({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
...commonFunctionalUIServices,
},
esTestCluster: {
...xpackFunctionalTestsConfig.get('esTestCluster'),
serverArgs: [

View file

@ -12,6 +12,8 @@
"@kbn/test",
"@kbn/dev-utils",
"@kbn/cypress-config",
"@kbn/observability-onboarding-plugin"
"@kbn/observability-onboarding-plugin",
"@kbn/ftr-common-functional-services",
"@kbn/ftr-common-functional-ui-services"
]
}

View file

@ -7,6 +7,8 @@
import { FtrConfigProviderContext } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import path from 'path';
const kibanaYamlFilePath = path.join(__dirname, './ftr_kibana.yml');
@ -22,6 +24,11 @@ async function ftrConfig({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
...commonFunctionalUIServices,
},
esTestCluster: {
...xpackFunctionalTestsConfig.get('esTestCluster'),
serverArgs: [

View file

@ -12,6 +12,8 @@
"@kbn/test",
"@kbn/dev-utils",
"@kbn/cypress-config",
"@kbn/observability-plugin"
"@kbn/observability-plugin",
"@kbn/ftr-common-functional-services",
"@kbn/ftr-common-functional-ui-services"
]
}

View file

@ -7,6 +7,8 @@
import { FtrConfigProviderContext } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { readKibanaConfig } from './tasks/read_kibana_config';
const MANIFEST_KEY = 'xpack.uptime.service.manifestUrl';
const SERVICE_PASSWORD = 'xpack.uptime.service.password';
@ -29,6 +31,11 @@ async function config({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
...commonFunctionalUIServices,
},
esTestCluster: {
...xpackFunctionalTestsConfig.get('esTestCluster'),
serverArgs: [

View file

@ -15,6 +15,7 @@
"@kbn/apm-plugin",
"@kbn/es-archiver",
"@kbn/repo-info",
"@kbn/synthetics-plugin"
"@kbn/synthetics-plugin",
"@kbn/ftr-common-functional-ui-services"
]
}

View file

@ -7,6 +7,8 @@
import { FtrConfigProviderContext } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { readKibanaConfig } from './tasks/read_kibana_config';
const MANIFEST_KEY = 'xpack.uptime.service.manifestUrl';
const SERVICE_PASSWORD = 'xpack.uptime.service.password';
@ -29,6 +31,11 @@ async function config({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
...commonFunctionalUIServices,
},
esTestCluster: {
...xpackFunctionalTestsConfig.get('esTestCluster'),
serverArgs: [

View file

@ -13,6 +13,7 @@
"@kbn/ux-plugin/e2e",
"@kbn/ftr-common-functional-services",
"@kbn/apm-plugin",
"@kbn/es-archiver"
"@kbn/es-archiver",
"@kbn/ftr-common-functional-ui-services"
]
}

View file

@ -11,7 +11,7 @@ import expect from '@kbn/expect';
import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common';
import type { IndexDetails } from '@kbn/cloud-security-posture-common';
import { CLOUD_SECURITY_PLUGIN_VERSION } from '@kbn/cloud-security-posture-plugin/common/constants';
import { SecurityService } from '@kbn/test-suites-src/common/services/security/security';
import { SecurityService } from '@kbn/ftr-common-functional-ui-services';
export interface RoleCredentials {
apiKey: { id: string; name: string };

View file

@ -26,7 +26,7 @@ import {
ELASTIC_HTTP_VERSION_HEADER,
X_ELASTIC_INTERNAL_ORIGIN_REQUEST,
} from '@kbn/core-http-common';
import type { SecurityService } from '@kbn/test-suites-src/common/services/security/security';
import type { SecurityService } from '@kbn/ftr-common-functional-ui-services';
import basicClusterFixture from './fixtures/basiccluster.json';
import multiClusterFixture from './fixtures/multicluster.json';
import type { FtrProviderContext } from '../../ftr_provider_context';

View file

@ -5,8 +5,8 @@
* 2.0.
*/
// NOTE: This is pretty much a copy/paste from test/common/services/bsearch.ts but with the ability
// to provide custom auth
// NOTE: This is pretty much a copy/paste from packages/kbn-ftr-common-functional-services/services/bsearch.ts
// but with the ability to provide custom auth
import expect from '@kbn/expect';
import request from 'superagent';

View file

@ -6,7 +6,8 @@
*/
import { services as kibanaApiIntegrationServices } from '@kbn/test-suites-src/api_integration/services';
import { services as kibanaCommonServices } from '@kbn/test-suites-src/common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { InfraLogViewsServiceProvider } from './infra_log_views';
import { SpacesServiceProvider } from './spaces';
import { BsearchSecureService } from './bsearch_secure';
@ -14,7 +15,8 @@ import { ApmSynthtraceKibanaClientProvider } from './apm_synthtrace_kibana_clien
import { InfraSynthtraceKibanaClientProvider } from './infra_synthtrace_kibana_client';
export const services = {
...kibanaCommonServices,
...commonFunctionalServices,
...commonFunctionalUIServices,
infraLogViews: InfraLogViewsServiceProvider,
supertest: kibanaApiIntegrationServices.supertest,
spaces: SpacesServiceProvider,

View file

@ -5,7 +5,7 @@
* 2.0.
*/
import type { SecurityService } from '@kbn/test-suites-src/common/services/security/security';
import type { SecurityService } from '@kbn/ftr-common-functional-ui-services';
export const testUsers: {
[rollName: string]: { username: string; password: string; permissions?: any };

View file

@ -6,7 +6,6 @@
*/
import { FtrConfigProviderContext, getKibanaCliLoggers } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
export default async function ({ readConfigFile }: FtrConfigProviderContext) {

View file

@ -6,6 +6,8 @@
*/
import { FtrConfigProviderContext } from '@kbn/test';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
import { EnterpriseSearchCypressCliTestRunner } from './runner';
export default async function ({ readConfigFile }: FtrConfigProviderContext) {
@ -16,6 +18,12 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
...commonFunctionalUIServices,
},
// default to the xpack functional config
...baseConfig.getAll(),

View file

@ -5,4 +5,10 @@
* 2.0.
*/
export * from '@kbn/test-suites-src/common/services';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
import { commonFunctionalUIServices } from '@kbn/ftr-common-functional-ui-services';
export const services = {
...commonFunctionalServices,
...commonFunctionalUIServices,
} as const;

View file

@ -8,7 +8,7 @@
/* eslint-disable no-console */
import { difference, union } from 'lodash';
import { SecurityService } from '@kbn/test-suites-src/common/services/security/security';
import type { SecurityService } from '@kbn/ftr-common-functional-ui-services';
import { Elasticsearch, Kibana } from '..';
import { callKibana, isAxiosError } from './call_kibana';

View file

@ -5,7 +5,7 @@
* 2.0.
*/
import { asyncForEach } from '@kbn/std';
import { SecurityService } from '@kbn/test-suites-src/common/services/security/security';
import type { SecurityService } from '@kbn/ftr-common-functional-ui-services';
import { ProfilingUsername, profilingUsers } from './authentication';
import { AbortError, callKibana } from './helpers/call_kibana';
import { createOrUpdateUser } from './helpers/create_or_update_user';

View file

@ -6,6 +6,7 @@
*/
import { FtrConfigProviderContext } from '@kbn/test';
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
export default async function ({ readConfigFile }: FtrConfigProviderContext) {
const kibanaCommonTestsConfig = await readConfigFile(
@ -15,6 +16,10 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services: {
...commonFunctionalServices,
},
testFiles: [require.resolve('./test')],
esTestCluster: {

View file

@ -9,7 +9,7 @@ import supertest from 'supertest';
import { format as formatUrl } from 'url';
import { IEsSearchResponse } from '@kbn/search-types';
import { RoleCredentials } from '@kbn/test-suites-serverless/shared/services';
import type { SendOptions } from '@kbn/test-suites-src/common/services/bsearch';
import type { SendOptions } from '@kbn/ftr-common-functional-services';
import type { SendOptions as SecureBsearchSendOptions } from '@kbn/test-suites-serverless/shared/services/bsearch_secure';
import type { FtrProviderContext } from '../../ftr_provider_context';
import type { SecuritySolutionUtilsInterface } from './types';

View file

@ -9,7 +9,7 @@ import TestAgent from 'supertest/lib/agent';
import type { IEsSearchResponse } from '@kbn/search-types';
import type { BsearchSecureService } from '@kbn/test-suites-serverless/shared/services/bsearch_secure';
import type { BsearchService, SendOptions } from '@kbn/test-suites-src/common/services/bsearch';
import type { BsearchService, SendOptions } from '@kbn/ftr-common-functional-services';
export interface SecuritySolutionServerlessBsearch extends Omit<BsearchSecureService, 'send'> {
send: <T extends IEsSearchResponse>(options: SendOptions) => Promise<T>;

View file

@ -5,7 +5,7 @@
* 2.0.
*/
import { SecurityService } from '@kbn/test-suites-src/common/services/security/security';
import type { SecurityService } from '@kbn/ftr-common-functional-ui-services';
export const usersAndRolesFactory = (security: SecurityService) => ({
createRole: async ({ name, privileges }: { name: string; privileges: any }) => {

View file

@ -11,7 +11,7 @@ import {
HostsQueries,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
import { hostDetailsFilebeatExpectedResult } from '../mocks/host_details';

View file

@ -16,7 +16,7 @@ import {
FirstLastSeenStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

View file

@ -12,7 +12,7 @@ import {
HostsUncommonProcessesStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
const FROM = '2000-01-01T00:00:00.000Z';

View file

@ -11,7 +11,7 @@ import {
NetworkQueries,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

View file

@ -14,7 +14,7 @@ import {
NetworkDnsStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
export default function ({ getService }: FtrProviderContextWithSpaces) {

View file

@ -15,7 +15,7 @@ import {
NetworkTopNFlowStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

View file

@ -14,7 +14,8 @@ import {
NetworkTlsStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

View file

@ -12,7 +12,7 @@ import {
HostsOverviewStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
export default function ({ getService }: FtrProviderContextWithSpaces) {

View file

@ -11,7 +11,7 @@ import {
NetworkQueries,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
export default function ({ getService }: FtrProviderContextWithSpaces) {

View file

@ -15,7 +15,7 @@ import {
import type { UserAuthenticationsRequestOptions } from '@kbn/security-solution-plugin/common/api/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
const FROM = '2000-01-01T00:00:00.000Z';

View file

@ -14,7 +14,8 @@ import {
NetworkUsersStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';

View file

@ -14,8 +14,9 @@ import {
TimelineEventsAllStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
import { getFieldsToRequest, getFilterValue } from '../../../../utils';
const TO = '3000-01-01T00:00:00.000Z';

View file

@ -13,7 +13,8 @@ import {
TimelineKpiStrategyResponse,
} from '@kbn/security-solution-plugin/common/search_strategy';
import TestAgent from 'supertest/lib/agent';
import { BsearchService } from '@kbn/test-suites-src/common/services/bsearch';
import { BsearchService } from '@kbn/ftr-common-functional-services';
import { FtrProviderContextWithSpaces } from '../../../../../ftr_provider_context_with_spaces';
import { timelineDetailsFilebeatExpectedResults as EXPECTED_DATA } from '../mocks/timeline_details';

View file

@ -49,6 +49,6 @@
"@kbn/dev-cli-runner",
"@kbn/search-types",
"@kbn/security-plugin",
"@kbn/test-suites-src",
"@kbn/ftr-common-functional-ui-services",
]
}

View file

@ -6,9 +6,8 @@
*/
import { FtrConfigProviderContext } from '@kbn/test';
import { CA_CERT_PATH } from '@kbn/dev-utils';
import { services } from './services';
export default async function ({ readConfigFile }: FtrConfigProviderContext) {
const kibanaCommonTestsConfig = await readConfigFile(
require.resolve('@kbn/test-suites-src/common/config')
@ -20,6 +19,8 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
return {
...kibanaCommonTestsConfig.getAll(),
services,
esTestCluster: {
...xpackFunctionalTestsConfig.get('esTestCluster'),
serverArgs: [

View file

@ -5,6 +5,8 @@
* 2.0.
*/
import { commonFunctionalServices } from '@kbn/ftr-common-functional-services';
export default async function ({ readConfigFile }) {
// Read the Kibana API integration tests config file so that we can utilize its services.
const kibanaAPITestsConfig = await readConfigFile(
@ -13,15 +15,12 @@ export default async function ({ readConfigFile }) {
const xPackFunctionalTestsConfig = await readConfigFile(
require.resolve('../functional/config.base.js')
);
const kibanaCommonConfig = await readConfigFile(
require.resolve('@kbn/test-suites-src/common/config')
);
return {
testFiles: [require.resolve('./upgrade_assistant')],
servers: xPackFunctionalTestsConfig.get('servers'),
services: {
...kibanaCommonConfig.get('services'),
...commonFunctionalServices,
supertest: kibanaAPITestsConfig.get('services.supertest'),
},
junit: {

View file

@ -11,7 +11,7 @@ import { InternalRequestHeader, RoleCredentials } from '../../../../shared/servi
export default ({ getService }: FtrProviderContext) => {
const svlCommonApi = getService('svlCommonApi');
const consoleService = getService('console');
const console = getService('console');
const svlUserManager = getService('svlUserManager');
const supertestWithoutAuth = getService('supertestWithoutAuth');
@ -27,17 +27,6 @@ export default ({ getService }: FtrProviderContext) => {
};
describe('/api/console/autocomplete_entities', function () {
let createIndex: (typeof consoleService)['helpers']['createIndex'];
let createAlias: (typeof consoleService)['helpers']['createAlias'];
let createIndexTemplate: (typeof consoleService)['helpers']['createIndexTemplate'];
let createComponentTemplate: (typeof consoleService)['helpers']['createComponentTemplate'];
let createDataStream: (typeof consoleService)['helpers']['createDataStream'];
let deleteIndex: (typeof consoleService)['helpers']['deleteIndex'];
let deleteAlias: (typeof consoleService)['helpers']['deleteAlias'];
let deleteIndexTemplate: (typeof consoleService)['helpers']['deleteIndexTemplate'];
let deleteComponentTemplate: (typeof consoleService)['helpers']['deleteComponentTemplate'];
let deleteDataStream: (typeof consoleService)['helpers']['deleteDataStream'];
const indexName = 'test-index-1';
const aliasName = 'test-alias-1';
const indexTemplateName = 'test-index-template-1';
@ -47,36 +36,26 @@ export default ({ getService }: FtrProviderContext) => {
before(async () => {
roleAuthc = await svlUserManager.createM2mApiKeyWithRoleScope('admin');
internalRequestHeader = svlCommonApi.getInternalRequestHeader();
({
helpers: {
createIndex,
createAlias,
createIndexTemplate,
createComponentTemplate,
createDataStream,
deleteIndex,
deleteAlias,
deleteIndexTemplate,
deleteComponentTemplate,
deleteDataStream,
},
} = consoleService);
// Setup indices, aliases, templates, and data streams
await createIndex(indexName);
await createAlias(indexName, aliasName);
await createComponentTemplate(componentTemplateName);
await createIndexTemplate(indexTemplateName, [dataStreamName], [componentTemplateName]);
await createDataStream(dataStreamName);
await console.createIndex(indexName);
await console.createAlias(indexName, aliasName);
await console.createComponentTemplate(componentTemplateName);
await console.createIndexTemplate(
indexTemplateName,
[dataStreamName],
[componentTemplateName]
);
await console.createDataStream(dataStreamName);
});
after(async () => {
// Cleanup indices, aliases, templates, and data streams
await deleteAlias(indexName, aliasName);
await deleteIndex(indexName);
await deleteDataStream(dataStreamName);
await deleteIndexTemplate(indexTemplateName);
await deleteComponentTemplate(componentTemplateName);
await console.deleteAlias(indexName, aliasName);
await console.deleteIndex(indexName);
await console.deleteDataStream(dataStreamName);
await console.deleteIndexTemplate(indexTemplateName);
await console.deleteComponentTemplate(componentTemplateName);
await svlUserManager.invalidateM2mApiKeyWithRoleScope(roleAuthc);
});

View file

@ -5,8 +5,8 @@
* 2.0.
*/
// NOTE: This is pretty much a copy/paste from test/common/services/bsearch.ts but with the ability
// to provide custom auth
// NOTE: This is pretty much a copy/paste from packages/kbn-ftr-common-functional-services/services/bsearch.ts
// but with the ability to provide custom auth
import expect from '@kbn/expect';
import { GenericFtrService } from '@kbn/test';