github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix issue, where tags are vanishing after double resize (#14822) (#14899)

Browse source 
* Fix issue, where tags vanishing after resizing

* Also fix rawText in debug log
This commit is contained in:
Tim Roes 2017-11-10 17:46:53 +01:00 • committed by GitHub
parent d813d99caa
commit 6996d0599b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core_plugins/tagcloud/public/tag_cloud.js
View file

@ -281,7 +281,7 @@ class TagCloud extends EventEmitter {
y: tag.y,
rotate: tag.rotate,
size: tag.size,
rawText: tag.text,
rawText: tag.rawText || tag.text,
displayText: tag.displayText
};
})
@ -339,7 +339,7 @@ class TagCloud extends EventEmitter {
debug.positions = this._completedJob ? this._completedJob.words.map(tag => {
return {
displayText: tag.displayText,
rawText: tag.text,
rawText: tag.rawText || tag.text,
x: tag.x,
y: tag.y,
rotate: tag.rotate

12
test/functional/apps/visualize/_tag_cloud.js
View file

@ -60,6 +60,18 @@ export default function ({ getService, getPageObjects }) {
expect(data).to.eql([ '32,212,254,720', '21,474,836,480', '20,401,094,656', '19,327,352,832', '18,253,611,008' ]);
});
it('should still show all tags after sidebar has been collapsed', async function () {
await PageObjects.visualize.clickEditorSidebarCollapse();
// Give d3 tag cloud some time to rearrange tags
await PageObjects.common.sleep(1000);
await PageObjects.visualize.clickEditorSidebarCollapse();
// Give d3 tag cloud some time to rearrange tags
await PageObjects.common.sleep(1000);
const data = await PageObjects.visualize.getTextTag();
log.debug(data);
expect(data).to.eql([ '32,212,254,720', '21,474,836,480', '20,401,094,656', '19,327,352,832', '18,253,611,008' ]);
});
it('should save and load', function () {
return PageObjects.visualize.saveVisualization(vizName1)
.then(function (message) {

4
test/functional/page_objects/visualize_page.js
View file

@ -60,6 +60,10 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
await find.clickByPartialLinkText('Visual Builder');
}
async clickEditorSidebarCollapse() {
await testSubjects.click('collapseSideBarButton');
}
async selectTagCloudTag(tagDisplayText) {
await testSubjects.click(tagDisplayText);
}