mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
# Backport This will backport the following commits from `main` to `9.0`: - [[A11y][APM] Add `aria-label` to popover service in service overview (#215640)](https://github.com/elastic/kibana/pull/215640) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2025-03-24T12:54:30Z","message":"[A11y][APM] Add `aria-label` to popover service in service overview (#215640)\n\n## Summary\n\nFixes #210258\n\nThis PR adds an `aria-label` with the same content as the title to solve\nthe \"Button must have a discernible text\" A11y critical issue.\n\n## How to test\n1. Download the [axe\ndevtools](https://chromewebstore.google.com/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd)\n2. Go into a service overview and run the scanner from axe devtools\n3. You should see a critical error\n4. Checkout this branch\n5. Error should be solved","sha":"2654b8c702ae29dd2aad4fe9471d95dbdd8b17df","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-infra_services","backport:version","a11y","v8.18.0","v9.1.0","v8.19.0"],"title":"[A11y][APM] Add `aria-label` to popover service in service overview","number":215640,"url":"https://github.com/elastic/kibana/pull/215640","mergeCommit":{"message":"[A11y][APM] Add `aria-label` to popover service in service overview (#215640)\n\n## Summary\n\nFixes #210258\n\nThis PR adds an `aria-label` with the same content as the title to solve\nthe \"Button must have a discernible text\" A11y critical issue.\n\n## How to test\n1. Download the [axe\ndevtools](https://chromewebstore.google.com/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd)\n2. Go into a service overview and run the scanner from axe devtools\n3. You should see a critical error\n4. Checkout this branch\n5. Error should be solved","sha":"2654b8c702ae29dd2aad4fe9471d95dbdd8b17df"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215640","number":215640,"mergeCommit":{"message":"[A11y][APM] Add `aria-label` to popover service in service overview (#215640)\n\n## Summary\n\nFixes #210258\n\nThis PR adds an `aria-label` with the same content as the title to solve\nthe \"Button must have a discernible text\" A11y critical issue.\n\n## How to test\n1. Download the [axe\ndevtools](https://chromewebstore.google.com/detail/axe-devtools-web-accessib/lhdoppojpmngadmnindnejefpokejbdd)\n2. Go into a service overview and run the scanner from axe devtools\n3. You should see a critical error\n4. Checkout this branch\n5. Error should be solved","sha":"2654b8c702ae29dd2aad4fe9471d95dbdd8b17df"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
This commit is contained in:
parent
ba6aa259b1
commit
6a0e800bf9
1 changed files with 1 additions and 0 deletions
|
@ -43,6 +43,7 @@ export function IconPopover({
|
|||
color="text"
|
||||
onClick={onClick}
|
||||
iconType={icon.type}
|
||||
aria-label={title}
|
||||
iconSize={icon.size ?? 'l'}
|
||||
className="serviceIcon_button"
|
||||
data-test-subj={`popover_${title}`}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue