github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ObsUX][APM][Profiling] Update documentation links to use doc link service instead of hardcoded URLs (#212051)

Browse source 
## Summary

Closes #208895

This PR updates documentation links to use the doc link service, to
avoid hardcoding URLs
This commit is contained in:
Sergi Romeu 2025-02-21 15:52:40 +01:00 • committed by GitHub
parent 8ab9b66a80
commit 6a6f0e70b3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

7
x-pack/solutions/observability/plugins/apm/public/components/fleet_integration/apm_policy_form/settings_definition/tail_sampling_settings.test.tsx
View file

@ -4,12 +4,13 @@
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { docLinksServiceMock } from '@kbn/core/public/mocks';
import { getTailSamplingSettings, isTailBasedSamplingValid } from './tail_sampling_settings';
const DOCS_LINK =
'https://www.elastic.co/guide/en/apm/guide/current/configure-tail-based-sampling.html';
describe('tail_sampling_settings - isTailBasedSamplingFormValid', () => {
const docLinks = docLinksServiceMock.createStartContract();
const DOCS_LINK = docLinks.links.apm.tailSamplingPolicies;
it('return true when tail_sampling_interval is greater than 1s', () => {
const settings = getTailSamplingSettings(DOCS_LINK);
const isValid = isTailBasedSamplingValid(

12
x-pack/solutions/observability/plugins/profiling/public/views/add_data_view/index.tsx
View file

@ -68,6 +68,7 @@ export function AddDataView() {
services: { setupDataCollectionInstructions },
start: { core },
} = useProfilingDependencies();
const { docLinks } = core;
const { data, status } = useAsync(
({ http }) => {
@ -410,7 +411,7 @@ EOF`}
<EuiLink
data-test-subj="profilingAddDataViewInstructionsHereLink"
target="_blank"
href={`https://www.elastic.co/guide/en/kibana/current/api-keys.html`}
href={docLinks.links.management.apiKeys}
>
{i18n.translate('xpack.profiling.tabs.symbols.step2.instructions', {
defaultMessage: 'Instructions here',
@ -455,7 +456,7 @@ EOF`}
<EuiLink
data-test-subj="profilingAddDataViewTheCorrespondingDocumentationPageLink"
target="_blank"
href={`${core.docLinks.ELASTIC_WEBSITE_URL}/guide/en/observability/${core.docLinks.DOC_LINK_VERSION}/profiling-add-symbols.html`}
href={`${docLinks.ELASTIC_WEBSITE_URL}/guide/en/observability/${docLinks.DOC_LINK_VERSION}/profiling-add-symbols.html`}
>
{i18n.translate('xpack.profiling.tabs.symbols.step3.doc-ref.link', {
defaultMessage: 'the corresponding documentation page',
@ -475,8 +476,9 @@ EOF`}
],
[
collectionAgentHost,
core.docLinks.DOC_LINK_VERSION,
core.docLinks.ELASTIC_WEBSITE_URL,
docLinks.DOC_LINK_VERSION,
docLinks.ELASTIC_WEBSITE_URL,
docLinks.links.management.apiKeys,
core.http.basePath,
data?.profilerAgent.version,
majorVersion,
@ -593,7 +595,7 @@ EOF`}
<EuiLink
data-test-subj="profilingAddDataViewAdvancedConfigurationLink"
target="_blank"
href={`${core.docLinks.ELASTIC_WEBSITE_URL}/guide/en/observability/${core.docLinks.DOC_LINK_VERSION}/profiling-advanced-configuration.html`}
href={`${docLinks.ELASTIC_WEBSITE_URL}/guide/en/observability/${docLinks.DOC_LINK_VERSION}/profiling-advanced-configuration.html`}
>
{i18n.translate('xpack.profiling.tabs.debWarning.advancedLink', {
defaultMessage: 'Advanced configuration',