github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[test] Fix wrong waiting on toast message (#22131) (#22153)

Browse source
This commit is contained in:
Marco Vettorello 2018-08-17 22:36:11 +02:00 • committed by GitHub
parent 5d28825cfb
commit 6b4c015530
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 18 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/functional/apps/visualize/_area_chart.js
View file

@ -62,7 +62,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizNamewithSpecialChars);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
});
it('should save and load with non-ascii characters', async function () {
@ -78,7 +78,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Saved viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();
return PageObjects.common.sleep(2000);

2
test/functional/apps/visualize/_data_table.js
View file

@ -71,7 +71,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();
});

4
test/functional/apps/visualize/_heatmap_chart.js
View file

@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();
});
@ -62,7 +62,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.waitForVisualization();

2
test/functional/apps/visualize/_line_chart.js
View file

@ -118,7 +118,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();
});

4
test/functional/apps/visualize/_pie_chart.js
View file

@ -55,7 +55,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();
// sleep a bit before trying to get the pie chart data below
@ -143,7 +143,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();

2
test/functional/apps/visualize/_tag_cloud.js
View file

@ -105,7 +105,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.visualize.waitForVisualization();
});

2
test/functional/apps/visualize/_vertical_bar_chart.js
View file

@ -57,7 +57,7 @@ export default function ({ getService, getPageObjects }) {
const pageTitle = await PageObjects.common.getBreadcrumbPageTitle();
log.debug(`Save viz page title is ${pageTitle}`);
expect(pageTitle).to.contain(vizName1);
await PageObjects.header.waitForToastMessageGone();
await PageObjects.visualize.waitForVisualizationSavedToastGone();
await PageObjects.visualize.loadSavedVisualization(vizName1);
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.visualize.waitForVisualization();

5
test/functional/page_objects/header_page.js
View file

@ -236,11 +236,6 @@ export function HeaderPageProvider({ getService, getPageObjects }) {
return messageText;
}
async waitForToastMessageGone() {
remote.setFindTimeout(defaultFindTimeout);
await remote.waitForDeletedByCssSelector('kbn-truncated.toast-message');
}
async clickToastOK() {
log.debug('clickToastOK');
await retry.try(async () => {

4
test/functional/page_objects/visualize_page.js
View file

@ -927,6 +927,10 @@ export function VisualizePageProvider({ getService, getPageObjects }) {
return await find.byCssSelector('.visualization');
}
async waitForVisualizationSavedToastGone() {
return await testSubjects.waitForDeleted('saveVisualizationSuccess');
}
async getZoomSelectors(zoomSelector) {
return await find.allByCssSelector(zoomSelector);
}

4
test/functional/services/test_subjects.js
View file

@ -190,6 +190,10 @@ export function TestSubjectsProvider({ getService }) {
return await mapAsync(elements, mapFn);
});
}
async waitForDeleted(selector) {
await remote.waitForDeletedByCssSelector(testSubjSelector(selector));
}
}
return new TestSubjects();