github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.14] [Search/Connector] Make minute-level scheduling default option in ConnectorCronEditor (#189250) (#189276)

Browse source 
# Backport

This will backport the following commits from `main` to `8.14`:
- [[Search/Connector] Make minute-level scheduling default option in
ConnectorCronEditor
(#189250)](https://github.com/elastic/kibana/pull/189250)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jedr
Blaszyk","email":"jedrazb@gmail.com"},"sourceCommit":{"committedDate":"2024-07-26T12:04:03Z","message":"[Search/Connector]
Make minute-level scheduling default option in ConnectorCronEditor
(#189250)\n\n## Summary\r\n\r\nEnable minute level scheduling in UI for
all connector sync jobs. This\r\nfixes the bug with minute level
scheduling not present for incremental\r\nsync jobs.\r\n\r\nIt seems
that during
[this\r\nmigration](bb5ca2e187 (diff-328630e75e33bdb823bad243330681942ab5a391c5b83cad7f3186c4ca651e9dL219))\r\nthe
minute level scheduling for incremental syncs was lost
somehow.\r\n\r\nAs of now the `ConnectorCronEditor` is only used for
connector sync\r\njobs, all connector sync jobs support minute-level
scheduling so I\r\ndeleted the `MINUTE` from default
`frequencyBlockList` in the component.\r\n\r\n<img width=\"680\"
alt=\"Screenshot 2024-07-26 at 10 32
16\"\r\nsrc=\"https://github.com/user-attachments/assets/7070227e-b332-4217-beea-a169c8b3d4fc\">","sha":"754de3be4f1f09e5868384c6dee76d3428159c2d","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.14.0","v8.15.0","v8.16.0"],"title":"[Search/Connector]
Make minute-level scheduling default option in
ConnectorCronEditor","number":189250,"url":"https://github.com/elastic/kibana/pull/189250","mergeCommit":{"message":"[Search/Connector]
Make minute-level scheduling default option in ConnectorCronEditor
(#189250)\n\n## Summary\r\n\r\nEnable minute level scheduling in UI for
all connector sync jobs. This\r\nfixes the bug with minute level
scheduling not present for incremental\r\nsync jobs.\r\n\r\nIt seems
that during
[this\r\nmigration](bb5ca2e187 (diff-328630e75e33bdb823bad243330681942ab5a391c5b83cad7f3186c4ca651e9dL219))\r\nthe
minute level scheduling for incremental syncs was lost
somehow.\r\n\r\nAs of now the `ConnectorCronEditor` is only used for
connector sync\r\njobs, all connector sync jobs support minute-level
scheduling so I\r\ndeleted the `MINUTE` from default
`frequencyBlockList` in the component.\r\n\r\n<img width=\"680\"
alt=\"Screenshot 2024-07-26 at 10 32
16\"\r\nsrc=\"https://github.com/user-attachments/assets/7070227e-b332-4217-beea-a169c8b3d4fc\">","sha":"754de3be4f1f09e5868384c6dee76d3428159c2d"}},"sourceBranch":"main","suggestedTargetBranches":["8.14","8.15"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189250","number":189250,"mergeCommit":{"message":"[Search/Connector]
Make minute-level scheduling default option in ConnectorCronEditor
(#189250)\n\n## Summary\r\n\r\nEnable minute level scheduling in UI for
all connector sync jobs. This\r\nfixes the bug with minute level
scheduling not present for incremental\r\nsync jobs.\r\n\r\nIt seems
that during
[this\r\nmigration](bb5ca2e187 (diff-328630e75e33bdb823bad243330681942ab5a391c5b83cad7f3186c4ca651e9dL219))\r\nthe
minute level scheduling for incremental syncs was lost
somehow.\r\n\r\nAs of now the `ConnectorCronEditor` is only used for
connector sync\r\njobs, all connector sync jobs support minute-level
scheduling so I\r\ndeleted the `MINUTE` from default
`frequencyBlockList` in the component.\r\n\r\n<img width=\"680\"
alt=\"Screenshot 2024-07-26 at 10 32
16\"\r\nsrc=\"https://github.com/user-attachments/assets/7070227e-b332-4217-beea-a169c8b3d4fc\">","sha":"754de3be4f1f09e5868384c6dee76d3428159c2d"}}]}]
BACKPORT-->

Co-authored-by: Jedr Blaszyk <jedrazb@gmail.com>
This commit is contained in:
Kibana Machine 2024-07-26 16:04:17 +02:00 • committed by GitHub
parent 779020a250
commit 6b50d4909a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/kbn-search-connectors/components/scheduling/connector_cron_editor.tsx
View file

@ -26,7 +26,7 @@ interface ConnectorCronEditorProps {
export const ConnectorCronEditor: React.FC<ConnectorCronEditorProps> = ({
dataTelemetryIdPrefix,
disabled = false,
frequencyBlockList = ['MINUTE'],
frequencyBlockList = [],
hasSyncTypeChanges,
onReset,
onSave,

3
packages/kbn-search-connectors/components/scheduling/full_content.tsx
View file

@ -216,9 +216,6 @@ export const ConnectorContentScheduling: React.FC<ConnectorContentSchedulingProp
hasSyncTypeChanges={hasSyncTypeChanges}
setHasSyncTypeChanges={setHasSyncTypeChanges}
disabled={isGated}
frequencyBlockList={
type === SyncJobType.ACCESS_CONTROL || type === SyncJobType.FULL ? [] : undefined
}
scheduling={scheduling[type]}
onReset={() => {
setScheduling({