[5.x] Remaining default to named conversions in ui/public (#11323) (#11351)

* Remaining default to named conversions in ui/public (#11323)

* use named ui-modules

* x-pack conversion is checked in so no need for the default uiModules export

* Final removal of all export default in ui/public

And turned on the eslint rule for that folder.

* Moe import to top of file

* Convert remaining default exports in 5.x to get tests passing with the new rule

src/core_plugins/console/public/src/input.js

@@ -7,7 +7,7 @@ let settings = require('./settings');
 let utils = require('./utils');
 let es = require('./es');
 let history = require('./history');
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 let input;
 export function initializeInput($el, $actionsEl, $copyAsCurlEl, output) {

src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import heatmapOptionsTemplate from 'plugins/kbn_vislib_vis_types/controls/heatmap_options.html';
 import _ from 'lodash';
 const module = uiModules.get('kibana');

src/core_plugins/kbn_vislib_vis_types/public/controls/line_interpolation_option.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import lineInterpolationOptionTemplate from 'plugins/kbn_vislib_vis_types/controls/line_interpolation_option.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kbn_vislib_vis_types/public/controls/point_series/category_axis.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import vislibValueAxesTemplate from 'plugins/kbn_vislib_vis_types/controls/point_series/category_axis.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kbn_vislib_vis_types/public/controls/point_series/grid.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import vislibGridTemplate from 'plugins/kbn_vislib_vis_types/controls/point_series/grid.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kbn_vislib_vis_types/public/controls/point_series/series.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import vislibSeriesTemplate from 'plugins/kbn_vislib_vis_types/controls/point_series/series.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kbn_vislib_vis_types/public/controls/point_series/value_axes.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import vislibValueAxesTemplate from 'plugins/kbn_vislib_vis_types/controls/point_series/value_axes.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kbn_vislib_vis_types/public/controls/point_series_options.js

@@ -1,5 +1,5 @@
 import 'ui/directives/inequality';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import pointSeriesOptionsTemplate from 'plugins/kbn_vislib_vis_types/controls/point_series_options.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import vislibBasicOptionsTemplate from 'plugins/kbn_vislib_vis_types/controls/vislib_basic_options.html';
 const module = uiModules.get('kibana');
 

src/core_plugins/kibana/public/context/app.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import contextAppTemplate from './app.html';
 import './components/loading_button';
 import './components/size_picker/size_picker';

src/core_plugins/kibana/public/context/components/loading_button/loading_button.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import contextLoadingButtonTemplate from './loading_button.html';
 
 

src/core_plugins/kibana/public/context/components/size_picker/size_picker.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import contextSizePickerTemplate from './size_picker.html';
 import './size_picker.less';
 

src/core_plugins/kibana/public/dashboard/dashboard.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import angular from 'angular';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import uiRoutes from 'ui/routes';
 import chrome from 'ui/chrome';
 

src/core_plugins/kibana/public/dashboard/grid.js

@@ -3,7 +3,7 @@ import $ from 'jquery';
 import { Binder } from 'ui/binder';
 import chrome from 'ui/chrome';
 import 'gridster';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { DashboardViewMode } from 'plugins/kibana/dashboard/dashboard_view_mode';
 import { PanelUtils } from 'plugins/kibana/dashboard/panel/panel_utils';
 

src/core_plugins/kibana/public/dashboard/panel/get_object_loaders_for_dashboard.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('app/dashboard');
 
 /**

src/core_plugins/kibana/public/dashboard/panel/panel.js

@@ -4,7 +4,7 @@ import 'ui/doc_table';
 import * as columnActions from 'ui/doc_table/actions/columns';
 import 'plugins/kibana/dashboard/panel/get_object_loaders_for_dashboard';
 import { FilterManagerProvider } from 'ui/filter_manager';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import panelTemplate from 'plugins/kibana/dashboard/panel/panel.html';
 import { savedObjectManagementRegistry } from 'plugins/kibana/management/saved_object_registry';
 import { getPersistedStateId } from 'plugins/kibana/dashboard/panel/panel_state';

src/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboard.js

@@ -1,6 +1,6 @@
 import angular from 'angular';
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('app/dashboard');
 
 // Used only by the savedDashboards service, usually no reason to change this

src/core_plugins/kibana/public/dashboard/saved_dashboard/saved_dashboards.js

@@ -1,5 +1,5 @@
 import 'plugins/kibana/dashboard/saved_dashboard/saved_dashboard';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { SavedObjectLoader } from 'ui/courier/saved_object/saved_object_loader';
 import { savedObjectManagementRegistry } from 'plugins/kibana/management/saved_object_registry';
 

src/core_plugins/kibana/public/dev_tools/directives/dev_tools_app.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { DevToolsRegistryProvider } from 'ui/registry/dev_tools';
 import template from 'plugins/kibana/dev_tools/partials/dev_tools_app.html';
 import 'plugins/kibana/dev_tools/styles/dev_tools_app.less';

src/core_plugins/kibana/public/dev_tools/hacks/hide_empty_tools.js

@@ -1,4 +1,4 @@
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import chrome from 'ui/chrome';
 import { DevToolsRegistryProvider } from 'ui/registry/dev_tools';
 
@@ -10,4 +10,4 @@ export function hideEmptyDevTools(Private) {
   }
 }
 
-modules.get('kibana').run(hideEmptyDevTools);
+uiModules.get('kibana').run(hideEmptyDevTools);

src/core_plugins/kibana/public/discover/components/field_chooser/discover_field.js

@@ -4,7 +4,7 @@ import _ from 'lodash';
 import 'ui/directives/css_truncate';
 import 'ui/directives/field_name';
 import detailsHtml from 'plugins/kibana/discover/components/field_chooser/lib/detail_views/string.html';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const app = uiModules.get('apps/discover');
 
 

src/core_plugins/kibana/public/discover/components/field_chooser/field_chooser.js

@@ -8,7 +8,7 @@ import $ from 'jquery';
 import rison from 'rison-node';
 import { fieldCalculator } from 'plugins/kibana/discover/components/field_chooser/lib/field_calculator';
 import { IndexPatternsFieldListProvider } from 'ui/index_patterns/_field_list';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import fieldChooserTemplate from 'plugins/kibana/discover/components/field_chooser/field_chooser.html';
 const app = uiModules.get('apps/discover');
 

src/core_plugins/kibana/public/discover/controllers/discover.js

@@ -24,7 +24,7 @@ import { FilterManagerProvider } from 'ui/filter_manager';
 import { AggTypesBucketsIntervalOptionsProvider } from 'ui/agg_types/buckets/_interval_options';
 import { stateMonitorFactory } from 'ui/state_management/state_monitor_factory';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import indexTemplate from 'plugins/kibana/discover/index.html';
 import { StateProvider } from 'ui/state_management/state';
 

src/core_plugins/kibana/public/discover/directives/no_results.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import noResultsTemplate from '../partials/no_results.html';
 
 uiModules

src/core_plugins/kibana/public/discover/directives/timechart.js

@@ -1,5 +1,5 @@
 import VislibProvider from 'ui/vislib';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 uiModules
 .get('apps/discover')
 .directive('discoverTimechart', function (Private) {

src/core_plugins/kibana/public/discover/saved_searches/_saved_search.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import 'ui/notify';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 
 const module = uiModules.get('discover/saved_searches', [

src/core_plugins/kibana/public/discover/saved_searches/saved_searches.js

@@ -1,6 +1,6 @@
 import 'plugins/kibana/discover/saved_searches/_saved_search';
 import 'ui/notify';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { SavedObjectLoader } from 'ui/courier/saved_object/saved_object_loader';
 import { savedObjectManagementRegistry } from 'plugins/kibana/management/saved_object_registry';
 const module = uiModules.get('discover/saved_searches', [

src/core_plugins/kibana/public/doc/controllers/doc.js

@@ -4,7 +4,7 @@ import 'ui/doc_viewer';
 import 'ui/index_patterns';
 import html from 'plugins/kibana/doc/index.html';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 
 const app = uiModules.get('apps/doc', [

src/core_plugins/kibana/public/kibana.js

@@ -4,7 +4,7 @@
 import moment from 'moment-timezone';
 import chrome from 'ui/chrome';
 import routes from 'ui/routes';
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 import 'ui/autoload/all';
 import 'plugins/kibana/discover/index';
@@ -48,4 +48,4 @@ chrome
   }
 });
 
-modules.get('kibana').run(Notifier.pullMessageFromUrl);
+uiModules.get('kibana').run(Notifier.pullMessageFromUrl);

src/core_plugins/kibana/public/management/index.js

@@ -3,7 +3,7 @@ import 'plugins/kibana/management/styles/main.less';
 import 'ui/filters/start_from';
 import 'ui/field_editor';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import appTemplate from 'plugins/kibana/management/app.html';
 import landingTemplate from 'plugins/kibana/management/landing.html';
 import { management } from 'ui/management';

src/core_plugins/kibana/public/management/sections/indices/create_index_pattern/create_index_pattern.js

@@ -4,7 +4,7 @@ import 'ui/directives/validate_index_name';
 import 'ui/directives/auto_select_if_only_one';
 import { RefreshKibanaIndex } from '../refresh_kibana_index';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import template from './create_index_pattern.html';
 import { getDefaultPatternForInterval } from './get_default_pattern_for_interval';
 import { sendCreateIndexPatternRequest } from './send_create_index_pattern_request';

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/edit_index_pattern.js

@@ -8,7 +8,7 @@ import { RefreshKibanaIndex } from '../refresh_kibana_index';
 import UrlProvider from 'ui/url';
 import { IndicesEditSectionsProvider } from './edit_sections';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import template from './edit_index_pattern.html';
 
 uiRoutes

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/index_header/index_header.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import template from './index_header.html';
 uiModules
 .get('apps/management')

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/indexed_fields_table/indexed_fields_table.js

@@ -3,7 +3,7 @@ import 'ui/paginated_table';
 import fieldNameHtml from './field_name.html';
 import fieldTypeHtml from './field_type.html';
 import fieldControlsHtml from '../field_controls.html';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { FieldWildcardProvider } from 'ui/field_wildcard';
 import template from './indexed_fields_table.html';
 

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/scripted_fields_table/scripted_fields_table.js

@@ -2,9 +2,9 @@ import _ from 'lodash';
 import 'ui/paginated_table';
 import fieldControlsHtml from '../field_controls.html';
 import { dateScripts } from './date_scripts';
-import uiModules from 'ui/modules';
 import { getSupportedScriptingLangs } from 'ui/scripting_langs';
 import { scriptedFields as docLinks } from 'ui/documentation_links/documentation_links';
+import { uiModules } from 'ui/modules';
 import template from './scripted_fields_table.html';
 
 uiModules.get('apps/management')

src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/source_filters_table/source_filters_table.js

@@ -1,6 +1,6 @@
 import { find, each, escape, invoke, size, without } from 'lodash';
 
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { Notifier } from 'ui/notify/notifier';
 import { FieldWildcardProvider } from 'ui/field_wildcard';
 

src/core_plugins/kibana/public/management/sections/indices/index.js

@@ -2,7 +2,7 @@ import { management } from 'ui/management';
 import './create_index_pattern';
 import './edit_index_pattern';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import indexTemplate from 'plugins/kibana/management/sections/indices/index.html';
 
 const indexPatternsResolutions = {

src/core_plugins/kibana/public/management/sections/objects/_objects.js

@@ -5,7 +5,7 @@ import { savedObjectManagementRegistry } from 'plugins/kibana/management/saved_o
 import objectIndexHTML from 'plugins/kibana/management/sections/objects/_objects.html';
 import 'ui/directives/file_upload';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiRoutes
 .when('/management/kibana/objects', {

src/core_plugins/kibana/public/management/sections/objects/_view.js

@@ -5,7 +5,7 @@ import { savedObjectManagementRegistry } from 'plugins/kibana/management/saved_o
 import objectViewHTML from 'plugins/kibana/management/sections/objects/_view.html';
 import { IndexPatternsCastMappingTypeProvider } from 'ui/index_patterns/_cast_mapping_type';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiRoutes
 .when('/management/kibana/objects/:service/:id', {

src/core_plugins/kibana/public/management/sections/objects/index.js

@@ -3,7 +3,7 @@ import 'plugins/kibana/management/sections/objects/_view';
 import 'plugins/kibana/management/sections/objects/_objects';
 import 'ace';
 import 'ui/directives/confirm_click';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 // add the module deps to this module
 uiModules.get('apps/management');

src/core_plugins/kibana/public/management/sections/settings/advanced_row.js

@@ -1,6 +1,6 @@
 import 'ui/elastic_textarea';
 import 'ui/filters/markdown';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import advancedRowTemplate from 'plugins/kibana/management/sections/settings/advanced_row.html';
 
 uiModules.get('apps/management')

src/core_plugins/kibana/public/management/sections/settings/index.js

@@ -3,7 +3,7 @@ import { toEditableConfig } from 'plugins/kibana/management/sections/settings/li
 import 'plugins/kibana/management/sections/settings/advanced_row';
 import { management } from 'ui/management';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import indexTemplate from 'plugins/kibana/management/sections/settings/index.html';
 
 uiRoutes

src/core_plugins/kibana/public/visualize/editor/agg.js

@@ -1,7 +1,7 @@
 import 'plugins/kibana/visualize/editor/agg_params';
 import 'plugins/kibana/visualize/editor/agg_add';
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import aggTemplate from 'plugins/kibana/visualize/editor/agg.html';
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/editor/agg_add.js

@@ -1,5 +1,5 @@
 import { VisAggConfigProvider } from 'ui/vis/agg_config';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import aggAddTemplate from 'plugins/kibana/visualize/editor/agg_add.html';
 
 uiModules

src/core_plugins/kibana/public/visualize/editor/agg_filter.js

@@ -1,5 +1,5 @@
 import { propFilter } from 'ui/filters/_prop_filter';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('kibana')

src/core_plugins/kibana/public/visualize/editor/agg_group.js

@@ -2,7 +2,7 @@ import _ from 'lodash';
 import 'plugins/kibana/visualize/editor/agg';
 import 'plugins/kibana/visualize/editor/agg_add';
 import 'plugins/kibana/visualize/editor/nesting_indicator';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import aggGroupTemplate from 'plugins/kibana/visualize/editor/agg_group.html';
 
 uiModules

src/core_plugins/kibana/public/visualize/editor/agg_param.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/editor/agg_params.js

@@ -6,7 +6,7 @@ import advancedToggleHtml from 'plugins/kibana/visualize/editor/advanced_toggle.
 import 'ui/filters/match_any';
 import 'plugins/kibana/visualize/editor/agg_param';
 import { AggTypesIndexProvider } from 'ui/agg_types/index';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import aggParamsTemplate from 'plugins/kibana/visualize/editor/agg_params.html';
 
 uiModules

src/core_plugins/kibana/public/visualize/editor/draggable_container.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import dragula from 'dragula';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/editor/draggable_handle.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/editor/draggable_item.js

@@ -1,5 +1,5 @@
 import $ from 'jquery';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/editor/editor.js

@@ -15,7 +15,7 @@ import { FilterBarQueryFilterProvider } from 'ui/filter_bar/query_filter';
 import { FilterBarClickHandlerProvider } from 'ui/filter_bar/filter_bar_click_handler';
 import { stateMonitorFactory } from 'ui/state_management/state_monitor_factory';
 import uiRoutes from 'ui/routes';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import editorTemplate from 'plugins/kibana/visualize/editor/editor.html';
 import { DashboardConstants } from 'plugins/kibana/dashboard/dashboard_constants';
 import { VisualizeConstants } from '../visualize_constants';

src/core_plugins/kibana/public/visualize/editor/nesting_indicator.js

@@ -1,6 +1,6 @@
 import $ from 'jquery';
 import { createColorPalette } from 'ui/vis/components/color/color_palette';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('kibana')

src/core_plugins/kibana/public/visualize/editor/sidebar.js

@@ -1,6 +1,6 @@
 import 'plugins/kibana/visualize/editor/agg_group';
 import 'plugins/kibana/visualize/editor/vis_options';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import sidebarTemplate from 'plugins/kibana/visualize/editor/sidebar.html';
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/editor/vis_options.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import visOptionsTemplate from 'plugins/kibana/visualize/editor/vis_options.html';
 
 uiModules

src/core_plugins/kibana/public/visualize/saved_visualizations/_saved_vis.js

@@ -8,7 +8,7 @@
 
 import _ from 'lodash';
 import { VisProvider } from 'ui/vis';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules
 .get('app/visualize')

src/core_plugins/kibana/public/visualize/saved_visualizations/saved_visualizations.js

@@ -1,6 +1,6 @@
 import 'plugins/kibana/visualize/saved_visualizations/_saved_vis';
 import { VisTypesRegistryProvider } from 'ui/registry/vis_types';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { SavedObjectLoader } from 'ui/courier/saved_object/saved_object_loader';
 import { savedObjectManagementRegistry } from 'plugins/kibana/management/saved_object_registry';
 

src/core_plugins/kibana/public/visualize/wizard/wizard.js

@@ -10,7 +10,7 @@ import { DashboardConstants } from 'plugins/kibana/dashboard/dashboard_constants
 import { VisualizeConstants } from '../visualize_constants';
 import routes from 'ui/routes';
 import { VisTypesRegistryProvider } from 'ui/registry/vis_types';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import visualizeWizardStep1Template from './step_1.html';
 import visualizeWizardStep2Template from './step_2.html';
 

src/core_plugins/markdown_vis/public/markdown_vis_controller.js

@@ -1,5 +1,5 @@
 import marked from 'marked';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import 'angular-sanitize';
 
 marked.setOptions({

src/core_plugins/metric_vis/public/metric_vis_controller.js

@@ -1,5 +1,5 @@
 import { AggResponseTabifyProvider } from 'ui/agg_response/tabify/tabify';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 // get the kibana/metric_vis module, and make sure that it requires the "kibana" module if it
 // didn't already
 const module = uiModules.get('kibana/metric_vis', ['kibana']);

src/core_plugins/metrics/public/directives/vis_editor.js

@@ -1,11 +1,11 @@
 import React from 'react';
 import { render, unmountComponentAtNode } from 'react-dom';
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import VisEditor from '../components/vis_editor';
 import addScope from '../lib/add_scope';
 import angular from 'angular';
 import createBrushHandler from '../lib/create_brush_handler';
-const app = modules.get('apps/metrics/directives');
+const app = uiModules.get('apps/metrics/directives');
 app.directive('metricsVisEditor', (timefilter) => {
   return {
     restrict: 'E',

src/core_plugins/metrics/public/directives/visualization.js

@@ -4,9 +4,10 @@ import React from 'react';
 import { render, unmountComponentAtNode } from 'react-dom';
 import Visualization from '../components/visualization';
 import addScope from '../lib/add_scope';
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import createBrushHandler from '../lib/create_brush_handler';
-const app = modules.get('apps/metrics/directives');
+
+const app = uiModules.get('apps/metrics/directives');
 app.directive('metricsVisualization', (timefilter, $timeout) => {
   return {
     restrict: 'E',

src/core_plugins/metrics/public/kbn_vis_types/editor_controller.js

@@ -1,4 +1,4 @@
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import '../services/executor';
 import createNewPanel from '../lib/create_new_panel';
 import '../directives/vis_editor';
@@ -6,7 +6,7 @@ import _ from 'lodash';
 import angular from 'angular';
 import { FilterBarQueryFilterProvider } from 'ui/filter_bar/query_filter';
 
-const app = modules.get('kibana/metrics_vis', ['kibana']);
+const app = uiModules.get('kibana/metrics_vis', ['kibana']);
 app.controller('MetricsEditorController', (
   $location,
   $element,

src/core_plugins/metrics/public/kbn_vis_types/vis_controller.js

@@ -1,9 +1,9 @@
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import 'ui/state_management/app_state';
 import '../directives/visualization';
 import { FilterBarQueryFilterProvider } from 'ui/filter_bar/query_filter';
 
-const app = modules.get('kibana/metrics_vis');
+const app = uiModules.get('kibana/metrics_vis');
 
 app.controller('MetricsVisController', (
   $scope,

src/core_plugins/metrics/public/services/executor.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import executorProvider from './executor_provider';
 const uiModule = uiModules.get('kibana/metrics_vis/executor', []);
 uiModule.service('metricsExecutor', executorProvider);

src/core_plugins/status_page/public/status_page.js

@@ -3,7 +3,7 @@ import { notify } from 'ui/notify';
 import 'ui/autoload/styles';
 import 'plugins/status_page/status_page_metric';
 import 'plugins/status_page/status_page.less';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 
 const chrome = require('ui/chrome')

src/core_plugins/status_page/public/status_page_metric.js

@@ -1,7 +1,7 @@
 import toTitleCase from './lib/to_title_case';
 import formatNumber from './lib/format_number';
 import readStatData from './lib/read_stat_data';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import statusPageMetricTemplate from 'plugins/status_page/status_page_metric.html';
 
 function calcAvg(metricList, metricNumberType) {

src/core_plugins/table_vis/public/table_vis_controller.js

@@ -1,5 +1,5 @@
 import { AggResponseTabifyProvider } from 'ui/agg_response/tabify/tabify';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { assign } from 'lodash';
 
 // get the kibana/table_vis module, and make sure that it requires the "kibana" module if it

src/core_plugins/table_vis/public/table_vis_params.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import tableVisParamsTemplate from 'plugins/table_vis/table_vis_params.html';
 
 uiModules.get('kibana/table_vis')

src/core_plugins/tagcloud/public/tag_cloud_controller.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import TagCloud from 'plugins/tagcloud/tag_cloud';
 import AggConfigResult from 'ui/vis/agg_config_result';
 import { FilterBarClickHandlerProvider } from 'ui/filter_bar/filter_bar_click_handler';

src/core_plugins/tagcloud/public/tag_cloud_vis_params.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import tagCloudVisParamsTemplate from 'plugins/tagcloud/tag_cloud_vis_params.html';
 import noUiSlider from 'no-ui-slider';
 import 'no-ui-slider/css/nouislider.css';

src/core_plugins/timelion/public/app.js

@@ -3,6 +3,7 @@ import moment from 'moment-timezone';
 
 import { DocTitleProvider } from 'ui/doc_title';
 import { SavedObjectRegistryProvider } from 'ui/saved_objects/saved_object_registry';
+import { notify } from 'ui/notify';
 
 require('plugins/timelion/directives/cells/cells');
 require('plugins/timelion/directives/fullscreen/fullscreen');
@@ -28,8 +29,7 @@ require('./vis');
 
 SavedObjectRegistryProvider.register(require('plugins/timelion/services/saved_sheet_register'));
 
-// TODO: Expose an api for dismissing notifications
-const unsafeNotifications = require('ui/notify').default._notifs;
+const unsafeNotifications = notify._notifs;
 
 require('ui/routes').enable();
 

src/core_plugins/timelion/public/services/_saved_sheet.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import _ from 'lodash';
 const module = uiModules.get('app/timelion');
 

src/test_utils/no_digest_promises.js

@@ -1,6 +1,6 @@
 import Bluebird from 'bluebird';
 import 'ui/promises';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 Bluebird.longStackTraces();
 

src/ui/public/.eslintrc

@@ -1,2 +1,6 @@
+plugins: [
+  '@elastic/kibana-custom'
+]
 rules:
   no-console: 2
+  kibana-custom/no-default-export: error

src/ui/public/agg_table/agg_table.js

@@ -2,7 +2,7 @@ import 'ui/paginated_table';
 import 'ui/compile_recursive_directive';
 import 'ui/agg_table/agg_table.less';
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import aggTableTemplate from 'ui/agg_table/agg_table.html';
 import { RegistryFieldFormatsProvider } from 'ui/registry/field_formats';
 

src/ui/public/agg_table/agg_table_group.js

@@ -1,6 +1,6 @@
 import 'ui/compile_recursive_directive';
 import 'ui/agg_table';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import aggTableGroupTemplate from 'ui/agg_table/agg_table_group.html';
 
 uiModules

src/ui/public/agg_types/index.js

@@ -99,6 +99,3 @@ export function AggTypesIndexProvider(Private) {
   });
 }
 
-export default AggTypesIndexProvider;
-
-// preload

src/ui/public/bind/bind.js

@@ -1,5 +1,5 @@
 import angular from 'angular';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 uiModules.get('kibana')
 .config(function ($provide) {

src/ui/public/chrome/api/angular.js

@@ -1,7 +1,7 @@
 import _ from 'lodash';
 import { format as formatUrl, parse as parseUrl } from 'url';
 
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { Notifier } from 'ui/notify/notifier';
 import { UrlOverflowServiceProvider } from '../../error_url_overflow';
 
@@ -14,7 +14,7 @@ export function initAngularApi(chrome, internals) {
   chrome.getBreadcrumbs = _.noop;
 
   chrome.setupAngular = function () {
-    const kibana = modules.get('kibana');
+    const kibana = uiModules.get('kibana');
 
     _.forOwn(chrome.getInjected(), function (val, name) {
       kibana.value(name, val);
@@ -100,7 +100,7 @@ export function initAngularApi(chrome, internals) {
 
     directivesProvider(chrome, internals);
 
-    modules.link(kibana);
+    uiModules.link(kibana);
   };
 
 }

src/ui/public/chrome/directives/append_nav_controls.js

@@ -1,9 +1,9 @@
 import { chromeNavControlsRegistry } from 'ui/registry/chrome_nav_controls';
-import UiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 export function kbnAppendChromeNavControls() {
 
-  UiModules
+  uiModules
   .get('kibana')
   .directive('kbnChromeAppendNavControls', function (Private) {
     return {

src/ui/public/chrome/directives/global_nav/app_switcher/app_switcher.js

@@ -1,6 +1,6 @@
 import { DomLocationProvider } from 'ui/dom_location';
 import { parse } from 'url';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import appSwitcherTemplate from './app_switcher.html';
 
 uiModules

src/ui/public/chrome/directives/global_nav/global_nav.js

@@ -4,7 +4,7 @@ import './global_nav_link';
 
 import globalNavTemplate from './global_nav.html';
 import './global_nav.less';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 const module = uiModules.get('kibana');
 

src/ui/public/chrome/directives/global_nav/global_nav_link/global_nav_link.js

@@ -1,7 +1,7 @@
 
 import globalNavLinkTemplate from './global_nav_link.html';
 import './global_nav_link.less';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 const module = uiModules.get('kibana');
 

src/ui/public/chrome/directives/kbn_chrome.js

@@ -2,17 +2,17 @@ import $ from 'jquery';
 import { remove } from 'lodash';
 
 import './kbn_chrome.less';
-import UiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { isSystemApiRequest } from 'ui/system_api';
 import {
   getUnhashableStatesProvider,
   unhashUrl,
 } from 'ui/state_management/state_hashing';
-import Notifier from 'ui/notify';
+import { notify } from 'ui/notify';
 
 export function kbnChromeProvider(chrome, internals) {
 
-  UiModules
+  uiModules
   .get('kibana')
   .directive('kbnChrome', () => {
     return {
@@ -56,7 +56,7 @@ export function kbnChromeProvider(chrome, internals) {
 
         // and some local values
         chrome.httpActive = $http.pendingRequests;
-        $scope.notifList = Notifier._notifs;
+        $scope.notifList = notify._notifs;
 
         return chrome;
       }

src/ui/public/chrome/directives/loading_indicator/loading_indicator.js

@@ -1,8 +1,8 @@
-import UiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import template from './loading_indicator.html';
 import './loading_indicator.less';
 
-UiModules
+uiModules
 .get('ui/kibana')
 .directive('kbnLoadingIndicator', function () {
   return {

src/ui/public/chrome/services/global_nav_state.js

@@ -1,7 +1,7 @@
 
-import modules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
-modules.get('kibana')
+uiModules.get('kibana')
 .service('globalNavState', (localStorage, $rootScope) => {
   return {
     isOpen: () => {

src/ui/public/collapsible_sidebar/collapsible_sidebar.js

@@ -1,7 +1,7 @@
 import 'ui/collapsible_sidebar/collapsible_sidebar.less';
 import _ from 'lodash';
 import $ from 'jquery';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 
 uiModules

src/ui/public/compile_recursive_directive.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 /**
  * Angular can't render directives that render themselves recursively:

src/ui/public/config/config.js

@@ -1,6 +1,6 @@
 import angular from 'angular';
 import { cloneDeep, defaultsDeep, isPlainObject } from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { Notifier } from 'ui/notify/notifier';
 import { ConfigDelayedUpdaterProvider } from 'ui/config/_delayed_updater';
 const module = uiModules.get('kibana/config');

src/ui/public/courier/courier.js

@@ -3,7 +3,7 @@ import _ from 'lodash';
 import 'ui/es';
 import 'ui/promises';
 import 'ui/index_patterns';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import { Notifier } from 'ui/notify/notifier';
 
 import { DocSourceProvider } from './data_source/doc_source';

src/ui/public/courier/saved_object/ui/saved_object_save_as_checkbox.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 import saveObjectSaveAsCheckboxTemplate from './saved_object_save_as_checkbox.html';
 
 uiModules

src/ui/public/debounce/debounce.js

@@ -1,5 +1,5 @@
 import _ from 'lodash';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 // Debounce service, angularized version of lodash debounce
 // borrowed heavily from https://github.com/shahata/angular-debounce
 

src/ui/public/directives/auto_select_if_only_one.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('kibana');
 
 module.directive('autoSelectIfOnlyOne', function () {

src/ui/public/directives/click_focus.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import $ from 'jquery';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('kibana');
 
 module.directive('clickFocus', function () {

src/ui/public/directives/confirm_click.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 uiModules
 .get('kibana')
 .directive('confirmClick', function ($window) {

src/ui/public/directives/css_truncate.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('kibana');
 
 module.directive('cssTruncate', function () {

src/ui/public/directives/field_name.js

@@ -1,6 +1,6 @@
 import $ from 'jquery';
 import 'ui/filters/short_dots';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('kibana');
 
 module.directive('fieldName', function ($compile, $rootScope, $filter) {

src/ui/public/directives/file_upload.js

@@ -1,6 +1,6 @@
 import _ from 'lodash';
 import $ from 'jquery';
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 const module = uiModules.get('kibana');
 
 const html = '<span class="dropzone" ng-transclude></span>';

src/ui/public/directives/inequality.js

@@ -1,4 +1,4 @@
-import uiModules from 'ui/modules';
+import { uiModules } from 'ui/modules';
 
 function makeDirectiveDef(id, compare) {
   return function ($parse) {