github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Refines hasAnyData check for alerts (#117499) (#117578)

Browse source 
* Refines hasAnyData check for alerts

* Fixes type refinements

* Applies review feedback

* Naming is hard

Co-authored-by: Claudio Procida <claudio.procida@gmail.com>
This commit is contained in:
Kibana Machine 2021-11-10 07:53:27 -05:00 • committed by GitHub
parent f4be80ff06
commit 6cafc358bd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/observability/public/context/has_data_context.test.tsx
View file

@ -556,7 +556,7 @@ describe('HasDataContextProvider', () => {
status: 'success',
},
},
hasAnyData: false,
hasAnyData: true,
isAllRequestsComplete: true,
forceUpdate: expect.any(String),
onRefreshTimeRange: expect.any(Function),

9
x-pack/plugins/observability/public/context/has_data_context.tsx
View file

@ -146,9 +146,12 @@ export function HasDataContextProvider({ children }: { children: React.ReactNode
return appStatus !== undefined && appStatus !== FETCH_STATUS.LOADING;
});
const hasAnyData = (Object.keys(hasDataMap) as ObservabilityFetchDataPlugins[]).some(
(app) => hasDataMap[app]?.hasData === true
);
const hasAnyData = (Object.keys(hasDataMap) as ObservabilityFetchDataPlugins[]).some((app) => {
const appHasData = hasDataMap[app]?.hasData;
return (
appHasData === true || (Array.isArray(appHasData) && (appHasData as Alert[])?.length > 0)
);
});
return (
<HasDataContext.Provider