mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 17:59:23 -04:00
[8.x] move content-management and react files left behind in the packages folder (#206874) (#206986)
# Backport This will backport the following commits from `main` to `8.x`: - [move content-management and react files left behind in the packages folder (#206874)](https://github.com/elastic/kibana/pull/206874) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-01-16T17:01:20Z","message":"move content-management and react files left behind in the packages folder (#206874)\n\n## Summary\r\n\r\nWhile looking at the `packages` folder at the root of Kibana, I noticed\r\nsome files were left over in otherwise empty folders:\r\n- 2 README files were left in the `content-management` folder\r\n- 1 README file and 1 png file were left in the `react` folder\r\n\r\nThe rest of the content was moved to a new location as part of the\r\nSustainable Kibana Architecture effort (see [this\r\nPR](https://github.com/elastic/kibana/pull/205593) and [that\r\none](https://github.com/elastic/kibana/pull/205924)) and I wonder if\r\nthose few files were left behind by mistake.\r\n\r\nI did not making any changes to the content of the files, I just moved\r\nthem to their respective new locations.\r\n\r\nPlease let me know if these were left behind intentionally, or if they\r\nshould be deleted instead of moved!\r\n\r\n### Notes\r\n\r\nThe `appex-sharedux` codeowner only appeared after pushing the second\r\ncommit which impacts the `react` folder. I realized that the codeowners\r\nfile was pointing to the folder within\r\n`src/platform/packages/shared/content-management/content_insights` and\r\n`src/platform/packages/shared/content-management/favorites` so update it\r\nto point to the parent folder, which now contains the moved README\r\nfiles. I hope that's ok!\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"097fb03bc487cb97d2b1a6871521cb90b895900b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:version","v8.18.0"],"title":"move content-management and react files left behind in the packages folder","number":206874,"url":"https://github.com/elastic/kibana/pull/206874","mergeCommit":{"message":"move content-management and react files left behind in the packages folder (#206874)\n\n## Summary\r\n\r\nWhile looking at the `packages` folder at the root of Kibana, I noticed\r\nsome files were left over in otherwise empty folders:\r\n- 2 README files were left in the `content-management` folder\r\n- 1 README file and 1 png file were left in the `react` folder\r\n\r\nThe rest of the content was moved to a new location as part of the\r\nSustainable Kibana Architecture effort (see [this\r\nPR](https://github.com/elastic/kibana/pull/205593) and [that\r\none](https://github.com/elastic/kibana/pull/205924)) and I wonder if\r\nthose few files were left behind by mistake.\r\n\r\nI did not making any changes to the content of the files, I just moved\r\nthem to their respective new locations.\r\n\r\nPlease let me know if these were left behind intentionally, or if they\r\nshould be deleted instead of moved!\r\n\r\n### Notes\r\n\r\nThe `appex-sharedux` codeowner only appeared after pushing the second\r\ncommit which impacts the `react` folder. I realized that the codeowners\r\nfile was pointing to the folder within\r\n`src/platform/packages/shared/content-management/content_insights` and\r\n`src/platform/packages/shared/content-management/favorites` so update it\r\nto point to the parent folder, which now contains the moved README\r\nfiles. I hope that's ok!\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"097fb03bc487cb97d2b1a6871521cb90b895900b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206874","number":206874,"mergeCommit":{"message":"move content-management and react files left behind in the packages folder (#206874)\n\n## Summary\r\n\r\nWhile looking at the `packages` folder at the root of Kibana, I noticed\r\nsome files were left over in otherwise empty folders:\r\n- 2 README files were left in the `content-management` folder\r\n- 1 README file and 1 png file were left in the `react` folder\r\n\r\nThe rest of the content was moved to a new location as part of the\r\nSustainable Kibana Architecture effort (see [this\r\nPR](https://github.com/elastic/kibana/pull/205593) and [that\r\none](https://github.com/elastic/kibana/pull/205924)) and I wonder if\r\nthose few files were left behind by mistake.\r\n\r\nI did not making any changes to the content of the files, I just moved\r\nthem to their respective new locations.\r\n\r\nPlease let me know if these were left behind intentionally, or if they\r\nshould be deleted instead of moved!\r\n\r\n### Notes\r\n\r\nThe `appex-sharedux` codeowner only appeared after pushing the second\r\ncommit which impacts the `react` folder. I realized that the codeowners\r\nfile was pointing to the folder within\r\n`src/platform/packages/shared/content-management/content_insights` and\r\n`src/platform/packages/shared/content-management/favorites` so update it\r\nto point to the parent folder, which now contains the moved README\r\nfiles. I hope that's ok!\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"097fb03bc487cb97d2b1a6871521cb90b895900b"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
This commit is contained in:
parent
0caa021ef1
commit
6cbbb41f0c
4 changed files with 0 additions and 0 deletions
Before Width: | Height: | Size: 124 KiB After Width: | Height: | Size: 124 KiB |
Loading…
Add table
Add a link
Reference in a new issue