mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 01:38:56 -04:00
[ResponseOps] Remove usage of deprecated React rendering utilities (#180521)
## Summary
Partially addresses https://github.com/elastic/kibana-team/issues/805
Follows https://github.com/elastic/kibana/pull/180098
These changes come up from searching in the code and finding where
certain kinds of deprecated AppEx-SharedUX modules are imported.
**Reviewers: Please interact with critical paths through the UI
components touched in this PR, ESPECIALLY in terms of testing dark mode
and i18n.**
This focuses on code within Response Ops.
<img width="1107" alt="image"
src="c0d2ce08
-ac35-45a7-8192-0b2256fceb0e">
### Checklist
Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
parent
119e110d7c
commit
6d1a347b0c
3 changed files with 13 additions and 17 deletions
|
@ -8,9 +8,8 @@
|
|||
import React from 'react';
|
||||
import { BehaviorSubject } from 'rxjs';
|
||||
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
|
||||
import { I18nProvider } from '@kbn/i18n-react';
|
||||
import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
|
||||
import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
|
||||
import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
|
||||
import { render as reactRender, RenderOptions, RenderResult } from '@testing-library/react';
|
||||
import { Capabilities, CoreStart } from '@kbn/core/public';
|
||||
import { coreMock } from '@kbn/core/public/mocks';
|
||||
|
@ -80,13 +79,11 @@ export const createAppMockRenderer = ({
|
|||
},
|
||||
};
|
||||
const AppWrapper: React.FC<{ children: React.ReactElement }> = React.memo(({ children }) => (
|
||||
<I18nProvider>
|
||||
<KibanaThemeProvider theme={core.theme}>
|
||||
<KibanaContextProvider services={services}>
|
||||
<QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
|
||||
</KibanaContextProvider>
|
||||
</KibanaThemeProvider>
|
||||
</I18nProvider>
|
||||
<KibanaRenderContextProvider {...core}>
|
||||
<KibanaContextProvider services={services}>
|
||||
<QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
|
||||
</KibanaContextProvider>
|
||||
</KibanaRenderContextProvider>
|
||||
));
|
||||
|
||||
AppWrapper.displayName = 'AppWrapper';
|
||||
|
|
|
@ -48,7 +48,6 @@
|
|||
"@kbn/kibana-react-plugin",
|
||||
"@kbn/management-plugin",
|
||||
"@kbn/es-ui-shared-plugin",
|
||||
"@kbn/i18n-react",
|
||||
"@kbn/ui-theme",
|
||||
"@kbn/core-doc-links-server-mocks",
|
||||
"@kbn/doc-links",
|
||||
|
@ -70,7 +69,6 @@
|
|||
"@kbn/core-http-router-server-internal",
|
||||
"@kbn/core-execution-context-server-mocks",
|
||||
"@kbn/react-kibana-context-render",
|
||||
"@kbn/react-kibana-context-theme"
|
||||
],
|
||||
"exclude": [
|
||||
"target/**/*"
|
||||
|
|
|
@ -7,11 +7,12 @@
|
|||
|
||||
import React from 'react';
|
||||
import { QueryClient, QueryClientProvider, QueryClientProviderProps } from '@tanstack/react-query';
|
||||
import { coreMock } from '@kbn/core/public/mocks';
|
||||
// FIXME: adds inefficient boilerplate that should not be required. See https://github.com/elastic/kibana/issues/180725
|
||||
import { I18nProvider } from '@kbn/i18n-react';
|
||||
import { coreMock } from '@kbn/core/public/mocks';
|
||||
import { KibanaContextProvider } from '@kbn/kibana-react-plugin/public';
|
||||
import { render as reactRender, RenderOptions, RenderResult } from '@testing-library/react';
|
||||
import { KibanaThemeProvider } from '@kbn/react-kibana-context-theme';
|
||||
import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
|
||||
|
||||
import { TriggersAndActionsUiServices } from '../..';
|
||||
import { createStartServicesMock } from '../../common/lib/kibana/kibana_react.mock';
|
||||
|
@ -52,13 +53,13 @@ export const createAppMockRenderer = (
|
|||
|
||||
const AppWrapper: React.FC<{ children: React.ReactElement }> = React.memo(({ children }) => (
|
||||
<I18nProvider>
|
||||
<KibanaContextProvider services={services}>
|
||||
<KibanaThemeProvider theme={core.theme}>
|
||||
<KibanaRenderContextProvider {...core}>
|
||||
<KibanaContextProvider services={services}>
|
||||
<QueryClientProvider client={queryClient} context={queryClientContext}>
|
||||
{children}
|
||||
</QueryClientProvider>
|
||||
</KibanaThemeProvider>
|
||||
</KibanaContextProvider>
|
||||
</KibanaContextProvider>
|
||||
</KibanaRenderContextProvider>
|
||||
</I18nProvider>
|
||||
));
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue