github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.x] [React18] Migrate test suites to account for testing library upgrades response-ops (#201141) (#201432)

Browse source 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[React18] Migrate test suites to account for testing library upgrades
response-ops (#201141)](https://github.com/elastic/kibana/pull/201141)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Eyo O.
Eyo","email":"7893459+eokoneyo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-22T16:43:23Z","message":"[React18]
Migrate test suites to account for testing library upgrades response-ops
(#201141)\n\nThis PR migrates test suites that use `renderHook` from the
library\r\n`@testing-library/react-hooks` to adopt the equivalent and
replacement\r\nof `renderHook` from the export that is now available
from\r\n`@testing-library/react`. This work is required for the
planned\r\nmigration to react18.\r\n\r\n## Context\r\n\r\nIn this PR,
usages of `waitForNextUpdate` that previously could have\r\nbeen
destructured from `renderHook` are now been replaced with
`waitFor`\r\nexported from `@testing-library/react`, furthermore
`waitFor`\r\nthat would also have been destructured from the same
renderHook result\r\nis now been replaced with `waitFor` from the export
of\r\n`@testing-library/react`.\r\n\r\n***Why is `waitFor` a sufficient
enough replacement for\r\n`waitForNextUpdate`, and better for testing
values subject to async\r\ncomputations?***\r\n\r\nWaitFor will retry
the provided callback if an error is returned, till\r\nthe configured
timeout elapses. By default the retry interval is `50ms`\r\nwith a
timeout value of `1000ms` that\r\neffectively translates to at least 20
retries for assertions placed\r\nwithin waitFor.
See\r\nhttps://testing-library.com/docs/dom-testing-library/api-async/#waitfor\r\nfor
more information.\r\nThis however means that for person's writing tests,
said person has to\r\nbe explicit about expectations that describe the
internal state of the\r\nhook being tested.\r\nThis implies checking for
instance when a react query hook is being\r\nrendered, there's an
assertion that said hook isn't loading anymore.\r\n\r\nIn this PR you'd
notice that this pattern has been adopted, with most\r\nexisting
assertions following an invocation of `waitForNextUpdate`
being\r\nplaced within a `waitFor`\r\ninvocation. In some cases the
replacement is simply a `waitFor(() => new\r\nPromise((resolve) =>
resolve(null)))` (many thanks to @kapral18, for\r\npoint out exactly why
this works),\r\nwhere this suffices the assertions that follow aren't
placed within a\r\nwaitFor so this PR doesn't get larger than it needs
to be.\r\n\r\nIt's also worth pointing out this PR might also contain
changes to test\r\nand application code to improve said existing
test.\r\n\r\n### What to do next?\r\n1. Review the changes in this
PR.\r\n2. If you think the changes are correct, approve the
PR.\r\n\r\n## Any questions?\r\nIf you have any questions or need help
with this PR, please leave\r\ncomments in this
PR.","sha":"3890bde1ab9510adc7b6b8333861d3de51381ef5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","React@18"],"title":"[React18]
Migrate test suites to account for testing library upgrades
response-ops","number":201141,"url":"https://github.com/elastic/kibana/pull/201141","mergeCommit":{"message":"[React18]
Migrate test suites to account for testing library upgrades response-ops
(#201141)\n\nThis PR migrates test suites that use `renderHook` from the
library\r\n`@testing-library/react-hooks` to adopt the equivalent and
replacement\r\nof `renderHook` from the export that is now available
from\r\n`@testing-library/react`. This work is required for the
planned\r\nmigration to react18.\r\n\r\n## Context\r\n\r\nIn this PR,
usages of `waitForNextUpdate` that previously could have\r\nbeen
destructured from `renderHook` are now been replaced with
`waitFor`\r\nexported from `@testing-library/react`, furthermore
`waitFor`\r\nthat would also have been destructured from the same
renderHook result\r\nis now been replaced with `waitFor` from the export
of\r\n`@testing-library/react`.\r\n\r\n***Why is `waitFor` a sufficient
enough replacement for\r\n`waitForNextUpdate`, and better for testing
values subject to async\r\ncomputations?***\r\n\r\nWaitFor will retry
the provided callback if an error is returned, till\r\nthe configured
timeout elapses. By default the retry interval is `50ms`\r\nwith a
timeout value of `1000ms` that\r\neffectively translates to at least 20
retries for assertions placed\r\nwithin waitFor.
See\r\nhttps://testing-library.com/docs/dom-testing-library/api-async/#waitfor\r\nfor
more information.\r\nThis however means that for person's writing tests,
said person has to\r\nbe explicit about expectations that describe the
internal state of the\r\nhook being tested.\r\nThis implies checking for
instance when a react query hook is being\r\nrendered, there's an
assertion that said hook isn't loading anymore.\r\n\r\nIn this PR you'd
notice that this pattern has been adopted, with most\r\nexisting
assertions following an invocation of `waitForNextUpdate`
being\r\nplaced within a `waitFor`\r\ninvocation. In some cases the
replacement is simply a `waitFor(() => new\r\nPromise((resolve) =>
resolve(null)))` (many thanks to @kapral18, for\r\npoint out exactly why
this works),\r\nwhere this suffices the assertions that follow aren't
placed within a\r\nwaitFor so this PR doesn't get larger than it needs
to be.\r\n\r\nIt's also worth pointing out this PR might also contain
changes to test\r\nand application code to improve said existing
test.\r\n\r\n### What to do next?\r\n1. Review the changes in this
PR.\r\n2. If you think the changes are correct, approve the
PR.\r\n\r\n## Any questions?\r\nIf you have any questions or need help
with this PR, please leave\r\ncomments in this
PR.","sha":"3890bde1ab9510adc7b6b8333861d3de51381ef5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201141","number":201141,"mergeCommit":{"message":"[React18]
Migrate test suites to account for testing library upgrades response-ops
(#201141)\n\nThis PR migrates test suites that use `renderHook` from the
library\r\n`@testing-library/react-hooks` to adopt the equivalent and
replacement\r\nof `renderHook` from the export that is now available
from\r\n`@testing-library/react`. This work is required for the
planned\r\nmigration to react18.\r\n\r\n## Context\r\n\r\nIn this PR,
usages of `waitForNextUpdate` that previously could have\r\nbeen
destructured from `renderHook` are now been replaced with
`waitFor`\r\nexported from `@testing-library/react`, furthermore
`waitFor`\r\nthat would also have been destructured from the same
renderHook result\r\nis now been replaced with `waitFor` from the export
of\r\n`@testing-library/react`.\r\n\r\n***Why is `waitFor` a sufficient
enough replacement for\r\n`waitForNextUpdate`, and better for testing
values subject to async\r\ncomputations?***\r\n\r\nWaitFor will retry
the provided callback if an error is returned, till\r\nthe configured
timeout elapses. By default the retry interval is `50ms`\r\nwith a
timeout value of `1000ms` that\r\neffectively translates to at least 20
retries for assertions placed\r\nwithin waitFor.
See\r\nhttps://testing-library.com/docs/dom-testing-library/api-async/#waitfor\r\nfor
more information.\r\nThis however means that for person's writing tests,
said person has to\r\nbe explicit about expectations that describe the
internal state of the\r\nhook being tested.\r\nThis implies checking for
instance when a react query hook is being\r\nrendered, there's an
assertion that said hook isn't loading anymore.\r\n\r\nIn this PR you'd
notice that this pattern has been adopted, with most\r\nexisting
assertions following an invocation of `waitForNextUpdate`
being\r\nplaced within a `waitFor`\r\ninvocation. In some cases the
replacement is simply a `waitFor(() => new\r\nPromise((resolve) =>
resolve(null)))` (many thanks to @kapral18, for\r\npoint out exactly why
this works),\r\nwhere this suffices the assertions that follow aren't
placed within a\r\nwaitFor so this PR doesn't get larger than it needs
to be.\r\n\r\nIt's also worth pointing out this PR might also contain
changes to test\r\nand application code to improve said existing
test.\r\n\r\n### What to do next?\r\n1. Review the changes in this
PR.\r\n2. If you think the changes are correct, approve the
PR.\r\n\r\n## Any questions?\r\nIf you have any questions or need help
with this PR, please leave\r\ncomments in this
PR.","sha":"3890bde1ab9510adc7b6b8333861d3de51381ef5"}}]}] BACKPORT-->

Co-authored-by: Eyo O. Eyo <7893459+eokoneyo@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2024-11-23 05:36:36 +11:00 • committed by GitHub
parent 59c36e2d6a
commit 6d691854f4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
149 changed files with 1531 additions and 1774 deletions
Download patch file Download diff file Expand all files Collapse all files

78
packages/kbn-alerts-ui-shared/src/alert_filter_controls/hooks/use_filters_sync_to_local_storage.test.ts
View file

@ -8,7 +8,7 @@
*/ */
import type { ControlGroupRuntimeState } from '@kbn/controls-plugin/public'; import type { ControlGroupRuntimeState } from '@kbn/controls-plugin/public';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, act, renderHook } from '@testing-library/react';
import { useControlGroupSyncToLocalStorage } from './use_control_group_sync_to_local_storage'; import { useControlGroupSyncToLocalStorage } from './use_control_group_sync_to_local_storage';
import { Storage } from '@kbn/kibana-utils-plugin/public'; import { Storage } from '@kbn/kibana-utils-plugin/public';
@ -34,77 +34,97 @@ describe('Filters Sync to Local Storage', () => {
writable: true, writable: true,
}); });
}); });
afterEach(() => { afterEach(() => {
mockLocalStorage = {}; mockLocalStorage = {};
}); });
it('should not be undefined if localStorage has initial value', () => {
it('should not be undefined if localStorage has initial value', async () => {
global.localStorage.setItem(TEST_STORAGE_KEY, JSON.stringify(DEFAULT_STORED_VALUE)); global.localStorage.setItem(TEST_STORAGE_KEY, JSON.stringify(DEFAULT_STORED_VALUE));
const { result, waitForNextUpdate } = renderHook(() => const { result } = renderHook(() =>
useControlGroupSyncToLocalStorage({ useControlGroupSyncToLocalStorage({
Storage, Storage,
storageKey: TEST_STORAGE_KEY, storageKey: TEST_STORAGE_KEY,
shouldSync: true, shouldSync: true,
}) })
); );
waitForNextUpdate(); await waitFor(() =>
expect(result.current.controlGroupState).toMatchObject(DEFAULT_STORED_VALUE); expect(result.current.controlGroupState).toMatchObject(DEFAULT_STORED_VALUE)
);
}); });
it('should be undefined if localstorage as NO initial value', () => {
const { result, waitForNextUpdate } = renderHook(() => it('should be undefined if localstorage as NO initial value', async () => {
const { result } = renderHook(() =>
useControlGroupSyncToLocalStorage({ useControlGroupSyncToLocalStorage({
Storage, Storage,
storageKey: TEST_STORAGE_KEY, storageKey: TEST_STORAGE_KEY,
shouldSync: true, shouldSync: true,
}) })
); );
waitForNextUpdate(); await waitFor(() =>
expect(result.current.controlGroupState).toBeUndefined(); expect(result.current).toEqual(
expect(result.current.setControlGroupState).toBeTruthy(); expect.objectContaining({
controlGroupState: undefined,
setControlGroupState: expect.any(Function),
})
)
);
}); });
it('should be update values to local storage when sync is ON', () => { it('should be update values to local storage when sync is ON', async () => {
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useControlGroupSyncToLocalStorage({ useControlGroupSyncToLocalStorage({
Storage, Storage,
storageKey: TEST_STORAGE_KEY, storageKey: TEST_STORAGE_KEY,
shouldSync: true, shouldSync: true,
}) })
); );
waitFor(() => { await waitFor(() => {
expect(result.current.controlGroupState).toBeUndefined(); expect(result.current.controlGroupState).toBeUndefined();
expect(result.current.setControlGroupState).toBeTruthy(); expect(result.current.setControlGroupState).toBeTruthy();
}); });
result.current.setControlGroupState(DEFAULT_STORED_VALUE); act(() => {
waitFor(() => { result.current.setControlGroupState(DEFAULT_STORED_VALUE);
});
await waitFor(() => {
expect(result.current.controlGroupState).toMatchObject(DEFAULT_STORED_VALUE); expect(result.current.controlGroupState).toMatchObject(DEFAULT_STORED_VALUE);
expect(global.localStorage.getItem(TEST_STORAGE_KEY)).toBe( expect(global.localStorage.getItem(TEST_STORAGE_KEY)).toBe(
JSON.stringify(DEFAULT_STORED_VALUE) JSON.stringify(DEFAULT_STORED_VALUE)
); );
}); });
}); });
it('should not update values to local storage when sync is OFF', () => { it('should not update values to local storage when sync is OFF', async () => {
const { waitFor, result, rerender } = renderHook(() => const initialProps = {
useControlGroupSyncToLocalStorage({ Storage,
Storage, storageKey: TEST_STORAGE_KEY,
storageKey: TEST_STORAGE_KEY, shouldSync: true,
shouldSync: true, };
})
); const { result, rerender } = renderHook(useControlGroupSyncToLocalStorage, {
initialProps,
});
// Sync is ON // Sync is ON
waitFor(() => { await waitFor(() => {
expect(result.current.controlGroupState).toBeUndefined(); expect(result.current.controlGroupState).toBeUndefined();
expect(result.current.setControlGroupState).toBeTruthy(); expect(result.current.setControlGroupState).toBeTruthy();
}); });
result.current.setControlGroupState(DEFAULT_STORED_VALUE); act(() => {
waitFor(() => { result.current.setControlGroupState(DEFAULT_STORED_VALUE);
});
await waitFor(() => {
expect(result.current.controlGroupState).toMatchObject(DEFAULT_STORED_VALUE); expect(result.current.controlGroupState).toMatchObject(DEFAULT_STORED_VALUE);
}); });
// Sync is OFF // Sync is OFF
rerender({ storageKey: TEST_STORAGE_KEY, shouldSync: false }); rerender({ ...initialProps, shouldSync: false });
result.current.setControlGroupState(ANOTHER_SAMPLE_VALUE);
waitFor(() => { act(() => {
result.current.setControlGroupState(ANOTHER_SAMPLE_VALUE);
});
await waitFor(() => {
expect(result.current.controlGroupState).toMatchObject(ANOTHER_SAMPLE_VALUE); expect(result.current.controlGroupState).toMatchObject(ANOTHER_SAMPLE_VALUE);
// old value // old value
expect(global.localStorage.getItem(TEST_STORAGE_KEY)).toBe( expect(global.localStorage.getItem(TEST_STORAGE_KEY)).toBe(

23
packages/kbn-alerts-ui-shared/src/common/hooks/use_alerts_data_view.test.tsx
View file

@ -10,7 +10,7 @@
import React from 'react'; import React from 'react';
import { AlertConsumers } from '@kbn/rule-data-utils'; import { AlertConsumers } from '@kbn/rule-data-utils';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { renderHook, waitFor } from '@testing-library/react';
import { DataView } from '@kbn/data-views-plugin/common'; import { DataView } from '@kbn/data-views-plugin/common';
import { httpServiceMock } from '@kbn/core-http-browser-mocks'; import { httpServiceMock } from '@kbn/core-http-browser-mocks';
import { notificationServiceMock } from '@kbn/core-notifications-browser-mocks'; import { notificationServiceMock } from '@kbn/core-notifications-browser-mocks';
@ -69,7 +69,7 @@ describe('useAlertsDataView', () => {
dataView: undefined, dataView: undefined,
}; };
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useAlertsDataView({ useAlertsDataView({
...mockServices, ...mockServices,
@ -84,7 +84,7 @@ describe('useAlertsDataView', () => {
}); });
it('fetches indexes and fields for non-siem feature ids, returning a DataViewBase object', async () => { it('fetches indexes and fields for non-siem feature ids, returning a DataViewBase object', async () => {
const { result, waitForValueToChange } = renderHook( const { result } = renderHook(
() => () =>
useAlertsDataView({ useAlertsDataView({
...mockServices, ...mockServices,
@ -95,7 +95,7 @@ describe('useAlertsDataView', () => {
} }
); );
await waitForValueToChange(() => result.current.isLoading, { timeout: 5000 }); await waitFor(() => result.current.isLoading, { timeout: 5000 });
expect(mockFetchAlertsFields).toHaveBeenCalledTimes(1); expect(mockFetchAlertsFields).toHaveBeenCalledTimes(1);
expect(mockFetchAlertsIndexNames).toHaveBeenCalledTimes(1); expect(mockFetchAlertsIndexNames).toHaveBeenCalledTimes(1);
@ -103,7 +103,7 @@ describe('useAlertsDataView', () => {
}); });
it('only fetches index names for the siem feature id, returning a DataView', async () => { it('only fetches index names for the siem feature id, returning a DataView', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useAlertsDataView({ ...mockServices, featureIds: [AlertConsumers.SIEM] }), () => useAlertsDataView({ ...mockServices, featureIds: [AlertConsumers.SIEM] }),
{ {
wrapper, wrapper,
@ -117,7 +117,7 @@ describe('useAlertsDataView', () => {
}); });
it('does not fetch anything if siem and other feature ids are mixed together', async () => { it('does not fetch anything if siem and other feature ids are mixed together', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useAlertsDataView({ useAlertsDataView({
...mockServices, ...mockServices,
@ -141,7 +141,7 @@ describe('useAlertsDataView', () => {
it('returns an undefined data view if any of the queries fails', async () => { it('returns an undefined data view if any of the queries fails', async () => {
mockFetchAlertsIndexNames.mockRejectedValue('error'); mockFetchAlertsIndexNames.mockRejectedValue('error');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useAlertsDataView({ ...mockServices, featureIds: observabilityFeatureIds }), () => useAlertsDataView({ ...mockServices, featureIds: observabilityFeatureIds }),
{ {
wrapper, wrapper,
@ -159,12 +159,9 @@ describe('useAlertsDataView', () => {
it('shows an error toast if any of the queries fails', async () => { it('shows an error toast if any of the queries fails', async () => {
mockFetchAlertsIndexNames.mockRejectedValue('error'); mockFetchAlertsIndexNames.mockRejectedValue('error');
const { waitFor } = renderHook( renderHook(() => useAlertsDataView({ ...mockServices, featureIds: observabilityFeatureIds }), {
() => useAlertsDataView({ ...mockServices, featureIds: observabilityFeatureIds }), wrapper,
{ });
wrapper,
}
);
await waitFor(() => expect(mockServices.toasts.addDanger).toHaveBeenCalled()); await waitFor(() => expect(mockServices.toasts.addDanger).toHaveBeenCalled());
}); });

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_create_rule.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import type { HttpStart } from '@kbn/core-http-browser'; import type { HttpStart } from '@kbn/core-http-browser';
import { useCreateRule } from './use_create_rule'; import { useCreateRule } from './use_create_rule';

62
packages/kbn-alerts-ui-shared/src/common/hooks/use_fetch_alerts_fields_query.test.tsx
View file

@ -10,7 +10,7 @@
import React, { FC } from 'react'; import React, { FC } from 'react';
import { AlertConsumers } from '@kbn/rule-data-utils'; import { AlertConsumers } from '@kbn/rule-data-utils';
import * as ReactQuery from '@tanstack/react-query'; import * as ReactQuery from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { testQueryClientConfig } from '../test_utils/test_query_client_config'; import { testQueryClientConfig } from '../test_utils/test_query_client_config';
import { useFetchAlertsFieldsQuery } from './use_fetch_alerts_fields_query'; import { useFetchAlertsFieldsQuery } from './use_fetch_alerts_fields_query';
import { httpServiceMock } from '@kbn/core-http-browser-mocks'; import { httpServiceMock } from '@kbn/core-http-browser-mocks';
@ -88,35 +88,37 @@ describe('useFetchAlertsFieldsQuery', () => {
}); });
it('should call the api only once', async () => { it('should call the api only once', async () => {
const { result, rerender, waitForValueToChange } = renderHook( const { result, rerender } = renderHook(
() => useFetchAlertsFieldsQuery({ http: mockHttpClient, featureIds: ['apm'] }), () => useFetchAlertsFieldsQuery({ http: mockHttpClient, featureIds: ['apm'] }),
{ {
wrapper, wrapper,
} }
); );
await waitForValueToChange(() => result.current.data); await waitFor(() => {
expect(mockHttpGet).toHaveBeenCalledTimes(1);
expect(mockHttpGet).toHaveBeenCalledTimes(1); expect(result.current.data).toEqual({
expect(result.current.data).toEqual({ browserFields: { fakeCategory: {} },
browserFields: { fakeCategory: {} }, fields: [
fields: [ {
{ name: 'fakeCategory',
name: 'fakeCategory', },
}, ],
], });
}); });
rerender(); rerender();
expect(mockHttpGet).toHaveBeenCalledTimes(1); await waitFor(() => {
expect(result.current.data).toEqual({ expect(mockHttpGet).toHaveBeenCalledTimes(1);
browserFields: { fakeCategory: {} }, expect(result.current.data).toEqual({
fields: [ browserFields: { fakeCategory: {} },
{ fields: [
name: 'fakeCategory', {
}, name: 'fakeCategory',
], },
],
});
}); });
}); });
@ -132,8 +134,10 @@ describe('useFetchAlertsFieldsQuery', () => {
} }
); );
expect(mockHttpGet).toHaveBeenCalledTimes(0); await waitFor(() => {
expect(result.current.data).toEqual(emptyData); expect(mockHttpGet).toHaveBeenCalledTimes(0);
expect(result.current.data).toEqual(emptyData);
});
}); });
it('should not fetch if all featureId are not valid', async () => { it('should not fetch if all featureId are not valid', async () => {
@ -148,8 +152,10 @@ describe('useFetchAlertsFieldsQuery', () => {
} }
); );
expect(mockHttpGet).toHaveBeenCalledTimes(0); await waitFor(() => {
expect(result.current.data).toEqual(emptyData); expect(mockHttpGet).toHaveBeenCalledTimes(0);
expect(result.current.data).toEqual(emptyData);
});
}); });
it('should filter out the non valid feature id', async () => { it('should filter out the non valid feature id', async () => {
@ -164,9 +170,11 @@ describe('useFetchAlertsFieldsQuery', () => {
} }
); );
expect(mockHttpGet).toHaveBeenCalledTimes(1); await waitFor(() => {
expect(mockHttpGet).toHaveBeenCalledWith('/internal/rac/alerts/browser_fields', { expect(mockHttpGet).toHaveBeenCalledTimes(1);
query: { featureIds: ['apm', 'logs'] }, expect(mockHttpGet).toHaveBeenCalledWith('/internal/rac/alerts/browser_fields', {
query: { featureIds: ['apm', 'logs'] },
});
}); });
}); });
}); });

6
packages/kbn-alerts-ui-shared/src/common/hooks/use_fetch_alerts_index_names_query.test.tsx
View file

@ -9,7 +9,7 @@
import React, { FunctionComponent } from 'react'; import React, { FunctionComponent } from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { testQueryClientConfig } from '../test_utils/test_query_client_config'; import { testQueryClientConfig } from '../test_utils/test_query_client_config';
import { useFetchAlertsIndexNamesQuery } from './use_fetch_alerts_index_names_query'; import { useFetchAlertsIndexNamesQuery } from './use_fetch_alerts_index_names_query';
import { fetchAlertsIndexNames } from '../apis/fetch_alerts_index_names'; import { fetchAlertsIndexNames } from '../apis/fetch_alerts_index_names';
@ -56,14 +56,14 @@ describe('useFetchAlertsIndexNamesQuery', () => {
}); });
it('correctly caches the index names', async () => { it('correctly caches the index names', async () => {
const { result, rerender, waitForValueToChange } = renderHook( const { result, rerender } = renderHook(
() => useFetchAlertsIndexNamesQuery({ http: mockHttpClient, featureIds: ['apm'] }), () => useFetchAlertsIndexNamesQuery({ http: mockHttpClient, featureIds: ['apm'] }),
{ {
wrapper, wrapper,
} }
); );
await waitForValueToChange(() => result.current.data); await waitFor(() => result.current.data);
expect(mockFetchAlertsIndexNames).toHaveBeenCalledTimes(1); expect(mockFetchAlertsIndexNames).toHaveBeenCalledTimes(1);

22
packages/kbn-alerts-ui-shared/src/common/hooks/use_fetch_flapping_settings.test.tsx
View file

@ -9,7 +9,7 @@
import React, { FunctionComponent } from 'react'; import React, { FunctionComponent } from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook, waitFor } from '@testing-library/react';
import { testQueryClientConfig } from '../test_utils/test_query_client_config'; import { testQueryClientConfig } from '../test_utils/test_query_client_config';
import { useFetchFlappingSettings } from './use_fetch_flapping_settings'; import { useFetchFlappingSettings } from './use_fetch_flapping_settings';
import { httpServiceMock } from '@kbn/core-http-browser-mocks'; import { httpServiceMock } from '@kbn/core-http-browser-mocks';
@ -43,12 +43,9 @@ describe('useFetchFlappingSettings', () => {
}); });
test('should call fetchFlappingSettings with the correct parameters', async () => { test('should call fetchFlappingSettings with the correct parameters', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(() => useFetchFlappingSettings({ http, enabled: true }), {
() => useFetchFlappingSettings({ http, enabled: true }), wrapper,
{ });
wrapper,
}
);
await waitFor(() => { await waitFor(() => {
return expect(result.current.isInitialLoading).toEqual(false); return expect(result.current.isInitialLoading).toEqual(false);
@ -66,12 +63,9 @@ describe('useFetchFlappingSettings', () => {
}); });
test('should not call fetchFlappingSettings if enabled is false', async () => { test('should not call fetchFlappingSettings if enabled is false', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(() => useFetchFlappingSettings({ http, enabled: false }), {
() => useFetchFlappingSettings({ http, enabled: false }), wrapper,
{ });
wrapper,
}
);
await waitFor(() => { await waitFor(() => {
return expect(result.current.isInitialLoading).toEqual(false); return expect(result.current.isInitialLoading).toEqual(false);
@ -82,7 +76,7 @@ describe('useFetchFlappingSettings', () => {
test('should call onSuccess when the fetching was successful', async () => { test('should call onSuccess when the fetching was successful', async () => {
const onSuccessMock = jest.fn(); const onSuccessMock = jest.fn();
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useFetchFlappingSettings({ http, enabled: true, onSuccess: onSuccessMock }), () => useFetchFlappingSettings({ http, enabled: true, onSuccess: onSuccessMock }),
{ {
wrapper, wrapper,

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_get_alerts_group_aggregations_query.test.tsx
View file

@ -9,13 +9,12 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom';
import type { HttpStart } from '@kbn/core-http-browser'; import type { HttpStart } from '@kbn/core-http-browser';
import { ToastsStart } from '@kbn/core-notifications-browser'; import { ToastsStart } from '@kbn/core-notifications-browser';
import { AlertConsumers } from '@kbn/rule-data-utils'; import { AlertConsumers } from '@kbn/rule-data-utils';
import { useGetAlertsGroupAggregationsQuery } from './use_get_alerts_group_aggregations_query'; import { useGetAlertsGroupAggregationsQuery } from './use_get_alerts_group_aggregations_query';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import { BASE_RAC_ALERTS_API_PATH } from '../constants'; import { BASE_RAC_ALERTS_API_PATH } from '../constants';
const queryClient = new QueryClient({ const queryClient = new QueryClient({

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_health_check.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import type { HttpStart } from '@kbn/core-http-browser'; import type { HttpStart } from '@kbn/core-http-browser';
import { useHealthCheck } from './use_health_check'; import { useHealthCheck } from './use_health_check';

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_load_connector_types.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import { httpServiceMock } from '@kbn/core/public/mocks'; import { httpServiceMock } from '@kbn/core/public/mocks';
import { useLoadConnectorTypes } from './use_load_connector_types'; import { useLoadConnectorTypes } from './use_load_connector_types';

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_load_connectors.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import { httpServiceMock } from '@kbn/core/public/mocks'; import { httpServiceMock } from '@kbn/core/public/mocks';
import { useLoadConnectors } from './use_load_connectors'; import { useLoadConnectors } from './use_load_connectors';

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_load_rule_type_aad_template_fields.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import { httpServiceMock } from '@kbn/core/public/mocks'; import { httpServiceMock } from '@kbn/core/public/mocks';
import { useLoadRuleTypeAadTemplateField } from './use_load_rule_type_aad_template_fields'; import { useLoadRuleTypeAadTemplateField } from './use_load_rule_type_aad_template_fields';

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_resolve_rule.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import type { HttpStart } from '@kbn/core-http-browser'; import type { HttpStart } from '@kbn/core-http-browser';
import { useResolveRule } from './use_resolve_rule'; import { useResolveRule } from './use_resolve_rule';

226
packages/kbn-alerts-ui-shared/src/common/hooks/use_search_alerts_query.test.tsx
View file

@ -12,7 +12,7 @@ import { of } from 'rxjs';
import type { DataPublicPluginStart } from '@kbn/data-plugin/public'; import type { DataPublicPluginStart } from '@kbn/data-plugin/public';
import type { IKibanaSearchResponse } from '@kbn/search-types'; import type { IKibanaSearchResponse } from '@kbn/search-types';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import type { UseSearchAlertsQueryParams } from './use_search_alerts_query'; import type { UseSearchAlertsQueryParams } from './use_search_alerts_query';
import { AlertsQueryContext } from '../contexts/alerts_query_context'; import { AlertsQueryContext } from '../contexts/alerts_query_context';
import { useSearchAlertsQuery } from './use_search_alerts_query'; import { useSearchAlertsQuery } from './use_search_alerts_query';
@ -126,126 +126,128 @@ describe('useSearchAlertsQuery', () => {
}); });
it('returns the response correctly', async () => { it('returns the response correctly', async () => {
const { result, waitForValueToChange } = renderHook(() => useSearchAlertsQuery(params), { const { result } = renderHook(() => useSearchAlertsQuery(params), {
wrapper, wrapper,
}); });
await waitForValueToChange(() => result.current.data); await waitFor(() => {
expect(result.current.data).toEqual( expect(result.current.data).toBeDefined();
expect.objectContaining({ expect(result.current.data).toEqual(
...expectedResponse, expect.objectContaining({
alerts: [ ...expectedResponse,
{ alerts: [
_index: '.internal.alerts-security.alerts-default-000001', {
_id: '38dd308706a127696cc63b8f142e8e4d66f8f79bc7d491dd79a42ea4ead62dd1', _index: '.internal.alerts-security.alerts-default-000001',
'@timestamp': ['2022-03-22T16:48:07.518Z'], _id: '38dd308706a127696cc63b8f142e8e4d66f8f79bc7d491dd79a42ea4ead62dd1',
'host.name': ['Host-4dbzugdlqd'], '@timestamp': ['2022-03-22T16:48:07.518Z'],
'kibana.alert.reason': [ 'host.name': ['Host-4dbzugdlqd'],
'registry event with process iexlorer.exe, by 5qcxz8o4j7 on Host-4dbzugdlqd created low alert test.', 'kibana.alert.reason': [
], 'registry event with process iexlorer.exe, by 5qcxz8o4j7 on Host-4dbzugdlqd created low alert test.',
'kibana.alert.risk_score': [21], ],
'kibana.alert.rule.name': ['test'], 'kibana.alert.risk_score': [21],
'kibana.alert.severity': ['low'], 'kibana.alert.rule.name': ['test'],
'process.name': ['iexlorer.exe'], 'kibana.alert.severity': ['low'],
'user.name': ['5qcxz8o4j7'], 'process.name': ['iexlorer.exe'],
}, 'user.name': ['5qcxz8o4j7'],
{ },
_index: '.internal.alerts-security.alerts-default-000001', {
_id: '8361363c0db6f30ca2dfb4aeb4835e7d6ec57bc195b96d9ee5a4ead1bb9f8b86', _index: '.internal.alerts-security.alerts-default-000001',
'@timestamp': ['2022-03-22T16:17:50.769Z'], _id: '8361363c0db6f30ca2dfb4aeb4835e7d6ec57bc195b96d9ee5a4ead1bb9f8b86',
'host.name': ['Host-4dbzugdlqd'], '@timestamp': ['2022-03-22T16:17:50.769Z'],
'kibana.alert.reason': [ 'host.name': ['Host-4dbzugdlqd'],
'network event with process iexlorer.exe, by hdgsmwj08h on Host-4dbzugdlqd created low alert test.', 'kibana.alert.reason': [
], 'network event with process iexlorer.exe, by hdgsmwj08h on Host-4dbzugdlqd created low alert test.',
'kibana.alert.risk_score': [21], ],
'kibana.alert.rule.name': ['test'], 'kibana.alert.risk_score': [21],
'kibana.alert.severity': ['low'], 'kibana.alert.rule.name': ['test'],
'process.name': ['iexlorer.exe'], 'kibana.alert.severity': ['low'],
'user.name': ['hdgsmwj08h'], 'process.name': ['iexlorer.exe'],
}, 'user.name': ['hdgsmwj08h'],
], },
total: 2, ],
ecsAlertsData: [ total: 2,
{ ecsAlertsData: [
kibana: { {
alert: { kibana: {
severity: ['low'], alert: {
risk_score: [21], severity: ['low'],
rule: { name: ['test'] }, risk_score: [21],
reason: [ rule: { name: ['test'] },
reason: [
'registry event with process iexlorer.exe, by 5qcxz8o4j7 on Host-4dbzugdlqd created low alert test.',
],
},
},
process: { name: ['iexlorer.exe'] },
'@timestamp': ['2022-03-22T16:48:07.518Z'],
user: { name: ['5qcxz8o4j7'] },
host: { name: ['Host-4dbzugdlqd'] },
_id: '38dd308706a127696cc63b8f142e8e4d66f8f79bc7d491dd79a42ea4ead62dd1',
_index: '.internal.alerts-security.alerts-default-000001',
},
{
kibana: {
alert: {
severity: ['low'],
risk_score: [21],
rule: { name: ['test'] },
reason: [
'network event with process iexlorer.exe, by hdgsmwj08h on Host-4dbzugdlqd created low alert test.',
],
},
},
process: { name: ['iexlorer.exe'] },
'@timestamp': ['2022-03-22T16:17:50.769Z'],
user: { name: ['hdgsmwj08h'] },
host: { name: ['Host-4dbzugdlqd'] },
_id: '8361363c0db6f30ca2dfb4aeb4835e7d6ec57bc195b96d9ee5a4ead1bb9f8b86',
_index: '.internal.alerts-security.alerts-default-000001',
},
],
oldAlertsData: [
[
{ field: 'kibana.alert.severity', value: ['low'] },
{ field: 'process.name', value: ['iexlorer.exe'] },
{ field: '@timestamp', value: ['2022-03-22T16:48:07.518Z'] },
{ field: 'kibana.alert.risk_score', value: [21] },
{ field: 'kibana.alert.rule.name', value: ['test'] },
{ field: 'user.name', value: ['5qcxz8o4j7'] },
{
field: 'kibana.alert.reason',
value: [
'registry event with process iexlorer.exe, by 5qcxz8o4j7 on Host-4dbzugdlqd created low alert test.', 'registry event with process iexlorer.exe, by 5qcxz8o4j7 on Host-4dbzugdlqd created low alert test.',
], ],
}, },
}, { field: 'host.name', value: ['Host-4dbzugdlqd'] },
process: { name: ['iexlorer.exe'] }, {
'@timestamp': ['2022-03-22T16:48:07.518Z'], field: '_id',
user: { name: ['5qcxz8o4j7'] }, value: '38dd308706a127696cc63b8f142e8e4d66f8f79bc7d491dd79a42ea4ead62dd1',
host: { name: ['Host-4dbzugdlqd'] }, },
_id: '38dd308706a127696cc63b8f142e8e4d66f8f79bc7d491dd79a42ea4ead62dd1', { field: '_index', value: '.internal.alerts-security.alerts-default-000001' },
_index: '.internal.alerts-security.alerts-default-000001', ],
}, [
{ { field: 'kibana.alert.severity', value: ['low'] },
kibana: { { field: 'process.name', value: ['iexlorer.exe'] },
alert: { { field: '@timestamp', value: ['2022-03-22T16:17:50.769Z'] },
severity: ['low'], { field: 'kibana.alert.risk_score', value: [21] },
risk_score: [21], { field: 'kibana.alert.rule.name', value: ['test'] },
rule: { name: ['test'] }, { field: 'user.name', value: ['hdgsmwj08h'] },
reason: [ {
field: 'kibana.alert.reason',
value: [
'network event with process iexlorer.exe, by hdgsmwj08h on Host-4dbzugdlqd created low alert test.', 'network event with process iexlorer.exe, by hdgsmwj08h on Host-4dbzugdlqd created low alert test.',
], ],
}, },
}, { field: 'host.name', value: ['Host-4dbzugdlqd'] },
process: { name: ['iexlorer.exe'] }, {
'@timestamp': ['2022-03-22T16:17:50.769Z'], field: '_id',
user: { name: ['hdgsmwj08h'] }, value: '8361363c0db6f30ca2dfb4aeb4835e7d6ec57bc195b96d9ee5a4ead1bb9f8b86',
host: { name: ['Host-4dbzugdlqd'] }, },
_id: '8361363c0db6f30ca2dfb4aeb4835e7d6ec57bc195b96d9ee5a4ead1bb9f8b86', { field: '_index', value: '.internal.alerts-security.alerts-default-000001' },
_index: '.internal.alerts-security.alerts-default-000001', ],
},
],
oldAlertsData: [
[
{ field: 'kibana.alert.severity', value: ['low'] },
{ field: 'process.name', value: ['iexlorer.exe'] },
{ field: '@timestamp', value: ['2022-03-22T16:48:07.518Z'] },
{ field: 'kibana.alert.risk_score', value: [21] },
{ field: 'kibana.alert.rule.name', value: ['test'] },
{ field: 'user.name', value: ['5qcxz8o4j7'] },
{
field: 'kibana.alert.reason',
value: [
'registry event with process iexlorer.exe, by 5qcxz8o4j7 on Host-4dbzugdlqd created low alert test.',
],
},
{ field: 'host.name', value: ['Host-4dbzugdlqd'] },
{
field: '_id',
value: '38dd308706a127696cc63b8f142e8e4d66f8f79bc7d491dd79a42ea4ead62dd1',
},
{ field: '_index', value: '.internal.alerts-security.alerts-default-000001' },
], ],
[ })
{ field: 'kibana.alert.severity', value: ['low'] }, );
{ field: 'process.name', value: ['iexlorer.exe'] }, });
{ field: '@timestamp', value: ['2022-03-22T16:17:50.769Z'] },
{ field: 'kibana.alert.risk_score', value: [21] },
{ field: 'kibana.alert.rule.name', value: ['test'] },
{ field: 'user.name', value: ['hdgsmwj08h'] },
{
field: 'kibana.alert.reason',
value: [
'network event with process iexlorer.exe, by hdgsmwj08h on Host-4dbzugdlqd created low alert test.',
],
},
{ field: 'host.name', value: ['Host-4dbzugdlqd'] },
{
field: '_id',
value: '8361363c0db6f30ca2dfb4aeb4835e7d6ec57bc195b96d9ee5a4ead1bb9f8b86',
},
{ field: '_index', value: '.internal.alerts-security.alerts-default-000001' },
],
],
})
);
}); });
it('returns empty placeholder data', () => { it('returns empty placeholder data', () => {

3
packages/kbn-alerts-ui-shared/src/common/hooks/use_update_rule.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import type { HttpStart } from '@kbn/core-http-browser'; import type { HttpStart } from '@kbn/core-http-browser';
import { useUpdateRule } from './use_update_rule'; import { useUpdateRule } from './use_update_rule';

11
packages/kbn-alerts-ui-shared/src/common/hooks/use_virtual_data_view_query.test.tsx
View file

@ -9,7 +9,7 @@
import React, { FunctionComponent } from 'react'; import React, { FunctionComponent } from 'react';
import * as ReactQuery from '@tanstack/react-query'; import * as ReactQuery from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { testQueryClientConfig } from '../test_utils/test_query_client_config'; import { testQueryClientConfig } from '../test_utils/test_query_client_config';
import { queryKeyPrefix, useVirtualDataViewQuery } from './use_virtual_data_view_query'; import { queryKeyPrefix, useVirtualDataViewQuery } from './use_virtual_data_view_query';
import { DataView } from '@kbn/data-views-plugin/common'; import { DataView } from '@kbn/data-views-plugin/common';
@ -38,10 +38,11 @@ describe('useVirtualDataViewQuery', () => {
it('does not create a data view if indexNames is empty or nullish', () => { it('does not create a data view if indexNames is empty or nullish', () => {
const { rerender } = renderHook( const { rerender } = renderHook(
({ indexNames }: React.PropsWithChildren<{ indexNames: string[] }>) => ({ indexNames }: { indexNames?: string[] }) =>
useVirtualDataViewQuery({ dataViewsService: mockDataViewsService, indexNames }), useVirtualDataViewQuery({ dataViewsService: mockDataViewsService, indexNames }),
{ {
wrapper, wrapper,
initialProps: {},
} }
); );
@ -89,7 +90,7 @@ describe('useVirtualDataViewQuery', () => {
}); });
it('removes the data view from the instance cache on unmount', async () => { it('removes the data view from the instance cache on unmount', async () => {
const { result, waitForValueToChange, unmount } = renderHook( const { result, unmount } = renderHook(
() => () =>
useVirtualDataViewQuery({ useVirtualDataViewQuery({
dataViewsService: mockDataViewsService, dataViewsService: mockDataViewsService,
@ -100,10 +101,10 @@ describe('useVirtualDataViewQuery', () => {
} }
); );
await waitForValueToChange(() => result.current.data); await waitFor(() => expect(result.current.data).toBeDefined());
unmount(); unmount();
expect(mockDataViewsService.clearInstanceCache).toHaveBeenCalled(); await waitFor(() => expect(mockDataViewsService.clearInstanceCache).toHaveBeenCalled());
}); });
}); });

3
packages/kbn-alerts-ui-shared/src/rule_form/hooks/use_load_dependencies.test.tsx
View file

@ -9,8 +9,7 @@
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import { renderHook } from '@testing-library/react-hooks/dom'; import { waitFor, renderHook } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import type { HttpStart } from '@kbn/core-http-browser'; import type { HttpStart } from '@kbn/core-http-browser';
import type { ToastsStart } from '@kbn/core-notifications-browser'; import type { ToastsStart } from '@kbn/core-notifications-browser';

2
packages/kbn-alerts-ui-shared/src/rule_form/rule_form_state/rule_form_state_reducer.test.tsx
View file

@ -8,7 +8,7 @@
*/ */
import React, { useReducer } from 'react'; import React, { useReducer } from 'react';
import { act, renderHook } from '@testing-library/react-hooks/dom'; import { renderHook, act } from '@testing-library/react';
import { ruleFormStateReducer } from './rule_form_state_reducer'; import { ruleFormStateReducer } from './rule_form_state_reducer';
import { RuleFormState } from '../types'; import { RuleFormState } from '../types';
import { getAction } from '../../common/test_utils/actions_test_utils'; import { getAction } from '../../common/test_utils/actions_test_utils';

2
packages/kbn-grouping/src/hooks/state/reducer.test.ts
View file

@ -7,7 +7,7 @@
* License v3.0 only", or the "Server Side Public License, v 1". * License v3.0 only", or the "Server Side Public License, v 1".
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { useReducer } from 'react'; import { useReducer } from 'react';
import { groupActions, groupsReducerWithStorage, initialState } from '.'; import { groupActions, groupsReducerWithStorage, initialState } from '.';
import { defaultGroup, LOCAL_STORAGE_GROUPING_KEY } from '../..'; import { defaultGroup, LOCAL_STORAGE_GROUPING_KEY } from '../..';

2
packages/kbn-grouping/src/hooks/use_get_group_selector.test.tsx
View file

@ -7,7 +7,7 @@
* License v3.0 only", or the "Server Side Public License, v 1". * License v3.0 only", or the "Server Side Public License, v 1".
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { useGetGroupSelector, useGetGroupSelectorStateless } from './use_get_group_selector'; import { useGetGroupSelector, useGetGroupSelectorStateless } from './use_get_group_selector';
import { initialState } from './state'; import { initialState } from './state';

157
packages/kbn-grouping/src/hooks/use_grouping.test.tsx
View file

@ -8,9 +8,8 @@
*/ */
import React from 'react'; import React from 'react';
import { act, renderHook } from '@testing-library/react-hooks';
import { __IntlProvider as IntlProvider } from '@kbn/i18n-react'; import { __IntlProvider as IntlProvider } from '@kbn/i18n-react';
import { render } from '@testing-library/react'; import { render, waitFor, renderHook } from '@testing-library/react';
import { useGrouping } from './use_grouping'; import { useGrouping } from './use_grouping';
@ -46,92 +45,86 @@ const groupingArgs = {
describe('useGrouping', () => { describe('useGrouping', () => {
it('Renders child component without grouping table wrapper when no group is selected', async () => { it('Renders child component without grouping table wrapper when no group is selected', async () => {
await act(async () => { const { result } = renderHook(() => useGrouping(defaultArgs));
const { result, waitForNextUpdate } = renderHook(() => useGrouping(defaultArgs)); await waitFor(() => new Promise((resolve) => resolve(null)));
await waitForNextUpdate(); const { getByTestId, queryByTestId } = render(
await waitForNextUpdate(); <IntlProvider locale="en">
const { getByTestId, queryByTestId } = render( {result.current.getGrouping({
<IntlProvider locale="en"> ...groupingArgs,
{result.current.getGrouping({ data: {
...groupingArgs, groupsCount: {
data: { value: 9,
groupsCount: {
value: 9,
},
groupByFields: {
buckets: [
{
key: ['critical hosts', 'description'],
key_as_string: 'critical hosts|description',
doc_count: 3,
unitsCount: {
value: 3,
},
},
],
},
unitsCount: {
value: 18,
},
}, },
renderChildComponent: () => <p data-test-subj="innerTable">{'hello'}</p>, groupByFields: {
selectedGroup: 'none', buckets: [
})} {
</IntlProvider> key: ['critical hosts', 'description'],
); key_as_string: 'critical hosts|description',
doc_count: 3,
unitsCount: {
value: 3,
},
},
],
},
unitsCount: {
value: 18,
},
},
renderChildComponent: () => <p data-test-subj="innerTable">{'hello'}</p>,
selectedGroup: 'none',
})}
</IntlProvider>
);
expect(getByTestId('innerTable')).toBeInTheDocument(); expect(getByTestId('innerTable')).toBeInTheDocument();
expect(queryByTestId('grouping-table')).not.toBeInTheDocument(); expect(queryByTestId('grouping-table')).not.toBeInTheDocument();
});
}); });
it('Renders child component with grouping table wrapper when group is selected', async () => { it('Renders child component with grouping table wrapper when group is selected', async () => {
await act(async () => { const getItem = jest.spyOn(window.localStorage.__proto__, 'getItem');
const getItem = jest.spyOn(window.localStorage.__proto__, 'getItem'); getItem.mockReturnValue(
getItem.mockReturnValue( JSON.stringify({
JSON.stringify({ 'test-table': {
'test-table': { itemsPerPageOptions: [10, 25, 50, 100],
itemsPerPageOptions: [10, 25, 50, 100], itemsPerPage: 25,
itemsPerPage: 25, activeGroup: 'kibana.alert.rule.name',
activeGroup: 'kibana.alert.rule.name', options: defaultGroupingOptions,
options: defaultGroupingOptions, },
}, })
}) );
);
const { result, waitForNextUpdate } = renderHook(() => useGrouping(defaultArgs)); const { result } = renderHook(() => useGrouping(defaultArgs));
await waitForNextUpdate(); await waitFor(() => new Promise((resolve) => resolve(null)));
await waitForNextUpdate(); const { getByTestId } = render(
const { getByTestId } = render( <IntlProvider locale="en">
<IntlProvider locale="en"> {result.current.getGrouping({
{result.current.getGrouping({ ...groupingArgs,
...groupingArgs, data: {
data: { groupsCount: {
groupsCount: { value: 9,
value: 9,
},
groupByFields: {
buckets: [
{
key: ['critical hosts', 'description'],
key_as_string: 'critical hosts|description',
doc_count: 3,
unitsCount: {
value: 3,
},
},
],
},
unitsCount: {
value: 18,
},
}, },
renderChildComponent: jest.fn(), groupByFields: {
selectedGroup: 'test', buckets: [
})} {
</IntlProvider> key: ['critical hosts', 'description'],
); key_as_string: 'critical hosts|description',
doc_count: 3,
unitsCount: {
value: 3,
},
},
],
},
unitsCount: {
value: 18,
},
},
renderChildComponent: jest.fn(),
selectedGroup: 'test',
})}
</IntlProvider>
);
expect(getByTestId('grouping-table')).toBeInTheDocument(); expect(getByTestId('grouping-table')).toBeInTheDocument();
});
}); });
}); });

4
x-pack/plugins/alerting/public/hooks/use_archive_maintenance_window.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook, act } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useArchiveMaintenanceWindow } from './use_archive_maintenance_window'; import { useArchiveMaintenanceWindow } from './use_archive_maintenance_window';

2
x-pack/plugins/alerting/public/hooks/use_breadcrumbs.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { useBreadcrumbs } from './use_breadcrumbs'; import { useBreadcrumbs } from './use_breadcrumbs';
import { MAINTENANCE_WINDOW_DEEP_LINK_IDS } from '../../common'; import { MAINTENANCE_WINDOW_DEEP_LINK_IDS } from '../../common';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';

4
x-pack/plugins/alerting/public/hooks/use_create_maintenance_window.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook, act } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useCreateMaintenanceWindow } from './use_create_maintenance_window'; import { useCreateMaintenanceWindow } from './use_create_maintenance_window';

4
x-pack/plugins/alerting/public/hooks/use_find_maintenance_windows.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useFindMaintenanceWindows } from './use_find_maintenance_windows'; import { useFindMaintenanceWindows } from './use_find_maintenance_windows';

4
x-pack/plugins/alerting/public/hooks/use_finish_and_archive_maintenance_window.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook, act } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useFinishAndArchiveMaintenanceWindow } from './use_finish_and_archive_maintenance_window'; import { useFinishAndArchiveMaintenanceWindow } from './use_finish_and_archive_maintenance_window';

4
x-pack/plugins/alerting/public/hooks/use_finish_maintenance_window.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook, act } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useFinishMaintenanceWindow } from './use_finish_maintenance_window'; import { useFinishMaintenanceWindow } from './use_finish_maintenance_window';

4
x-pack/plugins/alerting/public/hooks/use_get_maintenance_window.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useGetMaintenanceWindow } from './use_get_maintenance_window'; import { useGetMaintenanceWindow } from './use_get_maintenance_window';

2
x-pack/plugins/alerting/public/hooks/use_license.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import { licensingMock } from '@kbn/licensing-plugin/public/mocks'; import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { useLicense } from './use_license'; import { useLicense } from './use_license';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';

2
x-pack/plugins/alerting/public/hooks/use_navigation.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { import {
useCreateMaintenanceWindowNavigation, useCreateMaintenanceWindowNavigation,

4
x-pack/plugins/alerting/public/hooks/use_update_maintenance_window.test.tsx
View file

@ -4,8 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks/dom';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook, act } from '@testing-library/react';
import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils'; import { AppMockRenderer, createAppMockRenderer } from '../lib/test_utils';
import { useUpdateMaintenanceWindow } from './use_update_maintenance_window'; import { useUpdateMaintenanceWindow } from './use_update_maintenance_window';

14
x-pack/plugins/cases/public/common/apm/use_cases_transactions.test.ts
View file

@ -5,12 +5,8 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import type { CaseAttachmentsWithoutOwner } from '../../types'; import type { CaseAttachmentsWithoutOwner } from '../../types';
import type {
StartAddAttachmentToExistingCaseTransaction,
StartCreateCaseWithAttachmentsTransaction,
} from './use_cases_transactions';
import { import {
useAddAttachmentToExistingCaseTransaction, useAddAttachmentToExistingCaseTransaction,
useCreateCaseWithAttachmentsTransaction, useCreateCaseWithAttachmentsTransaction,
@ -37,14 +33,10 @@ const bulkAttachments = [
] as CaseAttachmentsWithoutOwner; ] as CaseAttachmentsWithoutOwner;
const renderUseCreateCaseWithAttachmentsTransaction = () => const renderUseCreateCaseWithAttachmentsTransaction = () =>
renderHook<void, { startTransaction: StartCreateCaseWithAttachmentsTransaction }>( renderHook(useCreateCaseWithAttachmentsTransaction);
useCreateCaseWithAttachmentsTransaction
);
const renderUseAddAttachmentToExistingCaseTransaction = () => const renderUseAddAttachmentToExistingCaseTransaction = () =>
renderHook<void, { startTransaction: StartAddAttachmentToExistingCaseTransaction }>( renderHook(useAddAttachmentToExistingCaseTransaction);
useAddAttachmentToExistingCaseTransaction
);
describe('cases transactions', () => { describe('cases transactions', () => {
beforeEach(() => { beforeEach(() => {

2
x-pack/plugins/cases/public/common/hooks.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { TestProviders } from './mock'; import { TestProviders } from './mock';
import { useIsMainApplication } from './hooks'; import { useIsMainApplication } from './hooks';

7
x-pack/plugins/cases/public/common/lib/kibana/hooks.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { useApplicationCapabilities } from './hooks'; import { useApplicationCapabilities } from './hooks';
import { allCasesPermissions, TestProviders } from '../../mock'; import { allCasesPermissions, TestProviders } from '../../mock';
@ -14,10 +14,7 @@ import { allCasesPermissions, TestProviders } from '../../mock';
describe('hooks', () => { describe('hooks', () => {
describe('useApplicationCapabilities', () => { describe('useApplicationCapabilities', () => {
it('should return the correct capabilities', async () => { it('should return the correct capabilities', async () => {
const { result } = renderHook< const { result } = renderHook(() => useApplicationCapabilities(), {
React.PropsWithChildren<{}>,
ReturnType<typeof useApplicationCapabilities>
>(() => useApplicationCapabilities(), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });

2
x-pack/plugins/cases/public/common/lib/kibana/use_application.test.tsx
View file

@ -7,7 +7,7 @@
import type { PublicAppInfo } from '@kbn/core-application-browser'; import type { PublicAppInfo } from '@kbn/core-application-browser';
import { AppStatus } from '@kbn/core-application-browser'; import { AppStatus } from '@kbn/core-application-browser';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { BehaviorSubject, Subject } from 'rxjs'; import { BehaviorSubject, Subject } from 'rxjs';
import type { AppMockRenderer } from '../../mock'; import type { AppMockRenderer } from '../../mock';
import { createAppMockRenderer } from '../../mock'; import { createAppMockRenderer } from '../../mock';

3
x-pack/plugins/cases/public/common/navigation/hooks.test.tsx
View file

@ -6,7 +6,8 @@
*/ */
import React from 'react'; import React from 'react';
import { act, renderHook } from '@testing-library/react-hooks';
import { renderHook, act } from '@testing-library/react';
import { APP_ID } from '../../../common/constants'; import { APP_ID } from '../../../common/constants';
import { useNavigation } from '../lib/kibana'; import { useNavigation } from '../lib/kibana';

40
x-pack/plugins/cases/public/common/use_cases_features.test.tsx
View file

@ -6,10 +6,9 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { licensingMock } from '@kbn/licensing-plugin/public/mocks'; import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
import type { CasesContextFeatures } from '../../common/ui'; import type { CasesContextFeatures } from '../../common/ui';
import type { UseCasesFeatures } from './use_cases_features';
import { useCasesFeatures } from './use_cases_features'; import { useCasesFeatures } from './use_cases_features';
import { TestProviders } from './mock/test_providers'; import { TestProviders } from './mock/test_providers';
import type { LicenseType } from '@kbn/licensing-plugin/common/types'; import type { LicenseType } from '@kbn/licensing-plugin/common/types';
@ -37,14 +36,9 @@ describe('useCasesFeatures', () => {
it.each(tests)( it.each(tests)(
'returns isAlertsEnabled=%s and isSyncAlertsEnabled=%s if feature.alerts=%s', 'returns isAlertsEnabled=%s and isSyncAlertsEnabled=%s if feature.alerts=%s',
async (isAlertsEnabled, isSyncAlertsEnabled, alerts) => { async (isAlertsEnabled, isSyncAlertsEnabled, alerts) => {
const { result } = renderHook<React.PropsWithChildren<{}>, UseCasesFeatures>( const { result } = renderHook(() => useCasesFeatures(), {
() => useCasesFeatures(), wrapper: ({ children }) => <TestProviders features={{ alerts }}>{children}</TestProviders>,
{ });
wrapper: ({ children }) => (
<TestProviders features={{ alerts }}>{children}</TestProviders>
),
}
);
expect(result.current).toEqual({ expect(result.current).toEqual({
isAlertsEnabled, isAlertsEnabled,
@ -57,16 +51,13 @@ describe('useCasesFeatures', () => {
); );
it('returns the metrics correctly', async () => { it('returns the metrics correctly', async () => {
const { result } = renderHook<React.PropsWithChildren<{}>, UseCasesFeatures>( const { result } = renderHook(() => useCasesFeatures(), {
() => useCasesFeatures(), wrapper: ({ children }) => (
{ <TestProviders features={{ metrics: [CaseMetricsFeature.CONNECTORS] }}>
wrapper: ({ children }) => ( {children}
<TestProviders features={{ metrics: [CaseMetricsFeature.CONNECTORS] }}> </TestProviders>
{children} ),
</TestProviders> });
),
}
);
expect(result.current).toEqual({ expect(result.current).toEqual({
isAlertsEnabled: true, isAlertsEnabled: true,
@ -91,12 +82,9 @@ describe('useCasesFeatures', () => {
license: { type }, license: { type },
}); });
const { result } = renderHook<React.PropsWithChildren<{}>, UseCasesFeatures>( const { result } = renderHook(() => useCasesFeatures(), {
() => useCasesFeatures(), wrapper: ({ children }) => <TestProviders license={license}>{children}</TestProviders>,
{ });
wrapper: ({ children }) => <TestProviders license={license}>{children}</TestProviders>,
}
);
expect(result.current).toEqual({ expect(result.current).toEqual({
isAlertsEnabled: true, isAlertsEnabled: true,

2
x-pack/plugins/cases/public/common/use_cases_local_storage.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { Subject } from 'rxjs'; import { Subject } from 'rxjs';
import type { AppMockRenderer } from './mock/test_providers'; import type { AppMockRenderer } from './mock/test_providers';
import { createAppMockRenderer } from './mock/test_providers'; import { createAppMockRenderer } from './mock/test_providers';

3
x-pack/plugins/cases/public/common/use_cases_toast.test.tsx
View file

@ -5,7 +5,6 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks';
import { useKibana, useToasts } from './lib/kibana'; import { useKibana, useToasts } from './lib/kibana';
import type { AppMockRenderer } from './mock'; import type { AppMockRenderer } from './mock';
import { createAppMockRenderer, TestProviders } from './mock'; import { createAppMockRenderer, TestProviders } from './mock';
@ -14,7 +13,7 @@ import { alertComment, basicComment, mockCase } from '../containers/mock';
import React from 'react'; import React from 'react';
import userEvent from '@testing-library/user-event'; import userEvent from '@testing-library/user-event';
import type { SupportedCaseAttachment } from '../types'; import type { SupportedCaseAttachment } from '../types';
import { getByTestId, queryByTestId, screen } from '@testing-library/react'; import { getByTestId, queryByTestId, screen, renderHook } from '@testing-library/react';
import { OWNER_INFO } from '../../common/constants'; import { OWNER_INFO } from '../../common/constants';
import { useApplication } from './lib/kibana/use_application'; import { useApplication } from './lib/kibana/use_application';

2
x-pack/plugins/cases/public/common/use_is_user_typing.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import type { AppMockRenderer } from './mock'; import type { AppMockRenderer } from './mock';
import { createAppMockRenderer } from './mock'; import { createAppMockRenderer } from './mock';
import { useIsUserTyping } from './use_is_user_typing'; import { useIsUserTyping } from './use_is_user_typing';

2
x-pack/plugins/cases/public/common/use_license.test.tsx
View file

@ -7,7 +7,7 @@
import React from 'react'; import React from 'react';
import { licensingMock } from '@kbn/licensing-plugin/public/mocks'; import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { TestProviders } from './mock'; import { TestProviders } from './mock';
import { useLicense } from './use_license'; import { useLicense } from './use_license';

8
x-pack/plugins/cases/public/components/actions/assignees/use_assignees_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useAssigneesAction } from './use_assignees_action'; import { useAssigneesAction } from './use_assignees_action';
import * as api from '../../../containers/api'; import * as api from '../../../containers/api';
@ -56,7 +56,7 @@ describe('useAssigneesAction', () => {
it('update the assignees correctly', async () => { it('update the assignees correctly', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useAssigneesAction({ onAction, onActionSuccess, isDisabled: false }), () => useAssigneesAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -92,7 +92,7 @@ describe('useAssigneesAction', () => {
}); });
it('shows the success toaster correctly when updating one case', async () => { it('shows the success toaster correctly when updating one case', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useAssigneesAction({ onAction, onActionSuccess, isDisabled: false }), () => useAssigneesAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -118,7 +118,7 @@ describe('useAssigneesAction', () => {
}); });
it('shows the success toaster correctly when updating multiple cases', async () => { it('shows the success toaster correctly when updating multiple cases', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useAssigneesAction({ onAction, onActionSuccess, isDisabled: false }), () => useAssigneesAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,

6
x-pack/plugins/cases/public/components/actions/copy_id/use_copy_id_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useCopyIDAction } from './use_copy_id_action'; import { useCopyIDAction } from './use_copy_id_action';
import { basicCase } from '../../../containers/mock'; import { basicCase } from '../../../containers/mock';
@ -58,7 +58,7 @@ describe('useCopyIDAction', () => {
}); });
it('copies the id of the selected case to the clipboard', async () => { it('copies the id of the selected case to the clipboard', async () => {
const { result, waitFor } = renderHook(() => useCopyIDAction({ onActionSuccess }), { const { result } = renderHook(() => useCopyIDAction({ onActionSuccess }), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -73,7 +73,7 @@ describe('useCopyIDAction', () => {
}); });
it('shows the success toaster correctly when copying the case id', async () => { it('shows the success toaster correctly when copying the case id', async () => {
const { result, waitFor } = renderHook(() => useCopyIDAction({ onActionSuccess }), { const { result } = renderHook(() => useCopyIDAction({ onActionSuccess }), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });

10
x-pack/plugins/cases/public/components/actions/delete/use_delete_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useDeleteAction } from './use_delete_action'; import { useDeleteAction } from './use_delete_action';
import * as api from '../../../containers/api'; import * as api from '../../../containers/api';
@ -84,7 +84,7 @@ describe('useDeleteAction', () => {
it('deletes the selected cases', async () => { it('deletes the selected cases', async () => {
const deleteSpy = jest.spyOn(api, 'deleteCases'); const deleteSpy = jest.spyOn(api, 'deleteCases');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }), () => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -112,7 +112,7 @@ describe('useDeleteAction', () => {
}); });
it('closes the modal', async () => { it('closes the modal', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }), () => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -137,7 +137,7 @@ describe('useDeleteAction', () => {
}); });
it('shows the success toaster correctly when delete one case', async () => { it('shows the success toaster correctly when delete one case', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }), () => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -163,7 +163,7 @@ describe('useDeleteAction', () => {
}); });
it('shows the success toaster correctly when delete multiple case', async () => { it('shows the success toaster correctly when delete multiple case', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }), () => useDeleteAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,

8
x-pack/plugins/cases/public/components/actions/severity/use_severity_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useSeverityAction } from './use_severity_action'; import { useSeverityAction } from './use_severity_action';
import * as api from '../../../containers/api'; import * as api from '../../../containers/api';
@ -80,7 +80,7 @@ describe('useSeverityAction', () => {
it('update the severity cases', async () => { it('update the severity cases', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useSeverityAction({ onAction, onActionSuccess, isDisabled: false }), () => useSeverityAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -120,7 +120,7 @@ describe('useSeverityAction', () => {
it.each(singleCaseTests)( it.each(singleCaseTests)(
'shows the success toaster correctly when updating the severity of the case: %s', 'shows the success toaster correctly when updating the severity of the case: %s',
async (_, index, expectedMessage) => { async (_, index, expectedMessage) => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useSeverityAction({ onAction, onActionSuccess, isDisabled: false }), () => useSeverityAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -153,7 +153,7 @@ describe('useSeverityAction', () => {
it.each(multipleCasesTests)( it.each(multipleCasesTests)(
'shows the success toaster correctly when updating the severity of the case: %s', 'shows the success toaster correctly when updating the severity of the case: %s',
async (_, index, expectedMessage) => { async (_, index, expectedMessage) => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useSeverityAction({ onAction, onActionSuccess, isDisabled: false }), () => useSeverityAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,

8
x-pack/plugins/cases/public/components/actions/status/use_status_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useStatusAction } from './use_status_action'; import { useStatusAction } from './use_status_action';
import * as api from '../../../containers/api'; import * as api from '../../../containers/api';
@ -82,7 +82,7 @@ describe('useStatusAction', () => {
it('update the status cases', async () => { it('update the status cases', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useStatusAction({ onAction, onActionSuccess, isDisabled: false }), () => useStatusAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -120,7 +120,7 @@ describe('useStatusAction', () => {
it.each(singleCaseTests)( it.each(singleCaseTests)(
'shows the success toaster correctly when updating the status of the case: %s', 'shows the success toaster correctly when updating the status of the case: %s',
async (_, index, expectedMessage) => { async (_, index, expectedMessage) => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useStatusAction({ onAction, onActionSuccess, isDisabled: false }), () => useStatusAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -152,7 +152,7 @@ describe('useStatusAction', () => {
it.each(multipleCasesTests)( it.each(multipleCasesTests)(
'shows the success toaster correctly when updating the status of the case: %s', 'shows the success toaster correctly when updating the status of the case: %s',
async (_, index, expectedMessage) => { async (_, index, expectedMessage) => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useStatusAction({ onAction, onActionSuccess, isDisabled: false }), () => useStatusAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,

8
x-pack/plugins/cases/public/components/actions/tags/use_tags_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useTagsAction } from './use_tags_action'; import { useTagsAction } from './use_tags_action';
import * as api from '../../../containers/api'; import * as api from '../../../containers/api';
@ -56,7 +56,7 @@ describe('useTagsAction', () => {
it('update the tags correctly', async () => { it('update the tags correctly', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useTagsAction({ onAction, onActionSuccess, isDisabled: false }), () => useTagsAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -86,7 +86,7 @@ describe('useTagsAction', () => {
}); });
it('shows the success toaster correctly when updating one case', async () => { it('shows the success toaster correctly when updating one case', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useTagsAction({ onAction, onActionSuccess, isDisabled: false }), () => useTagsAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -112,7 +112,7 @@ describe('useTagsAction', () => {
}); });
it('shows the success toaster correctly when updating multiple cases', async () => { it('shows the success toaster correctly when updating multiple cases', async () => {
const { result, waitFor } = renderHook( const { result } = renderHook(
() => useTagsAction({ onAction, onActionSuccess, isDisabled: false }), () => useTagsAction({ onAction, onActionSuccess, isDisabled: false }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,

24
x-pack/plugins/cases/public/components/actions/use_items_action.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useItemsAction } from './use_items_action'; import { useItemsAction } from './use_items_action';
import * as api from '../../containers/api'; import * as api from '../../containers/api';
@ -54,7 +54,7 @@ describe('useItemsAction', () => {
}); });
it('closes the flyout', async () => { it('closes the flyout', async () => {
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -81,7 +81,7 @@ describe('useItemsAction', () => {
it('update the items correctly', async () => { it('update the items correctly', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -117,7 +117,7 @@ describe('useItemsAction', () => {
}); });
it('calls fieldSelector correctly', async () => { it('calls fieldSelector correctly', async () => {
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -142,7 +142,7 @@ describe('useItemsAction', () => {
}); });
it('calls itemsTransformer correctly', async () => { it('calls itemsTransformer correctly', async () => {
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -169,7 +169,7 @@ describe('useItemsAction', () => {
it('removes duplicates', async () => { it('removes duplicates', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -203,7 +203,7 @@ describe('useItemsAction', () => {
}); });
it('shows the success toaster correctly when updating a case', async () => { it('shows the success toaster correctly when updating a case', async () => {
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -229,7 +229,7 @@ describe('useItemsAction', () => {
it('do not update cases with no changes', async () => { it('do not update cases with no changes', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -254,7 +254,7 @@ describe('useItemsAction', () => {
it('do not update if the selected items are the same but with different order', async () => { it('do not update if the selected items are the same but with different order', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -279,7 +279,7 @@ describe('useItemsAction', () => {
it('do not update if the selected items are the same', async () => { it('do not update if the selected items are the same', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -304,7 +304,7 @@ describe('useItemsAction', () => {
it('do not update if selecting and unselecting the same item', async () => { it('do not update if selecting and unselecting the same item', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -329,7 +329,7 @@ describe('useItemsAction', () => {
it('do not update with empty items and no selection', async () => { it('do not update with empty items and no selection', async () => {
const updateSpy = jest.spyOn(api, 'updateCases'); const updateSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor } = renderHook(() => useItemsAction(props), { const { result } = renderHook(() => useItemsAction(props), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });

2
x-pack/plugins/cases/public/components/actions/use_items_state.test.tsx
View file

@ -7,7 +7,7 @@
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { useItemsState } from './use_items_state'; import { useItemsState } from './use_items_state';
import { basicCase } from '../../containers/mock'; import { basicCase } from '../../containers/mock';

9
x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx
View file

@ -7,8 +7,7 @@
import React from 'react'; import React from 'react';
import moment from 'moment-timezone'; import moment from 'moment-timezone';
import { render, waitFor, screen, within } from '@testing-library/react'; import { render, waitFor, screen, within, renderHook } from '@testing-library/react';
import { renderHook } from '@testing-library/react-hooks';
import userEvent from '@testing-library/user-event'; import userEvent from '@testing-library/user-event';
import { waitForEuiPopoverOpen } from '@elastic/eui/lib/test/rtl'; import { waitForEuiPopoverOpen } from '@elastic/eui/lib/test/rtl';
@ -27,7 +26,6 @@ import { SECURITY_SOLUTION_OWNER } from '../../../common/constants';
import { getEmptyCellValue } from '../empty_value'; import { getEmptyCellValue } from '../empty_value';
import { useKibana } from '../../common/lib/kibana'; import { useKibana } from '../../common/lib/kibana';
import { AllCasesList } from './all_cases_list'; import { AllCasesList } from './all_cases_list';
import type { GetCasesColumn, UseCasesColumnsReturnValue } from './use_cases_columns';
import { useCasesColumns } from './use_cases_columns'; import { useCasesColumns } from './use_cases_columns';
import { triggersActionsUiMock } from '@kbn/triggers-actions-ui-plugin/public/mocks'; import { triggersActionsUiMock } from '@kbn/triggers-actions-ui-plugin/public/mocks';
import { registerConnectorsToMockActionRegistry } from '../../common/mock/register_connectors'; import { registerConnectorsToMockActionRegistry } from '../../common/mock/register_connectors';
@ -267,10 +265,7 @@ describe.skip('AllCasesListGeneric', () => {
expect(column[key].querySelector('span')).toHaveTextContent(emptyTag); expect(column[key].querySelector('span')).toHaveTextContent(emptyTag);
}; };
const { result } = renderHook< const { result } = renderHook(() => useCasesColumns(defaultColumnArgs), {
React.PropsWithChildren<GetCasesColumn>,
UseCasesColumnsReturnValue
>(() => useCasesColumns(defaultColumnArgs), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });

14
x-pack/plugins/cases/public/components/all_cases/selector_modal/use_cases_add_to_existing_case_modal.test.tsx
View file

@ -5,8 +5,7 @@
* 2.0. * 2.0.
*/ */
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook, act } from '@testing-library/react';
import { act, renderHook } from '@testing-library/react-hooks';
import userEvent from '@testing-library/user-event'; import userEvent from '@testing-library/user-event';
import type { FC, PropsWithChildren } from 'react'; import type { FC, PropsWithChildren } from 'react';
import React from 'react'; import React from 'react';
@ -96,12 +95,11 @@ describe('use cases add to existing case modal hook', () => {
}); });
it('should throw if called outside of a cases context', () => { it('should throw if called outside of a cases context', () => {
const { result } = renderHook(() => { expect(() =>
useCasesAddToExistingCaseModal(defaultParams()); renderHook(() => {
}); useCasesAddToExistingCaseModal(defaultParams());
expect(result.error?.message).toContain( })
'useCasesContext must be used within a CasesProvider and have a defined value' ).toThrow(/useCasesContext must be used within a CasesProvider and have a defined value/);
);
}); });
it('should dispatch the open action when invoked', () => { it('should dispatch the open action when invoked', () => {

6
x-pack/plugins/cases/public/components/all_cases/table_filter_config/use_filter_config.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import type { FilterConfig, FilterConfigRenderParams } from './types'; import type { FilterConfig, FilterConfigRenderParams } from './types';
@ -64,7 +64,7 @@ describe('useFilterConfig', () => {
it('should remove a selected option if the filter is deleted', async () => { it('should remove a selected option if the filter is deleted', async () => {
const { rerender } = renderHook(useFilterConfig, { const { rerender } = renderHook(useFilterConfig, {
wrapper: ({ children }: React.PropsWithChildren<Parameters<typeof useFilterConfig>[0]>) => ( wrapper: ({ children }: React.PropsWithChildren) => (
<appMockRender.AppWrapper>{children}</appMockRender.AppWrapper> <appMockRender.AppWrapper>{children}</appMockRender.AppWrapper>
), ),
initialProps: { initialProps: {
@ -106,7 +106,7 @@ describe('useFilterConfig', () => {
); );
const { result } = renderHook(useFilterConfig, { const { result } = renderHook(useFilterConfig, {
wrapper: ({ children }: React.PropsWithChildren<Parameters<typeof useFilterConfig>[0]>) => ( wrapper: ({ children }: React.PropsWithChildren) => (
<appMockRender.AppWrapper>{children}</appMockRender.AppWrapper> <appMockRender.AppWrapper>{children}</appMockRender.AppWrapper>
), ),
initialProps: { initialProps: {

3
x-pack/plugins/cases/public/components/all_cases/use_actions.test.tsx
View file

@ -6,8 +6,7 @@
*/ */
import userEvent, { type UserEvent } from '@testing-library/user-event'; import userEvent, { type UserEvent } from '@testing-library/user-event';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import { renderHook } from '@testing-library/react-hooks/dom';
import { import {
waitForEuiPopoverOpen, waitForEuiPopoverOpen,
waitForEuiContextMenuPanelTransition, waitForEuiContextMenuPanelTransition,

3
x-pack/plugins/cases/public/components/all_cases/use_all_cases_state.test.tsx
View file

@ -6,8 +6,7 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook, act } from '@testing-library/react-hooks'; import { waitFor, renderHook, act } from '@testing-library/react';
import { waitFor } from '@testing-library/react';
import { CaseStatuses } from '@kbn/cases-components'; import { CaseStatuses } from '@kbn/cases-components';
import { TestProviders } from '../../common/mock'; import { TestProviders } from '../../common/mock';

41
x-pack/plugins/cases/public/components/all_cases/use_bulk_actions.test.tsx
View file

@ -8,8 +8,7 @@
import React from 'react'; import React from 'react';
import { EuiContextMenu } from '@elastic/eui'; import { EuiContextMenu } from '@elastic/eui';
import userEvent from '@testing-library/user-event'; import userEvent from '@testing-library/user-event';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import { renderHook } from '@testing-library/react-hooks/dom';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { import {
@ -190,7 +189,7 @@ describe('useBulkActions', () => {
it('change the status of cases', async () => { it('change the status of cases', async () => {
const updateCasesSpy = jest.spyOn(api, 'updateCases'); const updateCasesSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -219,7 +218,7 @@ describe('useBulkActions', () => {
pointerEventsCheck: 0, pointerEventsCheck: 0,
}); });
await waitForHook(() => { await waitFor(() => {
expect(updateCasesSpy).toHaveBeenCalled(); expect(updateCasesSpy).toHaveBeenCalled();
}); });
}); });
@ -227,7 +226,7 @@ describe('useBulkActions', () => {
it('change the severity of cases', async () => { it('change the severity of cases', async () => {
const updateCasesSpy = jest.spyOn(api, 'updateCases'); const updateCasesSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -257,7 +256,7 @@ describe('useBulkActions', () => {
pointerEventsCheck: 0, pointerEventsCheck: 0,
}); });
await waitForHook(() => { await waitFor(() => {
expect(updateCasesSpy).toHaveBeenCalled(); expect(updateCasesSpy).toHaveBeenCalled();
}); });
}); });
@ -266,7 +265,7 @@ describe('useBulkActions', () => {
it('delete a case', async () => { it('delete a case', async () => {
const deleteSpy = jest.spyOn(api, 'deleteCases'); const deleteSpy = jest.spyOn(api, 'deleteCases');
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -299,7 +298,7 @@ describe('useBulkActions', () => {
await userEvent.click(res.getByTestId('confirmModalConfirmButton')); await userEvent.click(res.getByTestId('confirmModalConfirmButton'));
await waitForHook(() => { await waitFor(() => {
expect(deleteSpy).toHaveBeenCalled(); expect(deleteSpy).toHaveBeenCalled();
}); });
}); });
@ -355,7 +354,7 @@ describe('useBulkActions', () => {
it('change the tags of the case', async () => { it('change the tags of the case', async () => {
const updateCasesSpy = jest.spyOn(api, 'updateCases'); const updateCasesSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -394,7 +393,7 @@ describe('useBulkActions', () => {
await userEvent.click(res.getByText('coke')); await userEvent.click(res.getByText('coke'));
await userEvent.click(res.getByTestId('cases-edit-tags-flyout-submit')); await userEvent.click(res.getByTestId('cases-edit-tags-flyout-submit'));
await waitForHook(() => { await waitFor(() => {
expect(updateCasesSpy).toHaveBeenCalled(); expect(updateCasesSpy).toHaveBeenCalled();
}); });
}); });
@ -402,7 +401,7 @@ describe('useBulkActions', () => {
it('change the assignees of the case', async () => { it('change the assignees of the case', async () => {
const updateCasesSpy = jest.spyOn(api, 'updateCases'); const updateCasesSpy = jest.spyOn(api, 'updateCases');
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -441,7 +440,7 @@ describe('useBulkActions', () => {
await userEvent.click(res.getByText('Damaged Raccoon')); await userEvent.click(res.getByText('Damaged Raccoon'));
await userEvent.click(res.getByTestId('cases-edit-assignees-flyout-submit')); await userEvent.click(res.getByTestId('cases-edit-assignees-flyout-submit'));
await waitForHook(() => { await waitFor(() => {
expect(updateCasesSpy).toHaveBeenCalled(); expect(updateCasesSpy).toHaveBeenCalled();
}); });
}); });
@ -450,7 +449,7 @@ describe('useBulkActions', () => {
describe('Permissions', () => { describe('Permissions', () => {
it('shows the correct actions with all permissions', async () => { it('shows the correct actions with all permissions', async () => {
appMockRender = createAppMockRenderer({ permissions: allCasesPermissions() }); appMockRender = createAppMockRenderer({ permissions: allCasesPermissions() });
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -467,7 +466,7 @@ describe('useBulkActions', () => {
</> </>
); );
await waitForHook(() => { await waitFor(() => {
expect(res.getByTestId('case-bulk-action-status')).toBeInTheDocument(); expect(res.getByTestId('case-bulk-action-status')).toBeInTheDocument();
expect(res.getByTestId('cases-bulk-action-delete')).toBeInTheDocument(); expect(res.getByTestId('cases-bulk-action-delete')).toBeInTheDocument();
expect(res.getByTestId('bulk-actions-separator')).toBeInTheDocument(); expect(res.getByTestId('bulk-actions-separator')).toBeInTheDocument();
@ -476,7 +475,7 @@ describe('useBulkActions', () => {
it('shows the correct actions with no delete permissions', async () => { it('shows the correct actions with no delete permissions', async () => {
appMockRender = createAppMockRenderer({ permissions: noDeleteCasesPermissions() }); appMockRender = createAppMockRenderer({ permissions: noDeleteCasesPermissions() });
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -493,7 +492,7 @@ describe('useBulkActions', () => {
</> </>
); );
await waitForHook(() => { await waitFor(() => {
expect(res.getByTestId('case-bulk-action-status')).toBeInTheDocument(); expect(res.getByTestId('case-bulk-action-status')).toBeInTheDocument();
expect(res.queryByTestId('cases-bulk-action-delete')).toBeFalsy(); expect(res.queryByTestId('cases-bulk-action-delete')).toBeFalsy();
expect(res.queryByTestId('bulk-actions-separator')).toBeFalsy(); expect(res.queryByTestId('bulk-actions-separator')).toBeFalsy();
@ -502,7 +501,7 @@ describe('useBulkActions', () => {
it('shows the correct actions with only delete permissions', async () => { it('shows the correct actions with only delete permissions', async () => {
appMockRender = createAppMockRenderer({ permissions: onlyDeleteCasesPermission() }); appMockRender = createAppMockRenderer({ permissions: onlyDeleteCasesPermission() });
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCase] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -519,7 +518,7 @@ describe('useBulkActions', () => {
</> </>
); );
await waitForHook(() => { await waitFor(() => {
expect(res.queryByTestId('case-bulk-action-status')).toBeFalsy(); expect(res.queryByTestId('case-bulk-action-status')).toBeFalsy();
expect(res.getByTestId('cases-bulk-action-delete')).toBeInTheDocument(); expect(res.getByTestId('cases-bulk-action-delete')).toBeInTheDocument();
expect(res.queryByTestId('bulk-actions-separator')).toBeFalsy(); expect(res.queryByTestId('bulk-actions-separator')).toBeFalsy();
@ -528,7 +527,7 @@ describe('useBulkActions', () => {
it('shows the correct actions with no reopen permissions', async () => { it('shows the correct actions with no reopen permissions', async () => {
appMockRender = createAppMockRenderer({ permissions: noReopenCasesPermissions() }); appMockRender = createAppMockRenderer({ permissions: noReopenCasesPermissions() });
const { result, waitFor: waitForHook } = renderHook( const { result } = renderHook(
() => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCaseClosed] }), () => useBulkActions({ onAction, onActionSuccess, selectedCases: [basicCaseClosed] }),
{ {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
@ -545,12 +544,12 @@ describe('useBulkActions', () => {
</> </>
); );
await waitForHook(() => { await waitFor(() => {
expect(res.queryByTestId('case-bulk-action-status')).toBeInTheDocument(); expect(res.queryByTestId('case-bulk-action-status')).toBeInTheDocument();
res.queryByTestId('case-bulk-action-status')?.click(); res.queryByTestId('case-bulk-action-status')?.click();
}); });
await waitForHook(() => { await waitFor(() => {
expect(res.queryByTestId('cases-bulk-action-status-open')).toBeDisabled(); expect(res.queryByTestId('cases-bulk-action-status-open')).toBeDisabled();
expect(res.queryByTestId('cases-bulk-action-status-in-progress')).toBeDisabled(); expect(res.queryByTestId('cases-bulk-action-status-in-progress')).toBeDisabled();
expect(res.queryByTestId('cases-bulk-action-status-closed')).toBeDisabled(); expect(res.queryByTestId('cases-bulk-action-status-closed')).toBeDisabled();

2
x-pack/plugins/cases/public/components/all_cases/use_cases_columns.test.tsx
View file

@ -15,7 +15,7 @@ import { useGetCasesMockState } from '../../containers/mock';
import { connectors, useCaseConfigureResponse } from '../configure_cases/__mock__'; import { connectors, useCaseConfigureResponse } from '../configure_cases/__mock__';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer, readCasesPermissions, TestProviders } from '../../common/mock'; import { createAppMockRenderer, readCasesPermissions, TestProviders } from '../../common/mock';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { CaseStatuses, CustomFieldTypes } from '../../../common/types/domain'; import { CaseStatuses, CustomFieldTypes } from '../../../common/types/domain';
import { userProfilesMap } from '../../containers/user_profiles/api.mock'; import { userProfilesMap } from '../../containers/user_profiles/api.mock';
import { useGetCaseConfiguration } from '../../containers/configure/use_get_case_configuration'; import { useGetCaseConfiguration } from '../../containers/configure/use_get_case_configuration';

2
x-pack/plugins/cases/public/components/all_cases/use_cases_columns_configuration.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import { licensingMock } from '@kbn/licensing-plugin/public/mocks'; import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';

2
x-pack/plugins/cases/public/components/all_cases/use_cases_columns_selection.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import { licensingMock } from '@kbn/licensing-plugin/public/mocks'; import { licensingMock } from '@kbn/licensing-plugin/public/mocks';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';

2
x-pack/plugins/cases/public/components/all_cases/use_on_refresh_cases.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';
import { casesQueriesKeys } from '../../containers/constants'; import { casesQueriesKeys } from '../../containers/constants';

2
x-pack/plugins/cases/public/components/app/use_available_owners.test.ts
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { APP_ID, OBSERVABILITY_OWNER, SECURITY_SOLUTION_OWNER } from '../../../common/constants'; import { APP_ID, OBSERVABILITY_OWNER, SECURITY_SOLUTION_OWNER } from '../../../common/constants';
import { useKibana } from '../../common/lib/kibana'; import { useKibana } from '../../common/lib/kibana';

2
x-pack/plugins/cases/public/components/app/use_readonly_header.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { useKibana } from '../../common/lib/kibana'; import { useKibana } from '../../common/lib/kibana';
import { readCasesPermissions, TestProviders } from '../../common/mock'; import { readCasesPermissions, TestProviders } from '../../common/mock';

7
x-pack/plugins/cases/public/components/cases_context/state/use_is_add_to_case_open.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { useCasesAddToExistingCaseModal } from '../../all_cases/selector_modal/use_cases_add_to_existing_case_modal'; import { useCasesAddToExistingCaseModal } from '../../all_cases/selector_modal/use_cases_add_to_existing_case_modal';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { useIsAddToCaseOpen } from './use_is_add_to_case_open'; import { useIsAddToCaseOpen } from './use_is_add_to_case_open';
@ -26,9 +26,8 @@ describe('use is add to existing case modal open hook', () => {
}); });
it('should throw if called outside of a cases context', () => { it('should throw if called outside of a cases context', () => {
const { result } = renderHook(useIsAddToCaseOpen); expect(() => renderHook(useIsAddToCaseOpen)).toThrow(
expect(result.error?.message).toContain( /useCasesStateContext must be used within a CasesProvider and have a defined value/
'useCasesStateContext must be used within a CasesProvider and have a defined value'
); );
}); });

8
x-pack/plugins/cases/public/components/connectors/jira/use_get_fields_by_issue_type.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import { connector } from '../mock'; import { connector } from '../mock';
@ -30,7 +30,7 @@ describe('useGetFieldsByIssueType', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getFieldsByIssueType'); const spy = jest.spyOn(api, 'getFieldsByIssueType');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetFieldsByIssueType({ useGetFieldsByIssueType({
http, http,
@ -88,7 +88,7 @@ describe('useGetFieldsByIssueType', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetFieldsByIssueType({ useGetFieldsByIssueType({
http, http,
@ -114,7 +114,7 @@ describe('useGetFieldsByIssueType', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetFieldsByIssueType({ useGetFieldsByIssueType({
http, http,

24
x-pack/plugins/cases/public/components/connectors/jira/use_get_issue.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import { connector as actionConnector } from '../mock'; import { connector as actionConnector } from '../mock';
@ -30,7 +30,7 @@ describe('useGetIssue', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getIssue'); const spy = jest.spyOn(api, 'getIssue');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssue({ useGetIssue({
http, http,
@ -40,7 +40,7 @@ describe('useGetIssue', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitFor(() => result.current.isSuccess); await waitFor(() => expect(result.current.isSuccess).toBe(true));
expect(spy).toHaveBeenCalledWith({ expect(spy).toHaveBeenCalledWith({
http, http,
@ -88,7 +88,7 @@ describe('useGetIssue', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssue({ useGetIssue({
http, http,
@ -98,9 +98,10 @@ describe('useGetIssue', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitFor(() => result.current.isError); await waitFor(() => {
expect(result.current.isError).toBe(true);
expect(addError).toHaveBeenCalled(); expect(addError).toHaveBeenCalled();
});
}); });
it('calls addError when the getIssue api returns successfully but contains an error', async () => { it('calls addError when the getIssue api returns successfully but contains an error', async () => {
@ -114,7 +115,7 @@ describe('useGetIssue', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssue({ useGetIssue({
http, http,
@ -124,8 +125,9 @@ describe('useGetIssue', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitFor(() => result.current.isSuccess); await waitFor(() => {
expect(result.current.isSuccess).toBe(true);
expect(addError).toHaveBeenCalled(); expect(addError).toHaveBeenCalled();
});
}); });
}); });

8
x-pack/plugins/cases/public/components/connectors/jira/use_get_issue_types.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import { connector } from '../mock'; import { connector } from '../mock';
@ -30,7 +30,7 @@ describe('useGetIssueTypes', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getIssueTypes'); const spy = jest.spyOn(api, 'getIssueTypes');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssueTypes({ useGetIssueTypes({
http, http,
@ -70,7 +70,7 @@ describe('useGetIssueTypes', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetIssueTypes({ useGetIssueTypes({
http, http,
@ -95,7 +95,7 @@ describe('useGetIssueTypes', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetIssueTypes({ useGetIssueTypes({
http, http,

37
x-pack/plugins/cases/public/components/connectors/jira/use_get_issues.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import { connector as actionConnector } from '../mock'; import { connector as actionConnector } from '../mock';
@ -30,7 +30,7 @@ describe('useGetIssues', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getIssues'); const spy = jest.spyOn(api, 'getIssues');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssues({ useGetIssues({
http, http,
@ -40,13 +40,14 @@ describe('useGetIssues', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitFor(() => result.current.isSuccess); await waitFor(() => {
expect(result.current.isSuccess).toBe(true);
expect(spy).toHaveBeenCalledWith({ expect(spy).toHaveBeenCalledWith({
http, http,
signal: expect.anything(), signal: expect.anything(),
connectorId: actionConnector.id, connectorId: actionConnector.id,
title: 'Task', title: 'Task',
});
}); });
}); });
@ -74,7 +75,7 @@ describe('useGetIssues', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssues({ useGetIssues({
http, http,
@ -84,9 +85,10 @@ describe('useGetIssues', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitFor(() => result.current.isError); await waitFor(() => {
expect(result.current.isError).toBe(true);
expect(addError).toHaveBeenCalled(); expect(addError).toHaveBeenCalled();
});
}); });
it('calls addError when the getIssues api returns successfully but contains an error', async () => { it('calls addError when the getIssues api returns successfully but contains an error', async () => {
@ -100,7 +102,7 @@ describe('useGetIssues', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIssues({ useGetIssues({
http, http,
@ -110,8 +112,9 @@ describe('useGetIssues', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitFor(() => result.current.isSuccess); await waitFor(() => {
expect(result.current.isSuccess).toBe(true);
expect(addError).toHaveBeenCalled(); expect(addError).toHaveBeenCalled();
});
}); });
}); });

8
x-pack/plugins/cases/public/components/connectors/resilient/use_get_incident_types.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import { connector } from '../mock'; import { connector } from '../mock';
@ -30,7 +30,7 @@ describe('useGetIncidentTypes', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getIncidentTypes'); const spy = jest.spyOn(api, 'getIncidentTypes');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetIncidentTypes({ useGetIncidentTypes({
http, http,
@ -70,7 +70,7 @@ describe('useGetIncidentTypes', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetIncidentTypes({ useGetIncidentTypes({
http, http,
@ -95,7 +95,7 @@ describe('useGetIncidentTypes', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetIncidentTypes({ useGetIncidentTypes({
http, http,

8
x-pack/plugins/cases/public/components/connectors/resilient/use_get_severity.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import { connector } from '../mock'; import { connector } from '../mock';
@ -30,7 +30,7 @@ describe('useGetSeverity', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getSeverity'); const spy = jest.spyOn(api, 'getSeverity');
const { result, waitFor } = renderHook( const { result } = renderHook(
() => () =>
useGetSeverity({ useGetSeverity({
http, http,
@ -70,7 +70,7 @@ describe('useGetSeverity', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetSeverity({ useGetSeverity({
http, http,
@ -95,7 +95,7 @@ describe('useGetSeverity', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetSeverity({ useGetSeverity({
http, http,

8
x-pack/plugins/cases/public/components/connectors/servicenow/use_get_choices.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useKibana, useToasts } from '../../../common/lib/kibana'; import { useKibana, useToasts } from '../../../common/lib/kibana';
import type { ActionConnector } from '../../../../common/types/domain'; import type { ActionConnector } from '../../../../common/types/domain';
@ -47,7 +47,7 @@ describe('useGetChoices', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getChoices'); const spy = jest.spyOn(api, 'getChoices');
const { waitFor } = renderHook( renderHook(
() => () =>
useGetChoices({ useGetChoices({
http, http,
@ -92,7 +92,7 @@ describe('useGetChoices', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetChoices({ useGetChoices({
http, http,
@ -118,7 +118,7 @@ describe('useGetChoices', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess: jest.fn(), addError });
const { waitFor } = renderHook( renderHook(
() => () =>
useGetChoices({ useGetChoices({
http, http,

13
x-pack/plugins/cases/public/components/create/flyout/use_cases_add_to_new_case_flyout.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import { alertComment } from '../../../containers/mock'; import { alertComment } from '../../../containers/mock';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import type { FC, PropsWithChildren } from 'react'; import type { FC, PropsWithChildren } from 'react';
import React from 'react'; import React from 'react';
import { CasesContext } from '../../cases_context'; import { CasesContext } from '../../cases_context';
@ -47,12 +47,11 @@ describe('use cases add to new case flyout hook', () => {
}); });
it('should throw if called outside of a cases context', () => { it('should throw if called outside of a cases context', () => {
const { result } = renderHook(() => { expect(() =>
useCasesAddToNewCaseFlyout(); renderHook(() => {
}); useCasesAddToNewCaseFlyout();
expect(result.error?.message).toContain( })
'useCasesContext must be used within a CasesProvider and have a defined value' ).toThrow(/useCasesContext must be used within a CasesProvider and have a defined value/);
);
}); });
it('should dispatch the open action when invoked without attachments', () => { it('should dispatch the open action when invoked without attachments', () => {

2
x-pack/plugins/cases/public/components/create/use_cancel_creation_action.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';
import { useCancelCreationAction } from './use_cancel_creation_action'; import { useCancelCreationAction } from './use_cancel_creation_action';

2
x-pack/plugins/cases/public/components/files/use_file_preview.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { useFilePreview } from './use_file_preview'; import { useFilePreview } from './use_file_preview';

2
x-pack/plugins/cases/public/components/files/use_files_table_columns.test.tsx
View file

@ -9,7 +9,7 @@ import type { FilesTableColumnsProps } from './use_files_table_columns';
import { useFilesTableColumns } from './use_files_table_columns'; import { useFilesTableColumns } from './use_files_table_columns';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { basicCase } from '../../containers/mock'; import { basicCase } from '../../containers/mock';
describe('useFilesTableColumns', () => { describe('useFilesTableColumns', () => {

35
x-pack/plugins/cases/public/components/markdown_editor/use_markdown_session_storage.test.tsx
View file

@ -5,11 +5,9 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { waitFor, renderHook, act } from '@testing-library/react';
import type { FieldHook } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib'; import type { FieldHook } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
import type { SessionStorageType } from './use_markdown_session_storage';
import { useMarkdownSessionStorage } from './use_markdown_session_storage'; import { useMarkdownSessionStorage } from './use_markdown_session_storage';
import { waitForComponentToUpdate } from '../../common/test_utils';
describe('useMarkdownSessionStorage', () => { describe('useMarkdownSessionStorage', () => {
const field = { const field = {
@ -45,7 +43,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should return hasConflicts as false', async () => { it('should return hasConflicts as false', async () => {
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useMarkdownSessionStorage({ field, sessionKey, initialValue }) useMarkdownSessionStorage({ field, sessionKey, initialValue })
); );
@ -55,7 +53,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should return hasConflicts as false when sessionKey is empty', async () => { it('should return hasConflicts as false when sessionKey is empty', async () => {
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useMarkdownSessionStorage({ field, sessionKey: '', initialValue }) useMarkdownSessionStorage({ field, sessionKey: '', initialValue })
); );
@ -66,7 +64,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should update the session value with field value when it is first render', async () => { it('should update the session value with field value when it is first render', async () => {
const { waitFor } = renderHook<SessionStorageType, { hasConflicts: boolean }>( renderHook(
(props) => { (props) => {
return useMarkdownSessionStorage(props); return useMarkdownSessionStorage(props);
}, },
@ -86,7 +84,7 @@ describe('useMarkdownSessionStorage', () => {
it('should set session storage when field has value and session key is not created yet', async () => { it('should set session storage when field has value and session key is not created yet', async () => {
const specialCharsValue = '!{tooltip[Hello again](This is tooltip!)}'; const specialCharsValue = '!{tooltip[Hello again](This is tooltip!)}';
const { waitFor, result } = renderHook<SessionStorageType, { hasConflicts: boolean }>( const { result } = renderHook(
(props) => { (props) => {
return useMarkdownSessionStorage(props); return useMarkdownSessionStorage(props);
}, },
@ -101,8 +99,6 @@ describe('useMarkdownSessionStorage', () => {
jest.advanceTimersByTime(1000); jest.advanceTimersByTime(1000);
}); });
await waitForComponentToUpdate();
await waitFor(() => { await waitFor(() => {
expect(result.current.hasConflicts).toBe(false); expect(result.current.hasConflicts).toBe(false);
expect(sessionStorage.getItem(sessionKey)).toBe(specialCharsValue); expect(sessionStorage.getItem(sessionKey)).toBe(specialCharsValue);
@ -110,7 +106,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should update session value ', async () => { it('should update session value ', async () => {
const { result, rerender, waitFor } = renderHook<SessionStorageType, { hasConflicts: boolean }>( const { result, rerender } = renderHook(
(props) => { (props) => {
return useMarkdownSessionStorage(props); return useMarkdownSessionStorage(props);
}, },
@ -129,8 +125,6 @@ describe('useMarkdownSessionStorage', () => {
jest.advanceTimersByTime(1000); jest.advanceTimersByTime(1000);
}); });
await waitForComponentToUpdate();
await waitFor(() => { await waitFor(() => {
expect(result.current.hasConflicts).toBe(false); expect(result.current.hasConflicts).toBe(false);
expect(sessionStorage.getItem(sessionKey)).toBe('new value'); expect(sessionStorage.getItem(sessionKey)).toBe('new value');
@ -138,7 +132,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should return has conflict true', async () => { it('should return has conflict true', async () => {
const { result, rerender, waitFor } = renderHook<SessionStorageType, { hasConflicts: boolean }>( const { result, rerender } = renderHook(
(props) => { (props) => {
return useMarkdownSessionStorage(props); return useMarkdownSessionStorage(props);
}, },
@ -162,7 +156,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should set field value if session already exists and it is a first render', async () => { it('should set field value if session already exists and it is a first render', async () => {
const { waitFor, result } = renderHook<SessionStorageType, { hasConflicts: boolean }>( const { result } = renderHook(
(props) => { (props) => {
return useMarkdownSessionStorage(props); return useMarkdownSessionStorage(props);
}, },
@ -171,8 +165,6 @@ describe('useMarkdownSessionStorage', () => {
} }
); );
await waitForComponentToUpdate();
await waitFor(() => { await waitFor(() => {
expect(field.setValue).toHaveBeenCalled(); expect(field.setValue).toHaveBeenCalled();
}); });
@ -181,8 +173,6 @@ describe('useMarkdownSessionStorage', () => {
jest.advanceTimersByTime(1000); jest.advanceTimersByTime(1000);
}); });
await waitForComponentToUpdate();
await waitFor(() => { await waitFor(() => {
expect(result.current.hasConflicts).toBe(false); expect(result.current.hasConflicts).toBe(false);
expect(field.value).toBe(sessionStorage.getItem(sessionKey)); expect(field.value).toBe(sessionStorage.getItem(sessionKey));
@ -190,10 +180,7 @@ describe('useMarkdownSessionStorage', () => {
}); });
it('should update existing session key if field value changed', async () => { it('should update existing session key if field value changed', async () => {
const { waitFor, rerender, result } = renderHook< const { rerender, result } = renderHook(
SessionStorageType,
{ hasConflicts: boolean }
>(
(props) => { (props) => {
return useMarkdownSessionStorage(props); return useMarkdownSessionStorage(props);
}, },
@ -202,8 +189,6 @@ describe('useMarkdownSessionStorage', () => {
} }
); );
await waitForComponentToUpdate();
await waitFor(() => { await waitFor(() => {
expect(field.setValue).toHaveBeenCalled(); expect(field.setValue).toHaveBeenCalled();
}); });
@ -218,8 +203,6 @@ describe('useMarkdownSessionStorage', () => {
jest.advanceTimersByTime(1000); jest.advanceTimersByTime(1000);
}); });
await waitForComponentToUpdate();
await waitFor(() => { await waitFor(() => {
expect(result.current.hasConflicts).toBe(false); expect(result.current.hasConflicts).toBe(false);
expect(sessionStorage.getItem(sessionKey)).toBe('new value'); expect(sessionStorage.getItem(sessionKey)).toBe('new value');

2
x-pack/plugins/cases/public/components/use_breadcrumbs/index.test.tsx
View file

@ -7,7 +7,7 @@
import type { ReactNode } from 'react'; import type { ReactNode } from 'react';
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { TestProviders } from '../../common/mock'; import { TestProviders } from '../../common/mock';
import { useCasesBreadcrumbs, useCasesTitleBreadcrumbs } from '.'; import { useCasesBreadcrumbs, useCasesTitleBreadcrumbs } from '.';
import { CasesDeepLinkId } from '../../common/navigation'; import { CasesDeepLinkId } from '../../common/navigation';

29
x-pack/plugins/cases/public/components/use_create_case_modal/index.test.tsx
View file

@ -6,10 +6,10 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook, act } from '@testing-library/react-hooks';
import { renderHook, act } from '@testing-library/react';
import { useKibana } from '../../common/lib/kibana'; import { useKibana } from '../../common/lib/kibana';
import type { UseCreateCaseModalProps, UseCreateCaseModalReturnedValues } from '.';
import { useCreateCaseModal } from '.'; import { useCreateCaseModal } from '.';
import { TestProviders } from '../../common/mock'; import { TestProviders } from '../../common/mock';
@ -27,10 +27,7 @@ describe('useCreateCaseModal', () => {
}); });
it('init', async () => { it('init', async () => {
const { result } = renderHook< const { result } = renderHook(() => useCreateCaseModal({ onCaseCreated }), {
React.PropsWithChildren<UseCreateCaseModalProps>,
UseCreateCaseModalReturnedValues
>(() => useCreateCaseModal({ onCaseCreated }), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });
@ -38,10 +35,7 @@ describe('useCreateCaseModal', () => {
}); });
it('opens the modal', async () => { it('opens the modal', async () => {
const { result } = renderHook< const { result } = renderHook(() => useCreateCaseModal({ onCaseCreated }), {
React.PropsWithChildren<UseCreateCaseModalProps>,
UseCreateCaseModalReturnedValues
>(() => useCreateCaseModal({ onCaseCreated }), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });
@ -53,10 +47,7 @@ describe('useCreateCaseModal', () => {
}); });
it('closes the modal', async () => { it('closes the modal', async () => {
const { result } = renderHook< const { result } = renderHook(() => useCreateCaseModal({ onCaseCreated }), {
React.PropsWithChildren<UseCreateCaseModalProps>,
UseCreateCaseModalReturnedValues
>(() => useCreateCaseModal({ onCaseCreated }), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });
@ -69,10 +60,7 @@ describe('useCreateCaseModal', () => {
}); });
it('returns a memoized value', async () => { it('returns a memoized value', async () => {
const { result, rerender } = renderHook< const { result, rerender } = renderHook(() => useCreateCaseModal({ onCaseCreated }), {
React.PropsWithChildren<UseCreateCaseModalProps>,
UseCreateCaseModalReturnedValues
>(() => useCreateCaseModal({ onCaseCreated }), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });
@ -84,10 +72,7 @@ describe('useCreateCaseModal', () => {
}); });
it('closes the modal when creating a case', async () => { it('closes the modal when creating a case', async () => {
const { result } = renderHook< const { result } = renderHook(() => useCreateCaseModal({ onCaseCreated }), {
React.PropsWithChildren<UseCreateCaseModalProps>,
UseCreateCaseModalReturnedValues
>(() => useCreateCaseModal({ onCaseCreated }), {
wrapper: ({ children }) => <TestProviders>{children}</TestProviders>, wrapper: ({ children }) => <TestProviders>{children}</TestProviders>,
}); });

135
x-pack/plugins/cases/public/components/use_push_to_service/index.test.tsx
View file

@ -6,9 +6,8 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook, act } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import type { ReturnUsePushToService, UsePushToService } from '.';
import { usePushToService } from '.'; import { usePushToService } from '.';
import { noPushCasesPermissions, readCasesPermissions, TestProviders } from '../../common/mock'; import { noPushCasesPermissions, readCasesPermissions, TestProviders } from '../../common/mock';
import { usePostPushToService } from '../../containers/use_post_push_to_service'; import { usePostPushToService } from '../../containers/use_post_push_to_service';
@ -67,10 +66,7 @@ describe('usePushToService', () => {
}); });
it('calls pushCaseToExternalService with correct arguments', async () => { it('calls pushCaseToExternalService with correct arguments', async () => {
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -93,10 +89,7 @@ describe('usePushToService', () => {
}, },
})); }));
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -115,10 +108,7 @@ describe('usePushToService', () => {
}, },
})); }));
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -129,10 +119,7 @@ describe('usePushToService', () => {
}); });
it('Displays message when user has select none as connector', async () => { it('Displays message when user has select none as connector', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -155,10 +142,7 @@ describe('usePushToService', () => {
}); });
it('Displays message when connector is deleted', async () => { it('Displays message when connector is deleted', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -182,10 +166,7 @@ describe('usePushToService', () => {
}); });
it('should not call pushCaseToExternalService when the selected connector is none', async () => { it('should not call pushCaseToExternalService when the selected connector is none', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -209,10 +190,7 @@ describe('usePushToService', () => {
}); });
it('refresh case view page after push', async () => { it('refresh case view page after push', async () => {
const { result, waitFor } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -227,10 +205,7 @@ describe('usePushToService', () => {
describe('user does not have write or push permissions', () => { describe('user does not have write or push permissions', () => {
it('returns correct information about push permissions', async () => { it('returns correct information about push permissions', async () => {
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => ( wrapper: ({ children }) => (
<TestProviders permissions={noPushCasesPermissions()}> {children}</TestProviders> <TestProviders permissions={noPushCasesPermissions()}> {children}</TestProviders>
), ),
@ -248,10 +223,7 @@ describe('usePushToService', () => {
}, },
})); }));
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => ( wrapper: ({ children }) => (
<TestProviders permissions={readCasesPermissions()}> {children}</TestProviders> <TestProviders permissions={readCasesPermissions()}> {children}</TestProviders>
), ),
@ -270,10 +242,7 @@ describe('usePushToService', () => {
}, },
})); }));
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => ( wrapper: ({ children }) => (
<TestProviders permissions={readCasesPermissions()}> {children}</TestProviders> <TestProviders permissions={readCasesPermissions()}> {children}</TestProviders>
), ),
@ -284,10 +253,7 @@ describe('usePushToService', () => {
}); });
it('does not display a message when user does not have any connector configured', async () => { it('does not display a message when user does not have any connector configured', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -310,10 +276,7 @@ describe('usePushToService', () => {
}); });
it('does not display a message when user does have a connector but is configured to none', async () => { it('does not display a message when user does have a connector but is configured to none', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -336,10 +299,7 @@ describe('usePushToService', () => {
}); });
it('does not display a message when connector is deleted', async () => { it('does not display a message when connector is deleted', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -363,10 +323,7 @@ describe('usePushToService', () => {
}); });
it('does not display a message when case is closed', async () => { it('does not display a message when case is closed', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -386,10 +343,7 @@ describe('usePushToService', () => {
describe('returned values', () => { describe('returned values', () => {
it('initial', async () => { it('initial', async () => {
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -408,10 +362,7 @@ describe('usePushToService', () => {
it('isLoading is true when usePostPushToService is loading', async () => { it('isLoading is true when usePostPushToService is loading', async () => {
usePostPushToServiceMock.mockReturnValue({ ...mockPostPush, isLoading: true }); usePostPushToServiceMock.mockReturnValue({ ...mockPostPush, isLoading: true });
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -424,10 +375,7 @@ describe('usePushToService', () => {
data: actionLicense, data: actionLicense,
}); });
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -435,21 +383,18 @@ describe('usePushToService', () => {
}); });
it('hasErrorMessages=true if there are error messages', async () => { it('hasErrorMessages=true if there are error messages', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>, () => usePushToService({ ...defaultArgs, isValidConnector: false }),
ReturnUsePushToService {
>(() => usePushToService({ ...defaultArgs, isValidConnector: false }), { wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, }
}); );
expect(result.current.hasErrorMessages).toBe(true); expect(result.current.hasErrorMessages).toBe(true);
}); });
it('needsToBePushed=true if the connector needs to be pushed', async () => { it('needsToBePushed=true if the connector needs to be pushed', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -473,10 +418,7 @@ describe('usePushToService', () => {
}); });
it('needsToBePushed=false if the connector does not exist', async () => { it('needsToBePushed=false if the connector does not exist', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -497,10 +439,7 @@ describe('usePushToService', () => {
}); });
it('hasBeenPushed=false if the connector has been pushed', async () => { it('hasBeenPushed=false if the connector has been pushed', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -524,10 +463,7 @@ describe('usePushToService', () => {
}); });
it('hasBeenPushed=false if the connector does not exist', async () => { it('hasBeenPushed=false if the connector does not exist', async () => {
const { result } = renderHook< const { result } = renderHook(
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(
() => () =>
usePushToService({ usePushToService({
...defaultArgs, ...defaultArgs,
@ -553,10 +489,7 @@ describe('usePushToService', () => {
data: actionLicense, data: actionLicense,
}); });
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => ( wrapper: ({ children }) => (
<TestProviders permissions={noPushCasesPermissions()}> {children}</TestProviders> <TestProviders permissions={noPushCasesPermissions()}> {children}</TestProviders>
), ),
@ -574,10 +507,7 @@ describe('usePushToService', () => {
}, },
})); }));
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });
@ -590,10 +520,7 @@ describe('usePushToService', () => {
data: undefined, data: undefined,
})); }));
const { result } = renderHook< const { result } = renderHook(() => usePushToService(defaultArgs), {
React.PropsWithChildren<UsePushToService>,
ReturnUsePushToService
>(() => usePushToService(defaultArgs), {
wrapper: ({ children }) => <TestProviders> {children}</TestProviders>, wrapper: ({ children }) => <TestProviders> {children}</TestProviders>,
}); });

2
x-pack/plugins/cases/public/components/user_actions/property_actions/use_delete_property_action.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import type { AppMockRenderer } from '../../../common/mock'; import type { AppMockRenderer } from '../../../common/mock';
import { createAppMockRenderer } from '../../../common/mock'; import { createAppMockRenderer } from '../../../common/mock';
import { useDeletePropertyAction } from './use_delete_property_action'; import { useDeletePropertyAction } from './use_delete_property_action';

2
x-pack/plugins/cases/public/components/user_actions/use_last_page.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { renderHook } from '@testing-library/react';
import { useLastPage } from './use_last_page'; import { useLastPage } from './use_last_page';
import type { UserActivityParams } from '../user_actions_activity_bar/types'; import type { UserActivityParams } from '../user_actions_activity_bar/types';

2
x-pack/plugins/cases/public/components/user_actions/use_user_actions_handler.test.tsx
View file

@ -7,7 +7,7 @@
import type { FC, PropsWithChildren } from 'react'; import type { FC, PropsWithChildren } from 'react';
import React from 'react'; import React from 'react';
import { renderHook, act } from '@testing-library/react-hooks'; import { renderHook, act } from '@testing-library/react';
import { basicCase } from '../../containers/mock'; import { basicCase } from '../../containers/mock';
import { useUpdateComment } from '../../containers/use_update_comment'; import { useUpdateComment } from '../../containers/use_update_comment';

8
x-pack/plugins/cases/public/components/user_actions/use_user_actions_last_page.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useLastPageUserActions } from './use_user_actions_last_page'; import { useLastPageUserActions } from './use_user_actions_last_page';
import type { UserActivityParams } from '../user_actions_activity_bar/types'; import type { UserActivityParams } from '../user_actions_activity_bar/types';
@ -32,7 +32,7 @@ describe('useLastPageUserActions', () => {
}); });
it('renders correctly', async () => { it('renders correctly', async () => {
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useLastPageUserActions({ useLastPageUserActions({
lastPage: 5, lastPage: 5,
userActivityQueryParams, userActivityQueryParams,
@ -79,7 +79,7 @@ describe('useLastPageUserActions', () => {
it('returns loading state correctly', async () => { it('returns loading state correctly', async () => {
useFindCaseUserActionsMock.mockReturnValue({ isLoading: true }); useFindCaseUserActionsMock.mockReturnValue({ isLoading: true });
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useLastPageUserActions({ useLastPageUserActions({
lastPage: 2, lastPage: 2,
userActivityQueryParams, userActivityQueryParams,
@ -108,7 +108,7 @@ describe('useLastPageUserActions', () => {
it('returns empty array when data is undefined', async () => { it('returns empty array when data is undefined', async () => {
useFindCaseUserActionsMock.mockReturnValue({ isLoading: false, data: undefined }); useFindCaseUserActionsMock.mockReturnValue({ isLoading: false, data: undefined });
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useLastPageUserActions({ useLastPageUserActions({
lastPage: 2, lastPage: 2,
userActivityQueryParams, userActivityQueryParams,

12
x-pack/plugins/cases/public/components/user_actions/use_user_actions_pagination.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useUserActionsPagination } from './use_user_actions_pagination'; import { useUserActionsPagination } from './use_user_actions_pagination';
import type { UserActivityParams } from '../user_actions_activity_bar/types'; import type { UserActivityParams } from '../user_actions_activity_bar/types';
@ -32,7 +32,7 @@ describe('useUserActionsPagination', () => {
}); });
it('renders expandable option correctly when user actions are more than 10', async () => { it('renders expandable option correctly when user actions are more than 10', async () => {
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useUserActionsPagination({ useUserActionsPagination({
userActivityQueryParams, userActivityQueryParams,
caseId: basicCase.id, caseId: basicCase.id,
@ -62,7 +62,7 @@ describe('useUserActionsPagination', () => {
}); });
it('renders less than 10 user actions correctly', async () => { it('renders less than 10 user actions correctly', async () => {
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useUserActionsPagination({ useUserActionsPagination({
userActivityQueryParams, userActivityQueryParams,
caseId: basicCase.id, caseId: basicCase.id,
@ -92,7 +92,7 @@ describe('useUserActionsPagination', () => {
it('returns loading state correctly', async () => { it('returns loading state correctly', async () => {
useInfiniteFindCaseUserActionsMock.mockReturnValue({ isLoading: true }); useInfiniteFindCaseUserActionsMock.mockReturnValue({ isLoading: true });
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useUserActionsPagination({ useUserActionsPagination({
userActivityQueryParams, userActivityQueryParams,
caseId: basicCase.id, caseId: basicCase.id,
@ -124,7 +124,7 @@ describe('useUserActionsPagination', () => {
it('returns empty array when data is undefined', async () => { it('returns empty array when data is undefined', async () => {
useInfiniteFindCaseUserActionsMock.mockReturnValue({ isLoading: false, data: undefined }); useInfiniteFindCaseUserActionsMock.mockReturnValue({ isLoading: false, data: undefined });
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useUserActionsPagination({ useUserActionsPagination({
userActivityQueryParams, userActivityQueryParams,
caseId: basicCase.id, caseId: basicCase.id,
@ -161,7 +161,7 @@ describe('useUserActionsPagination', () => {
}, },
}); });
const { result, waitFor } = renderHook(() => const { result } = renderHook(() =>
useUserActionsPagination({ useUserActionsPagination({
userActivityQueryParams, userActivityQueryParams,
caseId: basicCase.id, caseId: basicCase.id,

8
x-pack/plugins/cases/public/containers/configure/use_action_types.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import * as api from './api'; import * as api from './api';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';
@ -43,10 +43,10 @@ describe('useActionTypes', () => {
(useToasts as jest.Mock).mockReturnValue({ addError: addErrorMock }); (useToasts as jest.Mock).mockReturnValue({ addError: addErrorMock });
const { waitForNextUpdate } = renderHook(() => useGetActionTypes(), { renderHook(() => useGetActionTypes(), {
wrapper: appMockRenderer.AppWrapper, wrapper: appMockRenderer.AppWrapper,
}); });
await waitForNextUpdate({ timeout: 2000 });
expect(addErrorMock).toHaveBeenCalled(); await waitFor(() => expect(addErrorMock).toHaveBeenCalled());
}); });
}); });

64
x-pack/plugins/cases/public/containers/configure/use_get_all_case_configurations.test.ts
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useGetAllCaseConfigurations } from './use_get_all_case_configurations'; import { useGetAllCaseConfigurations } from './use_get_all_case_configurations';
import * as api from './api'; import * as api from './api';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
@ -32,18 +32,11 @@ describe('Use get all case configurations hook', () => {
{ id: 'my-configuration-3', owner: '3' }, { id: 'my-configuration-3', owner: '3' },
]); ]);
const { result, waitForNextUpdate } = renderHook(() => useGetAllCaseConfigurations(), { const { result } = renderHook(() => useGetAllCaseConfigurations(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); expect(result.current.data).toEqual([
/**
* Ensures that the initial data is returned≠
* before fetching
*/
// @ts-expect-error: data is defined
expect(result.all[0].data).toEqual([
{ {
closureType: 'close-by-user', closureType: 'close-by-user',
connector: { fields: null, id: 'none', name: 'none', type: '.none' }, connector: { fields: null, id: 'none', name: 'none', type: '.none' },
@ -56,43 +49,36 @@ describe('Use get all case configurations hook', () => {
}, },
]); ]);
/** await waitFor(() =>
* The response after fetching expect(result.current.data).toEqual([
*/ { id: 'my-configuration-1', owner: '1' },
// @ts-expect-error: data is defined { id: 'my-configuration-2', owner: '2' },
expect(result.all[1].data).toEqual([ { id: 'my-configuration-3', owner: '3' },
{ id: 'my-configuration-1', owner: '1' }, ])
{ id: 'my-configuration-2', owner: '2' }, );
{ id: 'my-configuration-3', owner: '3' },
]);
}); });
it('returns the initial configuration if none is available', async () => { it('returns the initial configuration if none is available', async () => {
const spy = jest.spyOn(api, 'getCaseConfigure'); const spy = jest.spyOn(api, 'getCaseConfigure');
spy.mockResolvedValue([]); spy.mockResolvedValue([]);
const { result, waitForNextUpdate } = renderHook(() => useGetAllCaseConfigurations(), { const { result } = renderHook(() => useGetAllCaseConfigurations(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(result.current.data).toEqual([
/** {
* Ensures that the initial data is returned≠ closureType: 'close-by-user',
* before fetching connector: { fields: null, id: 'none', name: 'none', type: '.none' },
*/ customFields: [],
// @ts-expect-error: data is defined templates: [],
expect(result.all[0].data).toEqual([ id: '',
{ mappings: [],
closureType: 'close-by-user', version: '',
connector: { fields: null, id: 'none', name: 'none', type: '.none' }, owner: '',
customFields: [], },
templates: [], ])
id: '', );
mappings: [],
version: '',
owner: '',
},
]);
}); });
}); });

26
x-pack/plugins/cases/public/containers/configure/use_get_case_configuration.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useGetCaseConfiguration } from './use_get_case_configuration'; import { useGetCaseConfiguration } from './use_get_case_configuration';
import * as api from './api'; import * as api from './api';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
@ -35,16 +35,14 @@ describe('Use get case configuration hook', () => {
targetConfiguration, targetConfiguration,
]); ]);
const { result, waitForNextUpdate } = renderHook(() => useGetCaseConfiguration(), { const { result } = renderHook(() => useGetCaseConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate();
/** /**
* The response after fetching * The response after fetching
*/ */
expect(result.current.data).toEqual(targetConfiguration); await waitFor(() => expect(result.current.data).toEqual(targetConfiguration));
}); });
it('returns the initial configuration if none matches the owner', async () => { it('returns the initial configuration if none matches the owner', async () => {
@ -59,16 +57,14 @@ describe('Use get case configuration hook', () => {
{ ...initialConfiguration, id: 'my-new-configuration-2', owner: 'bar' }, { ...initialConfiguration, id: 'my-new-configuration-2', owner: 'bar' },
]); ]);
const { result, waitForNextUpdate } = renderHook(() => useGetCaseConfiguration(), { const { result } = renderHook(() => useGetCaseConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate();
/** /**
* The response after fetching * The response after fetching
*/ */
expect(result.current.data).toEqual(initialConfiguration); await waitFor(() => expect(result.current.data).toEqual(initialConfiguration));
}); });
it('returns the initial configuration if none exists', async () => { it('returns the initial configuration if none exists', async () => {
@ -76,16 +72,14 @@ describe('Use get case configuration hook', () => {
spy.mockResolvedValue([]); spy.mockResolvedValue([]);
const { result, waitForNextUpdate } = renderHook(() => useGetCaseConfiguration(), { const { result } = renderHook(() => useGetCaseConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate();
/** /**
* The response after fetching * The response after fetching
*/ */
expect(result.current.data).toEqual(initialConfiguration); await waitFor(() => expect(result.current.data).toEqual(initialConfiguration));
}); });
it('returns the initial configuration if the owner is undefined', async () => { it('returns the initial configuration if the owner is undefined', async () => {
@ -94,15 +88,13 @@ describe('Use get case configuration hook', () => {
spy.mockResolvedValue([]); spy.mockResolvedValue([]);
const { result, waitForNextUpdate } = renderHook(() => useGetCaseConfiguration(), { const { result } = renderHook(() => useGetCaseConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate();
/** /**
* The response after fetching * The response after fetching
*/ */
expect(result.current.data).toEqual(initialConfiguration); await waitFor(() => expect(result.current.data).toEqual(initialConfiguration));
}); });
}); });

3
x-pack/plugins/cases/public/containers/configure/use_get_case_configurations_query.test.ts
View file

@ -5,10 +5,9 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks';
import { useGetCaseConfigurationsQuery } from './use_get_case_configurations_query'; import { useGetCaseConfigurationsQuery } from './use_get_case_configurations_query';
import * as api from './api'; import * as api from './api';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import { useToasts } from '../../common/lib/kibana'; import { useToasts } from '../../common/lib/kibana';
import type { AppMockRenderer } from '../../common/mock'; import type { AppMockRenderer } from '../../common/mock';
import { createAppMockRenderer } from '../../common/mock'; import { createAppMockRenderer } from '../../common/mock';

33
x-pack/plugins/cases/public/containers/configure/use_get_supported_action_connectors.tsx.test.tsx
View file

@ -6,7 +6,7 @@
*/ */
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import * as api from './api'; import * as api from './api';
import { noConnectorsCasePermission, TestProviders } from '../../common/mock'; import { noConnectorsCasePermission, TestProviders } from '../../common/mock';
import { useApplicationCapabilities, useToasts } from '../../common/lib/kibana'; import { useApplicationCapabilities, useToasts } from '../../common/lib/kibana';
@ -26,15 +26,13 @@ describe('useConnectors', () => {
it('fetches connectors', async () => { it('fetches connectors', async () => {
const spy = jest.spyOn(api, 'getSupportedActionConnectors'); const spy = jest.spyOn(api, 'getSupportedActionConnectors');
const { waitForNextUpdate } = renderHook(() => useGetSupportedActionConnectors(), { renderHook(() => useGetSupportedActionConnectors(), {
wrapper: ({ children }: React.PropsWithChildren<{}>) => ( wrapper: ({ children }: React.PropsWithChildren<{}>) => (
<TestProviders>{children}</TestProviders> <TestProviders>{children}</TestProviders>
), ),
}); });
await waitForNextUpdate(); await waitFor(() => expect(spy).toHaveBeenCalledWith({ signal: expect.any(AbortSignal) }));
expect(spy).toHaveBeenCalledWith({ signal: expect.any(AbortSignal) });
}); });
it('shows a toast error when the API returns error', async () => { it('shows a toast error when the API returns error', async () => {
@ -46,45 +44,44 @@ describe('useConnectors', () => {
throw new Error('Something went wrong'); throw new Error('Something went wrong');
}); });
const { waitForNextUpdate } = renderHook(() => useGetSupportedActionConnectors(), { renderHook(() => useGetSupportedActionConnectors(), {
wrapper: ({ children }: React.PropsWithChildren<{}>) => ( wrapper: ({ children }: React.PropsWithChildren<{}>) => (
<TestProviders>{children}</TestProviders> <TestProviders>{children}</TestProviders>
), ),
}); });
await waitForNextUpdate();
expect(addError).toHaveBeenCalled(); await waitFor(() => expect(addError).toHaveBeenCalled());
}); });
it('does not fetch connectors when the user does not has access to actions', async () => { it('does not fetch connectors when the user does not has access to actions', async () => {
const spyOnFetchConnectors = jest.spyOn(api, 'getSupportedActionConnectors'); const spyOnFetchConnectors = jest.spyOn(api, 'getSupportedActionConnectors');
useApplicationCapabilitiesMock().actions = { crud: false, read: false }; useApplicationCapabilitiesMock().actions = { crud: false, read: false };
const { result, waitForNextUpdate } = renderHook(() => useGetSupportedActionConnectors(), { const { result } = renderHook(() => useGetSupportedActionConnectors(), {
wrapper: ({ children }: React.PropsWithChildren<{}>) => ( wrapper: ({ children }: React.PropsWithChildren<{}>) => (
<TestProviders>{children}</TestProviders> <TestProviders>{children}</TestProviders>
), ),
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(spyOnFetchConnectors).not.toHaveBeenCalled();
expect(spyOnFetchConnectors).not.toHaveBeenCalled(); expect(result.current.data).toEqual([]);
expect(result.current.data).toEqual([]); });
}); });
it('does not fetch connectors when the user does not has access to connectors', async () => { it('does not fetch connectors when the user does not has access to connectors', async () => {
const spyOnFetchConnectors = jest.spyOn(api, 'getSupportedActionConnectors'); const spyOnFetchConnectors = jest.spyOn(api, 'getSupportedActionConnectors');
useApplicationCapabilitiesMock().actions = { crud: true, read: true }; useApplicationCapabilitiesMock().actions = { crud: true, read: true };
const { result, waitForNextUpdate } = renderHook(() => useGetSupportedActionConnectors(), { const { result } = renderHook(() => useGetSupportedActionConnectors(), {
wrapper: ({ children }: React.PropsWithChildren<{}>) => ( wrapper: ({ children }: React.PropsWithChildren<{}>) => (
<TestProviders permissions={noConnectorsCasePermission()}>{children}</TestProviders> <TestProviders permissions={noConnectorsCasePermission()}>{children}</TestProviders>
), ),
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(spyOnFetchConnectors).not.toHaveBeenCalled();
expect(spyOnFetchConnectors).not.toHaveBeenCalled(); expect(result.current.data).toEqual([]);
expect(result.current.data).toEqual([]); });
}); });
}); });

18
x-pack/plugins/cases/public/containers/configure/use_persist_configuration.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { usePersistConfiguration } from './use_persist_configuration'; import { usePersistConfiguration } from './use_persist_configuration';
import * as api from './api'; import * as api from './api';
@ -55,7 +55,7 @@ describe('usePersistConfiguration', () => {
const spyPost = jest.spyOn(api, 'postCaseConfigure'); const spyPost = jest.spyOn(api, 'postCaseConfigure');
const spyPatch = jest.spyOn(api, 'patchCaseConfigure'); const spyPatch = jest.spyOn(api, 'patchCaseConfigure');
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -80,7 +80,7 @@ describe('usePersistConfiguration', () => {
const spyPost = jest.spyOn(api, 'postCaseConfigure'); const spyPost = jest.spyOn(api, 'postCaseConfigure');
const spyPatch = jest.spyOn(api, 'patchCaseConfigure'); const spyPatch = jest.spyOn(api, 'patchCaseConfigure');
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -104,7 +104,7 @@ describe('usePersistConfiguration', () => {
it('calls postCaseConfigure with correct data', async () => { it('calls postCaseConfigure with correct data', async () => {
const spyPost = jest.spyOn(api, 'postCaseConfigure'); const spyPost = jest.spyOn(api, 'postCaseConfigure');
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -133,7 +133,7 @@ describe('usePersistConfiguration', () => {
const spyPost = jest.spyOn(api, 'postCaseConfigure'); const spyPost = jest.spyOn(api, 'postCaseConfigure');
const spyPatch = jest.spyOn(api, 'patchCaseConfigure'); const spyPatch = jest.spyOn(api, 'patchCaseConfigure');
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -157,7 +157,7 @@ describe('usePersistConfiguration', () => {
it('calls patchCaseConfigure with correct data', async () => { it('calls patchCaseConfigure with correct data', async () => {
const spyPatch = jest.spyOn(api, 'patchCaseConfigure'); const spyPatch = jest.spyOn(api, 'patchCaseConfigure');
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -184,7 +184,7 @@ describe('usePersistConfiguration', () => {
it('invalidates the queries correctly', async () => { it('invalidates the queries correctly', async () => {
const queryClientSpy = jest.spyOn(appMockRender.queryClient, 'invalidateQueries'); const queryClientSpy = jest.spyOn(appMockRender.queryClient, 'invalidateQueries');
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -198,7 +198,7 @@ describe('usePersistConfiguration', () => {
}); });
it('shows the success toaster', async () => { it('shows the success toaster', async () => {
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -216,7 +216,7 @@ describe('usePersistConfiguration', () => {
.spyOn(api, 'postCaseConfigure') .spyOn(api, 'postCaseConfigure')
.mockRejectedValue(new Error('useCreateAttachments: Test error')); .mockRejectedValue(new Error('useCreateAttachments: Test error'));
const { waitFor, result } = renderHook(() => usePersistConfiguration(), { const { result } = renderHook(() => usePersistConfiguration(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });

40
x-pack/plugins/cases/public/containers/use_bulk_update_case.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useUpdateCases } from './use_bulk_update_case'; import { useUpdateCases } from './use_bulk_update_case';
import { allCases } from './mock'; import { allCases } from './mock';
import { useToasts } from '../common/lib/kibana'; import { useToasts } from '../common/lib/kibana';
@ -32,7 +32,7 @@ describe('useUpdateCases', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'updateCases'); const spy = jest.spyOn(api, 'updateCases');
const { waitForNextUpdate, result } = renderHook(() => useUpdateCases(), { const { result } = renderHook(() => useUpdateCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -40,14 +40,12 @@ describe('useUpdateCases', () => {
result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' }); result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() => expect(spy).toHaveBeenCalledWith({ cases: allCases.cases }));
expect(spy).toHaveBeenCalledWith({ cases: allCases.cases });
}); });
it('invalidates the queries correctly', async () => { it('invalidates the queries correctly', async () => {
const queryClientSpy = jest.spyOn(appMockRender.queryClient, 'invalidateQueries'); const queryClientSpy = jest.spyOn(appMockRender.queryClient, 'invalidateQueries');
const { waitForNextUpdate, result } = renderHook(() => useUpdateCases(), { const { result } = renderHook(() => useUpdateCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -55,15 +53,15 @@ describe('useUpdateCases', () => {
result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' }); result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.casesList());
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.casesList()); expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.tags());
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.tags()); expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.userProfiles());
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.userProfiles()); });
}); });
it('shows a success toaster', async () => { it('shows a success toaster', async () => {
const { waitForNextUpdate, result } = renderHook(() => useUpdateCases(), { const { result } = renderHook(() => useUpdateCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -71,18 +69,18 @@ describe('useUpdateCases', () => {
result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' }); result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(addSuccess).toHaveBeenCalledWith({
expect(addSuccess).toHaveBeenCalledWith({ title: 'Success title',
title: 'Success title', className: 'eui-textBreakWord',
className: 'eui-textBreakWord', })
}); );
}); });
it('shows a toast error when the api return an error', async () => { it('shows a toast error when the api return an error', async () => {
jest.spyOn(api, 'updateCases').mockRejectedValue(new Error('useUpdateCases: Test error')); jest.spyOn(api, 'updateCases').mockRejectedValue(new Error('useUpdateCases: Test error'));
const { waitForNextUpdate, result } = renderHook(() => useUpdateCases(), { const { result } = renderHook(() => useUpdateCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -90,8 +88,6 @@ describe('useUpdateCases', () => {
result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' }); result.current.mutate({ cases: allCases.cases, successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() => expect(addError).toHaveBeenCalled());
expect(addError).toHaveBeenCalled();
}); });
}); });

25
x-pack/plugins/cases/public/containers/use_create_attachments.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { AttachmentType } from '../../common/types/domain'; import { AttachmentType } from '../../common/types/domain';
import { SECURITY_SOLUTION_OWNER } from '../../common/constants'; import { SECURITY_SOLUTION_OWNER } from '../../common/constants';
@ -58,7 +58,7 @@ describe('useCreateAttachments', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'createAttachments'); const spy = jest.spyOn(api, 'createAttachments');
const { waitForNextUpdate, result } = renderHook(() => useCreateAttachments(), { const { result } = renderHook(() => useCreateAttachments(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -66,13 +66,16 @@ describe('useCreateAttachments', () => {
result.current.mutate(request); result.current.mutate(request);
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(spy).toHaveBeenCalledWith({
expect(spy).toHaveBeenCalledWith({ attachments: attachmentsWithOwner, caseId: request.caseId }); attachments: attachmentsWithOwner,
caseId: request.caseId,
})
);
}); });
it('does not show a success toaster', async () => { it('does not show a success toaster', async () => {
const { waitForNextUpdate, result } = renderHook(() => useCreateAttachments(), { const { result } = renderHook(() => useCreateAttachments(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -80,9 +83,7 @@ describe('useCreateAttachments', () => {
result.current.mutate(request); result.current.mutate(request);
}); });
await waitForNextUpdate(); await waitFor(() => expect(addSuccess).not.toHaveBeenCalled());
expect(addSuccess).not.toHaveBeenCalled();
}); });
it('shows a toast error when the api return an error', async () => { it('shows a toast error when the api return an error', async () => {
@ -90,7 +91,7 @@ describe('useCreateAttachments', () => {
.spyOn(api, 'createAttachments') .spyOn(api, 'createAttachments')
.mockRejectedValue(new Error('useCreateAttachments: Test error')); .mockRejectedValue(new Error('useCreateAttachments: Test error'));
const { waitForNextUpdate, result } = renderHook(() => useCreateAttachments(), { const { result } = renderHook(() => useCreateAttachments(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -98,8 +99,6 @@ describe('useCreateAttachments', () => {
result.current.mutate(request); result.current.mutate(request);
}); });
await waitForNextUpdate(); await waitFor(() => expect(addError).toHaveBeenCalled());
expect(addError).toHaveBeenCalled();
}); });
}); });

40
x-pack/plugins/cases/public/containers/use_delete_cases.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook, act } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useDeleteCases } from './use_delete_cases'; import { useDeleteCases } from './use_delete_cases';
import * as api from './api'; import * as api from './api';
@ -32,7 +32,7 @@ describe('useDeleteCases', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'deleteCases'); const spy = jest.spyOn(api, 'deleteCases');
const { waitForNextUpdate, result } = renderHook(() => useDeleteCases(), { const { result } = renderHook(() => useDeleteCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -40,14 +40,12 @@ describe('useDeleteCases', () => {
result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' }); result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() => expect(spy).toHaveBeenCalledWith({ caseIds: ['1', '2'] }));
expect(spy).toHaveBeenCalledWith({ caseIds: ['1', '2'] });
}); });
it('invalidates the queries correctly', async () => { it('invalidates the queries correctly', async () => {
const queryClientSpy = jest.spyOn(appMockRender.queryClient, 'invalidateQueries'); const queryClientSpy = jest.spyOn(appMockRender.queryClient, 'invalidateQueries');
const { waitForNextUpdate, result } = renderHook(() => useDeleteCases(), { const { result } = renderHook(() => useDeleteCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -55,15 +53,15 @@ describe('useDeleteCases', () => {
result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' }); result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.casesList());
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.casesList()); expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.tags());
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.tags()); expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.userProfiles());
expect(queryClientSpy).toHaveBeenCalledWith(casesQueriesKeys.userProfiles()); });
}); });
it('shows a success toaster', async () => { it('shows a success toaster', async () => {
const { waitForNextUpdate, result } = renderHook(() => useDeleteCases(), { const { result } = renderHook(() => useDeleteCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -71,18 +69,18 @@ describe('useDeleteCases', () => {
result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' }); result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(addSuccess).toHaveBeenCalledWith({
expect(addSuccess).toHaveBeenCalledWith({ title: 'Success title',
title: 'Success title', className: 'eui-textBreakWord',
className: 'eui-textBreakWord', })
}); );
}); });
it('shows a toast error when the api return an error', async () => { it('shows a toast error when the api return an error', async () => {
jest.spyOn(api, 'deleteCases').mockRejectedValue(new Error('useDeleteCases: Test error')); jest.spyOn(api, 'deleteCases').mockRejectedValue(new Error('useDeleteCases: Test error'));
const { waitForNextUpdate, result } = renderHook(() => useDeleteCases(), { const { result } = renderHook(() => useDeleteCases(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -90,8 +88,6 @@ describe('useDeleteCases', () => {
result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' }); result.current.mutate({ caseIds: ['1', '2'], successToasterTitle: 'Success title' });
}); });
await waitForNextUpdate(); await waitFor(() => expect(addError).toHaveBeenCalled());
expect(addError).toHaveBeenCalled();
}); });
}); });

84
x-pack/plugins/cases/public/containers/use_delete_comment.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import { useDeleteComment } from './use_delete_comment'; import { useDeleteComment } from './use_delete_comment';
import * as api from './api'; import * as api from './api';
import { basicCaseId } from './mock'; import { basicCaseId } from './mock';
@ -45,7 +45,7 @@ describe('useDeleteComment', () => {
it('calls deleteComment with correct arguments - case', async () => { it('calls deleteComment with correct arguments - case', async () => {
const spyOnDeleteComment = jest.spyOn(api, 'deleteComment'); const spyOnDeleteComment = jest.spyOn(api, 'deleteComment');
const { waitForNextUpdate, result } = renderHook(() => useDeleteComment(), { const { result } = renderHook(() => useDeleteComment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -57,32 +57,16 @@ describe('useDeleteComment', () => {
}); });
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(spyOnDeleteComment).toBeCalledWith({
expect(spyOnDeleteComment).toBeCalledWith({ caseId: basicCaseId,
caseId: basicCaseId, commentId,
commentId, })
}); );
}); });
it('refreshes the case page view after delete', async () => { it('refreshes the case page view after delete', async () => {
const { waitForNextUpdate, result } = renderHook(() => useDeleteComment(), { const { result } = renderHook(() => useDeleteComment(), {
wrapper: appMockRender.AppWrapper,
});
result.current.mutate({
caseId: basicCaseId,
commentId,
successToasterTitle,
});
await waitForNextUpdate();
expect(useRefreshCaseViewPage()).toBeCalled();
});
it('shows a success toaster correctly', async () => {
const { waitForNextUpdate, result } = renderHook(() => useDeleteComment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -94,36 +78,54 @@ describe('useDeleteComment', () => {
}); });
}); });
await waitForNextUpdate(); await waitFor(() => expect(useRefreshCaseViewPage()).toBeCalled());
});
expect(addSuccess).toHaveBeenCalledWith({ it('shows a success toaster correctly', async () => {
title: 'Deleted', const { result } = renderHook(() => useDeleteComment(), {
className: 'eui-textBreakWord', wrapper: appMockRender.AppWrapper,
}); });
act(() => {
result.current.mutate({
caseId: basicCaseId,
commentId,
successToasterTitle,
});
});
await waitFor(() =>
expect(addSuccess).toHaveBeenCalledWith({
title: 'Deleted',
className: 'eui-textBreakWord',
})
);
}); });
it('sets isError when fails to delete a case', async () => { it('sets isError when fails to delete a case', async () => {
const spyOnDeleteComment = jest.spyOn(api, 'deleteComment'); const spyOnDeleteComment = jest.spyOn(api, 'deleteComment');
spyOnDeleteComment.mockRejectedValue(new Error('Error')); spyOnDeleteComment.mockRejectedValue(new Error('Error'));
const { waitForNextUpdate, result } = renderHook(() => useDeleteComment(), { const { result } = renderHook(() => useDeleteComment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
result.current.mutate({ act(() => {
caseId: basicCaseId, result.current.mutate({
commentId, caseId: basicCaseId,
successToasterTitle, commentId,
successToasterTitle,
});
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(spyOnDeleteComment).toBeCalledWith({
caseId: basicCaseId,
commentId,
});
expect(spyOnDeleteComment).toBeCalledWith({ expect(addError).toHaveBeenCalled();
caseId: basicCaseId, expect(result.current.isError).toBe(true);
commentId,
}); });
expect(addError).toHaveBeenCalled();
expect(result.current.isError).toBe(true);
}); });
}); });

41
x-pack/plugins/cases/public/containers/use_delete_file_attachment.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { act, renderHook } from '@testing-library/react-hooks'; import { act, waitFor, renderHook } from '@testing-library/react';
import * as api from './api'; import * as api from './api';
import { basicCaseId, basicFileMock } from './mock'; import { basicCaseId, basicFileMock } from './mock';
import { useRefreshCaseViewPage } from '../components/case_view/use_on_refresh_case_view_page'; import { useRefreshCaseViewPage } from '../components/case_view/use_on_refresh_case_view_page';
@ -34,7 +34,7 @@ describe('useDeleteFileAttachment', () => {
it('calls deleteFileAttachment with correct arguments - case', async () => { it('calls deleteFileAttachment with correct arguments - case', async () => {
const spyOnDeleteFileAttachments = jest.spyOn(api, 'deleteFileAttachments'); const spyOnDeleteFileAttachments = jest.spyOn(api, 'deleteFileAttachments');
const { waitForNextUpdate, result } = renderHook(() => useDeleteFileAttachment(), { const { result } = renderHook(() => useDeleteFileAttachment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -45,16 +45,16 @@ describe('useDeleteFileAttachment', () => {
}); });
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(spyOnDeleteFileAttachments).toHaveBeenCalledWith({
expect(spyOnDeleteFileAttachments).toHaveBeenCalledWith({ caseId: basicCaseId,
caseId: basicCaseId, fileIds: [basicFileMock.id],
fileIds: [basicFileMock.id], })
}); );
}); });
it('refreshes the case page view', async () => { it('refreshes the case page view', async () => {
const { waitForNextUpdate, result } = renderHook(() => useDeleteFileAttachment(), { const { result } = renderHook(() => useDeleteFileAttachment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -65,13 +65,11 @@ describe('useDeleteFileAttachment', () => {
}) })
); );
await waitForNextUpdate(); await waitFor(() => expect(useRefreshCaseViewPage()).toBeCalled());
expect(useRefreshCaseViewPage()).toBeCalled();
}); });
it('shows a success toaster correctly', async () => { it('shows a success toaster correctly', async () => {
const { waitForNextUpdate, result } = renderHook(() => useDeleteFileAttachment(), { const { result } = renderHook(() => useDeleteFileAttachment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -82,19 +80,19 @@ describe('useDeleteFileAttachment', () => {
}) })
); );
await waitForNextUpdate(); await waitFor(() =>
expect(addSuccess).toHaveBeenCalledWith({
expect(addSuccess).toHaveBeenCalledWith({ title: 'File deleted successfully',
title: 'File deleted successfully', className: 'eui-textBreakWord',
className: 'eui-textBreakWord', })
}); );
}); });
it('sets isError when fails to delete a file attachment', async () => { it('sets isError when fails to delete a file attachment', async () => {
const spyOnDeleteFileAttachments = jest.spyOn(api, 'deleteFileAttachments'); const spyOnDeleteFileAttachments = jest.spyOn(api, 'deleteFileAttachments');
spyOnDeleteFileAttachments.mockRejectedValue(new Error('Error')); spyOnDeleteFileAttachments.mockRejectedValue(new Error('Error'));
const { waitForNextUpdate, result } = renderHook(() => useDeleteFileAttachment(), { const { result } = renderHook(() => useDeleteFileAttachment(), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -105,7 +103,7 @@ describe('useDeleteFileAttachment', () => {
}) })
); );
await waitForNextUpdate(); await waitFor(() => expect(result.current.isError).toBe(true));
expect(spyOnDeleteFileAttachments).toBeCalledWith({ expect(spyOnDeleteFileAttachments).toBeCalledWith({
caseId: basicCaseId, caseId: basicCaseId,
@ -113,6 +111,5 @@ describe('useDeleteFileAttachment', () => {
}); });
expect(addError).toHaveBeenCalled(); expect(addError).toHaveBeenCalled();
expect(result.current.isError).toBe(true);
}); });
}); });

78
x-pack/plugins/cases/public/containers/use_find_case_user_actions.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { useFindCaseUserActions } from './use_find_case_user_actions'; import { useFindCaseUserActions } from './use_find_case_user_actions';
import type { CaseUserActionTypeWithAll } from '../../common/ui/types'; import type { CaseUserActionTypeWithAll } from '../../common/ui/types';
import { basicCase, findCaseUserActionsResponse } from './mock'; import { basicCase, findCaseUserActionsResponse } from './mock';
@ -43,33 +43,32 @@ describe('UseFindCaseUserActions', () => {
}); });
it('returns proper state on findCaseUserActions', async () => { it('returns proper state on findCaseUserActions', async () => {
const { result, waitForNextUpdate } = renderHook( const { result } = renderHook(() => useFindCaseUserActions(basicCase.id, params, isEnabled), {
() => useFindCaseUserActions(basicCase.id, params, isEnabled), wrapper: appMockRender.AppWrapper,
{ wrapper: appMockRender.AppWrapper } });
);
await waitForNextUpdate(); await waitFor(() =>
expect(result.current).toEqual(
expect(result.current).toEqual( expect.objectContaining({
expect.objectContaining({ ...initialData,
...initialData, data: {
data: { userActions: [...findCaseUserActionsResponse.userActions],
userActions: [...findCaseUserActionsResponse.userActions], total: 30,
total: 30, perPage: 10,
perPage: 10, page: 1,
page: 1, },
}, isError: false,
isError: false, isLoading: false,
isLoading: false, isFetching: false,
isFetching: false, })
}) )
); );
}); });
it('calls the API with correct parameters', async () => { it('calls the API with correct parameters', async () => {
const spy = jest.spyOn(api, 'findCaseUserActions').mockRejectedValue(initialData); const spy = jest.spyOn(api, 'findCaseUserActions').mockRejectedValue(initialData);
const { waitForNextUpdate } = renderHook( renderHook(
() => () =>
useFindCaseUserActions( useFindCaseUserActions(
basicCase.id, basicCase.id,
@ -84,12 +83,12 @@ describe('UseFindCaseUserActions', () => {
{ wrapper: appMockRender.AppWrapper } { wrapper: appMockRender.AppWrapper }
); );
await waitForNextUpdate(); await waitFor(() =>
expect(spy).toHaveBeenCalledWith(
expect(spy).toHaveBeenCalledWith( basicCase.id,
basicCase.id, { type: 'user', sortOrder: 'desc', page: 1, perPage: 5 },
{ type: 'user', sortOrder: 'desc', page: 1, perPage: 5 }, expect.any(AbortSignal)
expect.any(AbortSignal) )
); );
}); });
@ -120,20 +119,17 @@ describe('UseFindCaseUserActions', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addError }); (useToasts as jest.Mock).mockReturnValue({ addError });
const { waitForNextUpdate } = renderHook( renderHook(() => useFindCaseUserActions(basicCase.id, params, isEnabled), {
() => useFindCaseUserActions(basicCase.id, params, isEnabled), wrapper: appMockRender.AppWrapper,
{ });
wrapper: appMockRender.AppWrapper,
}
);
await waitForNextUpdate(); await waitFor(() => {
expect(spy).toHaveBeenCalledWith(
expect(spy).toHaveBeenCalledWith( basicCase.id,
basicCase.id, { type: filterActionType, sortOrder, page: 1, perPage: 10 },
{ type: filterActionType, sortOrder, page: 1, perPage: 10 }, expect.any(AbortSignal)
expect.any(AbortSignal) );
); expect(addError).toHaveBeenCalled();
expect(addError).toHaveBeenCalled(); });
}); });
}); });

13
x-pack/plugins/cases/public/containers/use_get_action_license.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import * as api from './api'; import * as api from './api';
import { useGetActionLicense } from './use_get_action_license'; import { useGetActionLicense } from './use_get_action_license';
import type { AppMockRenderer } from '../common/mock'; import type { AppMockRenderer } from '../common/mock';
@ -25,12 +25,11 @@ describe('useGetActionLicense', () => {
it('calls getActionLicense with correct arguments', async () => { it('calls getActionLicense with correct arguments', async () => {
const spyOnGetActionLicense = jest.spyOn(api, 'getActionLicense'); const spyOnGetActionLicense = jest.spyOn(api, 'getActionLicense');
const { waitForNextUpdate } = renderHook(() => useGetActionLicense(), { renderHook(() => useGetActionLicense(), {
wrapper: appMockRenderer.AppWrapper, wrapper: appMockRenderer.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() => expect(spyOnGetActionLicense).toBeCalledWith(abortCtrl.signal));
expect(spyOnGetActionLicense).toBeCalledWith(abortCtrl.signal);
}); });
it('unhappy path', async () => { it('unhappy path', async () => {
@ -42,11 +41,9 @@ describe('useGetActionLicense', () => {
throw new Error('Something went wrong'); throw new Error('Something went wrong');
}); });
const { waitForNextUpdate } = renderHook(() => useGetActionLicense(), { renderHook(() => useGetActionLicense(), {
wrapper: appMockRenderer.AppWrapper, wrapper: appMockRenderer.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() => expect(addError).toHaveBeenCalled());
expect(addError).toHaveBeenCalled();
}); });
}); });

21
x-pack/plugins/cases/public/containers/use_get_case.test.tsx
View file

@ -5,10 +5,9 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks';
import { useGetCase } from './use_get_case'; import { useGetCase } from './use_get_case';
import * as api from './api'; import * as api from './api';
import { waitFor } from '@testing-library/react'; import { waitFor, renderHook } from '@testing-library/react';
import type { FC, PropsWithChildren } from 'react'; import type { FC, PropsWithChildren } from 'react';
import React from 'react'; import React from 'react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
@ -32,21 +31,21 @@ const wrapper: FC<PropsWithChildren<unknown>> = ({ children }) => {
describe.skip('Use get case hook', () => { describe.skip('Use get case hook', () => {
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'resolveCase'); const spy = jest.spyOn(api, 'resolveCase');
const { waitForNextUpdate } = renderHook(() => useGetCase('case-1'), { wrapper }); renderHook(() => useGetCase('case-1'), { wrapper });
await waitForNextUpdate(); await waitFor(() =>
expect(spy).toHaveBeenCalledWith({ expect(spy).toHaveBeenCalledWith({
caseId: 'case-1', caseId: 'case-1',
includeComments: true, includeComments: true,
signal: expect.any(AbortSignal), signal: expect.any(AbortSignal),
}); })
);
}); });
it('shows a toast error when the api return an error', async () => { it('shows a toast error when the api return an error', async () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addError }); (useToasts as jest.Mock).mockReturnValue({ addError });
const spy = jest.spyOn(api, 'resolveCase').mockRejectedValue(new Error("C'est la vie")); const spy = jest.spyOn(api, 'resolveCase').mockRejectedValue(new Error("C'est la vie"));
const { waitForNextUpdate } = renderHook(() => useGetCase('case-1'), { wrapper }); renderHook(() => useGetCase('case-1'), { wrapper });
await waitForNextUpdate();
await waitFor(() => { await waitFor(() => {
expect(spy).toHaveBeenCalledWith({ expect(spy).toHaveBeenCalledWith({
caseId: 'case-1', caseId: 'case-1',

6
x-pack/plugins/cases/public/containers/use_get_case_connectors.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import * as api from './api'; import * as api from './api';
import type { AppMockRenderer } from '../common/mock'; import type { AppMockRenderer } from '../common/mock';
import { createAppMockRenderer } from '../common/mock'; import { createAppMockRenderer } from '../common/mock';
@ -30,7 +30,7 @@ describe('useGetCaseConnectors', () => {
it('calls getCaseConnectors with correct arguments', async () => { it('calls getCaseConnectors with correct arguments', async () => {
const spyOnGetCases = jest.spyOn(api, 'getCaseConnectors'); const spyOnGetCases = jest.spyOn(api, 'getCaseConnectors');
const { waitFor } = renderHook(() => useGetCaseConnectors(caseId), { renderHook(() => useGetCaseConnectors(caseId), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
@ -50,7 +50,7 @@ describe('useGetCaseConnectors', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addSuccess, addError }); (useToasts as jest.Mock).mockReturnValue({ addSuccess, addError });
const { waitFor } = renderHook(() => useGetCaseConnectors(caseId), { renderHook(() => useGetCaseConnectors(caseId), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });

20
x-pack/plugins/cases/public/containers/use_get_case_file_stats.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { basicCase } from './mock'; import { basicCase } from './mock';
@ -37,12 +37,12 @@ describe('useGetCaseFileStats', () => {
}); });
it('calls filesClient.list with correct arguments', async () => { it('calls filesClient.list with correct arguments', async () => {
const { waitForNextUpdate } = renderHook(() => useGetCaseFileStats(hookParams), { renderHook(() => useGetCaseFileStats(hookParams), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(appMockRender.getFilesClient().list).toHaveBeenCalledWith(expectedCallParams)
expect(appMockRender.getFilesClient().list).toHaveBeenCalledWith(expectedCallParams); );
}); });
it('shows an error toast when filesClient.list throws', async () => { it('shows an error toast when filesClient.list throws', async () => {
@ -53,12 +53,12 @@ describe('useGetCaseFileStats', () => {
throw new Error('Something went wrong'); throw new Error('Something went wrong');
}); });
const { waitForNextUpdate } = renderHook(() => useGetCaseFileStats(hookParams), { renderHook(() => useGetCaseFileStats(hookParams), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(appMockRender.getFilesClient().list).toHaveBeenCalledWith(expectedCallParams);
expect(appMockRender.getFilesClient().list).toHaveBeenCalledWith(expectedCallParams); expect(addError).toHaveBeenCalled();
expect(addError).toHaveBeenCalled(); });
}); });
}); });

20
x-pack/plugins/cases/public/containers/use_get_case_files.test.tsx
View file

@ -5,7 +5,7 @@
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import { basicCase } from './mock'; import { basicCase } from './mock';
@ -48,22 +48,22 @@ describe('useGetCaseFiles', () => {
throw new Error('Something went wrong'); throw new Error('Something went wrong');
}); });
const { waitForNextUpdate } = renderHook(() => useGetCaseFiles(hookParams), { renderHook(() => useGetCaseFiles(hookParams), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(appMockRender.getFilesClient().list).toBeCalledWith(expectedCallParams);
expect(appMockRender.getFilesClient().list).toBeCalledWith(expectedCallParams); expect(addError).toHaveBeenCalled();
expect(addError).toHaveBeenCalled(); });
}); });
it('calls filesClient.list with correct arguments', async () => { it('calls filesClient.list with correct arguments', async () => {
const { waitForNextUpdate } = renderHook(() => useGetCaseFiles(hookParams), { renderHook(() => useGetCaseFiles(hookParams), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(appMockRender.getFilesClient().list).toBeCalledWith(expectedCallParams)
expect(appMockRender.getFilesClient().list).toBeCalledWith(expectedCallParams); );
}); });
}); });

19
x-pack/plugins/cases/public/containers/use_get_case_metrics.test.tsx
View file

@ -7,7 +7,7 @@
import type { FC, PropsWithChildren } from 'react'; import type { FC, PropsWithChildren } from 'react';
import React from 'react'; import React from 'react';
import { renderHook } from '@testing-library/react-hooks'; import { waitFor, renderHook } from '@testing-library/react';
import type { SingleCaseMetricsFeature } from '../../common/ui'; import type { SingleCaseMetricsFeature } from '../../common/ui';
import { useGetCaseMetrics } from './use_get_case_metrics'; import { useGetCaseMetrics } from './use_get_case_metrics';
import { basicCase } from './mock'; import { basicCase } from './mock';
@ -34,12 +34,13 @@ describe('useGetCaseMetrics', () => {
it('calls getSingleCaseMetrics with correct arguments', async () => { it('calls getSingleCaseMetrics with correct arguments', async () => {
const spyOnGetCaseMetrics = jest.spyOn(api, 'getSingleCaseMetrics'); const spyOnGetCaseMetrics = jest.spyOn(api, 'getSingleCaseMetrics');
const { waitForNextUpdate } = renderHook(() => useGetCaseMetrics(basicCase.id, features), { renderHook(() => useGetCaseMetrics(basicCase.id, features), {
wrapper, wrapper,
}); });
await waitForNextUpdate(); await waitFor(() =>
expect(spyOnGetCaseMetrics).toBeCalledWith(basicCase.id, features, abortCtrl.signal); expect(spyOnGetCaseMetrics).toBeCalledWith(basicCase.id, features, abortCtrl.signal)
);
}); });
it('shows an error toast when getSingleCaseMetrics throws', async () => { it('shows an error toast when getSingleCaseMetrics throws', async () => {
@ -51,13 +52,13 @@ describe('useGetCaseMetrics', () => {
throw new Error('Something went wrong'); throw new Error('Something went wrong');
}); });
const { waitForNextUpdate } = renderHook(() => useGetCaseMetrics(basicCase.id, features), { renderHook(() => useGetCaseMetrics(basicCase.id, features), {
wrapper, wrapper,
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(spyOnGetCaseMetrics).toBeCalledWith(basicCase.id, features, abortCtrl.signal);
expect(spyOnGetCaseMetrics).toBeCalledWith(basicCase.id, features, abortCtrl.signal); expect(addError).toHaveBeenCalled();
expect(addError).toHaveBeenCalled(); });
}); });
}); });

28
x-pack/plugins/cases/public/containers/use_get_case_user_actions_stats.test.tsx
View file

@ -4,7 +4,8 @@
* 2.0; you may not use this file except in compliance with the Elastic License * 2.0; you may not use this file except in compliance with the Elastic License
* 2.0. * 2.0.
*/ */
import { renderHook } from '@testing-library/react-hooks';
import { waitFor, renderHook } from '@testing-library/react';
import { useToasts } from '../common/lib/kibana'; import { useToasts } from '../common/lib/kibana';
import type { AppMockRenderer } from '../common/mock'; import type { AppMockRenderer } from '../common/mock';
@ -31,12 +32,11 @@ describe('useGetCaseUserActionsStats', () => {
}); });
it('returns proper state on getCaseUserActionsStats', async () => { it('returns proper state on getCaseUserActionsStats', async () => {
const { result, waitForNextUpdate } = renderHook( const { result } = renderHook(() => useGetCaseUserActionsStats(basicCase.id), {
() => useGetCaseUserActionsStats(basicCase.id), wrapper: appMockRender.AppWrapper,
{ wrapper: appMockRender.AppWrapper } });
);
await waitForNextUpdate(); await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current).toEqual( expect(result.current).toEqual(
expect.objectContaining({ expect.objectContaining({
@ -61,25 +61,23 @@ describe('useGetCaseUserActionsStats', () => {
const addError = jest.fn(); const addError = jest.fn();
(useToasts as jest.Mock).mockReturnValue({ addError }); (useToasts as jest.Mock).mockReturnValue({ addError });
const { waitForNextUpdate } = renderHook(() => useGetCaseUserActionsStats(basicCase.id), { renderHook(() => useGetCaseUserActionsStats(basicCase.id), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() => {
expect(spy).toHaveBeenCalledWith(basicCase.id, expect.any(AbortSignal));
expect(spy).toHaveBeenCalledWith(basicCase.id, expect.any(AbortSignal)); expect(addError).toHaveBeenCalled();
expect(addError).toHaveBeenCalled(); });
}); });
it('calls the api when invoked with the correct parameters', async () => { it('calls the api when invoked with the correct parameters', async () => {
const spy = jest.spyOn(api, 'getCaseUserActionsStats'); const spy = jest.spyOn(api, 'getCaseUserActionsStats');
const { waitForNextUpdate } = renderHook(() => useGetCaseUserActionsStats(basicCase.id), { renderHook(() => useGetCaseUserActionsStats(basicCase.id), {
wrapper: appMockRender.AppWrapper, wrapper: appMockRender.AppWrapper,
}); });
await waitForNextUpdate(); await waitFor(() => expect(spy).toHaveBeenCalledWith(basicCase.id, expect.any(AbortSignal)));
expect(spy).toHaveBeenCalledWith(basicCase.id, expect.any(AbortSignal));
}); });
}); });

Some files were not shown because too many files have changed in this diff Show more