github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution][Data Views] - Update bulk actions data views index param to be snake_case (#138429)

Browse source 
## Summary

Overlooked a param name - should be snake case per our APIs. `overwriteDataViews` --> `overwrite_data_views`
This commit is contained in:
Yara Tercero 2022-08-09 11:05:17 -07:00 • committed by GitHub
parent 2dfc992191
commit 6da6f18b2d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/security_solution/common/detection_engine/schemas/common/schemas.ts
View file

@ -401,7 +401,7 @@ const bulkActionEditPayloadIndexPatterns = t.intersection([
]),
value: index,
}),
t.exact(t.partial({ overwriteDataViews: t.boolean })),
t.exact(t.partial({ overwrite_data_views: t.boolean })),
]);
export type BulkActionEditPayloadIndexPatterns = t.TypeOf<

2
x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/bulk_actions/forms/index_patterns_form.tsx
View file

@ -118,7 +118,7 @@ const IndexPatternsFormComponent = ({
const payload = {
value: data.index,
type: data.overwrite ? BulkActionEditType.set_index_patterns : editAction,
overwriteDataViews: data.overwriteDataViews,
overwrite_data_views: data.overwriteDataViews,
};
onConfirm(payload);

8
x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions/rule_params_modifier.test.ts
View file

@ -99,28 +99,28 @@ describe('ruleParamsModifier', () => {
expect(editedRuleParams).toHaveProperty('index', ['index']);
});
test('should set dataViewId to undefined if overwriteDataViews=true on set_index_patterns action', () => {
test('should set dataViewId to undefined if overwrite_data_views=true on set_index_patterns action', () => {
const editedRuleParams = ruleParamsModifier(
{ dataViewId: 'test-data-view', index: ['test-*'] } as RuleAlertType['params'],
[
{
type: BulkActionEditType.set_index_patterns,
value: ['index'],
overwriteDataViews: true,
overwrite_data_views: true,
},
]
);
expect(editedRuleParams).toHaveProperty('dataViewId', undefined);
});
test('should set dataViewId to undefined if overwriteDataViews=true on add_index_patterns action', () => {
test('should set dataViewId to undefined if overwrite_data_views=true on add_index_patterns action', () => {
const editedRuleParams = ruleParamsModifier(
{ dataViewId: 'test-data-view', index: ['test-*'] } as RuleAlertType['params'],
[
{
type: BulkActionEditType.add_index_patterns,
value: ['index'],
overwriteDataViews: true,
overwrite_data_views: true,
},
]
);

4
x-pack/plugins/security_solution/server/lib/detection_engine/rules/bulk_actions/rule_params_modifier.ts
View file

@ -35,7 +35,7 @@ const applyBulkActionEditToRuleParams = (
"Index patterns can't be added. Machine learning rule doesn't have index patterns property"
);
if (action.overwriteDataViews) {
if (action.overwrite_data_views) {
ruleParams.dataViewId = undefined;
}
@ -59,7 +59,7 @@ const applyBulkActionEditToRuleParams = (
"Index patterns can't be overwritten. Machine learning rule doesn't have index patterns property"
);
if (action.overwriteDataViews) {
if (action.overwrite_data_views) {
ruleParams.dataViewId = undefined;
}

2
x-pack/test/detection_engine_api_integration/security_and_spaces/group1/perform_bulk_action.ts
View file

@ -580,7 +580,7 @@ export default ({ getService }: FtrProviderContext): void => {
{
type: BulkActionEditType.add_index_patterns,
value: ['initial-index-*'],
overwriteDataViews: true,
overwrite_data_views: true,
},
],
})