github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Uptime] Add-aria-labels-for-filter-inputs (#82249)

Browse source
This commit is contained in:
Shahzad 2020-11-03 16:43:07 +01:00 • committed by GitHub
parent a0fded52eb
commit 6f6c2cf042
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/plugins/uptime/public/components/overview/filter_group/__tests__/__snapshots__/filter_popover.test.tsx.snap generated
View file

@ -24,6 +24,7 @@ exports[`FilterPopover component does not show item list when loading 1`] = `
>
<EuiPopoverTitle>
<EuiFieldSearch
aria-label="Search for bar"
compressed={false}
disabled={true}
fullWidth={false}
@ -61,6 +62,7 @@ exports[`FilterPopover component renders without errors for valid props 1`] = `
>
<EuiPopoverTitle>
<EuiFieldSearch
aria-label="Search for bar"
compressed={false}
disabled={true}
fullWidth={false}

8
x-pack/plugins/uptime/public/components/overview/filter_group/filter_popover.tsx
View file

@ -100,6 +100,12 @@ export const FilterPopover = ({
incremental={true}
disabled={items.length === 0}
onSearch={(query) => setSearchQuery(query)}
aria-label={i18n.translate('xpack.uptime.filterPopout.searchMessage.ariaLabel', {
defaultMessage: 'Search for {title}',
values: {
title: title.toLowerCase(),
},
})}
placeholder={
loading
? i18n.translate('xpack.uptime.filterPopout.loadingMessage', {
@ -108,7 +114,7 @@ export const FilterPopover = ({
: i18n.translate('xpack.uptime.filterPopout.searchMessage', {
defaultMessage: 'Search {title}',
values: {
title,
title: title.toLowerCase(),
},
})
}