github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixing Failing test: X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/disable·ts - alerting api integration security and spaces enabled Alerts - Group 1 alerts disable superuser at space1 should still be able to disable alert when AAD is broken (#142483)

Browse source 
* Unskipping test

* Adding retries
This commit is contained in:
Ying Mao 2022-10-04 08:25:32 -04:00 • committed by GitHub
parent 24ce456ec1
commit 6f8e758f11
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 38 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

71
x-pack/test/alerting_api_integration/security_and_spaces/group1/tests/alerting/disable.ts
View file

@ -26,8 +26,7 @@ export default function createDisableAlertTests({ getService }: FtrProviderConte
const supertest = getService('supertest');
const supertestWithoutAuth = getService('supertestWithoutAuth');
// Failing: See https://github.com/elastic/kibana/issues/140797
describe.skip('disable', () => {
describe('disable', () => {
const objectRemover = new ObjectRemover(supertest);
after(() => objectRemover.removeAll());
@ -110,21 +109,23 @@ export default function createDisableAlertTests({ getService }: FtrProviderConte
expect(response.body).to.eql('');
// task should still exist but be disabled
const taskRecord2 = await getScheduledTask(createdAlert.scheduled_task_id);
expect(taskRecord2.type).to.eql('task');
expect(taskRecord2.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord2.task.params)).to.eql({
alertId: createdAlert.id,
spaceId: space.id,
consumer: 'alertsFixture',
});
expect(taskRecord2.task.enabled).to.eql(false);
// Ensure AAD isn't broken
await checkAAD({
supertest,
spaceId: space.id,
type: 'alert',
id: createdAlert.id,
await retry.try(async () => {
const taskRecord2 = await getScheduledTask(createdAlert.scheduled_task_id);
expect(taskRecord2.type).to.eql('task');
expect(taskRecord2.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord2.task.params)).to.eql({
alertId: createdAlert.id,
spaceId: space.id,
consumer: 'alertsFixture',
});
expect(taskRecord2.task.enabled).to.eql(false);
// Ensure AAD isn't broken
await checkAAD({
supertest,
spaceId: space.id,
type: 'alert',
id: createdAlert.id,
});
});
break;
default:
@ -295,15 +296,17 @@ export default function createDisableAlertTests({ getService }: FtrProviderConte
expect(response.statusCode).to.eql(204);
expect(response.body).to.eql('');
// task should still exist but be disabled
const taskRecord = await getScheduledTask(createdAlert.scheduled_task_id);
expect(taskRecord.type).to.eql('task');
expect(taskRecord.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord.task.params)).to.eql({
alertId: createdAlert.id,
spaceId: space.id,
consumer: 'alerts',
await retry.try(async () => {
const taskRecord = await getScheduledTask(createdAlert.scheduled_task_id);
expect(taskRecord.type).to.eql('task');
expect(taskRecord.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord.task.params)).to.eql({
alertId: createdAlert.id,
spaceId: space.id,
consumer: 'alerts',
});
expect(taskRecord.task.enabled).to.eql(false);
});
expect(taskRecord.task.enabled).to.eql(false);
break;
default:
throw new Error(`Scenario untested: ${JSON.stringify(scenario)}`);
@ -366,15 +369,17 @@ export default function createDisableAlertTests({ getService }: FtrProviderConte
expect(response.statusCode).to.eql(204);
expect(response.body).to.eql('');
// task should still exist but be disabled
const taskRecord2 = await getScheduledTask(createdAlert.scheduled_task_id);
expect(taskRecord2.type).to.eql('task');
expect(taskRecord2.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord2.task.params)).to.eql({
alertId: createdAlert.id,
spaceId: space.id,
consumer: 'alertsFixture',
await retry.try(async () => {
const taskRecord2 = await getScheduledTask(createdAlert.scheduled_task_id);
expect(taskRecord2.type).to.eql('task');
expect(taskRecord2.task.taskType).to.eql('alerting:test.noop');
expect(JSON.parse(taskRecord2.task.params)).to.eql({
alertId: createdAlert.id,
spaceId: space.id,
consumer: 'alertsFixture',
});
expect(taskRecord2.task.enabled).to.eql(false);
});
expect(taskRecord2.task.enabled).to.eql(false);
break;
default:
throw new Error(`Scenario untested: ${JSON.stringify(scenario)}`);