github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.6] [data view field editor] Fix runtime field format editor (#148497) (#148554)

Browse source 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[data view field editor] Fix runtime field format editor
(#148497)](https://github.com/elastic/kibana/pull/148497)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2023-01-09T15:33:12Z","message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Data
Views","Feature:Kibana
Management","backport:prev-minor","v8.7.0"],"number":148497,"url":"https://github.com/elastic/kibana/pull/148497","mergeCommit":{"message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148497","number":148497,"mergeCommit":{"message":"[data
view field editor] Fix runtime field format editor (#148497)\n\n##
Summary\r\n\r\nWhen editing a runtime field, the format setting would
successfully save\r\nbut it wouldn't be shown on subsequent uses of the
field editor. Fixed.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/144517","sha":"bc4e425f2c8b00bbbe73c4032c567acf2543ad86"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
This commit is contained in:
Kibana Machine 2023-01-09 12:09:18 -05:00 • committed by GitHub
parent 8baf72416d
commit 6fd64ee078
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/plugins/data_view_field_editor/public/open_editor.tsx
View file

@ -162,6 +162,7 @@ export const getFieldEditorOpener =
// Runtime field
field = {
name: fieldNameToEdit!,
format: dataView.getFormatterForFieldNoDefault(fieldNameToEdit!)?.toJSON(),
...dataView.getRuntimeField(fieldNameToEdit!)!,
};
} else {

9
test/functional/apps/management/_runtime_fields.ts
View file

@ -63,11 +63,20 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await testSubjects.click('editFieldFormat');
await PageObjects.settings.setFieldType('Long');
await PageObjects.settings.setFieldScriptWithoutToggle('emit(6);');
await PageObjects.settings.toggleRow('formatRow');
await PageObjects.settings.setFieldFormat('bytes');
await testSubjects.find('changeWarning');
await PageObjects.settings.clickSaveField();
await PageObjects.settings.confirmSave();
});
it('verify field format', async function () {
await testSubjects.click('editFieldFormat');
const select = await testSubjects.find('editorSelectedFormatId');
expect(await select.getAttribute('value')).to.be('bytes');
await PageObjects.settings.closeIndexPatternFieldEditor();
});
it('should delete runtime field', async function () {
await testSubjects.click('deleteField');
await PageObjects.settings.confirmDelete();