mirror of
https://github.com/elastic/kibana.git
synced 2025-04-23 01:13:23 -04:00
# Backport This will backport the following commits from `main` to `8.x`: - [[Embeddable] EUI Visual Refresh Integration (#204452)](https://github.com/elastic/kibana/pull/204452) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Catherine Liu","email":"catherine.liu@elastic.co"},"sourceCommit":{"committedDate":"2024-12-19T18:12:09Z","message":"[Embeddable] EUI Visual Refresh Integration (#204452)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/203132.\r\nPart of [#204596](https://github.com/elastic/kibana/issues/204596).\r\n\r\nThis replaces all references to euiThemeVars in favor of the useEuiTheme\r\nhook.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] [See some risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n- [ ] ...\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"b80980694a30f957fbd97dc57f16334daf59850d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:skip","v9.0.0","Feature:Embeddables","backport:version"],"title":"[Embeddable] EUI Visual Refresh Integration","number":204452,"url":"https://github.com/elastic/kibana/pull/204452","mergeCommit":{"message":"[Embeddable] EUI Visual Refresh Integration (#204452)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/203132.\r\nPart of [#204596](https://github.com/elastic/kibana/issues/204596).\r\n\r\nThis replaces all references to euiThemeVars in favor of the useEuiTheme\r\nhook.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] [See some risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n- [ ] ...\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"b80980694a30f957fbd97dc57f16334daf59850d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204452","number":204452,"mergeCommit":{"message":"[Embeddable] EUI Visual Refresh Integration (#204452)\n\n## Summary\r\n\r\nRelated to https://github.com/elastic/kibana/issues/203132.\r\nPart of [#204596](https://github.com/elastic/kibana/issues/204596).\r\n\r\nThis replaces all references to euiThemeVars in favor of the useEuiTheme\r\nhook.\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This was checked for breaking HTTP API changes, and any breaking\r\nchanges have been approved by the breaking-change committee. The\r\n`release_note:breaking` label should be applied in these situations.\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] [See some risk\r\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\r\n- [ ] ...\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"b80980694a30f957fbd97dc57f16334daf59850d"}}]}] BACKPORT-->
This commit is contained in:
parent
89fe701d70
commit
6fdd9fc9d7
5 changed files with 20 additions and 13 deletions
|
@ -7,7 +7,7 @@
|
|||
* License v3.0 only", or the "Server Side Public License, v 1".
|
||||
*/
|
||||
|
||||
import { EuiMarkdownEditor, EuiMarkdownFormat } from '@elastic/eui';
|
||||
import { EuiMarkdownEditor, EuiMarkdownFormat, useEuiTheme } from '@elastic/eui';
|
||||
import { css } from '@emotion/react';
|
||||
import { ReactEmbeddableFactory } from '@kbn/embeddable-plugin/public';
|
||||
import { i18n } from '@kbn/i18n';
|
||||
|
@ -16,7 +16,6 @@ import {
|
|||
useInheritedViewMode,
|
||||
useStateFromPublishingSubject,
|
||||
} from '@kbn/presentation-publishing';
|
||||
import { euiThemeVars } from '@kbn/ui-theme';
|
||||
import React from 'react';
|
||||
import { BehaviorSubject } from 'rxjs';
|
||||
import { EUI_MARKDOWN_ID } from './constants';
|
||||
|
@ -80,6 +79,7 @@ export const markdownEmbeddableFactory: ReactEmbeddableFactory<
|
|||
// get state for rendering
|
||||
const content = useStateFromPublishingSubject(content$);
|
||||
const viewMode = useInheritedViewMode(api) ?? 'view';
|
||||
const { euiTheme } = useEuiTheme();
|
||||
|
||||
return viewMode === 'edit' ? (
|
||||
<EuiMarkdownEditor
|
||||
|
@ -96,7 +96,7 @@ export const markdownEmbeddableFactory: ReactEmbeddableFactory<
|
|||
) : (
|
||||
<EuiMarkdownFormat
|
||||
css={css`
|
||||
padding: ${euiThemeVars.euiSizeM};
|
||||
padding: ${euiTheme.size.m};
|
||||
`}
|
||||
>
|
||||
{content ?? ''}
|
||||
|
|
|
@ -7,7 +7,7 @@
|
|||
* License v3.0 only", or the "Server Side Public License, v 1".
|
||||
*/
|
||||
|
||||
import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
|
||||
import { EuiFlexGroup, EuiFlexItem, useEuiTheme } from '@elastic/eui';
|
||||
import { css } from '@emotion/react';
|
||||
import type { Reference } from '@kbn/content-management-utils';
|
||||
import { CoreStart } from '@kbn/core-lifecycle-browser';
|
||||
|
@ -17,7 +17,6 @@ import { ReactEmbeddableFactory } from '@kbn/embeddable-plugin/public';
|
|||
import { i18n } from '@kbn/i18n';
|
||||
import { initializeTitleManager, useBatchedPublishingSubjects } from '@kbn/presentation-publishing';
|
||||
import { LazyDataViewPicker, withSuspense } from '@kbn/presentation-util-plugin/public';
|
||||
import { euiThemeVars } from '@kbn/ui-theme';
|
||||
import {
|
||||
UnifiedFieldListSidebarContainer,
|
||||
type UnifiedFieldListSidebarContainerProps,
|
||||
|
@ -150,6 +149,7 @@ export const getFieldListFactory = (
|
|||
dataViews$,
|
||||
selectedFieldNames$
|
||||
);
|
||||
const { euiTheme } = useEuiTheme();
|
||||
|
||||
const selectedDataView = renderDataViews?.[0];
|
||||
|
||||
|
@ -165,7 +165,7 @@ export const getFieldListFactory = (
|
|||
<EuiFlexItem
|
||||
grow={false}
|
||||
css={css`
|
||||
padding: ${euiThemeVars.euiSizeS};
|
||||
padding: ${euiTheme.size.s};
|
||||
`}
|
||||
>
|
||||
<DataViewPicker
|
||||
|
|
|
@ -7,7 +7,15 @@
|
|||
* License v3.0 only", or the "Server Side Public License, v 1".
|
||||
*/
|
||||
|
||||
import { EuiBadge, EuiCallOut, EuiFlexGroup, EuiFlexItem, EuiText, EuiTitle } from '@elastic/eui';
|
||||
import {
|
||||
EuiBadge,
|
||||
EuiCallOut,
|
||||
EuiFlexGroup,
|
||||
EuiFlexItem,
|
||||
EuiText,
|
||||
EuiTitle,
|
||||
useEuiTheme,
|
||||
} from '@elastic/eui';
|
||||
import { css } from '@emotion/react';
|
||||
import { CoreStart } from '@kbn/core-lifecycle-browser';
|
||||
import { ReactEmbeddableFactory } from '@kbn/embeddable-plugin/public';
|
||||
|
@ -20,7 +28,6 @@ import {
|
|||
SerializedPanelState,
|
||||
useBatchedPublishingSubjects,
|
||||
} from '@kbn/presentation-publishing';
|
||||
import { euiThemeVars } from '@kbn/ui-theme';
|
||||
import React from 'react';
|
||||
import { PresentationContainer } from '@kbn/presentation-containers';
|
||||
import { serializeBookAttributes, stateManagerFromAttributes } from './book_state';
|
||||
|
@ -156,6 +163,7 @@ export const getSavedBookEmbeddableFactory = (core: CoreStart) => {
|
|||
return {
|
||||
api,
|
||||
Component: () => {
|
||||
const { euiTheme } = useEuiTheme();
|
||||
const [authorName, numberOfPages, bookTitle, synopsis] = useBatchedPublishingSubjects(
|
||||
bookAttributesManager.authorName,
|
||||
bookAttributesManager.numberOfPages,
|
||||
|
@ -187,7 +195,7 @@ export const getSavedBookEmbeddableFactory = (core: CoreStart) => {
|
|||
)}
|
||||
<div
|
||||
css={css`
|
||||
padding: ${euiThemeVars.euiSizeM};
|
||||
padding: ${euiTheme.size.m};
|
||||
`}
|
||||
>
|
||||
<EuiFlexGroup
|
||||
|
|
|
@ -7,7 +7,7 @@
|
|||
* License v3.0 only", or the "Server Side Public License, v 1".
|
||||
*/
|
||||
|
||||
import { EuiBadge, EuiStat } from '@elastic/eui';
|
||||
import { EuiBadge, EuiStat, useEuiTheme } from '@elastic/eui';
|
||||
import { css } from '@emotion/react';
|
||||
import { DataView } from '@kbn/data-views-plugin/common';
|
||||
import { ReactEmbeddableFactory } from '@kbn/embeddable-plugin/public';
|
||||
|
@ -17,7 +17,6 @@ import {
|
|||
initializeTimeRange,
|
||||
useBatchedPublishingSubjects,
|
||||
} from '@kbn/presentation-publishing';
|
||||
import { euiThemeVars } from '@kbn/ui-theme';
|
||||
import React, { useEffect } from 'react';
|
||||
import { BehaviorSubject, switchMap, tap } from 'rxjs';
|
||||
import { SEARCH_EMBEDDABLE_ID } from './constants';
|
||||
|
@ -124,6 +123,7 @@ export const getSearchEmbeddableFactory = (services: Services) => {
|
|||
api,
|
||||
Component: () => {
|
||||
const [count, error] = useBatchedPublishingSubjects(count$, blockingError$);
|
||||
const { euiTheme } = useEuiTheme();
|
||||
|
||||
useEffect(() => {
|
||||
return () => {
|
||||
|
@ -138,7 +138,7 @@ export const getSearchEmbeddableFactory = (services: Services) => {
|
|||
<div
|
||||
css={css`
|
||||
width: 100%;
|
||||
padding: ${euiThemeVars.euiSizeM};
|
||||
padding: ${euiTheme.size.m};
|
||||
`}
|
||||
>
|
||||
<EuiStat
|
||||
|
|
|
@ -18,7 +18,6 @@
|
|||
"@kbn/dashboard-plugin",
|
||||
"@kbn/embeddable-plugin",
|
||||
"@kbn/presentation-publishing",
|
||||
"@kbn/ui-theme",
|
||||
"@kbn/i18n",
|
||||
"@kbn/es-query",
|
||||
"@kbn/data-views-plugin",
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue