github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution] Enable Entity Analytics feature flags by default (#175899)

Browse source 
## Summary

Enables the following feature flags by default:
* newUserDetailsFlyout
* newHostDetailsFlyout
* ~entityAnalyticsAssetCriticalityEnabled~
* Cleanup any unnecessary feature flag enablements within Cypress/FTR
tests


- [ ] Wait for the green flag 🟢

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Pablo Machado 2024-02-13 15:39:43 +01:00 • committed by GitHub
parent d11b73d55a
commit 708db13e6e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 2 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/security_solution/common/experimental_features.ts
View file

@ -107,7 +107,7 @@ export const allowedExperimentalValues = Object.freeze({
* Enables the new user details flyout displayed on the Alerts table.
*
**/
newUserDetailsFlyout: false,
newUserDetailsFlyout: true,
/*
* Enables the Managed User section inside the new user details flyout.
@ -120,7 +120,7 @@ export const allowedExperimentalValues = Object.freeze({
* Enables the new host details flyout displayed on the Alerts table.
*
**/
newHostDetailsFlyout: false,
newHostDetailsFlyout: true,
/**
* Enable risk engine client and initialisation of datastream, component templates and mappings

2
x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/new_entity_flyout.cy.ts → x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts
View file

@ -54,8 +54,6 @@ describe(
ftrConfig: {
kbnServerArgs: [
`--xpack.securitySolution.enableExperimental=${JSON.stringify([
'newUserDetailsFlyout',
'newHostDetailsFlyout',
'entityAnalyticsAssetCriticalityEnabled',
'newUserDetailsFlyoutManagedUser',
])}`,

40
x-pack/test/security_solution_cypress/cypress/e2e/explore/users/user_details.cy.ts
View file

@ -1,40 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { ALERT_FLYOUT } from '../../../screens/alerts_details';
import { createRule } from '../../../tasks/api_calls/rules';
import { waitForAlertsToPopulate } from '../../../tasks/create_new_rule';
import { login } from '../../../tasks/login';
import { visit } from '../../../tasks/navigation';
import { refreshPage } from '../../../tasks/security_header';
import { getNewRule } from '../../../objects/rule';
import { ALERTS_URL } from '../../../urls/navigation';
import {
expandAlertTableCellValue,
openUserDetailsFlyout,
scrollAlertTableColumnIntoView,
} from '../../../tasks/alerts';
import { USER_COLUMN } from '../../../screens/alerts';
describe('user details flyout', { tags: ['@ess', '@serverless'] }, () => {
beforeEach(() => {
login();
});
it('shows user detail flyout from alert table', () => {
visit(ALERTS_URL);
createRule(getNewRule({ query: 'user.name:*' }));
refreshPage();
waitForAlertsToPopulate();
scrollAlertTableColumnIntoView(USER_COLUMN);
expandAlertTableCellValue(USER_COLUMN);
openUserDetailsFlyout();
cy.get(ALERT_FLYOUT).should('be.visible');
});
});

6
x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts
View file

@ -62,8 +62,6 @@ import {
ENRICHMENT_QUERY_START_INPUT,
THREAT_INTEL_TAB,
CELL_EXPAND_VALUE,
CELL_EXPANSION_POPOVER,
USER_DETAILS_LINK,
} from '../screens/alerts_details';
import { FIELD_INPUT } from '../screens/exceptions';
import {
@ -421,10 +419,6 @@ export const scrollAlertTableColumnIntoView = (columnSelector: string) => {
});
};
export const openUserDetailsFlyout = () => {
cy.get(CELL_EXPANSION_POPOVER).find(USER_DETAILS_LINK).click();
};
export const waitForPageFilters = () => {
cy.log('Waiting for Page Filters');
cy.url().then((urlString) => {