github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fixing skipped saved tags test along with adding a missing aria-label (#137234) (#137347)

Browse source 
(cherry picked from commit 78da900fd4)

Co-authored-by: Bhavya RM <bhavya@elastic.co>
This commit is contained in:
Kibana Machine 2022-07-27 17:03:49 -04:00 • committed by GitHub
parent c134aa3130
commit 70d12cd558
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/saved_objects_tagging/public/components/assign_flyout/components/result_list.tsx
View file

@ -64,6 +64,7 @@ export const AssignFlyoutResultList: FC<AssignFlyoutResultListProps> = ({
<EuiSelectable<ResultInternals>
height="full"
data-test-subj="assignFlyoutResultList"
aria-label="Saved objects which can be assigned to this tag"
options={options}
allowExclusions={false}
isLoading={isLoading}

25
x-pack/test/accessibility/apps/tags.ts
View file

@ -13,11 +13,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const PageObjects = getPageObjects(['common', 'settings', 'header', 'home', 'tagManagement']);
const a11y = getService('a11y');
const testSubjects = getService('testSubjects');
const retry = getService('retry');
const toasts = getService('toasts');
// FLAKY: https://github.com/elastic/kibana/issues/136033
describe.skip('Kibana Tags Page Accessibility', () => {
describe('Kibana Tags Page Accessibility', () => {
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
useActualUrl: true,
@ -72,26 +69,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
});
// https://github.com/elastic/kibana/issues/135985 inconsistent test failure
it.skip('tag assignment panel meets a11y requirements', async () => {
it('tag assignment panel & tag management page with populated connections meets a11y requirements', async () => {
await testSubjects.click('euiCollapsedItemActionsButton');
const actionOnTag = 'assign';
await PageObjects.tagManagement.clickActionItem(actionOnTag);
await a11y.testAppSnapshot();
});
it('tag management page with connections column populated meets a11y requirements', async () => {
await testSubjects.click('euiCollapsedItemActionsButton');
const actionOnTag = 'assign';
await PageObjects.tagManagement.clickActionItem(actionOnTag);
await testSubjects.click('assignFlyout-selectAllButton');
await testSubjects.click('assignFlyoutConfirmButton');
await toasts.dismissAllToasts();
await retry.try(async () => {
await a11y.testAppSnapshot();
});
await testSubjects.click('euiFlyoutCloseButton');
await testSubjects.waitForDeleted('euiFlyoutCloseButton');
await a11y.testAppSnapshot();
});
it('bulk actions panel meets a11y requirements', async () => {