github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[7.2] Fix: handle null argument values (#37411) (#37416)

Browse source 
typeof null === 'object', so add an explicit check for null
This commit is contained in:
Joe Fleming 2019-05-29 14:53:52 -07:00 • committed by GitHub
parent 9c80725d98
commit 7253136e08
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/canvas/public/state/selectors/workpad.js
View file

@ -160,7 +160,7 @@ function extractFilterGroups(ast) {
return groups.concat(
buildGroupValues(args, argValue => {
// this only handles simple values
if (typeof argValue !== 'object') {
if (argValue !== null && typeof argValue !== 'object') {
return argValue;
}
})
@ -170,7 +170,7 @@ function extractFilterGroups(ast) {
return groups.concat(
buildGroupValues(args, argValue => {
// recursively collect filter groups
if (typeof argValue === 'object' && argValue.type === 'expression') {
if (argValue !== null && typeof argValue === 'object' && argValue.type === 'expression') {
return extractFilterGroups(argValue);
}
})