github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Add levels for registered deprecations (#117691)

Browse source
This commit is contained in:
Felix Stürmer 2021-11-05 23:10:55 +01:00 • committed by GitHub
parent 6fe005268a
commit 7455bde296
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 25 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

35
x-pack/plugins/monitoring/server/deprecations.ts
View file

@ -23,27 +23,39 @@ export const deprecations = ({
}: ConfigDeprecationFactory): ConfigDeprecation[] => {
return [
// This order matters. The "blanket rename" needs to happen at the end
renameFromRoot('xpack.monitoring.max_bucket_size', 'monitoring.ui.max_bucket_size'),
renameFromRoot('xpack.monitoring.min_interval_seconds', 'monitoring.ui.min_interval_seconds'),
renameFromRoot('xpack.monitoring.max_bucket_size', 'monitoring.ui.max_bucket_size', {
level: 'warning',
}),
renameFromRoot('xpack.monitoring.min_interval_seconds', 'monitoring.ui.min_interval_seconds', {
level: 'warning',
}),
renameFromRoot(
'xpack.monitoring.show_license_expiration',
'monitoring.ui.show_license_expiration'
'monitoring.ui.show_license_expiration',
{ level: 'warning' }
),
renameFromRoot(
'xpack.monitoring.ui.container.elasticsearch.enabled',
'monitoring.ui.container.elasticsearch.enabled'
'monitoring.ui.container.elasticsearch.enabled',
{ level: 'warning' }
),
renameFromRoot(
'xpack.monitoring.ui.container.logstash.enabled',
'monitoring.ui.container.logstash.enabled'
'monitoring.ui.container.logstash.enabled',
{ level: 'warning' }
),
renameFromRoot('xpack.monitoring.elasticsearch', 'monitoring.ui.elasticsearch'),
renameFromRoot('xpack.monitoring.ccs.enabled', 'monitoring.ui.ccs.enabled'),
renameFromRoot('xpack.monitoring.elasticsearch', 'monitoring.ui.elasticsearch', {
level: 'warning',
}),
renameFromRoot('xpack.monitoring.ccs.enabled', 'monitoring.ui.ccs.enabled', {
level: 'warning',
}),
renameFromRoot(
'xpack.monitoring.elasticsearch.logFetchCount',
'monitoring.ui.elasticsearch.logFetchCount'
'monitoring.ui.elasticsearch.logFetchCount',
{ level: 'warning' }
),
renameFromRoot('xpack.monitoring', 'monitoring'),
renameFromRoot('xpack.monitoring', 'monitoring', { level: 'warning' }),
(config, fromPath, addDeprecation) => {
const emailNotificationsEnabled = get(config, 'cluster_alerts.email_notifications.enabled');
if (emailNotificationsEnabled && !get(config, CLUSTER_ALERTS_ADDRESS_CONFIG_KEY)) {
@ -55,11 +67,14 @@ export const deprecations = ({
`Add [${fromPath}.${CLUSTER_ALERTS_ADDRESS_CONFIG_KEY}] to your kibana configs."`,
],
},
level: 'critical',
});
}
return config;
},
rename('xpack_api_polling_frequency_millis', 'licensing.api_polling_frequency'),
rename('xpack_api_polling_frequency_millis', 'licensing.api_polling_frequency', {
level: 'warning',
}),
// TODO: Add deprecations for "monitoring.ui.elasticsearch.username: elastic" and "monitoring.ui.elasticsearch.username: kibana".
// TODO: Add deprecations for using "monitoring.ui.elasticsearch.ssl.certificate" without "monitoring.ui.elasticsearch.ssl.key", and