github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Enable APM storybook publishing (#93353)

Browse source 
Changes to fix APM's Storybook setup were made in #93087 and #93294. This re-enables it and fixes a couple places where we weren't using a theme provider.
This commit is contained in:
Nathan L Smith 2021-03-08 10:39:25 -06:00 • committed by GitHub
parent adfbe976d6
commit 749a22989b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/scripts/jenkins_storybook.sh
View file

@ -7,7 +7,7 @@ node scripts/storybook --dll
cd "$KIBANA_DIR"
# yarn storybook --site apm # TODO re-enable after being fixed
yarn storybook --site apm
yarn storybook --site canvas
yarn storybook --site ci_composite
yarn storybook --site url_template_editor

23
x-pack/plugins/apm/public/components/alerting/error_count_alert_trigger/index.stories.tsx
View file

@ -8,6 +8,7 @@
import React from 'react';
import { MemoryRouter } from 'react-router-dom';
import { ErrorCountAlertTrigger } from '.';
import { EuiThemeProvider } from '../../../../../../../src/plugins/kibana_react/common';
import { ApmPluginContextValue } from '../../../context/apm_plugin/apm_plugin_context';
import {
mockApmPluginContextValue,
@ -19,15 +20,19 @@ export default {
component: ErrorCountAlertTrigger,
decorators: [
(Story: React.ComponentClass) => (
<MockApmPluginContextWrapper
value={(mockApmPluginContextValue as unknown) as ApmPluginContextValue}
>
<MemoryRouter>
<div style={{ width: 400 }}>
<Story />
</div>
</MemoryRouter>
</MockApmPluginContextWrapper>
<EuiThemeProvider>
<MockApmPluginContextWrapper
value={
(mockApmPluginContextValue as unknown) as ApmPluginContextValue
}
>
<MemoryRouter>
<div style={{ width: 400 }}>
<Story />
</div>
</MemoryRouter>
</MockApmPluginContextWrapper>
</EuiThemeProvider>
),
],
};

21
x-pack/plugins/apm/public/components/shared/ApmHeader/apm_header.stories.tsx
View file

@ -9,6 +9,7 @@ import { EuiTitle } from '@elastic/eui';
import React, { ComponentType } from 'react';
import { MemoryRouter } from 'react-router-dom';
import { HttpSetup } from '../../../../../../../src/core/public';
import { EuiThemeProvider } from '../../../../../../../src/plugins/kibana_react/common';
import { MockApmPluginContextWrapper } from '../../../context/apm_plugin/mock_apm_plugin_context';
import { MockUrlParamsContextProvider } from '../../../context/url_params_context/mock_url_params_context_provider';
import { createCallApmApi } from '../../../services/rest/createCallApmApi';
@ -22,15 +23,17 @@ export default {
createCallApmApi(({} as unknown) as HttpSetup);
return (
<MockUrlParamsContextProvider
params={{ rangeFrom: 'now-15m', rangeTo: 'now' }}
>
<MockApmPluginContextWrapper>
<MemoryRouter>
<Story />
</MemoryRouter>
</MockApmPluginContextWrapper>
</MockUrlParamsContextProvider>
<EuiThemeProvider>
<MockUrlParamsContextProvider
params={{ rangeFrom: 'now-15m', rangeTo: 'now' }}
>
<MockApmPluginContextWrapper>
<MemoryRouter>
<Story />
</MemoryRouter>
</MockApmPluginContextWrapper>
</MockUrlParamsContextProvider>
</EuiThemeProvider>
);
},
],