github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Do not expand index patterns by default (#11155) (#11162)

Browse source 
Updates the management screen for index patterns to make the field_stats behavior opt-in rather than the default. Also removes now-inaccurate warning about non-expanded wildcard patterns being non-performant.
This commit is contained in:
Matt Bargar 2017-04-11 17:55:37 -04:00 • committed by GitHub
parent af4de542d5
commit 74e2d44071
4 changed files with 10 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/core_plugins/kibana/public/management/sections/indices/_create.html
View file

@ -61,19 +61,10 @@
<div class="form-group" ng-if="canExpandIndices()">
<label>
<input ng-model="index.notExpandable" type="checkbox">
<span translate="KIBANA-NOT_EXPAND_INDEX_PATTERN"></span>
<small translate="KIBANA-NOT_RECOMMENDED"></small>
<input ng-model="index.expandable" type="checkbox">
<span translate="KIBANA-EXPAND_INDEX_PATTERN"></span>
</label>
<div ng-if="index.notExpandable" class="alert alert-info">
<span translate="KIBANA-NOT_EXPANDABLE"></span>
<span translate="KIBANA-ES_QUERY"></span>
<em translate="KIBANA-INDEX_NAME_VAR" translate-values="{ indexName: '{{index.name}}' }"></em>
<span translate="KIBANA-SEARCH_ALL_DATA"></span>
</div>
<p class="help-block" translate="KIBANA-WILDCARD_DEFAULT_EXPANDED_TO_CURRENT_TIME_RANGE"></p>
<p class="help-block">
@ -83,6 +74,8 @@
<em translate="KIBANA-EXAMPLE_TIME_RANGE"></em>
<span translate="KIBANA-FALL_WITHIN_CURRENT_TIME_RANGE"></span>
</p>
<p class="help-block" translate="KIBANA-EXPAND_INDEX_PATTERN_DEPRECATION"></p>
</div>
<div class="form-group time-and-pattern">

4
src/core_plugins/kibana/public/management/sections/indices/_create.js
View file

@ -24,7 +24,7 @@ uiModules.get('apps/management')
name: config.get('indexPattern:placeholder'),
isTimeBased: true,
nameIsPattern: false,
notExpandable: false,
expandable: false,
sampleCount: 5,
nameIntervalOptions: intervals,
@ -64,7 +64,7 @@ uiModules.get('apps/management')
}
}
if (index.notExpandable && $scope.canExpandIndices()) {
if (!index.expandable && $scope.canExpandIndices()) {
indexPattern.notExpandable = true;
}

19
src/core_plugins/kibana/public/management/sections/indices/_edit.html
View file

@ -49,25 +49,6 @@
</div>
</div>
<div
ng-if="!indexPattern.canExpandIndices()"
class="kuiInfoPanel kuiInfoPanel--warning kuiVerticalRhythm"
>
<div class="kuiInfoPanelHeader">
<span class="kuiInfoPanelHeader__icon kuiIcon kuiIcon--warning fa-bolt"></span>
<span class="kuiInfoPanelHeader__title">
Non-performant index pattern
</span>
</div>
<div class="kuiInfoPanelBody">
<div class="kuiInfoPanelBody__message">
This index pattern is set to be queried directly rather than being
expanded into more performant searches against individual indices.
</div>
</div>
</div>
<div
ng-if="conflictFields.length"
class="kuiInfoPanel kuiInfoPanel--warning kuiVerticalRhythm"

12
src/core_plugins/kibana/translations/en.json
View file

@ -17,18 +17,14 @@
"KIBANA-STATIC_TEXT_IN_DYNAMIC_INDEX_PATTERNS": "Patterns allow you to define dynamic index names. Static text in an index name is denoted using brackets. Example: [logstash-]YYYY.MM.DD. Please note that weeks are setup to use ISO weeks which start on Monday.",
"KIBANA-NOTE_COLON": "Note:",
"KIBANA-WEEKLY_ISO_NOTICE": "I noticed you are using weekly indices. Kibana requires ISO weeks be used in your index creation.",
"KIBANA-NOT_EXPAND_INDEX_PATTERN": "Do not expand index pattern when searching ",
"KIBANA-NOT_RECOMMENDED": "(Not recommended)",
"KIBANA-NOT_EXPANDABLE": "This index pattern will be queried directly rather than being expanded into more performant searches against individual indices.",
"KIBANA-ES_QUERY": "Elasticsearch will receive a query against ",
"KIBANA-INDEX_NAME_VAR": "{{indexName}} ",
"KIBANA-SEARCH_ALL_DATA": "and will have to search through all matching indices regardless of whether they have data that matches the current time range.",
"KIBANA-WILDCARD_DEFAULT_EXPANDED_TO_CURRENT_TIME_RANGE": "By default, searches against any time-based index pattern that contains a wildcard will automatically be expanded to query only the indices that contain data within the currently selected time range.",
"KIBANA-EXPAND_INDEX_PATTERN": "Expand index pattern when searching",
"KIBANA-WILDCARD_DEFAULT_EXPANDED_TO_CURRENT_TIME_RANGE": "With this option selected, searches against any time-based index pattern that contains a wildcard will automatically be expanded to query only the indices that contain data within the currently selected time range.",
"KIBANA-SEARCH_AGAINST_INDEX_PATTERN": "Searching against the index pattern ",
"KIBANA-LOGSTASH_WILDCARD": "logstash-*",
"KIBANA-ACTUALLY_QUERY": " will actually query elasticsearch for the specific matching indices (e.g. ",
"KIBANA-ACTUALLY_QUERY": " will actually query Elasticsearch for the specific matching indices (e.g. ",
"KIBANA-EXAMPLE_TIME_RANGE": "logstash-2015.12.21",
"KIBANA-FALL_WITHIN_CURRENT_TIME_RANGE": ") that fall within the current time range.",
"KIBANA-EXPAND_INDEX_PATTERN_DEPRECATION": "With recent changes to Elasticsearch, this option should no longer be necessary and will likely be removed in future versions of Kibana.",
"KIBANA-SAMPLE_ALERT": "Attempted to match the following indices and aliases:",
"KIBANA-EXPAND_SEARCH": "Expand Search",
"KIBANA-EXISTING_MATCH_PERCENT": "Pattern matches {{indexExistingMatchPercent}} of existing indices and aliases",