github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Remove redundant "Filter was added" toast (#155645)

Browse source 
Closes https://github.com/elastic/kibana/issues/154993

## Summary

This PR removes "Filter was added" toast (it was visible after adding
filters from the Doc Viewer flyout) which was not very useful. It's also
not shown when user adds filters from the grid or sidebar.
This commit is contained in:
Julia Rechkunova 2023-04-26 08:30:55 +02:00 • committed by GitHub
parent bd443eac1d
commit 7534cc7851
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 1 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx
View file

@ -217,18 +217,7 @@ export function DiscoverGridFlyout({
hit={actualHit}
columns={columns}
dataView={dataView}
filter={
onFilter
? (mapping, value, mode) => {
onFilter(mapping, value, mode);
services.toastNotifications.addSuccess(
i18n.translate('discover.grid.flyout.toastFilterAdded', {
defaultMessage: `Filter was added`,
})
);
}
: undefined
}
filter={onFilter}
onRemoveColumn={(columnName: string) => {
onRemoveColumn(columnName);
services.toastNotifications.addSuccess(

1
x-pack/plugins/translations/translations/fr-FR.json
View file

@ -2362,7 +2362,6 @@
"discover.grid.flyout.documentNavigation": "Navigation dans le document",
"discover.grid.flyout.toastColumnAdded": "La colonne \"{columnName}\" a été ajoutée.",
"discover.grid.flyout.toastColumnRemoved": "La colonne \"{columnName}\" a été supprimée.",
"discover.grid.flyout.toastFilterAdded": "Le filtre a été ajouté.",
"discover.grid.selectDoc": "Sélectionner le document \"{rowNumber}\"",
"discover.grid.tableRow.detailHeading": "Document développé",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "Document unique",

1
x-pack/plugins/translations/translations/ja-JP.json
View file

@ -2362,7 +2362,6 @@
"discover.grid.flyout.documentNavigation": "ドキュメントナビゲーション",
"discover.grid.flyout.toastColumnAdded": "列'{columnName}'が追加されました",
"discover.grid.flyout.toastColumnRemoved": "列'{columnName}'が削除されました",
"discover.grid.flyout.toastFilterAdded": "フィルターが追加されました",
"discover.grid.selectDoc": "ドキュメント'{rowNumber}'を選択",
"discover.grid.tableRow.detailHeading": "拡張ドキュメント",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "1つのドキュメント",

1
x-pack/plugins/translations/translations/zh-CN.json
View file

@ -2362,7 +2362,6 @@
"discover.grid.flyout.documentNavigation": "文档导航",
"discover.grid.flyout.toastColumnAdded": "已添加列“{columnName}”",
"discover.grid.flyout.toastColumnRemoved": "已移除列“{columnName}”",
"discover.grid.flyout.toastFilterAdded": "已添加筛选",
"discover.grid.selectDoc": "选择文档“{rowNumber}”",
"discover.grid.tableRow.detailHeading": "已展开文档",
"discover.grid.tableRow.viewSingleDocumentLinkTextSimple": "单个文档",