github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Console] Fix flaky tests and unskip the ones that now work (#193237)

Browse source
This commit is contained in:
Ignacio Rivas 2024-09-18 11:45:46 +03:00 • committed by GitHub
parent 6b2bdf93f0
commit 7549c11eb7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 22 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

10
test/functional/apps/console/_autocomplete.ts
View file

@ -62,8 +62,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
});
// FLAKY: https://github.com/elastic/kibana/issues/186501
describe.skip('Autocomplete behavior', () => {
describe('Autocomplete behavior', () => {
beforeEach(async () => {
await PageObjects.console.clearEditorText();
});
@ -86,11 +85,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
for (const [i, method] of methods.entries()) {
expect(await PageObjects.console.getAutocompleteSuggestion(i)).to.be.eql(method);
expect(await PageObjects.console.getAutocompleteSuggestion(i)).to.contain(method);
}
await PageObjects.console.pressEscape();
await PageObjects.console.clearEditorText();
await PageObjects.console.clickClearInput();
}
});
@ -354,8 +353,7 @@ GET _search
});
});
// FLAKY: https://github.com/elastic/kibana/issues/186935
describe.skip('index fields autocomplete', () => {
describe('index fields autocomplete', () => {
const indexName = `index_field_test-${Date.now()}-${Math.random()}`;
before(async () => {

3
test/functional/apps/console/_comments.ts
View file

@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const log = getService('log');
const PageObjects = getPageObjects(['common', 'console', 'header']);
// flaky
describe.skip('console app', function testComments() {
describe('console app', function testComments() {
this.tags('includeFirefox');
before(async () => {
log.debug('navigateTo console');

8
test/functional/apps/console/_console.ts
View file

@ -53,8 +53,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.console.isOutputPanelEmptyStateVisible()).to.be(false);
});
// the resizer doesn't work the same as in ace https://github.com/elastic/kibana/issues/184352
it.skip('should resize the editor', async () => {
it('should resize the editor', async () => {
const editor = await PageObjects.console.getEditor();
await browser.setWindowSize(1300, 1100);
const initialSize = await editor.getSize();
@ -149,7 +148,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.console.clearEditorText();
});
it('it should send successful request to Kibana API', async () => {
const expectedResponseContains = 'default space';
const expectedResponseContains = '"name": "Default"';
await PageObjects.console.enterText('GET kbn:/api/spaces/space');
await PageObjects.console.clickPlay();
await retry.try(async () => {
@ -160,8 +159,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
// Status badge is not yet implented in phase 2
describe.skip('with query params', () => {
describe('with query params', () => {
it('should issue a successful request', async () => {
await PageObjects.console.clearEditorText();
await PageObjects.console.enterText('GET _cat/aliases?format=json&v=true&pretty=true');

12
test/functional/apps/console/_misc_console_behavior.ts
View file

@ -25,6 +25,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.navigateToApp('console');
// Ensure that the text area can be interacted with
await PageObjects.console.skipTourIfExists();
await PageObjects.console.openConfig();
await PageObjects.console.toggleKeyboardShortcuts(true);
await PageObjects.console.openConsole();
});
beforeEach(async () => {
@ -131,13 +135,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});
// Settings not yet implemented
it.skip('can toggle keyboard shortcuts', async () => {
it('can toggle keyboard shortcuts', async () => {
// Enter a sample command
await PageObjects.console.enterText('GET _search');
// Disable keyboard shorcuts
await PageObjects.console.openConfig();
await PageObjects.console.toggleKeyboardShortcuts(false);
await PageObjects.console.openConsole();
// Upon clicking ctrl enter a newline character should be added to the editor
await PageObjects.console.pressCtrlEnter();
@ -145,11 +150,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await PageObjects.console.isOutputPanelEmptyStateVisible()).to.be(true);
// Restore setting
await PageObjects.console.openConfig();
await PageObjects.console.toggleKeyboardShortcuts(true);
await PageObjects.console.openConsole();
});
describe('customizable font size', () => {
// flaky
it('should allow the font size to be customized', async () => {
await PageObjects.console.openConfig();
await PageObjects.console.setFontSizeSetting(20);

8
test/functional/apps/console/_variables.ts
View file

@ -65,10 +65,12 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
});
});
describe.skip('with variables in request body', () => {
// bug in monaco https://github.com/elastic/kibana/issues/185999
it.skip('should send a successful request', async () => {
describe('with variables in request body', () => {
it('should send a successful request', async () => {
await PageObjects.console.openConfig();
await PageObjects.console.addNewVariable({ name: 'query1', value: '{"match_all": {}}' });
await PageObjects.console.openConsole();
await PageObjects.console.clickClearInput();
await PageObjects.console.enterText('\n GET _search\n');
await PageObjects.console.enterText(`{\n\t"query": "\${query1}"`);
await PageObjects.console.clickPlay();