github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

Make sure ESLint that should only work on TSX are set to only trigger on TSX files (#169361)

Browse source 
## Summary

This makes the newly created i18n ESLint rule actually activate on
paths, and narrows the use of the Telemetry ESLint rule to only activate
on .tsx files. This is done because the rule only makes sense in the
context of JSX.

## More words

Noticed that this:

```
        'x-pack/plugins/aiops/**/*.{tsx}',
        'x-pack/plugins/apm/**/*.{tsx}',
        'x-pack/plugins/exploratory_view/**/*.{tsx}',
```

does not work. 

This:

```
        'x-pack/plugins/aiops/**/*.tsx',
        'x-pack/plugins/apm/**/*.tsx',
        'x-pack/plugins/exploratory_view/**/*.tsx',
```

does.
This commit is contained in:
Coen Warmer 2023-10-19 14:17:25 +02:00 • committed by GitHub
parent f931fd8791
commit 7676cc4eb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

44
.eslintrc.js
View file

@ -910,17 +910,17 @@ module.exports = {
},
{
files: [
'x-pack/plugins/aiops/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/apm/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/exploratory_view/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/infra/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability_ai_assistant/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability_onboarding/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/observability_shared/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/profiling/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/synthetics/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/ux/**/*.{js,mjs,ts,tsx}',
'x-pack/plugins/aiops/**/*.tsx',
'x-pack/plugins/apm/**/*.tsx',
'x-pack/plugins/exploratory_view/**/*.tsx',
'x-pack/plugins/infra/**/*.tsx',
'x-pack/plugins/observability/**/*.tsx',
'x-pack/plugins/observability_ai_assistant/**/*.tsx',
'x-pack/plugins/observability_onboarding/**/*.tsx',
'x-pack/plugins/observability_shared/**/*.tsx',
'x-pack/plugins/profiling/**/*.tsx',
'x-pack/plugins/synthetics/**/*.tsx',
'x-pack/plugins/ux/**/*.tsx',
],
rules: {
'@kbn/telemetry/event_generating_elements_should_be_instrumented': 'error',
@ -928,17 +928,17 @@ module.exports = {
},
{
files: [
'x-pack/plugins/aiops/**/*.{tsx}',
'x-pack/plugins/apm/**/*.{tsx}',
'x-pack/plugins/exploratory_view/**/*.{tsx}',
'x-pack/plugins/infra/**/*.{tsx}',
'x-pack/plugins/observability/**/*.{tsx}',
'x-pack/plugins/observability_ai_assistant/**/*.{tsx}',
'x-pack/plugins/observability_onboarding/**/*.{tsx}',
'x-pack/plugins/observability_shared/**/*.{tsx}',
'x-pack/plugins/profiling/**/*.{tsx}',
'x-pack/plugins/synthetics/**/*.{tsx}',
'x-pack/plugins/ux/**/*.{tsx}',
'x-pack/plugins/aiops/**/*.tsx',
'x-pack/plugins/apm/**/*.tsx',
'x-pack/plugins/exploratory_view/**/*.tsx',
'x-pack/plugins/infra/**/*.tsx',
'x-pack/plugins/observability/**/*.tsx',
'x-pack/plugins/observability_ai_assistant/**/*.tsx',
'x-pack/plugins/observability_onboarding/**/*.tsx',
'x-pack/plugins/observability_shared/**/*.tsx',
'x-pack/plugins/profiling/**/*.tsx',
'x-pack/plugins/synthetics/**/*.tsx',
'x-pack/plugins/ux/**/*.tsx',
],
rules: {
'@kbn/i18n/strings_should_be_translated_with_i18n': 'warn',