github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 03:01:21 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix some type issues for APM UI (#167347)

Browse source 
## Summary

We're breaking https://github.com/elastic/kibana/pull/166813 up into
smaller PRs in the interest of getting PRs through sooner for type
fixes. These are the changes for APM UI.
This commit is contained in:
Brad White 2023-09-27 01:19:11 -06:00 • committed by GitHub
parent 26873aff87
commit 7a87c3615d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/apm/server/routes/assistant_functions/get_apm_service_summary/index.ts
View file

@ -275,6 +275,7 @@ export async function getApmServiceSummary({
start, start,
end, end,
serviceName, serviceName,
environment,
}), }),
getAnomalies({ getAnomalies({
serviceName, serviceName,

4
x-pack/plugins/observability_onboarding/public/components/app/custom_logs/install_elastic_agent.tsx
View file

@ -63,7 +63,7 @@ export function InstallElasticAgent() {
useState<ElasticAgentPlatform>('linux-tar'); useState<ElasticAgentPlatform>('linux-tar');
const enforcedDatasetName = const enforcedDatasetName =
integration === dataset ? dataset : `${integration}.${dataset}`; (integration === dataset ? dataset : `${integration}.${dataset}`) || '';
async function onContinue() { async function onContinue() {
await singleDatasetLocator!.navigate({ await singleDatasetLocator!.navigate({
@ -113,7 +113,7 @@ export function InstallElasticAgent() {
return callApi('POST /internal/observability_onboarding/logs/flow', { return callApi('POST /internal/observability_onboarding/logs/flow', {
params: { params: {
body: { body: {
name: datasetName, name: datasetName || '',
type: 'logFiles', type: 'logFiles',
state: { state: {
datasetName, datasetName,

2
x-pack/plugins/observability_onboarding/public/index.ts
View file

@ -17,7 +17,7 @@ import {
ObservabilityOnboardingPluginStart, ObservabilityOnboardingPluginStart,
} from './plugin'; } from './plugin';
export { OBSERVABILITY_ONBOARDING_LOCATOR } from './locators/onboarding_locator/locator_definition'; export type { OBSERVABILITY_ONBOARDING_LOCATOR } from './locators/onboarding_locator/locator_definition';
export type { ObservabilityOnboardingLocatorParams } from './locators/onboarding_locator/types'; export type { ObservabilityOnboardingLocatorParams } from './locators/onboarding_locator/types';
export interface ConfigSchema { export interface ConfigSchema {

2
x-pack/plugins/observability_onboarding/public/locators/onboarding_locator/locator_definition.ts
View file

@ -11,6 +11,8 @@ import {
OBSERVABILITY_ONBOARDING_LOCATOR, OBSERVABILITY_ONBOARDING_LOCATOR,
} from '@kbn/deeplinks-observability/locators'; } from '@kbn/deeplinks-observability/locators';
export type { OBSERVABILITY_ONBOARDING_LOCATOR } from '@kbn/deeplinks-observability/locators';
export class ObservabilityOnboardingLocatorDefinition export class ObservabilityOnboardingLocatorDefinition
implements LocatorDefinition<ObservabilityOnboardingLocatorParams> implements LocatorDefinition<ObservabilityOnboardingLocatorParams>
{ {

1
x-pack/plugins/observability_onboarding/public/locators/onboarding_locator/types.ts
View file

@ -8,5 +8,6 @@
import type { LocatorPublic } from '@kbn/share-plugin/public'; import type { LocatorPublic } from '@kbn/share-plugin/public';
import type { ObservabilityOnboardingLocatorParams } from '@kbn/deeplinks-observability/locators'; import type { ObservabilityOnboardingLocatorParams } from '@kbn/deeplinks-observability/locators';
export type { ObservabilityOnboardingLocatorParams } from '@kbn/deeplinks-observability/locators';
export type ObservabilityOnboardingLocator = export type ObservabilityOnboardingLocator =
LocatorPublic<ObservabilityOnboardingLocatorParams>; LocatorPublic<ObservabilityOnboardingLocatorParams>;