github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.x] [SecuritySolution][Endpoint] Re-enabled skipped tests (#197220) (#197380)

Browse source 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution][Endpoint] Re-enabled skipped tests
(#197220)](https://github.com/elastic/kibana/pull/197220)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-23T08:33:37Z","message":"[SecuritySolution][Endpoint]
Re-enabled skipped tests (#197220)\n\n## Summary\r\n\r\nThis PR attempts
to fix tests skipped in elastic/kibana/issues/193092\r\nand
elastic/kibana/issues/193554.\r\nThe tests seem to be flaky right after
an [upgrade
to\r\n`user-event`](https://github.com/elastic/kibana/pull/189949)
dependency\r\non Sep 10th.\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"e70b533bdb443a4ebc8229237583160eeeaad412","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","backport:version","v8.17.0"],"title":"[SecuritySolution][Endpoint]
Re-enabled skipped
tests","number":197220,"url":"https://github.com/elastic/kibana/pull/197220","mergeCommit":{"message":"[SecuritySolution][Endpoint]
Re-enabled skipped tests (#197220)\n\n## Summary\r\n\r\nThis PR attempts
to fix tests skipped in elastic/kibana/issues/193092\r\nand
elastic/kibana/issues/193554.\r\nThe tests seem to be flaky right after
an [upgrade
to\r\n`user-event`](https://github.com/elastic/kibana/pull/189949)
dependency\r\non Sep 10th.\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"e70b533bdb443a4ebc8229237583160eeeaad412"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197220","number":197220,"mergeCommit":{"message":"[SecuritySolution][Endpoint]
Re-enabled skipped tests (#197220)\n\n## Summary\r\n\r\nThis PR attempts
to fix tests skipped in elastic/kibana/issues/193092\r\nand
elastic/kibana/issues/193554.\r\nThe tests seem to be flaky right after
an [upgrade
to\r\n`user-event`](https://github.com/elastic/kibana/pull/189949)
dependency\r\non Sep 10th.\r\n\r\n### Checklist\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"e70b533bdb443a4ebc8229237583160eeeaad412"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2024-10-23 21:24:12 +11:00 • committed by GitHub
parent e42a5d3db6
commit 7c3334f03c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

22
x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_users_filter.test.tsx
View file

@ -15,9 +15,7 @@ import {
import { ActionsLogUsersFilter } from './actions_log_users_filter';
import { MANAGEMENT_PATH } from '../../../../../common/constants';
// FLAKY: https://github.com/elastic/kibana/issues/193554
// FLAKY: https://github.com/elastic/kibana/issues/193092
describe.skip('Users filter', () => {
describe('Users filter', () => {
let render: (
props?: React.ComponentProps<typeof ActionsLogUsersFilter>
) => ReturnType<AppContextTestRender['render']>;
@ -29,7 +27,7 @@ describe.skip('Users filter', () => {
const filterPrefix = 'users-filter';
let onChangeUsersFilter: jest.Mock;
beforeEach(async () => {
beforeEach(() => {
onChangeUsersFilter = jest.fn();
mockedContext = createAppRootMockRenderer();
({ history } = mockedContext);
@ -58,8 +56,8 @@ describe.skip('Users filter', () => {
render();
const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
await userEvent.type(searchInput, 'usernameX');
await userEvent.type(searchInput, '{enter}');
await userEvent.type(searchInput, 'usernameX', { delay: 10 });
await userEvent.keyboard('{enter}');
expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX']);
});
@ -67,8 +65,8 @@ describe.skip('Users filter', () => {
render();
const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
await userEvent.type(searchInput, 'usernameX,usernameY,usernameZ');
await userEvent.type(searchInput, '{enter}');
await userEvent.type(searchInput, 'usernameX,usernameY,usernameZ', { delay: 10 });
await userEvent.keyboard('{enter}');
expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX', 'usernameY', 'usernameZ']);
});
@ -76,8 +74,8 @@ describe.skip('Users filter', () => {
render();
const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
await userEvent.type(searchInput, ' usernameX ');
await userEvent.type(searchInput, '{enter}');
await userEvent.type(searchInput, ' usernameX ', { delay: 10 });
await userEvent.keyboard('{enter}');
expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX']);
});
@ -85,8 +83,8 @@ describe.skip('Users filter', () => {
render();
const searchInput = renderResult.getByTestId(`${testPrefix}-${filterPrefix}-search`);
await userEvent.type(searchInput, ' , usernameX ,usernameY , ');
await userEvent.type(searchInput, '{enter}');
await userEvent.type(searchInput, ' , usernameX ,usernameY , ', { delay: 10 });
await userEvent.keyboard('{enter}');
expect(onChangeUsersFilter).toHaveBeenCalledWith(['usernameX', 'usernameY']);
});
});