Remove several @ts-ignore/@ts-expect-errors around EUI imports (#163984)

## Summary

There's a few EUI imports out there that folks are reaching into
`@elastic/eui/lib/` for (which doesn't contain any types - something I'm
looking into separately) that could instead be imported at the top
`@elastic/eui` level, which is properly typed.

### Checklist

N/A - types only

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Cee Chen 2023-08-22 08:33:37 -07:00 committed by GitHub
parent c90e6d11c2
commit 7c896218dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
25 changed files with 44 additions and 56 deletions

View file

@ -9,8 +9,7 @@
import React from 'react';
import { mount, ReactWrapper } from 'enzyme';
import EuiCodeEditor from './code_editor';
// @ts-ignore
import { keys } from '@elastic/eui/lib/services';
import { keys } from '@elastic/eui';
import { findTestSubject, requiredProps, takeMountedSnapshot } from '@elastic/eui/lib/test';
describe('EuiCodeEditor', () => {

View file

@ -7,7 +7,7 @@
*/
import _ from 'lodash';
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
const thresholdLineDefaults = {
show: false,

View file

@ -7,8 +7,7 @@
*/
import { i18n } from '@kbn/i18n';
// @ts-ignore
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
import { Fit, Position } from '@elastic/charts';
import { AggGroupNames } from '@kbn/data-plugin/public';

View file

@ -7,8 +7,7 @@
*/
import { i18n } from '@kbn/i18n';
// @ts-ignore
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
import { Position } from '@elastic/charts';
import { AggGroupNames } from '@kbn/data-plugin/public';

View file

@ -7,8 +7,7 @@
*/
import { i18n } from '@kbn/i18n';
// @ts-ignore
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
import { Position } from '@elastic/charts';
import { AggGroupNames } from '@kbn/data-plugin/public';

View file

@ -7,8 +7,7 @@
*/
import { i18n } from '@kbn/i18n';
// @ts-ignore
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
import { Position, Fit } from '@elastic/charts';
import { AggGroupNames } from '@kbn/data-plugin/public';

View file

@ -8,8 +8,7 @@
import React, { FC } from 'react';
import { EuiBadge, EuiText, EuiToolTip } from '@elastic/eui';
// @ts-ignore
import { formatDate } from '@elastic/eui/lib/services/format';
import { formatDate } from '@elastic/eui';
const DATE_FORMAT = 'YYYY-MM-DD';
const TIME_FORMAT = 'HH:mm:ss';

View file

@ -19,8 +19,8 @@ import {
EuiIcon,
EuiHealth,
EuiToolTip,
RIGHT_ALIGNMENT,
} from '@elastic/eui';
import { RIGHT_ALIGNMENT } from '@elastic/eui/lib/services';
import styled from 'styled-components';
import { Status } from '@kbn/cases-components/src/status/status';
import type { UserProfileWithAvatar } from '@kbn/user-profile-components';

View file

@ -7,8 +7,7 @@
import React, { FC, ReactNode } from 'react';
import { EuiBasicTable, HorizontalAlignment, LEFT_ALIGNMENT, RIGHT_ALIGNMENT } from '@elastic/eui';
// @ts-ignore
import { formatDate } from '@elastic/eui/lib/services/format';
import { formatDate } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { i18n } from '@kbn/i18n';

View file

@ -6,8 +6,7 @@
*/
import { i18n } from '@kbn/i18n';
// @ts-ignore
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
export interface GenericIcon {
label: string;

View file

@ -13,8 +13,8 @@ import {
EuiFlexItem,
EuiButtonIcon,
EuiSpacer,
RIGHT_ALIGNMENT,
} from '@elastic/eui';
import { RIGHT_ALIGNMENT } from '@elastic/eui/lib/services';
import moment from 'moment';
import { i18n } from '@kbn/i18n';
import React, { useCallback, useMemo } from 'react';

View file

@ -7,26 +7,17 @@
import tinycolor from 'tinycolor2';
import {
// @ts-ignore
colorPalette as colorPaletteGenerator,
// @ts-ignore
euiPaletteForStatus,
// @ts-ignore
euiPaletteForTemperature,
// @ts-ignore
euiPaletteCool,
// @ts-ignore
euiPaletteWarm,
// @ts-ignore
euiPaletteNegative,
// @ts-ignore
euiPalettePositive,
// @ts-ignore
euiPaletteGray,
// @ts-ignore
euiPaletteColorBlind,
} from '@elastic/eui/lib/services';
import { EuiColorPalettePickerPaletteProps } from '@elastic/eui';
EuiColorPalettePickerPaletteProps,
} from '@elastic/eui';
import { PercentilesFieldMeta } from '../../../common/descriptor_types';
export const DEFAULT_HEATMAP_COLOR_RAMP_NAME = 'theclassic';

View file

@ -5,9 +5,8 @@
* 2.0.
*/
import { isValidHex } from '@elastic/eui';
import { isValidHex, euiPaletteColorBlind } from '@elastic/eui';
import _ from 'lodash';
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
const DEFAULT_CUSTOM_PALETTE = euiPaletteColorBlind({ rotations: 3 });

View file

@ -13,8 +13,7 @@ import {
ColorStaticStylePropertyDescriptor,
} from '../../../../../../common/descriptor_types';
import { COLOR_MAP_TYPE, FIELD_ORIGIN, STYLE_TYPE } from '../../../../../../common/constants';
// @ts-ignore
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
const blue = '#0000ff';
const yellow = '#ffff00';

View file

@ -25,12 +25,11 @@ import {
EuiLink,
EuiLoadingSpinner,
EuiToolTip,
RIGHT_ALIGNMENT,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { RIGHT_ALIGNMENT } from '@elastic/eui/lib/services';
import { addItemToRecentlyAccessed } from '../../../util/recently_accessed';
import { ml } from '../../../services/ml_api_service';
import { mlJobService } from '../../../services/job_service';

View file

@ -19,9 +19,11 @@ import {
EuiCallOut,
EuiButton,
EuiText,
LEFT_ALIGNMENT,
CENTER_ALIGNMENT,
SortableProperties,
} from '@elastic/eui';
import { LEFT_ALIGNMENT, CENTER_ALIGNMENT, SortableProperties } from '@elastic/eui/lib/services';
import { i18n } from '@kbn/i18n';
import { useMlKibana } from '../../../contexts/kibana';
import { ML_PAGES } from '../../../../../common/constants/locator';

View file

@ -6,10 +6,16 @@
*/
import React, { FC, Fragment, useEffect, useState } from 'react';
import { EuiCallOut, EuiFormRow, EuiPanel, EuiSpacer, EuiText } from '@elastic/eui';
import {
EuiCallOut,
EuiFormRow,
EuiPanel,
EuiSpacer,
EuiText,
LEFT_ALIGNMENT,
SortableProperties,
} from '@elastic/eui';
import { isEqual } from 'lodash';
// @ts-ignore no declaration
import { LEFT_ALIGNMENT, SortableProperties } from '@elastic/eui/lib/services';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { ES_FIELD_TYPES } from '@kbn/field-types';
@ -54,7 +60,7 @@ export const AnalysisFieldsTable: FC<{
unsupportedFieldsError,
setUnsupportedFieldsError,
}) => {
const [sortableProperties, setSortableProperties] = useState();
const [sortableProperties, setSortableProperties] = useState<SortableProperties<any>>();
const [currentPaginationData, setCurrentPaginationData] = useState<{
pageIndex: number;
itemsPerPage: number;

View file

@ -16,8 +16,8 @@ import {
EuiInMemoryTable,
EuiLink,
EuiLoadingSpinner,
formatNumber,
} from '@elastic/eui';
import { formatNumber } from '@elastic/eui/lib/services/format';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';

View file

@ -14,7 +14,7 @@
* @param {Integer} index: index of the chart series, 0-3
* @returns {String} Hex color to use for chart series at the given index
*/
import { euiPaletteColorBlind } from '@elastic/eui/lib/services';
import { euiPaletteColorBlind } from '@elastic/eui';
export function getColor(app, index) {
let seriesColors;

View file

@ -5,8 +5,7 @@
* 2.0.
*/
// @ts-expect-error no definitions in component folder
import { EuiButton } from '@elastic/eui/lib/components/button';
import { EuiButton } from '@elastic/eui';
import React from 'react';
import { renderToStaticMarkup } from 'react-dom/server';

View file

@ -5,8 +5,7 @@
* 2.0.
*/
// @ts-expect-error no definitions in component folder
import { EuiButton, EuiButtonEmpty } from '@elastic/eui/lib/components/button';
import { EuiButton, EuiButtonEmpty } from '@elastic/eui';
import React from 'react';
import type { IBasePath } from '@kbn/core/server';

View file

@ -8,8 +8,13 @@
import React, { useState, useMemo } from 'react';
import { FormattedMessage } from '@kbn/i18n-react';
import { orderBy } from 'lodash';
import { EuiBasicTable, EuiButtonIcon, EuiHealth } from '@elastic/eui';
import { RIGHT_ALIGNMENT } from '@elastic/eui/lib/services';
import {
EuiBasicTable,
EuiBasicTableColumn,
EuiButtonIcon,
EuiHealth,
RIGHT_ALIGNMENT,
} from '@elastic/eui';
import { SnapshotRestore } from '../../../../../../common/types';
import { UIM_RESTORE_LIST_EXPAND_INDEX } from '../../../../constants';
@ -94,7 +99,7 @@ export const RestoreTable: React.FunctionComponent<Props> = React.memo(({ restor
}, {} as { [key: string]: JSX.Element });
}, [expandedIndices, restores]);
const columns = [
const columns: Array<EuiBasicTableColumn<SnapshotRestore>> = [
{
field: 'index',
name: i18n.translate('xpack.snapshotRestore.restoreList.table.indexColumnTitle', {

View file

@ -5,8 +5,7 @@
* 2.0.
*/
// @ts-ignore formatNumber
import { formatNumber } from '@elastic/eui/lib/services/format';
import { formatNumber } from '@elastic/eui';
import {
EuiCallOut,
EuiCodeBlock,

View file

@ -10,7 +10,6 @@ import moment, { Duration } from 'moment';
import { padStart, chunk } from 'lodash';
import { EuiBasicTable, EuiToolTip } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { RIGHT_ALIGNMENT } from '@elastic/eui/lib/services';
import { AlertStatus, ALERT_STATUS_ACTIVE, ALERT_STATUS_RECOVERED } from '@kbn/rule-data-utils';
import { AlertStatusValues, MaintenanceWindow } from '@kbn/alerting-plugin/common';
import { DEFAULT_SEARCH_PAGE_SIZE } from '../../../constants';
@ -213,7 +212,7 @@ export const RuleAlertList = (props: RuleAlertListProps) => {
},
{
field: '',
align: RIGHT_ALIGNMENT,
align: 'right' as const,
width: '60px',
name: i18n.translate(
'xpack.triggersActionsUI.sections.ruleDetails.alertsList.columns.mute',

View file

@ -5,8 +5,7 @@
* 2.0.
*/
// @ts-ignore formatNumber
import { formatNumber } from '@elastic/eui/lib/services/format';
import { formatNumber } from '@elastic/eui';
import {
EuiCallOut,
EuiCodeBlock,