github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

cleanup dispose, bump VegaLite dep (#16066)

Browse source
This commit is contained in:
Yuri Astrakhan 2018-01-16 13:49:09 -05:00 • committed by GitHub
parent 2116eecb8a
commit 80a7340872
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -212,7 +212,7 @@
"uuid": "3.0.1",
"validate-npm-package-name": "2.2.2",
"vega": "3.0.8",
"vega-lite": "2.0.3",
"vega-lite": "2.0.4",
"vega-schema-url-parser": "1.0.0",
"vision": "4.1.0",
"webpack": "3.6.0",

3
src/core_plugins/vega/public/vega_view/vega_base_view.js
View file

@ -156,8 +156,7 @@ export class VegaBaseView {
// into the _ongoingDestroy promise, while handlers are being disposed
if (this._destroyHandlers) {
// If no destroy is yet running, execute all handlers and wait for all of them to resolve.
// Once done, keep the resolved promise, and get rid of any values returned from handlers.
this._ongoingDestroy = Promise.all(this._destroyHandlers.map(v => v())).then(() => 0);
this._ongoingDestroy = Promise.all(this._destroyHandlers.map(v => v()));
this._destroyHandlers = null;
}
return this._ongoingDestroy;

6
yarn.lock
View file

@ -11743,9 +11743,9 @@ vega-hierarchy@^2.1:
vega-dataflow "3"
vega-util "1"
vega-lite@2.0.3:
version "2.0.3"
resolved "https://registry.yarnpkg.com/vega-lite/-/vega-lite-2.0.3.tgz#3b42a3ee002cfd0d6c082a2b029d30f01c987ab4"
vega-lite@2.0.4:
version "2.0.4"
resolved "https://registry.yarnpkg.com/vega-lite/-/vega-lite-2.0.4.tgz#a30531e294dd2a831d96df05c58eed902d2cbb20"
dependencies:
json-stable-stringify "^1.0.1"
tslib "^1.8.0"