github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

Introduce workaround for vega height bug (#31461) (#31955)

Browse source
This commit is contained in:
Joe Reuter 2019-02-26 10:10:49 +01:00 • committed by GitHub
parent bc7ff50f15
commit 8125f044c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 50 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

43
src/legacy/core_plugins/vega/public/__tests__/vega_visualization.js
View file

@ -188,6 +188,49 @@ describe('VegaVisualizations', () => {
});
it('should add a small subpixel value to the height of the canvas to avoid getting it set to 0', async () => {
let vegaVis;
try {
vegaVis = new VegaVisualization(domNode, vis);
const vegaParser = new VegaParser(`{
"$schema": "https://vega.github.io/schema/vega/v3.json",
"marks": [
{
"type": "text",
"encode": {
"update": {
"text": {
"value": "Test"
},
"align": {"value": "center"},
"baseline": {"value": "middle"},
"xc": {"signal": "width/2"},
"yc": {"signal": "height/2"}
fontSize: {value: "14"}
}
}
}
]
}`, new SearchCache());
await vegaParser.parseAsync();
domNode.style.width = '256px';
domNode.style.height = '256px';
await vegaVis.render(vegaParser, { data: true });
const vegaView = vegaVis._vegaView._view;
expect(vegaView.height()).to.be(250.00000001);
vegaView.height(250);
await vegaView.runAsync();
// as soon as this test fails, the workaround with the subpixel value can be removed.
expect(vegaView.height()).to.be(0);
} finally {
vegaVis.destroy();
}
});
});

9
src/legacy/core_plugins/vega/public/vega_view/vega_base_view.js
View file

@ -195,8 +195,13 @@ export class VegaBaseView {
const heightExtraPadding = 6;
const width = Math.max(0, this._$container.width() - this._parser.paddingWidth);
const height = Math.max(0, this._$container.height() - this._parser.paddingHeight) - heightExtraPadding;
if (view.width() !== width || view.height() !== height) {
view.width(width).height(height);
// Somehow the `height` signal in vega becomes zero if the height is set exactly to
// an even number. This is a dirty workaround for this.
// when vega itself is updated again, it should be checked whether this is still
// necessary.
const adjustedHeight = height + 0.00000001;
if (view.width() !== width || view.height() !== adjustedHeight) {
view.width(width).height(adjustedHeight);
return true;
}
return false;