mirror of
https://github.com/elastic/kibana.git
synced 2025-04-24 09:48:58 -04:00
Clean up full errors being logged (#174440)
## Summary Fix a few logging calls where the full `Error` object was being logged, either as string representation in the message, or as log meta.
This commit is contained in:
parent
de961a54a7
commit
8186fc7300
5 changed files with 11 additions and 9 deletions
|
@ -285,8 +285,10 @@ describe('getPayloadSize', () => {
|
|||
} as unknown as Response,
|
||||
logger
|
||||
);
|
||||
expect(logger.warn.mock.calls[0][0]).toMatchInlineSnapshot(
|
||||
`"Failed to calculate response payload bytes."`
|
||||
);
|
||||
expect(logger.warn.mock.calls[0][0]).toMatchInlineSnapshot(`
|
||||
"Failed to calculate response payload bytes: Converting circular structure to JSON
|
||||
--> starting at object with constructor 'Object'
|
||||
--- property 'circular' closes the circle"
|
||||
`);
|
||||
});
|
||||
});
|
||||
|
|
|
@ -81,7 +81,7 @@ export function getResponsePayloadBytes(response: Response, log: Logger): number
|
|||
// We intentionally swallow any errors as this information is
|
||||
// only a nicety for logging purposes, and should not cause the
|
||||
// server to crash if it cannot be determined.
|
||||
log.warn('Failed to calculate response payload bytes.', e);
|
||||
log.warn(`Failed to calculate response payload bytes: ${e.message}`);
|
||||
}
|
||||
|
||||
return undefined;
|
||||
|
|
|
@ -97,7 +97,7 @@ export const convertModelVersionTransformFn = ({
|
|||
const result = modelTransformFn(doc, context);
|
||||
return { transformedDoc: result.document, additionalDocs: [] };
|
||||
} catch (error) {
|
||||
log.error(error);
|
||||
log.error(`Error trying to transform document: ${error.message}`);
|
||||
throw new TransformSavedObjectDocumentError(error, virtualVersion);
|
||||
}
|
||||
};
|
||||
|
|
|
@ -56,7 +56,7 @@ export function convertMigrationFunction(
|
|||
|
||||
return { transformedDoc: result, additionalDocs: [] };
|
||||
} catch (error) {
|
||||
log.error(error);
|
||||
log.error(`Error trying to transform document: ${error.message}`);
|
||||
throw new TransformSavedObjectDocumentError(error, version);
|
||||
}
|
||||
};
|
||||
|
|
|
@ -37,7 +37,7 @@ export async function bootstrap() {
|
|||
server = new Server({ config: configService, logger });
|
||||
serverStart = await server.start();
|
||||
} catch (e) {
|
||||
log.error(`Failed to start Server: ${e}`);
|
||||
log.error(`Failed to start Server: ${e.message}`);
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
|
@ -46,7 +46,7 @@ export async function bootstrap() {
|
|||
kibanaService = new KibanaService({ config: configService, logger });
|
||||
await kibanaService.start({ server: serverStart });
|
||||
} catch (e) {
|
||||
log.error(`Failed to start Kibana service: ${e}`);
|
||||
log.error(`Failed to start Kibana service: ${e.message}`);
|
||||
process.exit(1);
|
||||
}
|
||||
|
||||
|
@ -58,7 +58,7 @@ export async function bootstrap() {
|
|||
};
|
||||
|
||||
process.on('unhandledRejection', async (err: Error) => {
|
||||
log.error(err);
|
||||
log.error(`Unhandled rejection: ${err.message}`);
|
||||
await attemptGracefulShutdown(1);
|
||||
});
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue