github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 17:28:26 -04:00
Code Issues Projects Releases Packages Wiki Activity

Sustainable Kibana Architecture: Fix group inference logic: add missing packages folders (#201758)

Browse source 
## Summary

After relocating modules (plugins and packages) to their new folders,
according to the _Sustainable Kibana Architecture_ design, their groups
will be inferred based on their path.

The logic was taking into account plugins' folders, but not packages'
folders. This PR fixes that.
This commit is contained in:
Gerard Soldevila 2024-11-26 18:42:17 +01:00 • committed by GitHub
parent 310d922f13
commit 81993a10b9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 32 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

62
packages/kbn-repo-source-classifier/src/group.ts
View file

@ -19,36 +19,38 @@ const DEFAULT_MODULE_ATTRS: ModuleAttrs = {
visibility: 'shared',
};
const MODULE_GROUPING_BY_PATH: Record<string, ModuleAttrs> = {
'src/platform/plugins/shared': {
group: 'platform',
visibility: 'shared',
},
'src/platform/plugins/internal': {
group: 'platform',
visibility: 'private',
},
'x-pack/platform/plugins/shared': {
group: 'platform',
visibility: 'shared',
},
'x-pack/platform/plugins/internal': {
group: 'platform',
visibility: 'private',
},
'x-pack/solutions/observability/plugins': {
group: 'observability',
visibility: 'private',
},
'x-pack/solutions/security/plugins': {
group: 'security',
visibility: 'private',
},
'x-pack/solutions/search/plugins': {
group: 'search',
visibility: 'private',
},
};
const MODULE_GROUPING_BY_PATH: Record<string, ModuleAttrs> = ['packages', 'plugins']
.map<Record<string, ModuleAttrs>>((type) => ({
[`src/platform/${type}/shared`]: {
group: 'platform',
visibility: 'shared',
},
[`src/platform/${type}/private`]: {
group: 'platform',
visibility: 'private',
},
[`x-pack/platform/${type}/shared`]: {
group: 'platform',
visibility: 'shared',
},
[`x-pack/platform/${type}/private`]: {
group: 'platform',
visibility: 'private',
},
[`x-pack/solutions/observability/${type}`]: {
group: 'observability',
visibility: 'private',
},
[`x-pack/solutions/security/${type}`]: {
group: 'security',
visibility: 'private',
},
[`x-pack/solutions/search/${type}`]: {
group: 'search',
visibility: 'private',
},
}))
.reduce((acc, current) => ({ ...acc, ...current }), {});
/**
* Determine a plugin's grouping information based on the path where it is defined