github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Graph] Fix settings tabs when in dark mode (#165614)

Browse source 
## Summary

Fixes #165354 

Dark mode set at space level/Advanced settings

<img width="456" alt="Screenshot 2023-09-04 at 17 56 38"
src="09b8bf12-cb05-4766-aa91-3b30328997f0">

Light mode set at space level

<img width="465" alt="Screenshot 2023-09-04 at 17 57 06"
src="ec83372c-ff97-4825-bca4-b58a5b0e5cc5">

Dark mode set as profile setting:

<img width="451" alt="Screenshot 2023-09-04 at 17 55 40"
src="0d3065ed-099b-4b10-9008-4330345bb452">

Light mode set as profile setting:

<img width="440" alt="Screenshot 2023-09-04 at 17 56 05"
src="85a05df5-405f-494c-b14e-096d5e8d9a41">

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This commit is contained in:
Marco Liberati 2023-09-05 11:17:45 +02:00 • committed by GitHub
parent 531acda76c
commit 835e66a25d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
x-pack/plugins/graph/public/components/workspace_layout/workspace_top_nav_menu.tsx
View file

@ -12,7 +12,7 @@ import { AppMountParameters, Capabilities, CoreStart } from '@kbn/core/public';
import { useHistory, useLocation } from 'react-router-dom';
import { Start as InspectorPublicPluginStart, RequestAdapter } from '@kbn/inspector-plugin/public';
import { NavigationPublicPluginStart as NavigationStart } from '@kbn/navigation-plugin/public';
import { toMountPoint, wrapWithTheme } from '@kbn/kibana-react-plugin/public';
import { toMountPoint } from '@kbn/react-kibana-mount';
import { datasourceSelector, hasFieldsSelector } from '../../state_management';
import { GraphSavePolicy, GraphWorkspaceSavedObject, Workspace } from '../../types';
import { AsObservable, Settings, SettingsWorkspaceProps } from '../settings';
@ -162,12 +162,10 @@ export const WorkspaceTopNavMenu = (props: WorkspaceTopNavMenuProps) => {
props.coreStart.overlays.openFlyout(
toMountPoint(
wrapWithTheme(
<Provider store={store}>
<Settings observable={settingsObservable} />
</Provider>,
props.coreStart.theme.theme$
)
<Provider store={store}>
<Settings observable={settingsObservable} />
</Provider>,
{ theme: props.coreStart.theme, i18n: props.coreStart.i18n }
),
{
size: 'm',

1
x-pack/plugins/graph/tsconfig.json
View file

@ -46,6 +46,7 @@
"@kbn/content-management-table-list-view-table",
"@kbn/content-management-table-list-view",
"@kbn/core-ui-settings-browser",
"@kbn/react-kibana-mount",
],
"exclude": [
"target/**/*",