github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Reporting] Remove no longer relevant comment about frozen indices (#153359)

Browse source 
## Summary

close https://github.com/elastic/kibana/issues/152884 since
https://github.com/elastic/elasticsearch/pull/94377 was fixed. I tested
it, works well except for one thing I noticed deleting a PIT created for a frozen index
without `include_throttled=false` will result in a 404 error:

```
POST /test/_pit?keep_alive=1m // `test` index is frozen

// returns
{
  "id": "45XtAwAA"
}

DELETE /_pit
{
    "id" : "45XtAwAA"
}

// returns 404
{
  "succeeded": true,
  "num_freed": 0
}

```

Not sure if this expected
This commit is contained in:
Anton Dosov 2023-03-23 12:04:53 +01:00 • committed by GitHub
parent 97bca5019a
commit 847e78e65d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
x-pack/plugins/reporting/server/export_types/csv_searchsource/generate_csv/generate_csv.ts
View file

@ -66,10 +66,6 @@ export class CsvGenerator {
index: indexPatternTitle,
keep_alive: duration,
ignore_unavailable: true,
// TODO: currently this doesn't do anything as es has a bug that throttled indices are always included when using PIT api
// if es fixes the issue, everything should work as expected. Just needs to be tested and this comment removed
// if es decides to not fix, then we can close the issue and remove the `ignore_throttled` code from here
// https://github.com/elastic/kibana/issues/152884
// @ts-expect-error ignore_throttled is not in the type definition, but it is accepted by es
ignore_throttled: settings.includeFrozen ? false : undefined, // "true" will cause deprecation warnings logged in ES
},