Use actual listing limit in vis listing (#38246) (#39996)

This commit is contained in:
Tim Roes 2019-07-01 13:35:30 +02:00 committed by GitHub
parent 4e265b9d3d
commit 8557af8659
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 36 deletions

View file

@ -1,41 +1,13 @@
<div class="kuiViewContent kuiViewContent--constrainedWidth kuiViewContentItem"
data-test-subj="visualizeLandingPage"
>
<div class="kuiViewContentItem kuiVerticalRhythm" ng-if="listingController.showLimitError">
<div class="kuiInfoPanel kuiInfoPanel--warning">
<div class="kuiInfoPanelBody">
<div class="kuiInfoPanelBody__message">
<span
i18n-id="kbn.visualize.listing.listingLimitHelpText"
i18n-default-message="You have {totalItems} visualizations, but your &quot;listingLimit&quot;
setting prevents the table below from displaying more than {listingLimit}.
You can change this setting under"
i18n-values="{
totalItems: listingController.totalItems,
listingLimit: listingController.listingLimit
}"
i18n-description="Part of composite text kbn.visualize.listing.listingLimitHelpText +
kbn.visualize.listing.listingLimitAdvancedSettingsLinkText"
></span>
<a
kbn-href="#/management/kibana/settings"
class="kuiLink"
i18n-id="kbn.visualize.listing.listingLimitAdvancedSettingsLinkText"
i18n-default-message="Advanced Settings"
i18n-description="Part of composite text kbn.visualize.listing.listingLimitHelpText +
kbn.visualize.listing.listingLimitAdvancedSettingsLinkText"
></a>.
</div>
</div>
</div>
</div>
<visualize-listing-table
find-items="listingController.fetchItems"
delete-items="listingController.deleteSelectedItems"
create-item="listingController.createNewVis"
get-view-url="listingController.getViewUrl"
edit-item="listingController.editItem"
listing-limit="listingController.listingLimit"
></visualize-listing-table>
<new-vis-modal

View file

@ -84,8 +84,6 @@ export function VisualizeListingController($injector, createNewVis) {
return visualizationService.find(filter, config.get('savedObjects:listingLimit'))
.then(result => {
this.totalItems = result.total;
this.showLimitError = result.total > config.get('savedObjects:listingLimit');
this.listingLimit = config.get('savedObjects:listingLimit');
return {
total: result.total,
@ -104,4 +102,6 @@ export function VisualizeListingController($injector, createNewVis) {
defaultMessage: 'Visualize',
})
}]);
this.listingLimit = config.get('savedObjects:listingLimit');
}

View file

@ -49,7 +49,7 @@ class VisualizeListingTableUi extends Component {
deleteItems={capabilities.get().visualize.delete ? this.props.deleteItems : null}
editItem={capabilities.get().visualize.save ? this.props.editItem : null}
tableColumns={this.getTableColumns()}
listingLimit={100}
listingLimit={this.props.listingLimit}
initialFilter={''}
noItemsFragment={this.getNoItemsMessage()}
entityName={
@ -222,6 +222,7 @@ VisualizeListingTableUi.propTypes = {
createItem: PropTypes.func.isRequired,
getViewUrl: PropTypes.func.isRequired,
editItem: PropTypes.func.isRequired,
listingLimit: PropTypes.number.isRequired,
};
export const VisualizeListingTable = injectI18n(VisualizeListingTableUi);

View file

@ -2356,8 +2356,6 @@
"kbn.visualize.listing.createNew.title": "最初のビジュアライゼーションの作成",
"kbn.visualize.listing.experimentalTitle": "Experimental (実験的)",
"kbn.visualize.listing.experimentalTooltip": "このビジュアライゼーションは今後のリリースで変更または削除される可能性があり、SLA のサポート対象になりません。",
"kbn.visualize.listing.listingLimitAdvancedSettingsLinkText": "高度な設定",
"kbn.visualize.listing.listingLimitHelpText": "{totalItems} 個のダッシュボードがありますが、「listingLimit」の設定により {listingLimit} 個までしか下の表に表示できません。この設定は次の場所で変更できます",
"kbn.visualize.listing.noItemsMessage": "ビジュアライゼーションがないようです。",
"kbn.visualize.listing.noVisualizations.createVisualizationButtonLabel": "ビジュアライゼーションを作成",
"kbn.visualize.listing.noVisualizationsText": "ビジュアライゼーションがないようです。作ってみましょう!",

View file

@ -2356,8 +2356,6 @@
"kbn.visualize.listing.createNew.title": "创建首个可视化",
"kbn.visualize.listing.experimentalTitle": "实验性",
"kbn.visualize.listing.experimentalTooltip": "未来版本可能会更改或删除此可视化,其不受支持 SLA 的约束。",
"kbn.visualize.listing.listingLimitAdvancedSettingsLinkText": "高级设置",
"kbn.visualize.listing.listingLimitHelpText": "您有 {totalItems} 个可视化但“listingLimit”设置使得下表最多只能显示 {listingLimit} 个。此设置可在以下选项下更改:",
"kbn.visualize.listing.noItemsMessage": "看起来您还没有任何可视化。",
"kbn.visualize.listing.noVisualizations.createVisualizationButtonLabel": "创建可视化",
"kbn.visualize.listing.noVisualizationsText": "看起来您还没有任何可视化。开始创建一些吧!",