github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-06-28 11:05:39 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix crash caused by freezing Moment.js Locale objects in deepFreeze (#223133)

Browse source
This commit is contained in:
Steph Milovic 2025-06-09 15:04:08 -06:00 • committed by GitHub
parent 5f69154341
commit 855f1c62ef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/platform/packages/shared/kbn-std/src/deep_freeze.ts
View file

@ -8,6 +8,7 @@
*/ */
import type { RecursiveReadonly } from '@kbn/utility-types'; import type { RecursiveReadonly } from '@kbn/utility-types';
import moment from 'moment-timezone';
/** @public */ /** @public */
export type Freezable = { [k: string]: any } | any[]; export type Freezable = { [k: string]: any } | any[];
@ -23,8 +24,16 @@ export function deepFreeze<T extends Freezable>(object: T) {
// recursively frozen as well // recursively frozen as well
for (const value of Object.values(object)) { for (const value of Object.values(object)) {
if (value !== null && typeof value === 'object') { if (value !== null && typeof value === 'object') {
if (isMomentLocale(value)) {
// Skip moment.Locale instances, moment should not be frozen
continue;
}
deepFreeze(value); deepFreeze(value);
} }
} }
return Object.freeze(object) as RecursiveReadonly<T>; return Object.freeze(object) as RecursiveReadonly<T>;
} }
function isMomentLocale(obj: unknown): obj is moment.Locale {
return obj !== null && typeof obj === 'object' && '_longDateFormat' in obj;
}