github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.18] [APM] Fix missing exception stack trace (#208577) (#209495)

Browse source 
# Backport

This will backport the following commits from `main` to `8.18`:
- [[APM] Fix missing exception stack trace
(#208577)](https://github.com/elastic/kibana/pull/208577)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Milosz
Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-04T10:19:07Z","message":"[APM]
Fix missing exception stack trace (#208577)\n\nCloses #203359\r\n\r\n##
Summary\r\n\r\nFix the incorrect condition that prevents an exception
stack trace from\r\nbeing displayed.\r\n\r\n| before | after
|\r\n|-|-|\r\n| <img width=\"2560\" alt=\"Screenshot 2025-01-31 at 10 06
00\"\r\nsrc=\"https://github.com/user-attachments/assets/88656d5e-0964-4686-8a03-a07ab8459709\"\r\n/>
| <img width=\"2560\" alt=\"Screenshot 2025-01-31 at 10 06
38\"\r\nsrc=\"https://github.com/user-attachments/assets/037cbb98-d7cf-4388-8d94-80c32eb5b17f\"\r\n/>
|\r\n\r\n## AC:\r\n\r\n- [x] Exception stack trace is displayed in
APM,\r\n- [x] Tested with native Otel collector,\r\n- [x] ~~Wait until
data ingestion is fixed and changes can be tested\r\nwith v8.16 and
higher~~ (not applicable
anymore).","sha":"2fd10dbabe65896ab5031b9edb96654b80606fe7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-major","Team:obs-ux-infra_services","v9.1.0"],"title":"[APM]
Fix missing exception stack trace
","number":208577,"url":"https://github.com/elastic/kibana/pull/208577","mergeCommit":{"message":"[APM]
Fix missing exception stack trace (#208577)\n\nCloses #203359\r\n\r\n##
Summary\r\n\r\nFix the incorrect condition that prevents an exception
stack trace from\r\nbeing displayed.\r\n\r\n| before | after
|\r\n|-|-|\r\n| <img width=\"2560\" alt=\"Screenshot 2025-01-31 at 10 06
00\"\r\nsrc=\"https://github.com/user-attachments/assets/88656d5e-0964-4686-8a03-a07ab8459709\"\r\n/>
| <img width=\"2560\" alt=\"Screenshot 2025-01-31 at 10 06
38\"\r\nsrc=\"https://github.com/user-attachments/assets/037cbb98-d7cf-4388-8d94-80c32eb5b17f\"\r\n/>
|\r\n\r\n## AC:\r\n\r\n- [x] Exception stack trace is displayed in
APM,\r\n- [x] Tested with native Otel collector,\r\n- [x] ~~Wait until
data ingestion is fixed and changes can be tested\r\nwith v8.16 and
higher~~ (not applicable
anymore).","sha":"2fd10dbabe65896ab5031b9edb96654b80606fe7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208577","number":208577,"mergeCommit":{"message":"[APM]
Fix missing exception stack trace (#208577)\n\nCloses #203359\r\n\r\n##
Summary\r\n\r\nFix the incorrect condition that prevents an exception
stack trace from\r\nbeing displayed.\r\n\r\n| before | after
|\r\n|-|-|\r\n| <img width=\"2560\" alt=\"Screenshot 2025-01-31 at 10 06
00\"\r\nsrc=\"https://github.com/user-attachments/assets/88656d5e-0964-4686-8a03-a07ab8459709\"\r\n/>
| <img width=\"2560\" alt=\"Screenshot 2025-01-31 at 10 06
38\"\r\nsrc=\"https://github.com/user-attachments/assets/037cbb98-d7cf-4388-8d94-80c32eb5b17f\"\r\n/>
|\r\n\r\n## AC:\r\n\r\n- [x] Exception stack trace is displayed in
APM,\r\n- [x] Tested with native Otel collector,\r\n- [x] ~~Wait until
data ingestion is fixed and changes can be tested\r\nwith v8.16 and
higher~~ (not applicable
anymore).","sha":"2fd10dbabe65896ab5031b9edb96654b80606fe7"}}]}]
BACKPORT-->

Co-authored-by: Milosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
This commit is contained in:
Kibana Machine 2025-02-04 23:27:30 +11:00 • committed by GitHub
parent a8cfa7ae6b
commit 8607de6801
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
x-pack/solutions/observability/plugins/apm/server/routes/errors/get_error_groups/get_error_group_main_statistics.ts
View file

@ -176,7 +176,7 @@ export async function getErrorGroupMainStatistics({
error: {
...(event.error ?? {}),
exception:
(errorSource?.error.exception?.length ?? 0) > 1
(errorSource?.error.exception?.length ?? 0) > 0
? errorSource?.error.exception
: event?.error.exception && [event.error.exception],
},

2
x-pack/solutions/observability/plugins/apm/server/routes/errors/get_error_groups/get_error_sample_details.ts
View file

@ -159,7 +159,7 @@ export async function getErrorSampleDetails({
error: {
...errorFromFields.error,
exception:
(source?.error.exception?.length ?? 0) > 1
(source?.error.exception?.length ?? 0) > 0
? source?.error.exception
: errorFromFields?.error.exception && [errorFromFields.error.exception],
log: source?.error?.log,

2
x-pack/solutions/observability/plugins/apm/server/routes/mobile/crashes/get_crash_groups/get_crash_group_main_statistics.ts
View file

@ -142,7 +142,7 @@ export async function getMobileCrashGroupMainStatistics({
error: {
...(event.error ?? {}),
exception:
(errorSource?.error.exception?.length ?? 0) > 1
(errorSource?.error.exception?.length ?? 0) > 0
? errorSource?.error.exception
: event?.error.exception && [event.error.exception],
},

2
x-pack/solutions/observability/plugins/apm/server/routes/mobile/errors/get_mobile_error_group_main_statistics.ts
View file

@ -143,7 +143,7 @@ export async function getMobileErrorGroupMainStatistics({
error: {
...(event.error ?? {}),
exception:
(errorSource?.error.exception?.length ?? 0) > 1
(errorSource?.error.exception?.length ?? 0) > 0
? errorSource?.error.exception
: event?.error.exception && [event.error.exception],
},

2
x-pack/solutions/observability/plugins/apm/server/routes/traces/get_trace_items.ts
View file

@ -166,7 +166,7 @@ export async function getTraceItems({
error: {
...(event.error ?? {}),
exception:
(errorSource?.error.exception?.length ?? 0) > 1
(errorSource?.error.exception?.length ?? 0) > 0
? errorSource?.error.exception
: event?.error.exception && [event.error.exception],
log: errorSource?.error.log,