github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Security Solution][Detections] Remove the bulk editing feature switch (#125772)

Browse source 
**Addresses:** https://github.com/elastic/kibana/issues/125502

## Summary

Removed the `rulesBulkEditEnabled` experimental flag from the config and its usage from the client-side code.
This commit is contained in:
Georgii Gorbachev 2022-02-16 17:04:01 +03:00 • committed by GitHub
parent 6ca15e5b49
commit 86f212f6fe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

1
x-pack/plugins/security_solution/common/experimental_features.ts
View file

@ -22,7 +22,6 @@ export const allowedExperimentalValues = Object.freeze({
riskyHostsEnabled: false,
securityRulesCancelEnabled: false,
pendingActionResponsesWithAck: true,
rulesBulkEditEnabled: true,
policyListEnabled: false,
/**

47
x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/bulk_actions/use_bulk_actions.tsx
View file

@ -42,7 +42,6 @@ import { useHasActionsPrivileges } from '../use_has_actions_privileges';
import { useHasMlPermissions } from '../use_has_ml_permissions';
import { getCustomRulesCountFromCache } from './use_custom_rules_count';
import { useAppToasts } from '../../../../../../common/hooks/use_app_toasts';
import { useIsExperimentalFeatureEnabled } from '../../../../../../common/hooks/use_experimental_features';
import { convertRulesFilterToKQL } from '../../../../../containers/detection_engine/rules/utils';
import type {
@ -76,7 +75,6 @@ export const useBulkActions = ({
const [, dispatchToaster] = useStateToaster();
const hasActionsPrivileges = useHasActionsPrivileges();
const toasts = useAppToasts();
const isRulesBulkEditEnabled = useIsExperimentalFeatureEnabled('rulesBulkEditEnabled');
const getIsMounted = useIsMounted();
const filterQuery = convertRulesFilterToKQL(filterOptions);
@ -342,7 +340,7 @@ export const useBulkActions = ({
return [
{
id: 0,
title: isRulesBulkEditEnabled ? i18n.BULK_ACTION_MENU_TITLE : undefined,
title: i18n.BULK_ACTION_MENU_TITLE,
items: [
{
key: i18n.BULK_ACTION_ENABLE,
@ -353,7 +351,7 @@ export const useBulkActions = ({
onClick: handleActivateAction,
toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
toolTipPosition: 'right',
icon: isRulesBulkEditEnabled ? undefined : 'checkInCircleFilled',
icon: undefined,
},
{
key: i18n.BULK_ACTION_DUPLICATE,
@ -363,26 +361,22 @@ export const useBulkActions = ({
onClick: handleDuplicateAction,
toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
toolTipPosition: 'right',
icon: isRulesBulkEditEnabled ? undefined : 'crossInACircleFilled',
icon: undefined,
},
{
key: i18n.BULK_ACTION_INDEX_PATTERNS,
name: i18n.BULK_ACTION_INDEX_PATTERNS,
'data-test-subj': 'indexPatternsBulkEditRule',
disabled: isEditDisabled,
panel: 2,
},
{
key: i18n.BULK_ACTION_TAGS,
name: i18n.BULK_ACTION_TAGS,
'data-test-subj': 'tagsBulkEditRule',
disabled: isEditDisabled,
panel: 1,
},
...(isRulesBulkEditEnabled
? [
{
key: i18n.BULK_ACTION_INDEX_PATTERNS,
name: i18n.BULK_ACTION_INDEX_PATTERNS,
'data-test-subj': 'indexPatternsBulkEditRule',
disabled: isEditDisabled,
panel: 2,
},
{
key: i18n.BULK_ACTION_TAGS,
name: i18n.BULK_ACTION_TAGS,
'data-test-subj': 'tagsBulkEditRule',
disabled: isEditDisabled,
panel: 1,
},
]
: []),
{
key: i18n.BULK_ACTION_EXPORT,
name: i18n.BULK_ACTION_EXPORT,
@ -392,7 +386,7 @@ export const useBulkActions = ({
containsLoading ||
selectedRuleIds.length === 0,
onClick: handleExportAction,
icon: isRulesBulkEditEnabled ? undefined : 'exportAction',
icon: undefined,
},
{
key: i18n.BULK_ACTION_DISABLE,
@ -403,7 +397,7 @@ export const useBulkActions = ({
onClick: handleDeactivateActions,
toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
toolTipPosition: 'right',
icon: isRulesBulkEditEnabled ? undefined : 'copy',
icon: undefined,
},
{
key: i18n.BULK_ACTION_DELETE,
@ -421,7 +415,7 @@ export const useBulkActions = ({
? i18n.BATCH_ACTION_DELETE_SELECTED_IMMUTABLE
: undefined,
toolTipPosition: 'right',
icon: isRulesBulkEditEnabled ? undefined : 'trash',
icon: undefined,
},
],
},
@ -479,7 +473,6 @@ export const useBulkActions = ({
rules,
selectedRuleIds,
hasActionsPrivileges,
isRulesBulkEditEnabled,
isAllSelected,
loadingRuleIds,
hasMlPermissions,