github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Time to Visualize] Rename Visualize to Visualize Library (#91015)

Browse source 
* Renamed Visualize to Visualize Library
This commit is contained in:
Devon Thomson 2021-02-11 13:46:35 -05:00 • committed by GitHub
parent b4368bde14
commit 89327bf9de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 42 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/plugins/visualize/public/application/components/visualize_listing.tsx
View file

@ -69,12 +69,12 @@ export const VisualizeListing = () => {
chrome.setBreadcrumbs([
{
text: i18n.translate('visualize.visualizeListingBreadcrumbsTitle', {
defaultMessage: 'Visualize',
defaultMessage: 'Visualize Library',
}),
},
]);
chrome.docTitle.change(
i18n.translate('visualize.listingPageTitle', { defaultMessage: 'Visualize' })
i18n.translate('visualize.listingPageTitle', { defaultMessage: 'Visualize Library' })
);
});
useUnmount(() => closeNewVisModal.current());
@ -186,7 +186,7 @@ export const VisualizeListing = () => {
// for data exploration purposes
createItem={createNewVis}
tableCaption={i18n.translate('visualize.listing.table.listTitle', {
defaultMessage: 'Visualizations',
defaultMessage: 'Visualize Library',
})}
findItems={fetchItems}
deleteItems={visualizeCapabilities.delete ? deleteItems : undefined}
@ -204,7 +204,7 @@ export const VisualizeListing = () => {
defaultMessage: 'visualizations',
})}
tableListTitle={i18n.translate('visualize.listing.table.listTitle', {
defaultMessage: 'Visualizations',
defaultMessage: 'Visualize Library',
})}
toastNotifications={toastNotifications}
searchFilters={searchFilters}

2
src/plugins/visualize/public/application/utils/breadcrumbs.ts
View file

@ -18,7 +18,7 @@ export function getLandingBreadcrumbs() {
return [
{
text: i18n.translate('visualize.listing.breadcrumb', {
defaultMessage: 'Visualize',
defaultMessage: 'Visualize Library',
}),
href: `#${VisualizeConstants.LANDING_PAGE_PATH}`,
},

2
src/plugins/visualize/public/application/utils/utils.ts
View file

@ -15,7 +15,7 @@ import { VisualizeServices, VisualizeEditorVisInstance } from '../types';
export const addHelpMenuToAppChrome = (chrome: ChromeStart, docLinks: DocLinksStart) => {
chrome.setHelpExtension({
appName: i18n.translate('visualize.helpMenu.appName', {
defaultMessage: 'Visualize',
defaultMessage: 'Visualize Library',
}),
links: [
{

4
src/plugins/visualize/public/plugin.ts
View file

@ -133,7 +133,7 @@ export class VisualizePlugin
core.application.register({
id: VisualizeConstants.APP_ID,
title: 'Visualize',
title: 'Visualize Library',
order: 8000,
euiIconType: 'logoKibana',
defaultPath: '#/',
@ -224,7 +224,7 @@ export class VisualizePlugin
if (home) {
home.featureCatalogue.register({
id: 'visualize',
title: 'Visualize',
title: 'Visualize Library',
description: i18n.translate('visualize.visualizeDescription', {
defaultMessage:
'Create visualizations and aggregate data stores in your Elasticsearch indices.',

2
test/functional/apps/dashboard/edit_visualizations.js
View file

@ -104,7 +104,7 @@ export default function ({ getService, getPageObjects }) {
await PageObjects.visualize.saveVisualizationAndReturn();
await PageObjects.header.waitUntilLoadingHasFinished();
await appsMenu.clickLink('Visualize');
await appsMenu.clickLink('Visualize Library');
await PageObjects.common.clickConfirmOnModal();
expect(await testSubjects.exists('visualizationLandingPage')).to.be(true);
});

2
test/functional/page_objects/header_page.ts
View file

@ -27,7 +27,7 @@ export function HeaderPageProvider({ getService, getPageObjects }: FtrProviderCo
}
public async clickVisualize(ignoreAppLeaveWarning = false) {
await appsMenu.clickLink('Visualize', { category: 'kibana' });
await appsMenu.clickLink('Visualize Library', { category: 'kibana' });
await this.onAppLeaveWarning(ignoreAppLeaveWarning);
await this.awaitGlobalLoadingIndicatorHidden();
await retry.waitFor('Visualize app to be loaded', async () => {

2
x-pack/plugins/features/server/oss_features.ts
View file

@ -111,7 +111,7 @@ export const buildOSSFeatures = ({ savedObjectTypes, includeTimelion }: BuildOSS
{
id: 'visualize',
name: i18n.translate('xpack.features.visualizeFeatureName', {
defaultMessage: 'Visualize',
defaultMessage: 'Visualize Library',
}),
order: 700,
category: DEFAULT_APP_CATEGORIES.kibana,

24
x-pack/plugins/lens/public/app_plugin/app.test.tsx
View file

@ -393,7 +393,11 @@ describe('Lens App', () => {
const { component, services } = mountWith({});
expect(services.chrome.setBreadcrumbs).toHaveBeenCalledWith([
{ text: 'Visualize', href: '/testbasepath/app/visualize#/', onClick: expect.anything() },
{
text: 'Visualize Library',
href: '/testbasepath/app/visualize#/',
onClick: expect.anything(),
},
{ text: 'Create' },
]);
@ -403,7 +407,11 @@ describe('Lens App', () => {
});
expect(services.chrome.setBreadcrumbs).toHaveBeenCalledWith([
{ text: 'Visualize', href: '/testbasepath/app/visualize#/', onClick: expect.anything() },
{
text: 'Visualize Library',
href: '/testbasepath/app/visualize#/',
onClick: expect.anything(),
},
{ text: 'Daaaaaaadaumching!' },
]);
});
@ -417,7 +425,11 @@ describe('Lens App', () => {
expect(services.chrome.setBreadcrumbs).toHaveBeenCalledWith([
{ text: 'The Coolest Container Ever Made', onClick: expect.anything() },
{ text: 'Visualize', href: '/testbasepath/app/visualize#/', onClick: expect.anything() },
{
text: 'Visualize Library',
href: '/testbasepath/app/visualize#/',
onClick: expect.anything(),
},
{ text: 'Create' },
]);
@ -428,7 +440,11 @@ describe('Lens App', () => {
expect(services.chrome.setBreadcrumbs).toHaveBeenCalledWith([
{ text: 'The Coolest Container Ever Made', onClick: expect.anything() },
{ text: 'Visualize', href: '/testbasepath/app/visualize#/', onClick: expect.anything() },
{
text: 'Visualize Library',
href: '/testbasepath/app/visualize#/',
onClick: expect.anything(),
},
{ text: 'Daaaaaaadaumching!' },
]);
});

2
x-pack/plugins/lens/public/app_plugin/app.tsx
View file

@ -278,7 +278,7 @@ export function App({
e.preventDefault();
},
text: i18n.translate('xpack.lens.breadcrumbsTitle', {
defaultMessage: 'Visualize',
defaultMessage: 'Visualize Library',
}),
});
}

2
x-pack/test/functional/apps/lens/persistent_context.ts
View file

@ -49,7 +49,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'Sep 19, 2025 @ 06:31:44.000'
);
await filterBar.toggleFilterEnabled('ip');
await appsMenu.clickLink('Visualize', { category: 'kibana' });
await appsMenu.clickLink('Visualize Library', { category: 'kibana' });
await PageObjects.visualize.clickNewVisualization();
await PageObjects.visualize.waitForGroupsSelectPage();
await PageObjects.visualize.clickVisType('lens');

6
x-pack/test/functional/apps/visualize/feature_controls/visualize_security.ts
View file

@ -81,7 +81,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows visualize navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Visualize']);
expect(navLinks).to.eql(['Overview', 'Visualize Library']);
});
it(`landing page shows "Create new Visualization" button`, async () => {
@ -212,7 +212,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows visualize navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Visualize']);
expect(navLinks).to.eql(['Overview', 'Visualize Library']);
});
it(`landing page shows "Create new Visualization" button`, async () => {
@ -327,7 +327,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
it('shows visualize navlink', async () => {
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.eql(['Overview', 'Visualize']);
expect(navLinks).to.eql(['Overview', 'Visualize Library']);
});
it(`landing page shows "Create new Visualization" button`, async () => {

4
x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces.ts
View file

@ -44,7 +44,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
basePath: '/s/custom_space',
});
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).to.contain('Visualize');
expect(navLinks).to.contain('Visualize Library');
});
it(`can view existing Visualization`, async () => {
@ -85,7 +85,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
basePath: '/s/custom_space',
});
const navLinks = (await appsMenu.readLinks()).map((link) => link.text);
expect(navLinks).not.to.contain('Visualize');
expect(navLinks).not.to.contain('Visualize Library');
});
it(`create new visualization shows 404`, async () => {

8
x-pack/test/functional/apps/visualize/preserve_url.ts
View file

@ -27,7 +27,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.common.navigateToApp('visualize');
await PageObjects.visualize.openSavedVisualization('A Pie');
await PageObjects.common.navigateToApp('home');
await appsMenu.clickLink('Visualize');
await appsMenu.clickLink('Visualize Library');
await PageObjects.visChart.waitForVisualization();
const activeTitle = await globalNav.getLastBreadcrumb();
expect(activeTitle).to.be('A Pie');
@ -43,7 +43,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.spaceSelector.expectHomePage('another-space');
// other space
await appsMenu.clickLink('Visualize');
await appsMenu.clickLink('Visualize Library');
await PageObjects.visualize.openSavedVisualization('A Pie in another space');
await PageObjects.spaceSelector.openSpacesNav();
@ -51,7 +51,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.spaceSelector.expectHomePage('default');
// default space
await appsMenu.clickLink('Visualize');
await appsMenu.clickLink('Visualize Library');
await PageObjects.visChart.waitForVisualization();
const activeTitleDefaultSpace = await globalNav.getLastBreadcrumb();
expect(activeTitleDefaultSpace).to.be('A Pie');
@ -61,7 +61,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.spaceSelector.expectHomePage('another-space');
// other space
await appsMenu.clickLink('Visualize');
await appsMenu.clickLink('Visualize Library');
await PageObjects.visChart.waitForVisualization();
const activeTitleOtherSpace = await globalNav.getLastBreadcrumb();
expect(activeTitleOtherSpace).to.be('A Pie in another space');