github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 17:59:23 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.18] [Security Solution] Show banner to promote prebuilt rule customization in both Serverless and ESS (#218540) (#218594)

Browse source 
# Backport

This will backport the following commits from `main` to `8.18`:
- [[Security Solution] Show banner to promote prebuilt rule
customization in both Serverless and ESS
(#218540)](https://github.com/elastic/kibana/pull/218540)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nikita
Indik","email":"nikita.indik@elastic.co"},"sourceCommit":{"committedDate":"2025-04-17T17:11:47Z","message":"[Security
Solution] Show banner to promote prebuilt rule customization in both
Serverless and ESS (#218540)\n\n**Resolves:
https://github.com/elastic/kibana/issues/209000**\n**Related PR:
https://github.com/elastic/kibana/pull/213750**\n\n## Summary\n\nThis PR
updates the code to show a promo banner in the rules table. With\nthis
change, this banner will be shown in both ESS (8.18+) and\nServerless.
Previously it was shown only in ESS. In both ESS and\nServerless the
blog link is the same – this is expected and correct.\n\nWe couldn't add
a banner for Serverless earlier, because the blog post\nwas published on
the 8.18/9.0 release day. If we would have added it\nearlier, Serverless
users would click on a link at get a 404 page.\n\nExpected behaviour for
both ESS and Serverless:\n - Banner is visible above the rules table\n-
The link leads
to\nhttps://www.elastic.co/blog/security-prebuilt-rules-editing\n\n<img
width=\"1006\" alt=\"Scherm­afbeelding 2025-03-11 om 12 25
45\"\nsrc=\"https://github.com/user-attachments/assets/41d83db9-4bc4-433e-a7e2-c5ef1049a20c\"\n/>\n\n**Changes:**\n-
Adds a rule management table banner to promote prebuilt
rule\ncustomization in Serverless. Previously this banner was only shown
in\nESS. Banner is dismissible. Its state is stored in localStorage.\n-
Tweaks banner wording a bit as per docs
suggestion\n([comment](https://github.com/elastic/kibana/pull/213750/files#r1989313701))","sha":"40a91594350a02d6756caf78c7e337df65a48ecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection Rule
Management","Feature:Prebuilt Detection
Rules","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Security
Solution] Show banner to promote prebuilt rule customization in both
Serverless and
ESS","number":218540,"url":"https://github.com/elastic/kibana/pull/218540","mergeCommit":{"message":"[Security
Solution] Show banner to promote prebuilt rule customization in both
Serverless and ESS (#218540)\n\n**Resolves:
https://github.com/elastic/kibana/issues/209000**\n**Related PR:
https://github.com/elastic/kibana/pull/213750**\n\n## Summary\n\nThis PR
updates the code to show a promo banner in the rules table. With\nthis
change, this banner will be shown in both ESS (8.18+) and\nServerless.
Previously it was shown only in ESS. In both ESS and\nServerless the
blog link is the same – this is expected and correct.\n\nWe couldn't add
a banner for Serverless earlier, because the blog post\nwas published on
the 8.18/9.0 release day. If we would have added it\nearlier, Serverless
users would click on a link at get a 404 page.\n\nExpected behaviour for
both ESS and Serverless:\n - Banner is visible above the rules table\n-
The link leads
to\nhttps://www.elastic.co/blog/security-prebuilt-rules-editing\n\n<img
width=\"1006\" alt=\"Scherm­afbeelding 2025-03-11 om 12 25
45\"\nsrc=\"https://github.com/user-attachments/assets/41d83db9-4bc4-433e-a7e2-c5ef1049a20c\"\n/>\n\n**Changes:**\n-
Adds a rule management table banner to promote prebuilt
rule\ncustomization in Serverless. Previously this banner was only shown
in\nESS. Banner is dismissible. Its state is stored in localStorage.\n-
Tweaks banner wording a bit as per docs
suggestion\n([comment](https://github.com/elastic/kibana/pull/213750/files#r1989313701))","sha":"40a91594350a02d6756caf78c7e337df65a48ecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18","9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218540","number":218540,"mergeCommit":{"message":"[Security
Solution] Show banner to promote prebuilt rule customization in both
Serverless and ESS (#218540)\n\n**Resolves:
https://github.com/elastic/kibana/issues/209000**\n**Related PR:
https://github.com/elastic/kibana/pull/213750**\n\n## Summary\n\nThis PR
updates the code to show a promo banner in the rules table. With\nthis
change, this banner will be shown in both ESS (8.18+) and\nServerless.
Previously it was shown only in ESS. In both ESS and\nServerless the
blog link is the same – this is expected and correct.\n\nWe couldn't add
a banner for Serverless earlier, because the blog post\nwas published on
the 8.18/9.0 release day. If we would have added it\nearlier, Serverless
users would click on a link at get a 404 page.\n\nExpected behaviour for
both ESS and Serverless:\n - Banner is visible above the rules table\n-
The link leads
to\nhttps://www.elastic.co/blog/security-prebuilt-rules-editing\n\n<img
width=\"1006\" alt=\"Scherm­afbeelding 2025-03-11 om 12 25
45\"\nsrc=\"https://github.com/user-attachments/assets/41d83db9-4bc4-433e-a7e2-c5ef1049a20c\"\n/>\n\n**Changes:**\n-
Adds a rule management table banner to promote prebuilt
rule\ncustomization in Serverless. Previously this banner was only shown
in\nESS. Banner is dismissible. Its state is stored in localStorage.\n-
Tweaks banner wording a bit as per docs
suggestion\n([comment](https://github.com/elastic/kibana/pull/213750/files#r1989313701))","sha":"40a91594350a02d6756caf78c7e337df65a48ecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nikita Indik <nikita.indik@elastic.co>
This commit is contained in:
Kibana Machine 2025-04-18 11:25:09 +02:00 • committed by GitHub
parent d8e5155c84
commit 8c1a846ef9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/platform/packages/shared/kbn-doc-links/src/get_doc_links.ts
View file

@ -516,9 +516,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D
updatePrebuiltDetectionRules: isServerless
? `${SERVERLESS_DOCS}security-prebuilt-rules-management.html#update-prebuilt-rules`
: `${SECURITY_SOLUTION_DOCS}prebuilt-rules-management.html#update-prebuilt-rules`,
prebuiltRuleCustomizationPromoBlog: isServerless
? '' // URL for Serverless to be added later, once the blog post is published. Issue: https://github.com/elastic/kibana/issues/209000
: `${ELASTIC_WEBSITE_URL}blog/security-prebuilt-rules-editing`,
prebuiltRuleCustomizationPromoBlog: `${ELASTIC_WEBSITE_URL}blog/security-prebuilt-rules-editing`,
createEsqlRuleType: `${SECURITY_SOLUTION_DOCS}rules-ui-create.html#create-esql-rule`,
ruleUiAdvancedParams: `${SECURITY_SOLUTION_DOCS}rules-ui-create.html#rule-ui-advanced-params`,
entityAnalytics: {

3
x-pack/solutions/security/plugins/security_solution/public/detections/components/callouts/blog_post_prebuilt_rule_customization_callout/index.tsx
View file

@ -15,7 +15,6 @@ import { useKibana } from '../../../../common/lib/kibana';
import { BackgroundImageCallout } from '../background_image_callout';
export function BlogPostPrebuiltRuleCustomizationCallout() {
// URL is currently only available in ESS. So we are only showing this callout in ESS for now.
const blogPostUrl =
useKibana().services.docLinks.links.securitySolution.prebuiltRuleCustomizationPromoBlog;
@ -43,7 +42,7 @@ export function BlogPostPrebuiltRuleCustomizationCallout() {
dismiss(calloutMessage);
}, [dismiss, calloutMessage]);
if (blogPostUrl && isVisible(calloutMessage)) {
if (isVisible(calloutMessage)) {
return (
<>
<BackgroundImageCallout

2
x-pack/solutions/security/plugins/security_solution/public/detections/components/callouts/blog_post_prebuilt_rule_customization_callout/translations.ts
View file

@ -18,7 +18,7 @@ export const CALLOUT_DESCRIPTION = i18n.translate(
'xpack.securitySolution.detectionEngine.blogPostPrebuiltRuleCustomizationCallout.calloutDescription',
{
defaultMessage:
'Learn how to customize prebuilt rules and update them with the latest improvements.',
'Learn how to customize prebuilt rules and update them to get the latest improvements.',
}
);