github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[8.17] [SharedUX][A11y] Fix Share modal export icon focusable (#217313) (#217474)

Browse source 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[SharedUX][A11y] Fix Share modal export icon focusable
(#217313)](https://github.com/elastic/kibana/pull/217313)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Paulina
Shakirova","email":"paulina.shakirova@elastic.co"},"sourceCommit":{"committedDate":"2025-04-08T10:00:08Z","message":"[SharedUX][A11y]
Fix Share modal export icon focusable (#217313)\n\n## Summary\n\nThis PR
fixes [[Platform:Dashboards:DashboardViewMode] Tooltips on\nexport tab
on share panel are not announced because of lack of
focus\non](https://github.com/elastic/kibana/issues/214447) and fixes
[[a11y]\nIn the sharing menu the POST url info cannot be accessed with
the\nkeyboar](215991d)
issues.\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/9c8c532d-1628-4f57-a2f0-2fe1d09e5cb6\n\nAfter:
\n\n\nhttps://github.com/user-attachments/assets/d7716469-ad73-4241-934d-f9f4d23a1279","sha":"0a3e1fa3d8ed4c5741c10c7485fd7c6eb04d3a03","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","backport:prev-major","a11y","v9.1.0"],"title":"[SharedUX][A11y]
Fix Share modal export icon
focusable","number":217313,"url":"https://github.com/elastic/kibana/pull/217313","mergeCommit":{"message":"[SharedUX][A11y]
Fix Share modal export icon focusable (#217313)\n\n## Summary\n\nThis PR
fixes [[Platform:Dashboards:DashboardViewMode] Tooltips on\nexport tab
on share panel are not announced because of lack of
focus\non](https://github.com/elastic/kibana/issues/214447) and fixes
[[a11y]\nIn the sharing menu the POST url info cannot be accessed with
the\nkeyboar](215991d)
issues.\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/9c8c532d-1628-4f57-a2f0-2fe1d09e5cb6\n\nAfter:
\n\n\nhttps://github.com/user-attachments/assets/d7716469-ad73-4241-934d-f9f4d23a1279","sha":"0a3e1fa3d8ed4c5741c10c7485fd7c6eb04d3a03"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217313","number":217313,"mergeCommit":{"message":"[SharedUX][A11y]
Fix Share modal export icon focusable (#217313)\n\n## Summary\n\nThis PR
fixes [[Platform:Dashboards:DashboardViewMode] Tooltips on\nexport tab
on share panel are not announced because of lack of
focus\non](https://github.com/elastic/kibana/issues/214447) and fixes
[[a11y]\nIn the sharing menu the POST url info cannot be accessed with
the\nkeyboar](215991d)
issues.\n\nBefore:\n\n\nhttps://github.com/user-attachments/assets/9c8c532d-1628-4f57-a2f0-2fe1d09e5cb6\n\nAfter:
\n\n\nhttps://github.com/user-attachments/assets/d7716469-ad73-4241-934d-f9f4d23a1279","sha":"0a3e1fa3d8ed4c5741c10c7485fd7c6eb04d3a03"}}]}]
BACKPORT-->

Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
This commit is contained in:
Kibana Machine 2025-04-08 14:19:15 +02:00 • committed by GitHub
parent d568ede594
commit 8dee6a7414
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/plugins/share/public/components/tabs/export/export_content.tsx
View file

@ -18,13 +18,12 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiForm,
EuiIcon,
EuiRadioGroup,
EuiSpacer,
EuiSwitch,
EuiSwitchEvent,
EuiText,
EuiToolTip,
EuiIconTip,
type EuiRadioGroupOption,
} from '@elastic/eui';
import { SupportedExportTypes, ShareMenuItemV2 } from '../../../types';
@ -113,16 +112,14 @@ const ExportContentUi = ({
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiToolTip
<EuiIconTip
content={
<FormattedMessage
id="share.screenCapturePanelContent.optimizeForPrintingHelpText"
defaultMessage="Uses multiple pages, showing at most 2 visualizations per page "
/>
}
>
<EuiIcon type="questionInCircle" />
</EuiToolTip>
/>
</EuiFlexItem>
</EuiFlexGroup>
);
@ -152,7 +149,7 @@ const ExportContentUi = ({
</EuiCopy>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiToolTip
<EuiIconTip
content={
<EuiText size="s">
<FormattedMessage
@ -161,9 +158,7 @@ const ExportContentUi = ({
/>
</EuiText>
}
>
<EuiIcon type="questionInCircle" />
</EuiToolTip>
/>
</EuiFlexItem>
</EuiFlexGroup>
);