SKA: Unify serverless modules + storybook config (#211570)

## Summary

As part of the SKA, some groups of modules have been broken-down and
relocated in different folders, negatively impacting DX. This is the
case for `serverless` modules, that are spread across:
```
- packages/serverless  # storybook config
- src/platform/packages/private/serverless
- src/platform/packages/shared/serverless
```

The goal of this PR is to unify them back under
`src/platform/packages/shared/severless`.
In this scenario, I believe the simplification is worth the trade off.

CC @elastic/kibana-management @elastic/appex-sharedux WDYT?

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

.github/CODEOWNERS

@@ -140,7 +140,6 @@ packages/kbn-validate-next-docs-cli @elastic/kibana-operations
 packages/kbn-web-worker-stub @elastic/kibana-operations
 packages/kbn-whereis-pkg-cli @elastic/kibana-operations
 packages/kbn-yarn-lock-validator @elastic/kibana-operations
-packages/serverless/storybook/config @elastic/appex-sharedux
 src/core @elastic/kibana-core
 src/core/packages/analytics/browser @elastic/kibana-core
 src/core/packages/analytics/browser-internal @elastic/kibana-core
@@ -389,8 +388,6 @@ src/platform/packages/private/kbn-transpose-utils @elastic/kibana-visualizations
 src/platform/packages/private/kbn-ui-shared-deps-npm @elastic/kibana-operations
 src/platform/packages/private/kbn-ui-shared-deps-src @elastic/kibana-operations
 src/platform/packages/private/kbn-unsaved-changes-badge @elastic/kibana-data-discovery
-src/platform/packages/private/serverless/settings/common @elastic/appex-sharedux @elastic/kibana-management
-src/platform/packages/private/serverless/types @elastic/appex-sharedux
 src/platform/packages/private/shared-ux/page/analytics_no_data/impl @elastic/appex-sharedux
 src/platform/packages/private/shared-ux/page/analytics_no_data/mocks @elastic/appex-sharedux
 src/platform/packages/private/shared-ux/page/analytics_no_data/types @elastic/appex-sharedux
@@ -564,9 +561,12 @@ src/platform/packages/shared/response-ops/alerts-fields-browser @elastic/respons
 src/platform/packages/shared/response-ops/alerts-table @elastic/response-ops
 src/platform/packages/shared/response-ops/rule_form @elastic/response-ops
 src/platform/packages/shared/response-ops/rule_params @elastic/response-ops
+src/platform/packages/shared/serverless/settings/common @elastic/appex-sharedux @elastic/kibana-management
 src/platform/packages/shared/serverless/settings/observability_project @elastic/appex-sharedux @elastic/kibana-management @elastic/obs-ux-management-team
 src/platform/packages/shared/serverless/settings/search_project @elastic/search-kibana @elastic/kibana-management
 src/platform/packages/shared/serverless/settings/security_project @elastic/security-solution @elastic/kibana-management
+src/platform/packages/shared/serverless/storybook/config @elastic/appex-sharedux
+src/platform/packages/shared/serverless/types @elastic/appex-sharedux
 src/platform/packages/shared/shared-ux/avatar/solution @elastic/appex-sharedux
 src/platform/packages/shared/shared-ux/button_toolbar @elastic/appex-sharedux
 src/platform/packages/shared/shared-ux/button/exit_full_screen @elastic/appex-sharedux

package.json

@@ -868,13 +868,13 @@
     "@kbn/server-route-repository-client": "link:src/platform/packages/shared/kbn-server-route-repository-client",
     "@kbn/server-route-repository-utils": "link:src/platform/packages/shared/kbn-server-route-repository-utils",
     "@kbn/serverless": "link:x-pack/platform/plugins/shared/serverless",
-    "@kbn/serverless-common-settings": "link:src/platform/packages/private/serverless/settings/common",
+    "@kbn/serverless-common-settings": "link:src/platform/packages/shared/serverless/settings/common",
     "@kbn/serverless-observability": "link:x-pack/solutions/observability/plugins/serverless_observability",
     "@kbn/serverless-observability-settings": "link:src/platform/packages/shared/serverless/settings/observability_project",
     "@kbn/serverless-search": "link:x-pack/solutions/search/plugins/serverless_search",
     "@kbn/serverless-search-settings": "link:src/platform/packages/shared/serverless/settings/search_project",
     "@kbn/serverless-security-settings": "link:src/platform/packages/shared/serverless/settings/security_project",
-    "@kbn/serverless-types": "link:src/platform/packages/private/serverless/types",
+    "@kbn/serverless-types": "link:src/platform/packages/shared/serverless/types",
     "@kbn/session-notifications-plugin": "link:test/plugin_functional/plugins/session_notifications",
     "@kbn/session-view-plugin": "link:x-pack/solutions/security/plugins/session_view",
     "@kbn/share-examples-plugin": "link:examples/share_examples",
@@ -1495,7 +1495,7 @@
     "@kbn/scout-oblt": "link:x-pack/solutions/observability/packages/kbn-scout-oblt",
     "@kbn/scout-reporting": "link:packages/kbn-scout-reporting",
     "@kbn/security-api-integration-helpers": "link:x-pack/test/security_api_integration/packages/helpers",
-    "@kbn/serverless-storybook-config": "link:packages/serverless/storybook/config",
+    "@kbn/serverless-storybook-config": "link:src/platform/packages/shared/serverless/storybook/config",
     "@kbn/set-map": "link:packages/kbn-set-map",
     "@kbn/shared-ux-card-no-data-mocks": "link:src/platform/packages/shared/shared-ux/card/no_data/mocks",
     "@kbn/shared-ux-file-image-mocks": "link:src/platform/packages/shared/shared-ux/file/image/mocks",

src/dev/storybook/aliases.ts

@@ -69,7 +69,7 @@ export const storybookAliases = {
   // Skipped, please check and fix https://github.com/elastic/kibana/issues/207227
   // security_solution: 'x-pack/solutions/security/plugins/security_solution/.storybook',
   // security_solution_packages: 'x-pack/solutions/security/packages/storybook/config',
-  serverless: 'packages/serverless/storybook/config',
+  serverless: 'src/platform/packages/shared/serverless/storybook/config',
   shared_ux: 'src/platform/packages/private/shared-ux/storybook/config',
   threat_intelligence: 'x-pack/solutions/security/plugins/threat_intelligence/.storybook',
   triggers_actions_ui: 'x-pack/platform/plugins/shared/triggers_actions_ui/.storybook',

src/platform/packages/shared/serverless/settings/common/kibana.jsonc

@@ -6,5 +6,5 @@
     "@elastic/kibana-management"
   ],
   "group": "platform",
-  "visibility": "private"
-}
+  "visibility": "shared"
+}

src/platform/packages/shared/serverless/storybook/config/constants.ts

@@ -11,4 +11,5 @@
 export const TITLE = 'Serverless Storybook';
 
 /** The remote URL of the root from which Storybook loads stories for Serverless. */
-export const URL = 'https://github.com/elastic/kibana/tree/main/packages/serverless';
+export const URL =
+  'https://github.com/elastic/kibana/tree/main/src/platform/packages/shared/serverless';

src/platform/packages/shared/serverless/storybook/config/kibana.jsonc

@@ -2,5 +2,7 @@
   "type": "shared-common",
   "id": "@kbn/serverless-storybook-config",
   "owner": "@elastic/appex-sharedux",
+  "group": "platform",
+  "visibility": "shared",
   "devOnly": true
 }

src/platform/packages/shared/serverless/storybook/config/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "../../../../tsconfig.base.json",
+  "extends": "../../../../../../../tsconfig.base.json",
   "compilerOptions": {
     "outDir": "target/types",
     "types": [

src/platform/packages/shared/serverless/types/kibana.jsonc

@@ -5,5 +5,5 @@
     "@elastic/appex-sharedux"
   ],
   "group": "platform",
-  "visibility": "private"
-}
+  "visibility": "shared"
+}

tsconfig.base.json

@@ -1728,8 +1728,8 @@
       "@kbn/server-route-repository-utils/*": ["src/platform/packages/shared/kbn-server-route-repository-utils/*"],
       "@kbn/serverless": ["x-pack/platform/plugins/shared/serverless"],
       "@kbn/serverless/*": ["x-pack/platform/plugins/shared/serverless/*"],
-      "@kbn/serverless-common-settings": ["src/platform/packages/private/serverless/settings/common"],
-      "@kbn/serverless-common-settings/*": ["src/platform/packages/private/serverless/settings/common/*"],
+      "@kbn/serverless-common-settings": ["src/platform/packages/shared/serverless/settings/common"],
+      "@kbn/serverless-common-settings/*": ["src/platform/packages/shared/serverless/settings/common/*"],
       "@kbn/serverless-observability": ["x-pack/solutions/observability/plugins/serverless_observability"],
       "@kbn/serverless-observability/*": ["x-pack/solutions/observability/plugins/serverless_observability/*"],
       "@kbn/serverless-observability-settings": ["src/platform/packages/shared/serverless/settings/observability_project"],
@@ -1740,10 +1740,10 @@
       "@kbn/serverless-search-settings/*": ["src/platform/packages/shared/serverless/settings/search_project/*"],
       "@kbn/serverless-security-settings": ["src/platform/packages/shared/serverless/settings/security_project"],
       "@kbn/serverless-security-settings/*": ["src/platform/packages/shared/serverless/settings/security_project/*"],
-      "@kbn/serverless-storybook-config": ["packages/serverless/storybook/config"],
-      "@kbn/serverless-storybook-config/*": ["packages/serverless/storybook/config/*"],
-      "@kbn/serverless-types": ["src/platform/packages/private/serverless/types"],
-      "@kbn/serverless-types/*": ["src/platform/packages/private/serverless/types/*"],
+      "@kbn/serverless-storybook-config": ["src/platform/packages/shared/serverless/storybook/config"],
+      "@kbn/serverless-storybook-config/*": ["src/platform/packages/shared/serverless/storybook/config/*"],
+      "@kbn/serverless-types": ["src/platform/packages/shared/serverless/types"],
+      "@kbn/serverless-types/*": ["src/platform/packages/shared/serverless/types/*"],
       "@kbn/session-notifications-plugin": ["test/plugin_functional/plugins/session_notifications"],
       "@kbn/session-notifications-plugin/*": ["test/plugin_functional/plugins/session_notifications/*"],
       "@kbn/session-view-plugin": ["x-pack/solutions/security/plugins/session_view"],

yarn.lock

@@ -7321,7 +7321,7 @@
   version "0.0.0"
   uid ""
 
-"@kbn/serverless-common-settings@link:src/platform/packages/private/serverless/settings/common":
+"@kbn/serverless-common-settings@link:src/platform/packages/shared/serverless/settings/common":
   version "0.0.0"
   uid ""
 
@@ -7345,11 +7345,11 @@
   version "0.0.0"
   uid ""
 
-"@kbn/serverless-storybook-config@link:packages/serverless/storybook/config":
+"@kbn/serverless-storybook-config@link:src/platform/packages/shared/serverless/storybook/config":
   version "0.0.0"
   uid ""
 
-"@kbn/serverless-types@link:src/platform/packages/private/serverless/types":
+"@kbn/serverless-types@link:src/platform/packages/shared/serverless/types":
   version "0.0.0"
   uid ""