github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Discover] Unskip and improve runtime editor test (#126061) (#126270)

Browse source 
(cherry picked from commit 9b5ca19e49)

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
This commit is contained in:
Kibana Machine 2022-02-23 13:13:02 -05:00 • committed by GitHub
parent 3cf5d6df21
commit 8fab12616a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

45
test/functional/apps/discover/_runtime_fields_editor.ts
View file

@ -29,10 +29,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await fieldEditor.enableValue();
await fieldEditor.typeScript("emit('abc')");
await fieldEditor.save();
await PageObjects.header.waitUntilLoadingHasFinished();
};
// FLAKY: https://github.com/elastic/kibana/issues/123372
describe.skip('discover integration with runtime fields editor', function describeIndexTests() {
describe('discover integration with runtime fields editor', function describeIndexTests() {
before(async function () {
await security.testUser.setRoles(['kibana_admin', 'test_logstash_reader']);
await esArchiver.loadIfNeeded('test/functional/fixtures/es_archiver/logstash_functional');
@ -61,32 +61,35 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
it('allows creation of a new field', async function () {
await createRuntimeField('runtimefield');
await PageObjects.header.waitUntilLoadingHasFinished();
const field = '_runtimefield';
await createRuntimeField(field);
await retry.waitForWithTimeout('fieldNames to include runtimefield', 5000, async () => {
const fieldNames = await PageObjects.discover.getAllFieldNames();
return fieldNames.includes('runtimefield');
return fieldNames.includes(field);
});
});
it('allows editing of a newly created field', async function () {
await PageObjects.discover.editField('runtimefield');
await fieldEditor.setName('runtimefield edited');
const field = '_runtimefield-before-edit';
await createRuntimeField(field);
const newFieldName = '_runtimefield-after-edit';
await PageObjects.discover.editField(field);
await fieldEditor.setName(newFieldName, true);
await fieldEditor.save();
await fieldEditor.confirmSave();
await PageObjects.header.waitUntilLoadingHasFinished();
await retry.waitForWithTimeout('fieldNames to include edits', 5000, async () => {
const fieldNames = await PageObjects.discover.getAllFieldNames();
return fieldNames.includes('runtimefield edited');
return fieldNames.includes(newFieldName);
});
});
it('allows creation of a new field and use it in a saved search', async function () {
await createRuntimeField('discover runtimefield');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.clickFieldListItemAdd('discover runtimefield');
expect(await PageObjects.discover.getDocHeader()).to.have.string('discover runtimefield');
const fieldName = '_runtimefield-saved-search';
await createRuntimeField(fieldName);
await PageObjects.discover.clickFieldListItemAdd(fieldName);
expect(await PageObjects.discover.getDocHeader()).to.have.string(fieldName);
expect(await PageObjects.discover.saveSearch('Saved Search with runtimefield'));
await PageObjects.header.waitUntilLoadingHasFinished();
@ -95,24 +98,25 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.loadSavedSearch('Saved Search with runtimefield');
await PageObjects.header.waitUntilLoadingHasFinished();
expect(await PageObjects.discover.getDocHeader()).to.have.string('discover runtimefield');
expect(await PageObjects.discover.getDocHeader()).to.have.string(fieldName);
});
it('deletes a runtime field', async function () {
await createRuntimeField('delete');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.removeField('delete');
const fieldName = '_runtimefield-to-delete';
await createRuntimeField(fieldName);
await PageObjects.discover.removeField(fieldName);
await fieldEditor.confirmDelete();
await PageObjects.header.waitUntilLoadingHasFinished();
await retry.waitForWithTimeout('fieldNames to include edits', 5000, async () => {
const fieldNames = await PageObjects.discover.getAllFieldNames();
return !fieldNames.includes('delete');
return !fieldNames.includes(fieldName);
});
});
it('doc view includes runtime fields', async function () {
// navigate to doc view
const fieldName = '_runtimefield-doc-view';
await createRuntimeField(fieldName);
const table = await PageObjects.discover.getDocTable();
const useLegacyTable = await PageObjects.discover.useLegacyTable();
await table.clickRowToggle();
@ -136,10 +140,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// Maybe loading has not completed
throw new Error('test subject doc-hit is not yet displayed');
}
const runtimeFieldsRow = await testSubjects.exists(
'tableDocViewRow-discover runtimefield'
);
const runtimeFieldsRow = await testSubjects.exists(`tableDocViewRow-${fieldName}-value`);
return hasDocHit && runtimeFieldsRow;
}
);