github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] Keep rule editor flyout open on refresh (#53458) (#53496)

Browse source 
* [ML] prevent AnomaliesTable re-render

* [ML] 50935 update titles to sentence case

* [ML] update snapshots
This commit is contained in:
Dima Arnautov 2019-12-18 10:29:54 -08:00 • committed by GitHub
parent 99818e4090
commit 8fc24fe2a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 36 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

8
x-pack/legacy/plugins/ml/public/application/components/rule_editor/__snapshots__/rule_editor_flyout.test.js.snap generated
View file

@ -26,7 +26,7 @@ exports[`RuleEditorFlyout renders the flyout after adding a condition to a rule
id="flyoutTitle"
>
<FormattedMessage
defaultMessage="Create Rule"
defaultMessage="Create rule"
id="xpack.ml.ruleEditor.ruleEditorFlyout.createRuleTitle"
values={Object {}}
/>
@ -276,7 +276,7 @@ exports[`RuleEditorFlyout renders the flyout after setting the rule to edit 1`]
id="flyoutTitle"
>
<FormattedMessage
defaultMessage="Edit Rule"
defaultMessage="Edit rule"
id="xpack.ml.ruleEditor.ruleEditorFlyout.editRuleTitle"
values={Object {}}
/>
@ -540,7 +540,7 @@ exports[`RuleEditorFlyout renders the flyout for creating a rule with conditions
id="flyoutTitle"
>
<FormattedMessage
defaultMessage="Create Rule"
defaultMessage="Create rule"
id="xpack.ml.ruleEditor.ruleEditorFlyout.createRuleTitle"
values={Object {}}
/>
@ -782,7 +782,7 @@ exports[`RuleEditorFlyout renders the select action component for a detector wit
id="flyoutTitle"
>
<FormattedMessage
defaultMessage="Edit Rules"
defaultMessage="Edit rules"
id="xpack.ml.ruleEditor.ruleEditorFlyout.editRulesTitle"
values={Object {}}
/>

6
x-pack/legacy/plugins/ml/public/application/components/rule_editor/rule_editor_flyout.js
View file

@ -510,7 +510,7 @@ export const RuleEditorFlyout = injectI18n(
<h1 id="flyoutTitle">
<FormattedMessage
id="xpack.ml.ruleEditor.ruleEditorFlyout.editRulesTitle"
defaultMessage="Edit Rules"
defaultMessage="Edit rules"
/>
</h1>
</EuiTitle>
@ -569,12 +569,12 @@ export const RuleEditorFlyout = injectI18n(
{isCreate === true ? (
<FormattedMessage
id="xpack.ml.ruleEditor.ruleEditorFlyout.createRuleTitle"
defaultMessage="Create Rule"
defaultMessage="Create rule"
/>
) : (
<FormattedMessage
id="xpack.ml.ruleEditor.ruleEditorFlyout.editRuleTitle"
defaultMessage="Edit Rule"
defaultMessage="Edit rule"
/>
)}
</h1>

24
x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/__snapshots__/rule_action_panel.test.js.snap generated
View file

@ -11,7 +11,7 @@ exports[`RuleActionPanel renders panel for rule with a condition 1`] = `
Object {
"description": "skip result when actual is less than 1",
"title": <FormattedMessage
defaultMessage="rule"
defaultMessage="Rule"
id="xpack.ml.ruleEditor.ruleActionPanel.ruleTitle"
values={Object {}}
/>,
@ -40,7 +40,11 @@ exports[`RuleActionPanel renders panel for rule with a condition 1`] = `
conditionValue={1}
updateConditionValue={[Function]}
/>,
"title": "actions",
"title": <FormattedMessage
defaultMessage="Actions"
id="xpack.ml.ruleEditor.ruleActionPanel.actionsTitle"
values={Object {}}
/>,
},
Object {
"description": <ForwardRef
@ -79,7 +83,7 @@ exports[`RuleActionPanel renders panel for rule with a condition and scope, valu
Object {
"description": "skip model update when airline is not in eu-airlines",
"title": <FormattedMessage
defaultMessage="rule"
defaultMessage="Rule"
id="xpack.ml.ruleEditor.ruleActionPanel.ruleTitle"
values={Object {}}
/>,
@ -90,7 +94,11 @@ exports[`RuleActionPanel renders panel for rule with a condition and scope, valu
fieldValue="AAL"
filterId="eu-airlines"
/>,
"title": "actions",
"title": <FormattedMessage
defaultMessage="Actions"
id="xpack.ml.ruleEditor.ruleActionPanel.actionsTitle"
values={Object {}}
/>,
},
Object {
"description": <ForwardRef
@ -129,7 +137,7 @@ exports[`RuleActionPanel renders panel for rule with scope, value in filter list
Object {
"description": "skip model update when airline is not in eu-airlines",
"title": <FormattedMessage
defaultMessage="rule"
defaultMessage="Rule"
id="xpack.ml.ruleEditor.ruleActionPanel.ruleTitle"
values={Object {}}
/>,
@ -144,7 +152,11 @@ exports[`RuleActionPanel renders panel for rule with scope, value in filter list
values={Object {}}
/>
</ForwardRef>,
"title": "actions",
"title": <FormattedMessage
defaultMessage="Actions"
id="xpack.ml.ruleEditor.ruleActionPanel.actionsTitle"
values={Object {}}
/>,
},
Object {
"description": <DeleteRuleModal

9
x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/rule_action_panel.js
View file

@ -153,7 +153,7 @@ export class RuleActionPanel extends Component {
title: (
<FormattedMessage
id="xpack.ml.ruleEditor.ruleActionPanel.ruleTitle"
defaultMessage="rule"
defaultMessage="Rule"
/>
),
description: buildRuleDescription(this.rule, this.props.anomaly),
@ -186,7 +186,12 @@ export class RuleActionPanel extends Component {
});
}
descriptionListItems[1].title = 'actions';
descriptionListItems[1].title = (
<FormattedMessage
id="xpack.ml.ruleEditor.ruleActionPanel.actionsTitle"
defaultMessage="Actions"
/>
);
return (
<EuiPanel paddingSize="m" className="select-rule-action-panel">

2
x-pack/legacy/plugins/ml/public/application/components/rule_editor/select_rule_action/select_rule_action.js
View file

@ -59,7 +59,7 @@ export function SelectRuleAction({
<EuiText style={{ display: 'inline' }}>
<FormattedMessage
id="xpack.ml.ruleEditor.selectRuleAction.orText"
defaultMessage="or&nbsp;"
defaultMessage="Or&nbsp;"
/>
</EuiText>
</React.Fragment>

8
x-pack/legacy/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
View file

@ -1530,13 +1530,11 @@ export class TimeSeriesExplorer extends React.Component {
</EuiFlexItem>
</EuiFlexGroup>
<EuiSpacer size="m" />
<AnomaliesTable
tableData={tableData}
filter={this.tableFilter}
timefilter={timefilter}
/>
</EuiText>
)}
{arePartitioningFieldsProvided && jobs.length > 0 && (
<AnomaliesTable tableData={tableData} filter={this.tableFilter} timefilter={timefilter} />
)}
</TimeSeriesExplorerPage>
);
}