github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-23 09:19:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Add assertCloseTo calls to prevent off-by-one errors in unit tests for backend adapter. (#49928) (#49949)

Browse source
This commit is contained in:
Justin Kambic 2019-11-01 12:27:59 -04:00 • committed by GitHub
parent 7990eb9b6a
commit 908ec4c823
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
x-pack/legacy/plugins/uptime/server/lib/adapters/pings/__tests__/elasticsearch_pings_adapter.test.ts
View file

@ -7,6 +7,7 @@
import { set } from 'lodash';
import { DatabaseAdapter } from '../../database';
import { ElasticsearchPingsAdapter } from '../elasticsearch_pings_adapter';
import { assertCloseTo } from '../../../helper';
describe('ElasticsearchPingsAdapter class', () => {
let database: DatabaseAdapter;
@ -115,6 +116,8 @@ describe('ElasticsearchPingsAdapter class', () => {
};
const pingAdapter = new ElasticsearchPingsAdapter(pingDatabase);
const result = await pingAdapter.getPingHistogram(serverRequest, 'now-15m', 'now', null);
assertCloseTo(result.interval, 36000, 100);
result.interval = 36000;
expect(pingDatabase.search).toHaveBeenCalledTimes(1);
expect(result).toMatchSnapshot();
});
@ -132,6 +135,8 @@ describe('ElasticsearchPingsAdapter class', () => {
};
const pingAdapter = new ElasticsearchPingsAdapter(pingDatabase);
const result = await pingAdapter.getPingHistogram(serverRequest, 'now-15m', 'now', null);
assertCloseTo(result.interval, 36000, 100);
result.interval = 36000;
expect(pingDatabase.search).toHaveBeenCalledTimes(1);
expect(result).toMatchSnapshot();
@ -197,6 +202,8 @@ describe('ElasticsearchPingsAdapter class', () => {
undefined,
'down'
);
assertCloseTo(result.interval, 5609564928000, 1000);
result.interval = 5609564928000;
expect(pingDatabase.search).toHaveBeenCalledTimes(1);
expect(result).toMatchSnapshot();
@ -254,6 +261,8 @@ describe('ElasticsearchPingsAdapter class', () => {
searchFilter
);
assertCloseTo(result.interval, 36000, 100);
result.interval = 36000;
expect(pingDatabase.search).toHaveBeenCalledTimes(1);
expect(result).toMatchSnapshot();
});
@ -276,6 +285,8 @@ describe('ElasticsearchPingsAdapter class', () => {
undefined,
'down'
);
assertCloseTo(result.interval, 5609564928000, 1000);
result.interval = 5609564928000;
expect(pingDatabase.search).toHaveBeenCalledTimes(1);
expect(result).toMatchSnapshot();