github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 01:38:56 -04:00
Code Issues Projects Releases Packages Wiki Activity

[ML] AIOps: Replace useMount with useEffect to consider return cleanup callback. (#148229)

Browse source 
Replace `useMount` (just the usages with return callbacks) with
`useEffect` to consider return cleanup callback.
This commit is contained in:
Walter Rafelsberger 2023-01-03 15:58:15 +01:00 • committed by GitHub
parent 1c3dc4a151
commit 9111a2ebfc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

11
x-pack/plugins/aiops/public/components/change_point_detection/change_point_detection_context.tsx
View file

@ -16,7 +16,6 @@ import React, {
} from 'react';
import { type DataViewField } from '@kbn/data-views-plugin/public';
import { startWith } from 'rxjs';
import useMount from 'react-use/lib/useMount';
import type { Query, Filter } from '@kbn/es-query';
import { usePageUrlState } from '@kbn/ml-url-state';
import {
@ -129,7 +128,7 @@ export const ChangePointDetectionContextProvider: FC = ({ children }) => {
const timeRange = useTimeRangeUpdates();
useMount(function updateIntervalOnTimeBoundsChange() {
useEffect(function updateIntervalOnTimeBoundsChange() {
const timeUpdateSubscription = timefilter
.getTimeUpdate$()
.pipe(startWith(timefilter.getTime()))
@ -145,7 +144,8 @@ export const ChangePointDetectionContextProvider: FC = ({ children }) => {
return () => {
timeUpdateSubscription.unsubscribe();
};
});
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
const metricFieldOptions = useMemo<DataViewField[]>(() => {
return dataView.fields.filter(({ aggregatable, type }) => aggregatable && type === 'number');
@ -195,7 +195,7 @@ export const ChangePointDetectionContextProvider: FC = ({ children }) => {
[filterManager]
);
useMount(() => {
useEffect(() => {
setResultFilter(filterManager.getFilters());
const sub = filterManager.getUpdates$().subscribe(() => {
setResultFilter(filterManager.getFilters());
@ -203,7 +203,8 @@ export const ChangePointDetectionContextProvider: FC = ({ children }) => {
return () => {
sub.unsubscribe();
};
});
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);
useEffect(
function syncFilters() {