switch from sleeps to waiting for visualize-legend.

This commit is contained in:
LeeDr 2016-01-18 16:50:40 -06:00
parent 55330638c7
commit 9157cf7e16
8 changed files with 23 additions and 17 deletions

View file

@ -118,8 +118,8 @@ define(function (require) {
common.debug('Waiting...');
return headerPage.getSpinnerDone();
})
.then(function sleep() {
return common.sleep(4000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
})
.then(function takeScreenshot() {
common.debug('Take screenshot');

View file

@ -104,8 +104,8 @@ define(function (require) {
.then(function () {
return visualizePage.loadSavedVisualization(vizName1);
})
.then(function sleep() {
return common.sleep(4000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
})
.then(function takeScreenshot() {
common.debug('Take screenshot');

View file

@ -104,8 +104,8 @@ define(function (require) {
.then(function () {
return visualizePage.loadSavedVisualization(vizName1);
})
.then(function sleep() {
return common.sleep(4000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
})
.then(function takeScreenshot() {
// take a snapshot just as an example.

View file

@ -111,8 +111,8 @@ define(function (require) {
.then(function () {
return visualizePage.loadSavedVisualization(vizName1);
})
.then(function sleep() {
return common.sleep(4000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
})
.then(function takeScreenshot() {
common.debug('Take screenshot');

View file

@ -104,8 +104,8 @@ define(function (require) {
.then(function () {
return visualizePage.loadSavedVisualization(vizName1);
})
.then(function sleep() {
return common.sleep(4000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
})
.then(function takeScreenshot() {
common.debug('Take screenshot');

View file

@ -80,8 +80,8 @@ define(function (require) {
.then(function () {
return headerPage.getSpinnerDone(); // only matches the hidden spinner
})
.then(function sleep() {
return common.sleep(1000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
});
});
@ -109,8 +109,8 @@ define(function (require) {
.then(function () {
return headerPage.getSpinnerDone(); // only matches the hidden spinner
})
.then(function sleep() {
return common.sleep(4000);
.then(function waitForVisualization() {
return visualizePage.waitForVisualization();
})
.then(function takeScreenshot() {
common.debug('Take screenshot');

View file

@ -13,9 +13,9 @@ define(function (require) {
}],
tunnelOptions: serverConfig.servers.webdriver,
functionalSuites: [
'test/functional/status_page/index',
'test/functional/apps/settings/index',
'test/functional/apps/discover/index',
// 'test/functional/status_page/index',
// 'test/functional/apps/settings/index',
// 'test/functional/apps/discover/index',
'test/functional/apps/visualize/index'
],
excludeInstrumentation: /(fixtures|node_modules)\//,

View file

@ -673,6 +673,12 @@ define(function (require) {
});
},
waitForVisualization: function waitForVisualization() {
return this.remote
.setFindTimeout(defaultTimeout)
.findByCssSelector('visualize-legend');
}
};
return VisualizePage;