[Dataset quality] Change Dataset Quality app's title and add description. (#184728)

The PR changes the app's title from "Datasets" to "Data Set Quality".
Note that the changed title "Data Set Quality" will also be used as a
side nav menu item under Stack Management (in followups). The PR also
adds an app description as suggested in the parent issue.


![image](1d882f38-d062-40bc-b03f-717f9454b0cf)

The link leads to Doc's ECS page: [Data Stream
Fields](https://www.elastic.co/guide/en/ecs/current/ecs-data_stream.html).

The PR also changes the breadcrumb and quick search entry to use "Data
Set Quality" instead of "Data quality" or "Logs data quality".


![image](10d53c25-e3bd-489c-8a4d-a93153eb5499)

As per the [writing style
guidelines](https://brand.elastic.co/302f66895/p/194a3b-writing-style-guide/t/889c93),
any instance of "Dataest" is changed to either "Data Set" or "Data set".
This commit is contained in:
Abdul Wahab Zahid 2024-06-11 20:29:43 +02:00 committed by GitHub
parent d452a6228b
commit 9298c6f268
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
25 changed files with 134 additions and 105 deletions

View file

@ -536,11 +536,11 @@ Plugin server-side only. Plugin has three main functions:
|{kib-repo}blob/{branch}/x-pack/plugins/data_quality/README.md[dataQuality]
|Page where users can see the quality of their log datasets.
|Page where users can see the quality of their log data sets.
|{kib-repo}blob/{branch}/x-pack/plugins/observability_solution/dataset_quality/README.md[datasetQuality]
|In order to make ongoing maintenance of log collection easy we want to introduce the concept of dataset quality, where users can easily get an overview on the datasets they have with information such as integration, size, last activity, among others.
|In order to make ongoing maintenance of log collection easy we want to introduce the concept of data set quality, where users can easily get an overview on the data sets they have with information such as integration, size, last activity, among others.
|{kib-repo}blob/{branch}/x-pack/plugins/data_visualizer/README.md[dataVisualizer]

View file

@ -863,6 +863,7 @@ export const getDocLinks = ({ kibanaBranch, buildFlavor }: GetDocLinkOptions): D
},
ecs: {
guide: `${ELASTIC_WEBSITE_URL}guide/en/ecs/${ECS_VERSION}/index.html`,
dataStreams: `${ELASTIC_WEBSITE_URL}guide/en/ecs/${ECS_VERSION}/ecs-data_stream.html`,
},
clients: {
/** Changes to these URLs must also be synched in src/plugins/custom_integrations/server/language_clients/index.ts */

View file

@ -556,6 +556,7 @@ export interface DocLinks {
}>;
readonly ecs: {
readonly guide: string;
readonly dataStreams: string;
};
readonly clients: {
readonly guide: string;

View file

@ -1,2 +1,2 @@
# dataQuality
Page where users can see the quality of their log datasets.
Page where users can see the quality of their log data sets.

View file

@ -9,7 +9,7 @@ import { i18n } from '@kbn/i18n';
export const PLUGIN_ID = 'data_quality';
export const PLUGIN_NAME = i18n.translate('xpack.dataQuality.name', {
defaultMessage: 'Logs data quality',
defaultMessage: 'Data Set Quality',
});
export { DATA_QUALITY_URL_STATE_KEY, datasetQualityUrlSchemaV1 } from './url_schema';

View file

@ -38,7 +38,14 @@ export class DataQualityPlugin
id: PLUGIN_ID,
title: PLUGIN_NAME,
order: 2,
keywords: ['data', 'quality', 'data quality', 'datasets', 'datasets quality'],
keywords: [
'data',
'quality',
'data quality',
'datasets',
'datasets quality',
'data set quality',
],
async mount(params: ManagementAppMountParams) {
const [{ renderApp }, [coreStart, pluginsStartDeps, pluginStart]] = await Promise.all([
import('./application'),

View file

@ -46,7 +46,7 @@ const ConnectedContent = React.memo(() => {
title={
<FormattedMessage
id="xpack.dataQuality.Initializing"
defaultMessage="Initializing Data Quality page"
defaultMessage="Initializing Data Set Quality page"
/>
}
/>

View file

@ -1,12 +1,12 @@
# Dataset Quality
# Data Set Quality
In order to make ongoing maintenance of log collection easy we want to introduce the concept of dataset quality, where users can easily get an overview on the datasets they have with information such as integration, size, last activity, among others.
In order to make ongoing maintenance of log collection easy we want to introduce the concept of data set quality, where users can easily get an overview on the data sets they have with information such as integration, size, last activity, among others.
## Development
### Unit Tests
Kibana primarily uses Jest for unit testing. Each plugin or package defines a `jest.config.js` that extends a preset provided by the `@kbn/test` package. The following command runs all Dataset quality unit tests:
Kibana primarily uses Jest for unit testing. Each plugin or package defines a `jest.config.js` that extends a preset provided by the `@kbn/test` package. The following command runs all Data Set Quality unit tests:
```
yarn jest --config x-pack/plugins/observability_solution/dataset_quality/jest.config.js

View file

@ -8,7 +8,7 @@
import { i18n } from '@kbn/i18n';
export const datasetQualityAppTitle = i18n.translate('xpack.datasetQuality.appTitle', {
defaultMessage: 'Datasets',
defaultMessage: 'Data Set Quality',
});
export const noDatasetsDescription = i18n.translate('xpack.datasetQuality.noDatasetsDescription', {
@ -56,7 +56,7 @@ export const flyoutOpenInDiscoverText = i18n.translate(
export const flyoutDatasetDetailsText = i18n.translate(
'xpack.datasetQuality.flyoutDatasetDetailsText',
{
defaultMessage: 'Dataset details',
defaultMessage: 'Data set details',
}
);
@ -154,7 +154,7 @@ export const flyoutImprovementText = i18n.translate(
export const flyoutImprovementTooltip = i18n.translate(
'xpack.datasetQuality.flyoutDegradedFieldsSectionTooltip',
{
defaultMessage: 'A partial list of degraded fields found in your dataset.',
defaultMessage: 'A partial list of degraded fields found in your data set.',
}
);
@ -185,14 +185,14 @@ export const summaryPanelLast24hText = i18n.translate(
export const summaryPanelQualityText = i18n.translate(
'xpack.datasetQuality.summaryPanelQualityText',
{
defaultMessage: 'Datasets Quality',
defaultMessage: 'Data Sets Quality',
}
);
export const summaryPanelQualityTooltipText = i18n.translate(
'xpack.datasetQuality.summaryPanelQualityTooltipText',
{
defaultMessage: 'Quality is based on the percentage of degraded docs in a dataset.',
defaultMessage: 'Quality is based on the percentage of degraded docs in a data set.',
}
);
@ -220,14 +220,14 @@ export const summaryPanelQualityGoodText = i18n.translate(
export const summaryPanelDatasetsActivityText = i18n.translate(
'xpack.datasetQuality.summaryPanelDatasetsActivityText',
{
defaultMessage: 'Active Datasets',
defaultMessage: 'Active Data Sets',
}
);
export const summaryPanelDatasetsActivityTooltipText = i18n.translate(
'xpack.datasetQuality.summaryPanelDatasetsActivityTooltipText',
{
defaultMessage: 'The number of datasets with activity in the selected time range.',
defaultMessage: 'The number of data sets with activity in the selected time range.',
}
);
@ -246,7 +246,7 @@ export const summaryPanelEstimatedDataTooltipText = i18n.translate(
);
export const inactiveDatasetsLabel = i18n.translate('xpack.datasetQuality.inactiveDatasetsLabel', {
defaultMessage: 'Show inactive datasets',
defaultMessage: 'Show inactive data sets',
});
export const inactiveDatasetsDescription = i18n.translate(
@ -258,12 +258,12 @@ export const inactiveDatasetsDescription = i18n.translate(
);
export const fullDatasetNameLabel = i18n.translate('xpack.datasetQuality.fullDatasetNameLabel', {
defaultMessage: 'Show full dataset names',
defaultMessage: 'Show full data set names',
});
export const fullDatasetNameDescription = i18n.translate(
'xpack.datasetQuality.fullDatasetNameDescription',
{
defaultMessage: 'Turn on to show the actual dataset names used to store the documents.',
defaultMessage: 'Turn on to show the actual data set names used to store the documents.',
}
);

View file

@ -2,7 +2,7 @@
"type": "plugin",
"id": "@kbn/dataset-quality-plugin",
"owner": "@elastic/obs-ux-logs-team",
"description": "This plugin introduces the concept of dataset quality, where users can easily get an overview on the datasets they have.",
"description": "This plugin introduces the concept of data set quality, where users can easily get an overview on the data sets they have.",
"plugin": {
"id": "datasetQuality",
"server": true,

View file

@ -10,7 +10,7 @@ import { EuiFieldSearch } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
const placeholder = i18n.translate('xpack.datasetQuality.filterBar.placeholder', {
defaultMessage: 'Filter datasets',
defaultMessage: 'Filter data sets',
});
export interface FilterBarComponentProps {

View file

@ -5,46 +5,66 @@
* 2.0.
*/
import {
EuiBetaBadge,
EuiFlexGroup,
EuiFlexItem,
EuiPageHeader,
EuiPageHeaderSection,
EuiText,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React from 'react';
import { EuiBetaBadge, EuiLink, EuiPageHeader, EuiCode } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import { FormattedMessage } from '@kbn/i18n-react';
import { useKibanaContextForPlugin } from '../../utils';
import { datasetQualityAppTitle } from '../../../common/translations';
export const betaBadgeLabel = i18n.translate('xpack.datasetQuality.betaBadgeLabel', {
defaultMessage: 'Beta',
});
export const betaBadgeDescription = i18n.translate('xpack.datasetQuality.betaBadgeDescription', {
defaultMessage:
'This feature is currently in beta. If you encounter any bugs or have feedback, wed love to hear from you. Please open a support issue and/or visit our discussion forum.',
});
// Allow for lazy loading
// eslint-disable-next-line import/no-default-export
export default function Header() {
const {
services: { docLinks },
} = useKibanaContextForPlugin();
return (
<EuiPageHeader bottomBorder>
<EuiPageHeaderSection>
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiText>
<h2>{datasetQualityAppTitle}</h2>
</EuiText>
<EuiFlexItem>
<EuiBetaBadge
label={betaBadgeLabel}
title={betaBadgeLabel}
tooltipContent={betaBadgeDescription}
/>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPageHeaderSection>
</EuiPageHeader>
<EuiPageHeader
bottomBorder
pageTitle={
<>
{datasetQualityAppTitle}
&nbsp;
<EuiBetaBadge
label={betaBadgeLabel}
title={betaBadgeLabel}
tooltipContent={betaBadgeDescription}
/>
</>
}
description={
<FormattedMessage
id="xpack.datasetQuality.appDescription"
defaultMessage="Monitor the data set quality for {logsPattern} data streams that follow the {ecsNamingSchemeLink}."
values={{
logsPattern: <EuiCode>logs-*</EuiCode>,
ecsNamingSchemeLink: (
<EuiLink
data-test-subj="datasetQualityAppDescriptionEcsNamingSchemeLink"
href={docLinks.links.ecs.dataStreams}
target="_blank"
rel="noopener"
>
<FormattedMessage
id="xpack.datasetQuality.appDescription.ecsNamingSchemeLinkText"
defaultMessage="ECS naming scheme"
/>
</EuiLink>
),
}}
/>
}
/>
);
}
const betaBadgeLabel = i18n.translate('xpack.datasetQuality.betaBadgeLabel', {
defaultMessage: 'Beta',
});
const betaBadgeDescription = i18n.translate('xpack.datasetQuality.betaBadgeDescription', {
defaultMessage:
'This feature is currently in beta. If you encounter any bugs or have feedback, wed love to hear from you. Please open a support issue and/or visit our discussion forum.',
});

View file

@ -44,7 +44,7 @@ const collapseDatasetAriaLabel = i18n.translate('xpack.datasetQuality.collapseLa
defaultMessage: 'Collapse',
});
const nameColumnName = i18n.translate('xpack.datasetQuality.nameColumnName', {
defaultMessage: 'Dataset Name',
defaultMessage: 'Data Set Name',
});
const namespaceColumnName = i18n.translate('xpack.datasetQuality.namespaceColumnName', {
@ -60,7 +60,7 @@ const degradedDocsColumnName = i18n.translate('xpack.datasetQuality.degradedDocs
});
const datasetQualityColumnName = i18n.translate('xpack.datasetQuality.datasetQualityColumnName', {
defaultMessage: 'Dataset Quality',
defaultMessage: 'Data Set Quality',
});
const lastActivityColumnName = i18n.translate('xpack.datasetQuality.lastActivityColumnName', {
@ -102,7 +102,7 @@ const degradedDocsDescription = (
const degradedDocsColumnTooltip = (
<FormattedMessage
id="xpack.datasetQuality.degradedDocsColumnTooltip"
defaultMessage="The percentage of documents with the {ignoredProperty} property in your dataset."
defaultMessage="The percentage of documents with the {ignoredProperty} property in your data set."
values={{
ignoredProperty: (
<EuiCode language="json" transparentBackground>
@ -116,7 +116,7 @@ const degradedDocsColumnTooltip = (
const datasetQualityColumnTooltip = (
<FormattedMessage
id="xpack.datasetQuality.datasetQualityColumnTooltip"
defaultMessage="Quality is based on the percentage of degraded docs in a dataset. {visualQueue}"
defaultMessage="Quality is based on the percentage of degraded docs in a data set. {visualQueue}"
values={{
visualQueue: (
<EuiFlexGroup direction="column" gutterSize="xs">

View file

@ -101,7 +101,7 @@ export function DegradedDocs({
const degradedDocsTooltip = (
<FormattedMessage
id="xpack.datasetQuality.flyoutDegradedDocsTooltip"
defaultMessage="The percentage of degraded documents —documents with the {ignoredProperty} property— in your dataset."
defaultMessage="The percentage of degraded documents —documents with the {ignoredProperty} property— in your data set."
values={{
ignoredProperty: (
<EuiCode language="json" transparentBackground>

View file

@ -50,7 +50,7 @@ const nonAggregatableWarningDescription = (dataset: string) => (
howToFixIt: (
<FormattedMessage
id="xpack.datasetQuality.flyout.nonAggregatable.howToFixIt"
defaultMessage="Manually {rolloverLink} this dataset to prevent future delays."
defaultMessage="Manually {rolloverLink} this data set to prevent future delays."
values={{
rolloverLink: (
<EuiLink

View file

@ -73,6 +73,6 @@ export function FlyoutSummaryHeader({
const flyoutSummaryTooltip = (
<FormattedMessage
id="xpack.datasetQuality.flyoutSummaryTooltip"
defaultMessage="Stats of the dataset within the selected time range."
defaultMessage="Stats of the data set within the selected time range."
/>
);

View file

@ -34,7 +34,7 @@ const DatasetWithFewDegradedDocs = ({ degradedDocsCount }: { degradedDocsCount?:
~0%{' '}
<EuiToolTip
content={i18n.translate('xpack.datasetQuality.fewDegradedDocsTooltip', {
defaultMessage: '{degradedDocsCount} degraded docs in this dataset.',
defaultMessage: '{degradedDocsCount} degraded docs in this data set.',
values: {
degradedDocsCount,
},

View file

@ -11,7 +11,7 @@ import { i18n } from '@kbn/i18n';
export const fetchDatasetStatsFailedNotifier = (toasts: IToasts, error: Error) => {
toasts.addDanger({
title: i18n.translate('xpack.datasetQuality.fetchDatasetStatsFailed', {
defaultMessage: "We couldn't get your datasets.",
defaultMessage: "We couldn't get your data sets.",
}),
text: error.message,
});
@ -20,7 +20,7 @@ export const fetchDatasetStatsFailedNotifier = (toasts: IToasts, error: Error) =
export const fetchDatasetDetailsFailedNotifier = (toasts: IToasts, error: Error) => {
toasts.addDanger({
title: i18n.translate('xpack.datasetQuality.fetchDatasetDetailsFailed', {
defaultMessage: "We couldn't get your dataset details.",
defaultMessage: "We couldn't get your data set details.",
}),
text: error.message,
});
@ -29,7 +29,7 @@ export const fetchDatasetDetailsFailedNotifier = (toasts: IToasts, error: Error)
export const fetchDatasetSettingsFailedNotifier = (toasts: IToasts, error: Error) => {
toasts.addDanger({
title: i18n.translate('xpack.datasetQuality.fetchDatasetSettingsFailed', {
defaultMessage: "Dataset settings couldn't be loaded.",
defaultMessage: "Data set settings couldn't be loaded.",
}),
text: error.message,
});
@ -74,6 +74,6 @@ export const fetchIntegrationsFailedNotifier = (toasts: IToasts, error: Error) =
export const noDatasetSelected = i18n.translate(
'xpack.datasetQuality.fetchDatasetDetailsFailed.noDatasetSelected',
{
defaultMessage: 'No dataset have been selected',
defaultMessage: 'No data set have been selected',
}
);

View file

@ -69,7 +69,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
const testDatasetRowIndex = datasetNameColCellTexts.findIndex(

View file

@ -35,7 +35,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
it('shows the right number of rows in correct order', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
await datasetNameCol.sort('descending');
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql([...datasetNames].reverse());
@ -59,7 +59,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
it('shows degraded docs percentage', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
await datasetNameCol.sort('ascending');
const degradedDocsCol = cols['Degraded Docs (%)'];
@ -89,7 +89,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
it('shows the updated size of the index', async () => {
const testDatasetIndex = 2;
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
await datasetNameCol.sort('ascending');
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
@ -122,9 +122,9 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
});
it('sorts by dataset name', async () => {
// const header = await PageObjects.datasetQuality.getDatasetTableHeader('Dataset Name');
// const header = await PageObjects.datasetQuality.getDatasetTableHeader('Data Set Name');
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
// Sort ascending
await datasetNameCol.sort('ascending');
@ -152,7 +152,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
await PageObjects.datasetQuality.navigateTo();
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
// Sort ascending
await datasetNameCol.sort('ascending');
@ -169,7 +169,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
it('goes to log explorer page when opened', async () => {
const rowIndexToOpen = 1;
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const actionsCol = cols.Actions;
const datasetName = (await datasetNameCol.getCellTexts())[rowIndexToOpen];
@ -185,7 +185,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
await PageObjects.datasetQuality.navigateTo();
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const lastActivityCol = cols['Last Activity'];
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
// Set time range to Last 1 minute
const filtersContainer = await testSubjects.find(

View file

@ -48,7 +48,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
it('shows full dataset names when toggled', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql(datasetNames);
@ -65,7 +65,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
it('searches the datasets', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql(datasetNames);
@ -76,7 +76,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
);
const colsAfterSearch = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameColAfterSearch = colsAfterSearch['Dataset Name'];
const datasetNameColAfterSearch = colsAfterSearch['Data Set Name'];
const datasetNameColCellTextsAfterSearch = await datasetNameColAfterSearch.getCellTexts();
expect(datasetNameColCellTextsAfterSearch).to.eql([datasetNames[2]]);
await testSubjects.setValue(
@ -103,7 +103,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
await PageObjects.datasetQuality.navigateTo();
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql([apacheAccessDatasetHumanName, ...datasetNames]);
@ -111,7 +111,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
await PageObjects.datasetQuality.filterForIntegrations([apacheIntegrationName]);
const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameColAfterFilter = colsAfterFilter['Dataset Name'];
const datasetNameColAfterFilter = colsAfterFilter['Data Set Name'];
const datasetNameColCellTextsAfterFilter = await datasetNameColAfterFilter.getCellTexts();
expect(datasetNameColCellTextsAfterFilter).to.eql([apacheAccessDatasetHumanName]);
});
@ -174,7 +174,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
// Get default quality
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetQuality = cols['Dataset Quality'];
const datasetQuality = cols['Data Set Quality'];
const datasetQualityCellTexts = await datasetQuality.getCellTexts();
expect(datasetQualityCellTexts).to.contain(expectedQuality);
@ -182,7 +182,7 @@ export default function ({ getService, getPageObjects }: DatasetQualityFtrProvid
await PageObjects.datasetQuality.filterForQualities([expectedQuality]);
const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable();
const datasetQualityAfterFilter = colsAfterFilter['Dataset Quality'];
const datasetQualityAfterFilter = colsAfterFilter['Data Set Quality'];
const datasetQualityCellTextsAfterFilter = await datasetQualityAfterFilter.getCellTexts();
expect(datasetQualityCellTextsAfterFilter).to.eql([expectedQuality]);

View file

@ -62,9 +62,9 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv
datasetQualityTable: '[data-test-subj="datasetQualityTable"]',
datasetQualityTableColumn: (column: number) =>
`[data-test-subj="datasetQualityTable"] .euiTableRowCell:nth-child(${column})`,
datasetSearchInput: '[placeholder="Filter datasets"]',
showFullDatasetNamesSwitch: 'button[aria-label="Show full dataset names"]',
showInactiveDatasetsNamesSwitch: 'button[aria-label="Show inactive datasets"]',
datasetSearchInput: '[placeholder="Filter data sets"]',
showFullDatasetNamesSwitch: 'button[aria-label="Show full data set names"]',
showInactiveDatasetsNamesSwitch: 'button[aria-label="Show inactive data sets"]',
superDatePickerApplyButton: '.euiQuickSelect__applyButton',
};
@ -215,10 +215,10 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv
const table = await this.getDatasetsTable();
return parseDatasetTable(table, [
'0',
'Dataset Name',
'Data Set Name',
'Namespace',
'Size',
'Dataset Quality',
'Data Set Quality',
'Degraded Docs (%)',
'Last Activity',
'Actions',
@ -264,7 +264,7 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv
async openDatasetFlyout(datasetName: string) {
const cols = await this.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
const testDatasetRowIndex = datasetNameColCellTexts.findIndex(
(dName) => dName === datasetName
@ -534,7 +534,7 @@ const texts = {
datasetHealthPoor: 'Poor',
datasetHealthDegraded: 'Degraded',
datasetHealthGood: 'Good',
activeDatasets: 'Active Datasets',
activeDatasets: 'Active Data Sets',
estimatedData: 'Estimated Data',
docsCountTotal: 'Docs count (total)',
size: 'Size',

View file

@ -77,7 +77,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
const testDatasetRowIndex = datasetNameColCellTexts.findIndex(

View file

@ -39,7 +39,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('shows the right number of rows in correct order', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
await datasetNameCol.sort('descending');
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql([...datasetNames].reverse());
@ -63,7 +63,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('shows degraded docs percentage', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
await datasetNameCol.sort('ascending');
const degradedDocsCol = cols['Degraded Docs (%)'];
@ -94,7 +94,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it.skip('shows the updated size of the index', async () => {
const testDatasetIndex = 2;
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
await datasetNameCol.sort('ascending');
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
@ -129,7 +129,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('sorts by dataset name', async () => {
// const header = await PageObjects.datasetQuality.getDatasetTableHeader('Dataset Name');
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
// Sort ascending
await datasetNameCol.sort('ascending');
@ -157,7 +157,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.datasetQuality.navigateTo();
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
// Sort ascending
await datasetNameCol.sort('ascending');
@ -174,7 +174,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('goes to log explorer page when opened', async () => {
const rowIndexToOpen = 1;
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const actionsCol = cols.Actions;
const datasetName = (await datasetNameCol.getCellTexts())[rowIndexToOpen];
@ -190,7 +190,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.datasetQuality.navigateTo();
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const lastActivityCol = cols['Last Activity'];
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
// Set time range to Last 1 minute
const filtersContainer = await testSubjects.find(

View file

@ -52,7 +52,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('shows full dataset names when toggled', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql(datasetNames);
@ -69,7 +69,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
it('searches the datasets', async () => {
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql(datasetNames);
@ -80,7 +80,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
const colsAfterSearch = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameColAfterSearch = colsAfterSearch['Dataset Name'];
const datasetNameColAfterSearch = colsAfterSearch['Data Set Name'];
const datasetNameColCellTextsAfterSearch = await datasetNameColAfterSearch.getCellTexts();
expect(datasetNameColCellTextsAfterSearch).to.eql([datasetNames[2]]);
await testSubjects.setValue(
@ -107,7 +107,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.datasetQuality.navigateTo();
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameCol = cols['Dataset Name'];
const datasetNameCol = cols['Data Set Name'];
const datasetNameColCellTexts = await datasetNameCol.getCellTexts();
expect(datasetNameColCellTexts).to.eql([apacheAccessDatasetHumanName, ...datasetNames]);
@ -115,7 +115,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.datasetQuality.filterForIntegrations([apacheIntegrationName]);
const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable();
const datasetNameColAfterFilter = colsAfterFilter['Dataset Name'];
const datasetNameColAfterFilter = colsAfterFilter['Data Set Name'];
const datasetNameColCellTextsAfterFilter = await datasetNameColAfterFilter.getCellTexts();
expect(datasetNameColCellTextsAfterFilter).to.eql([apacheAccessDatasetHumanName]);
});
@ -178,7 +178,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
// Get default quality
const cols = await PageObjects.datasetQuality.parseDatasetTable();
const datasetQuality = cols['Dataset Quality'];
const datasetQuality = cols['Data Set Quality'];
const datasetQualityCellTexts = await datasetQuality.getCellTexts();
expect(datasetQualityCellTexts).to.contain(expectedQuality);
@ -186,7 +186,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.datasetQuality.filterForQualities([expectedQuality]);
const colsAfterFilter = await PageObjects.datasetQuality.parseDatasetTable();
const datasetQualityAfterFilter = colsAfterFilter['Dataset Quality'];
const datasetQualityAfterFilter = colsAfterFilter['Data Set Quality'];
const datasetQualityCellTextsAfterFilter = await datasetQualityAfterFilter.getCellTexts();
expect(datasetQualityCellTextsAfterFilter).to.eql([expectedQuality]);