github-mirrors/kibana
1
0
Fork 0
mirror of https://github.com/elastic/kibana.git synced 2025-04-24 09:48:58 -04:00
Code Issues Projects Releases Packages Wiki Activity

[Management] Add buffer time to ensure this test consistently passes when it should (#17200) (#17238)

Browse source 
* Add buffer time to ensure this test consistently passes when it should

* Move buffer to the function
This commit is contained in:
Chris Roberson 2018-03-19 10:49:11 -04:00 • committed by GitHub
parent 9f16b6af66
commit 937139877d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/core_plugins/kibana/public/management/sections/indices/create_index_pattern_wizard/lib/ensure_minimum_time.js
View file

@ -10,6 +10,12 @@ export const DEFAULT_MINIMUM_TIME_MS = 300;
export async function ensureMinimumTime(promiseOrPromises, minimumTimeMs = DEFAULT_MINIMUM_TIME_MS) {
let returnValue;
// https://kibana-ci.elastic.co/job/elastic+kibana+6.x+multijob-intake/128/console
// We're having periodic failures around the timing here. I'm not exactly sure
// why it's not consistent but I'm going to add some buffer space here to
// prevent these random failures
const bufferedMinimumTimeMs = minimumTimeMs + 5;
// Block on the async action and start the clock.
const asyncActionStartTime = new Date().getTime();
if (Array.isArray(promiseOrPromises)) {
@ -23,8 +29,8 @@ export async function ensureMinimumTime(promiseOrPromises, minimumTimeMs = DEFAU
const asyncActionDuration = asyncActionCompletionTime - asyncActionStartTime;
// Wait longer if the async action completed too quickly.
if (asyncActionDuration < minimumTimeMs) {
const additionalWaitingTime = minimumTimeMs - (asyncActionCompletionTime - asyncActionStartTime);
if (asyncActionDuration < bufferedMinimumTimeMs) {
const additionalWaitingTime = bufferedMinimumTimeMs - (asyncActionCompletionTime - asyncActionStartTime);
await new Promise(resolve => setTimeout(resolve, additionalWaitingTime));
}